| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
TBR=aa
BUG=59060
TEST=None
Review URL: http://codereview.chromium.org/3808005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor mock location provider to send new position to provider thread, rather than writing it into shared memory that was missing locking.
BUG=None
TEST=Geoloc* browser and unit tests.
Review URL: http://codereview.chromium.org/3749004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
CID=13288
Review URL: http://codereview.chromium.org/3781002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I got my double negatives incorrect, this should have been -Wnon-virtual-dtor.
BUG=45135
TEST=Targets build without error.
Review URL: http://codereview.chromium.org/3527003
TBR=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/3756003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also added ResetUseStubImpl() calls to some unit tests. Without them, a test in unit_tests, namely OfflineLoadPageTest.OfflinePaeProceed, crashes by NULL pointer dereference inside the newly added keyboard_library->GetHardwareKeyboardLayoutName() call:
1. Test X calls keyboard_library->GetXXX().
chromeos::CrosLibrary::Library<chromeos::KeyboardLibrary>::library_ becomes non-NULL, but the real libcros function is not called since EnsureLoaded() returns false.
2. Test Y (e.g. proxy_config_service_impl_unittest.cc) calls SetUseStubImpl(), but forgets to call ResetUseStubImpl().
3. OfflineLoadPageTest.OfflinePaeProceed calls keyboard_library->GetHardwareKeyboardLayoutName().
This time, since 'stub mode' is still on, EnsureLoaded() returns true, and the function pointer for GetHardwareKeyboardLayoutName libcros API, which is still NULL, is used.
BUG=chromium-os:6563
TEST=ran emerge, ran try bot.
Review URL: http://codereview.chromium.org/3735001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45135
TEST=Targets build without error.
Review URL: http://codereview.chromium.org/3527003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Call OnMenuOpened when the menu is showen on visible area.
TBR=isherman@chromium.org
BUG=none
TEST=TestMenuKeyboardAccess/TestAltMenuKeyboardAccess should pass
Review URL: http://codereview.chromium.org/3780006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before the fix, drag-and-drop in the bookmark manager on Chrome OS
resulted in a copy rather than move. The drag-and-drop logic is shared
with GTK and Views, but there was a subtle difference between the two
toolkits, that caused the bug.
BUG=chromium-os:7533
TEST=confirmed that dnd in the bookmark manager worked on Linux and Chrome OS
Review URL: http://codereview.chromium.org/3743002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62524 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-- removed trailing "..." and "obj:*" wildcards
-- replaced anonymous namespace salts with "*" wildcards
-- replaced the broken lines containing only namespace names with "..."
wildcards
TBR=timurrrr
Review URL: http://codereview.chromium.org/3817003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
as FLAKY
TBR=darin
BUG=51622
TEST=test_shell_tests
Review URL: http://codereview.chromium.org/3800004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
local functions into an anonymous namespace) and made the necessary changes to
sanity suppressions.
Review URL: http://codereview.chromium.org/3765002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=jknotten
BUG=19876, 48601
TEST=ui_tests
Review URL: http://codereview.chromium.org/3803003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Undid suppressions.
BUG=59019
TEST=Trybots
Review URL: http://codereview.chromium.org/3815003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It seems ListView_RemoveAllGroups disables groups on Win XP, so we re-enable them afterwards.
BUG=55452
TEST=Group headers in table views should be visible on XP
Review URL: http://codereview.chromium.org/3760002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58963
TEST=net_unittests
Review URL: http://codereview.chromium.org/3774002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
added.
BUG=chromium-os:7631
TEST=manually
Review URL: http://codereview.chromium.org/3811003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=green
Review URL: http://codereview.chromium.org/3746004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7301
TEST=manual
Review URL: http://codereview.chromium.org/3787001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
to "INTL"
BUG=chromium-os:7529
TEST=manually
Review URL: http://codereview.chromium.org/3705004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
put them in the base namespace.
TEST=it compiles
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the reload button tooltip was handled dynamically via
-view:stringForToolTip:point:userData:. Now that the button is a
distinct class, just have that class handle it directly.
BUG=58954
TEST=reload tooltip still works, and the crash in the bug stops happening.
Review URL: http://codereview.chromium.org/3814001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test hangs test_shell on Google Chrome builds. The process
cannot be killed and the slave exits without running subsequent
test steps. This is preventing us from running tests on official
builders.
BUG= http://bugs.chromium.org/54465
TEST= Google Chrome test builds from trunk get past webkit_tests.
http://goto/chrome-builders?builder=official%20release%20tests
Review URL: http://codereview.chromium.org/3809002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
allows through an empty string.
BUG=59116
TEST=none
Review URL: http://codereview.chromium.org/3782003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
work correctly
specifically when the attachment is downloaded in response to a form POST.
Fixes bug http://code.google.com/p/chromium/issues/detail?can=1&q=36694
Bug=36694
Test=There are some issues with downloading attachments off a localhost based URL. Will
submit a test once these issues are resolved.
TBR=stoyan
Review URL: http://codereview.chromium.org/3743005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58556
TEST=Manual
Review URL: http://codereview.chromium.org/3772001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
options"
The "Autofill options" popup menu item is renamed "Chrome Autofill options".
BUG=59127
TEST=Manual, visual inspection.
Review URL: http://codereview.chromium.org/3824001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3769003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
render_widget_host_view_views.
BUG=none
TEST=build with GYP_DEFINES="toolkit_views=1 library=shared_library"
Review URL: http://codereview.chromium.org/3751003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62493 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
apps.
BUG=58904
TEST=unit_tests --gtest_filter=Extension*
Review URL: http://codereview.chromium.org/3787002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/3801001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62491 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/3574014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=23581
TEST=trybots
Review URL: http://codereview.chromium.org/3745003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=40797
Review URL: http://codereview.chromium.org/3646004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/3683004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=52486
TEST=manual
Review URL: http://codereview.chromium.org/3582002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
allocates for the compositor and accelerated plugins, and clean them
up upon destruction. Guarded against potentially NULL RenderView in
WebGraphicsContext3DCommandBufferImpl's destructor.
Verified by loading http://twitter.com/henrikbennetsen# on Mac OS X,
then repeatedly clicking WebGL demos and closing them and verifying
that there are no renderer crashes.
BUG=58554
TEST=none
Review URL: http://codereview.chromium.org/3808004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/3750001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
the second.
BUG=none
TEST=none
TBR=mirandac
Review URL: http://codereview.chromium.org/3751005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Factors GUID generation into base/rand_util. The Autofill feature is in need of this utility so am factoring GUID generation out of metrics and moving to the commons.
BUG=58813
TEST=RandUtilTest.GUIDGeneratesAllZeroes, RandUtilTest.GUIDGeneratesCorrectly, RandUtilTest.GUIDCorrectlyFormatted, MetricsServiceTest.ClientIdCorrectlyFormatted
Review URL: http://codereview.chromium.org/3800001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
DOMViewCache caches one instance for current profile. It
delets and creates new one if profile is switched.
BUG=chromium-os:6497
TEST=none
Review URL: http://codereview.chromium.org/3778001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=57885
TEST=included
Review URL: http://codereview.chromium.org/3755006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we're triggering popups from javascript, there's no easy way to know when the tabcontents corresponding to the popup has loaded.
And we don't necessarily need to check for the title anyway, so removing the check.
BUG=
TEST=
Review URL: http://codereview.chromium.org/3772005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
I didn't mean to comment this out when I landed the protobuf-lite
change.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3742002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* RTL support is menu positioning only. Menu content will
be done after beta.
* Fix the location of menu when it has to be placed at the
left edge.
* Temporarily disable rounded corner for beta.
I'm pretty sure there was a bug filed for RTL, but I couldn't find it today.
BUG=chromium-os:7722
TEST=select rtl language (hebrew) and make sure menu's position is correctly adjusted. Language menu on info bar should have scroll button with this change.
Review URL: http://codereview.chromium.org/3803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles everywhere
Review URL: http://codereview.chromium.org/3748004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
show/hide the OTR exceptions tables when an OTR profile comes into being or its flame is extinguished
BUG=57459
TEST=manual
Review URL: http://codereview.chromium.org/3757002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
We've removed usage of these functions on non-Windows platforms.
Review URL: http://codereview.chromium.org/3762002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62470 0039d316-1c4b-4281-b951-d872f2087c98
|