summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Remove traces for the WhitelistExtension test. The flakiness seems to be gone.finnur@chromium.org2010-10-1410-81/+3
| | | | | | | | | | TBR=aa BUG=59060 TEST=None Review URL: http://codereview.chromium.org/3808005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62536 0039d316-1c4b-4281-b951-d872f2087c98
* Add extra logging to help in debugging flaky geolocation browser tests.joth@chromium.org2010-10-144-66/+48
| | | | | | | | | | | Refactor mock location provider to send new position to provider thread, rather than writing it into shared memory that was missing locking. BUG=None TEST=Geoloc* browser and unit tests. Review URL: http://codereview.chromium.org/3749004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62535 0039d316-1c4b-4281-b951-d872f2087c98
* SSLConfig struct CertAndStatus is not initializing all its members.finnur@chromium.org2010-10-141-2/+2
| | | | | | | | | | | BUG=None TEST=None CID=13288 Review URL: http://codereview.chromium.org/3781002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62532 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62529 - Add -Wno-non-virtual-dtor flag on posix targets.cbentzel@chromium.org2010-10-141-6/+0
| | | | | | | | | | | | | | I got my double negatives incorrect, this should have been -Wnon-virtual-dtor. BUG=45135 TEST=Targets build without error. Review URL: http://codereview.chromium.org/3527003 TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/3756003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62531 0039d316-1c4b-4281-b951-d872f2087c98
* Tiny cleanup: remove all use of kFallbackInputMethodId from the Chrome tree.yusukes@chromium.org2010-10-144-1/+5
| | | | | | | | | | | | | | | | | I also added ResetUseStubImpl() calls to some unit tests. Without them, a test in unit_tests, namely OfflineLoadPageTest.OfflinePaeProceed, crashes by NULL pointer dereference inside the newly added keyboard_library->GetHardwareKeyboardLayoutName() call: 1. Test X calls keyboard_library->GetXXX(). chromeos::CrosLibrary::Library<chromeos::KeyboardLibrary>::library_ becomes non-NULL, but the real libcros function is not called since EnsureLoaded() returns false. 2. Test Y (e.g. proxy_config_service_impl_unittest.cc) calls SetUseStubImpl(), but forgets to call ResetUseStubImpl(). 3. OfflineLoadPageTest.OfflinePaeProceed calls keyboard_library->GetHardwareKeyboardLayoutName(). This time, since 'stub mode' is still on, EnsureLoaded() returns true, and the function pointer for GetHardwareKeyboardLayoutName libcros API, which is still NULL, is used. BUG=chromium-os:6563 TEST=ran emerge, ran try bot. Review URL: http://codereview.chromium.org/3735001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62530 0039d316-1c4b-4281-b951-d872f2087c98
* Add -Wno-non-virtual-dtor flag on posix targets.cbentzel@chromium.org2010-10-141-0/+6
| | | | | | | | | BUG=45135 TEST=Targets build without error. Review URL: http://codereview.chromium.org/3527003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62529 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 554.0 to 555.0chrome-release@google.com2010-10-141-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62527 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromeos test failures.oshima@chromium.org2010-10-141-2/+3
| | | | | | | | | | | | Call OnMenuOpened when the menu is showen on visible area. TBR=isherman@chromium.org BUG=none TEST=TestMenuKeyboardAccess/TestAltMenuKeyboardAccess should pass Review URL: http://codereview.chromium.org/3780006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62525 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a drag-and-drop bug in the bookmark manager on Chrome OS.satorux@chromium.org2010-10-141-3/+27
| | | | | | | | | | | | | | Before the fix, drag-and-drop in the bookmark manager on Chrome OS resulted in a copy rather than move. The drag-and-drop logic is shared with GTK and Views, but there was a subtle difference between the two toolkits, that caused the bug. BUG=chromium-os:7533 TEST=confirmed that dnd in the bookmark manager worked on Linux and Chrome OS Review URL: http://codereview.chromium.org/3743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62524 0039d316-1c4b-4281-b951-d872f2087c98
* Suppressions cleanup. Fixed the following issues:glider@chromium.org2010-10-141-16/+8
| | | | | | | | | | | | | -- removed trailing "..." and "obj:*" wildcards -- replaced anonymous namespace salts with "*" wildcards -- replaced the broken lines containing only namespace names with "..." wildcards TBR=timurrrr Review URL: http://codereview.chromium.org/3817003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62523 0039d316-1c4b-4281-b951-d872f2087c98
* Mark ResourceFetcherTests.ResourceFetcherDownload and ResourceFetcherDidFail ↵phajdan.jr@chromium.org2010-10-141-2/+4
| | | | | | | | | | | | | as FLAKY TBR=darin BUG=51622 TEST=test_shell_tests Review URL: http://codereview.chromium.org/3800004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62522 0039d316-1c4b-4281-b951-d872f2087c98
* Copied Evan's http://codereview.chromium.org/3691007 (base_unittests: moveglider@chromium.org2010-10-142-28/+28
| | | | | | | | | local functions into an anonymous namespace) and made the necessary changes to sanity suppressions. Review URL: http://codereview.chromium.org/3765002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62521 0039d316-1c4b-4281-b951-d872f2087c98
* Mark AutomationProxyVisibleTest.AutocompleteMatchesTest as flaky.phajdan.jr@chromium.org2010-10-141-1/+4
| | | | | | | | | | | TBR=jknotten BUG=19876, 48601 TEST=ui_tests Review URL: http://codereview.chromium.org/3803003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62520 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Revamped ChromeSystemResources tests, fixed memory leakakalin@chromium.org2010-10-143-59/+53
| | | | | | | | | | | Undid suppressions. BUG=59019 TEST=Trybots Review URL: http://codereview.chromium.org/3815003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62517 0039d316-1c4b-4281-b951-d872f2087c98
* [Win] Enable groups in list views when updating groups.bauerb@chromium.org2010-10-141-2/+4
| | | | | | | | | | | It seems ListView_RemoveAllGroups disables groups on Win XP, so we re-enable them afterwards. BUG=55452 TEST=Group headers in table views should be visible on XP Review URL: http://codereview.chromium.org/3760002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62516 0039d316-1c4b-4281-b951-d872f2087c98
* Fix FTP directory listing for ftp.cisco.com.phajdan.jr@chromium.org2010-10-145-2/+45
| | | | | | | | | BUG=58963 TEST=net_unittests Review URL: http://codereview.chromium.org/3774002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62515 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in Language and Input page that caused "undefined" languge to be ↵satorux@chromium.org2010-10-142-2/+8
| | | | | | | | | | | added. BUG=chromium-os:7631 TEST=manually Review URL: http://codereview.chromium.org/3811003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62514 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit merge 69645:69697hayato@chromium.org2010-10-141-1/+1
| | | | | | | | | BUG=none TEST=green Review URL: http://codereview.chromium.org/3746004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62513 0039d316-1c4b-4281-b951-d872f2087c98
* BAdd purchase more link to 3g notifications.chocobo@chromium.org2010-10-1411-10/+135
| | | | | | | | BUG=chromium-os:7301 TEST=manual Review URL: http://codereview.chromium.org/3787001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62512 0039d316-1c4b-4281-b951-d872f2087c98
* Change the input method indicator for the US-international layout from "US" ↵yusukes@chromium.org2010-10-142-1/+6
| | | | | | | | | | | to "INTL" BUG=chromium-os:7529 TEST=manually Review URL: http://codereview.chromium.org/3705004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62511 0039d316-1c4b-4281-b951-d872f2087c98
* Move Stats, histograms, and field trial into a metrics subdirectory of base andbrettw@chromium.org2010-10-14237-826/+938
| | | | | | | | | put them in the base namespace. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Have reload button handle tooltip directly.shess@chromium.org2010-10-142-14/+5
| | | | | | | | | | | | | Previously the reload button tooltip was handled dynamically via -view:stringForToolTip:point:userData:. Now that the button is a distinct class, just have that class handle it directly. BUG=58954 TEST=reload tooltip still works, and the crash in the bug stops happening. Review URL: http://codereview.chromium.org/3814001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62508 0039d316-1c4b-4281-b951-d872f2087c98
* SKIP http/tests/media/video-play-stall-seek.html on Google Chrome/Win.mal@chromium.org2010-10-141-0/+7
| | | | | | | | | | | | | | | This test hangs test_shell on Google Chrome builds. The process cannot be killed and the slave exits without running subsequent test steps. This is preventing us from running tests on official builders. BUG= http://bugs.chromium.org/54465 TEST= Google Chrome test builds from trunk get past webkit_tests. http://goto/chrome-builders?builder=official%20release%20tests Review URL: http://codereview.chromium.org/3809002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62507 0039d316-1c4b-4281-b951-d872f2087c98
* Makes sure arg to window.chrome.setSuggestResult is a string andsky@chromium.org2010-10-142-3/+3
| | | | | | | | | | | allows through an empty string. BUG=59116 TEST=none Review URL: http://codereview.chromium.org/3782003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62506 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression in ChromeFrame which caused download attachments to not ↵ananta@chromium.org2010-10-141-0/+1
| | | | | | | | | | | | | | | | | | work correctly specifically when the attachment is downloaded in response to a form POST. Fixes bug http://code.google.com/p/chromium/issues/detail?can=1&q=36694 Bug=36694 Test=There are some issues with downloading attachments off a localhost based URL. Will submit a test once these issues are resolved. TBR=stoyan Review URL: http://codereview.chromium.org/3743005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62500 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Made notifications code read/write persistent state.akalin@chromium.org2010-10-142-44/+78
| | | | | | | | | BUG=58556 TEST=Manual Review URL: http://codereview.chromium.org/3772001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62499 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill dropdown: String change from "Autofill options" to "Chrome Autofill ↵dhollowa@chromium.org2010-10-142-5/+11
| | | | | | | | | | | | | options" The "Autofill options" popup menu item is renamed "Chrome Autofill options". BUG=59127 TEST=Manual, visual inspection. Review URL: http://codereview.chromium.org/3824001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62498 0039d316-1c4b-4281-b951-d872f2087c98
* Add a pp_resource include to the two private interfaces, which depend on this.brettw@chromium.org2010-10-142-0/+2
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/3769003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62496 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux_view build including both render_widget_host_view_gtk and ↵mattm@chromium.org2010-10-141-2/+2
| | | | | | | | | | | render_widget_host_view_views. BUG=none TEST=build with GYP_DEFINES="toolkit_views=1 library=shared_library" Review URL: http://codereview.chromium.org/3751003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62495 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the build warnings about bool conversion.brettw@chromium.org2010-10-141-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62493 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent browser actions and page actions from being used withaa@chromium.org2010-10-148-19/+58
| | | | | | | | | | | apps. BUG=58904 TEST=unit_tests --gtest_filter=Extension* Review URL: http://codereview.chromium.org/3787002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62492 0039d316-1c4b-4281-b951-d872f2087c98
* Update the audio interface implementation to use the latest Pepper.brettw@chromium.org2010-10-143-31/+61
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/3801001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62491 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old tunneling code from remoting/jingle_glue.sergeyu@chromium.org2010-10-1414-951/+7
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3574014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62489 0039d316-1c4b-4281-b951-d872f2087c98
* gfx: Get rid of deprecated version of CreateIconFileFromSkBitmap.tfarina@chromium.org2010-10-143-12/+5
| | | | | | | | | BUG=23581 TEST=trybots Review URL: http://codereview.chromium.org/3745003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62488 0039d316-1c4b-4281-b951-d872f2087c98
* Add an option ProxyService::Create() to disable use of proxy auto-config.eroman@chromium.org2010-10-148-52/+100
| | | | | | | BUG=40797 Review URL: http://codereview.chromium.org/3646004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62487 0039d316-1c4b-4281-b951-d872f2087c98
* SimpleFileWriter for test_shell and DRT.michaeln@chromium.org2010-10-1413-185/+516
| | | | | | | | | BUG=none TEST=manual Review URL: http://codereview.chromium.org/3683004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62486 0039d316-1c4b-4281-b951-d872f2087c98
* Add deletable file refs to Blobsmichaeln@chromium.org2010-10-144-51/+84
| | | | | | | | | BUG=52486 TEST=manual Review URL: http://codereview.chromium.org/3582002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62485 0039d316-1c4b-4281-b951-d872f2087c98
* Made RenderView keep track of the fake plugin window handles itkbr@google.com2010-10-143-4/+31
| | | | | | | | | | | | | | | | | allocates for the compositor and accelerated plugins, and clean them up upon destruction. Guarded against potentially NULL RenderView in WebGraphicsContext3DCommandBufferImpl's destructor. Verified by loading http://twitter.com/henrikbennetsen# on Mac OS X, then repeatedly clicking WebGL demos and closing them and verifying that there are no renderer crashes. BUG=58554 TEST=none Review URL: http://codereview.chromium.org/3808004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62484 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move SplitString functions into the base namespace and update the callers.tfarina@chromium.org2010-10-1485-150/+151
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3750001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62483 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build. There was a merge problem between the first landing attempt and ↵johnnyg@chromium.org2010-10-141-5/+3
| | | | | | | | | | | | the second. BUG=none TEST=none TBR=mirandac Review URL: http://codereview.chromium.org/3751005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62481 0039d316-1c4b-4281-b951-d872f2087c98
* Factoring GUID generation from metrics to basedhollowa@chromium.org2010-10-137-62/+96
| | | | | | | | | | | Factors GUID generation into base/rand_util. The Autofill feature is in need of this utility so am factoring GUID generation out of metrics and moving to the commons. BUG=58813 TEST=RandUtilTest.GUIDGeneratesAllZeroes, RandUtilTest.GUIDGeneratesCorrectly, RandUtilTest.GUIDCorrectlyFormatted, MetricsServiceTest.ClientIdCorrectlyFormatted Review URL: http://codereview.chromium.org/3800001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62480 0039d316-1c4b-4281-b951-d872f2087c98
* Warmup DOMView so that the 1st time menu open is fast.oshima@chromium.org2010-10-131-3/+134
| | | | | | | | | | | | DOMViewCache caches one instance for current profile. It delets and creates new one if profile is switched. BUG=chromium-os:6497 TEST=none Review URL: http://codereview.chromium.org/3778001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62479 0039d316-1c4b-4281-b951-d872f2087c98
* Reland http://codereview.chromium.org/3573014/show.johnnyg@chromium.org2010-10-1310-5/+402
| | | | | | | | | BUG=57885 TEST=included Review URL: http://codereview.chromium.org/3755006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62478 0039d316-1c4b-4281-b951-d872f2087c98
* Fix pyauto popup tests to be non-flakynirnimesh@chromium.org2010-10-131-1/+2
| | | | | | | | | | | | Since we're triggering popups from javascript, there's no easy way to know when the tabcontents corresponding to the popup has loaded. And we don't necessarily need to check for the title anyway, so removing the check. BUG= TEST= Review URL: http://codereview.chromium.org/3772005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62477 0039d316-1c4b-4281-b951-d872f2087c98
* Revert unintended commit.agl@chromium.org2010-10-131-1/+1
| | | | | | | I didn't mean to comment this out when I landed the protobuf-lite change. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62476 0039d316-1c4b-4281-b951-d872f2087c98
* Use CommandUpdater for disabling commands that were disabled by plugins.jam@chromium.org2010-10-1320-62/+113
| | | | | | Review URL: http://codereview.chromium.org/3742002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62475 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Resize/Scroll for dropdown as well. RTL support (location only)oshima@chromium.org2010-10-133-61/+61
| | | | | | | | | | | | | | | | | * RTL support is menu positioning only. Menu content will be done after beta. * Fix the location of menu when it has to be placed at the left edge. * Temporarily disable rounded corner for beta. I'm pretty sure there was a bug filed for RTL, but I couldn't find it today. BUG=chromium-os:7722 TEST=select rtl language (hebrew) and make sure menu's position is correctly adjusted. Language menu on info bar should have scroll button with this change. Review URL: http://codereview.chromium.org/3803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62474 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Further parts of r61237 that should be harmless to chrome_frame.erg@google.com2010-10-136-74/+103
| | | | | | | | | BUG=none TEST=compiles everywhere Review URL: http://codereview.chromium.org/3748004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62473 0039d316-1c4b-4281-b951-d872f2087c98
* DOM UI Settings - content settings exceptions tablesestade@chromium.org2010-10-136-15/+98
| | | | | | | | | | | show/hide the OTR exceptions tables when an OTR profile comes into being or its flame is extinguished BUG=57459 TEST=manual Review URL: http://codereview.chromium.org/3757002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62471 0039d316-1c4b-4281-b951-d872f2087c98
* file_util: don't compile any of the deprecated functions on non-Windowsevan@chromium.org2010-10-131-7/+2
| | | | | | | | We've removed usage of these functions on non-Windows platforms. Review URL: http://codereview.chromium.org/3762002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62470 0039d316-1c4b-4281-b951-d872f2087c98