summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Merge 217358 "[Android] Stop-gap solution for reducing INJECT_EV..."frankf@chromium.org2013-08-141-1/+1
| | | | | | | | | | | | | | | | | | > [Android] Stop-gap solution for reducing INJECT_EVENTS flakiness. > > Crash/ANR dialogs on Android are automatically dismissed after 5 > minutes. Run content_browsertests earlier in the test cycle. > > BUG=271071 > R=craigdh@chromium.org > > Review URL: https://codereview.chromium.org/23039006 TBR=frankf@chromium.org Review URL: https://codereview.chromium.org/23103003 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217630 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 217158 "Implement WAV decoder"rtoy@google.com2013-08-141-0/+305
| | | | | | | | | | | | | | | | | | | | > Implement WAV decoder > > > BUG=259048,255683, 235571 > > Implement a simple WAV decoder to handle simple WAV files and pass > anything else that isn't handled to MediaCodec. > > By doing the decoding ourselves, we also fix bug 255683 and 235571 > > Review URL: https://chromiumcodereview.appspot.com/21273002 TBR=rtoy@google.com Review URL: https://codereview.chromium.org/22825006 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217625 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 217238 "Randomize mach_override_ptr trampoline addresses o..."inferno@chromium.org2013-08-142-3/+15
| | | | | | | | | | | | | | > Randomize mach_override_ptr trampoline addresses on 32-bit > > BUG=265731 > > Review URL: https://chromiumcodereview.appspot.com/22798004 TBR=ianbeer@chromium.org Review URL: https://codereview.chromium.org/22928012 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217622 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 217331 "Do not use cross-fade effect for the transition to..."mukai@chromium.org2013-08-141-1/+1
| | | | | | | | | | | | | | | > Do not use cross-fade effect for the transition to fullscreen state. > > BUG=None > R=jamescook@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/22794006 TBR=mukai@chromium.org Review URL: https://codereview.chromium.org/23025003 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217610 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 217183 "Fixes a NULL-ptr deref crash caused by wrong assum..."jiayl@google.com2013-08-141-1/+4
| | | | | | | | | | | | | | | BUG=272535 > Fixes a NULL-ptr deref crash caused by wrong assumption of param evaluation order in WebRTCIdentityStoreBackend::FindIdentity > > BUG= > > Review URL: https://chromiumcodereview.appspot.com/22803005 TBR=jiayl@chromium.org Review URL: https://codereview.chromium.org/23200005 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217605 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 217486 "Recover from a situation where the copy of the man..."mek@chromium.org2013-08-141-0/+20
| | | | | | | | | | | | | | > Recover from a situation where the copy of the manifest file in the Preferences file got corrupted because of bug 272524. > > BUG=272547 > > Review URL: https://chromiumcodereview.appspot.com/23136005 TBR=mek@chromium.org Review URL: https://codereview.chromium.org/23007015 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217595 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 217394 "Don't merge two versions of the manifest together ..."mek@chromium.org2013-08-142-1/+67
| | | | | | | | | | | | | | | > Don't merge two versions of the manifest together when updating an extension, instead make sure the new version overwrites the old one. > > BUG=272524 > NOTRY=true > > Review URL: https://chromiumcodereview.appspot.com/22823004 TBR=mek@chromium.org Review URL: https://codereview.chromium.org/23205002 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217594 0039d316-1c4b-4281-b951-d872f2087c98
* Incrementing VERSION to 30.0.1599.8chrome-release@google.com2013-08-141-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217586 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 217338 "Fix the crash bug of close button for the resoluti..."mukai@chromium.org2013-08-143-8/+46
| | | | | | | | | | | | | | | | | | | | | > Fix the crash bug of close button for the resolution change notification. > > Close() is invoked in RemoveNotification() before removing the > notification (because the NotificationDelegate is owned by its notification). > Invoking AcceptResolutionChange() directly here causes the removing > notification twice, which will cause a crash. > > BUG=271784 > R=oshima@chromium.org > TEST=covered by the new test case > > Review URL: https://chromiumcodereview.appspot.com/22960004 TBR=mukai@chromium.org Review URL: https://codereview.chromium.org/23049003 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217585 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 217563 "Fixed apps v2 patch."jamiewalch@chromium.org2013-08-141-2/+2
| | | | | | | | | | | | | | > Fixed apps v2 patch. > > BUG=272657 > > Review URL: https://chromiumcodereview.appspot.com/22911009 TBR=jamiewalch@chromium.org Review URL: https://codereview.chromium.org/23194003 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217579 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 217378 "Don't add a dash for empty description"sail@chromium.org2013-08-141-0/+5
| | | | | | | | | | | | | | | | | | | | | | | > Don't add a dash for empty description > > In crrev.com/217109 I caused a regression that added a dash to the > omnibox popup even if the description was empty. > > This CL adds back the original check for an empty description. > > BUG=271951 > TEST=Typed youtube.com in the omnibox. Verified that omnibox > results with an empty description didn't have a dash at the end. > NOTRY=true > R=shess@chromium.org > > Review URL: https://codereview.chromium.org/23022003 TBR=sail@chromium.org Review URL: https://codereview.chromium.org/23204002 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217574 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 217219 "Fix index out of bounds in host_main"sergeyu@chromium.org2013-08-141-5/+6
| | | | | | | | | | | | | | | > Fix index out of bounds in host_main > > BUG= > > Review URL: https://chromiumcodereview.appspot.com/22989002 TBR=rmsousa@chromium.org BUG=271931 Review URL: https://codereview.chromium.org/23201002 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217572 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 217285 "Update |AppListService::ShowForProfile| and |AppLi..."karen@chromium.org2013-08-142-0/+6
| | | | | | | | | | | | | | > Update |AppListService::ShowForProfile| and |AppListController::ShowForProfile| to early return if the user is managed. > > BUG=269948 > > Review URL: https://chromiumcodereview.appspot.com/22650010 TBR=ibraaaa@chromium.org Review URL: https://codereview.chromium.org/22887005 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217561 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 217230 "Add missing NULL pointer check for pairing_registry_"lambroslambrou@chromium.org2013-08-141-1/+1
| | | | | | | | | | | | | | > Add missing NULL pointer check for pairing_registry_ > > BUG=271822 > > Review URL: https://chromiumcodereview.appspot.com/22882004 TBR=lambroslambrou@chromium.org Review URL: https://codereview.chromium.org/23114004 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217560 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 217234 "Enable Views Textfields on Win8 Metro by default."msw@chromium.org2013-08-141-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | > Enable Views Textfields on Win8 Metro by default. > > Replaces the old Win8 Metro native textfields and omnibox. > Views Textfields are already default on Win7, and Win8 Desktop. > Disable via "Views Textfield" flag (or --disable-views-textfield) if needed. > > Views Textfields were blocked on Win8 Metro by: > Issue 239690: Native Text Views: TSF stuff seems not working on metro mode. > Issue 265337: IME cannot be turned on for bookmark edit dialog in Win8 Metro mode, when NativeTextFieldViews is enabled > But those issues have been resolved. > We should ship Views Textfields by default on M-30. > > BUG=266099 > TEST=Win8 Metro browser UI textfields and IME work as intended. > R=sadrul@chromium.org > TBR=sky@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/22954003 TBR=msw@chromium.org Review URL: https://codereview.chromium.org/23196002 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217557 0039d316-1c4b-4281-b951-d872f2087c98
* Incrementing VERSION to 30.0.1599.7chrome-release@google.com2013-08-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217372 0039d316-1c4b-4281-b951-d872f2087c98
* Incrementing VERSION to 30.0.1599.6chrome-release@google.com2013-08-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217367 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 217359 "Fix visibility of performance tracing menu item in..."zork@chromium.org2013-08-131-1/+2
| | | | | | | | | | | | | | | > Fix visibility of performance tracing menu item in system tray > > BUG=272389 > R=sadrul@chromium.org > > Review URL: https://codereview.chromium.org/22842006 TBR=zork@chromium.org Review URL: https://codereview.chromium.org/22872006 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217363 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 217249 "This is to see if it is affecting the stability o..."karen@chromium.org2013-08-131-2/+2
| | | | | | | | | | > This is to see if it is affecting the stability of the browser process. I have a theory that r194793 might have caused a stability regression in M28. Following that patch, DXVA is always initialized unless --disable-accelerated-video is specified if the GPU process launched. Some configurations are known to blue screen or hang if a Direct3D device is created. TBR=karen@chromium.org Review URL: https://codereview.chromium.org/22988004 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217352 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 217251 "Revert 185611 "On Android, the browser process ca..."karen@chromium.org2013-08-133-20/+27
| | | | | | | | | | | | | | | | | | | | | | | | > Revert 185611 "On Android, the browser process can be killed any..." > > > On Android, the browser process can be killed anytime by the system. > > For stability purposes, we count a crash when the browser process dies when the app is in the foreground. We call MetricsService::OnAppEnterForeground (which sets kStabilityExitedCleanly to false) and OnAppEnterBackground (which sets it to true). > > If the process dies (for any reason) after OnAppEnterBackground has been called, it is not counted as a crash. > > > > The browser process can also be started while the app is in the background (to service a sync or bookmark widget request), we do not want to modify the kStabilityExitedCleanly in this case, because we won't get a chance to mark clean shutdown. > > > > BUG=179143 > > > > Review URL: https://chromiumcodereview.appspot.com/12326114 > > TBR=nileshagrawal@chromium.org > > Review URL: https://codereview.chromium.org/23052003 TBR=karen@chromium.org Review URL: https://codereview.chromium.org/23072006 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217351 0039d316-1c4b-4281-b951-d872f2087c98
* Incrementing VERSION to 30.0.1599.5chrome-release@google.com2013-08-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217317 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 217250 "Merge 217049 "Make sure unexpected exit paths gen..."karen@chromium.org2013-08-131-12/+0
| | | | | | | | | | | | | | | | | | | | | | | | | > Merge 217049 "Make sure unexpected exit paths generate crash dum..." > > > Make sure unexpected exit paths generate crash dumps for the browser. > > > > Right now it is possible for some random code to directly terminate the > > browser process without generating a crash dump. This CL should fix that. > > > > BUG=none > > TEST=none > > R=jam@chromium.org > > > > Review URL: https://codereview.chromium.org/22264015 > > TBR=rvargas@chromium.org > > Review URL: https://codereview.chromium.org/23065002 TBR=karen@chromium.org Review URL: https://codereview.chromium.org/23097003 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217316 0039d316-1c4b-4281-b951-d872f2087c98
* Incrementing VERSION to 30.0.1599.4chrome-release@google.com2013-08-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217315 0039d316-1c4b-4281-b951-d872f2087c98
* Incrementing VERSION to 30.0.1599.3chrome-release@google.com2013-08-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217299 0039d316-1c4b-4281-b951-d872f2087c98
* Incrementing VERSION to 30.0.1599.2chrome-release@google.com2013-08-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217252 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 185611 "On Android, the browser process can be killed any..."karen@chromium.org2013-08-133-27/+20
| | | | | | | | | | | | | | | | | | > On Android, the browser process can be killed anytime by the system. > For stability purposes, we count a crash when the browser process dies when the app is in the foreground. We call MetricsService::OnAppEnterForeground (which sets kStabilityExitedCleanly to false) and OnAppEnterBackground (which sets it to true). > If the process dies (for any reason) after OnAppEnterBackground has been called, it is not counted as a crash. > > The browser process can also be started while the app is in the background (to service a sync or bookmark widget request), we do not want to modify the kStabilityExitedCleanly in this case, because we won't get a chance to mark clean shutdown. > > BUG=179143 > > Review URL: https://chromiumcodereview.appspot.com/12326114 TBR=nileshagrawal@chromium.org Review URL: https://codereview.chromium.org/23052003 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217251 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 217049 "Make sure unexpected exit paths generate crash dum..."karen@chromium.org2013-08-131-0/+12
| | | | | | | | | | | | | | | | | | | > Make sure unexpected exit paths generate crash dumps for the browser. > > Right now it is possible for some random code to directly terminate the > browser process without generating a crash dump. This CL should fix that. > > BUG=none > TEST=none > R=jam@chromium.org > > Review URL: https://codereview.chromium.org/22264015 TBR=rvargas@chromium.org Review URL: https://codereview.chromium.org/23065002 git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217250 0039d316-1c4b-4281-b951-d872f2087c98
* This is to see if it is affecting the stability of the browser process. I ↵karen@chromium.org2013-08-131-2/+2
| | | | | | have a theory that r194793 might have caused a stability regression in M28. Following that patch, DXVA is always initialized unless --disable-accelerated-video is specified if the GPU process launched. Some configurations are known to blue screen or hang if a Direct3D device is created. git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217249 0039d316-1c4b-4281-b951-d872f2087c98
* Incrementing VERSION to 30.0.1599.1chrome-release@google.com2013-08-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217187 0039d316-1c4b-4281-b951-d872f2087c98
* Branching for 1599 @217147chrome-release@google.com2013-08-130-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/branches/1599/src@217185 0039d316-1c4b-4281-b951-d872f2087c98
* [chromedriver] Accept loadAsync as a non-op chromeOption.chrisgao@chromium.org2013-08-134-27/+70
| | | | | | | | BUG=none Review URL: https://chromiumcodereview.appspot.com/19773012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217147 0039d316-1c4b-4281-b951-d872f2087c98
* optimize png files in chrome/browser/resources chrome/renderer/resourcesoshima@chromium.org2013-08-1354-0/+0
| | | | | | | | | | | | | $./build/sanitize-png-files.sh -o2 chrome/browser/resources chrome/renderer/resources Processed 54 files (out of 564 files) in 02:39:45s Result : 261637 => 261221 bytes (416 bytes : 0 %) BUG=271299 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/22991002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217146 0039d316-1c4b-4281-b951-d872f2087c98
* Clone of @ https://codereview.chromium.org/22452002/mallinath@chromium.org2013-08-139-14/+112
| | | | | | | | | | | | | | | which is LGTMed by @sergeyu and @juberti. Adding TLS support to the TCP Client sockets. In case of WebRTC TLS socket will be created when application passes TURNS url. TurnPort will request for creating TLS sockets. In other instances TLS will be done using Pseudo-TLS, i.e. when TCPPort creates ssltcp, it's actually a pseudo-tls. TBR=vrk@chromium.org,jln@chromium.org,sergeyu@chromium.org,juberti@chromium.org Review URL: https://codereview.chromium.org/22990002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217145 0039d316-1c4b-4281-b951-d872f2087c98
* Optimize png files in webkit/glue/resourcesoshima@chromium.org2013-08-13111-0/+0
| | | | | | | | | | | | | ./build/sanitize-png-files.sh -o2 webkit/glue/resources 1 files (out of 151 files) in 01:59:56s Result : 299061 => 296898 bytes (2163 bytes : 0 %) BUG=271299 TBR=jamesr@chromium.org Review URL: https://codereview.chromium.org/22987002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217144 0039d316-1c4b-4281-b951-d872f2087c98
* Updates the list of display info in TrayDisplay even if notification is ↵mukai@chromium.org2013-08-133-9/+44
| | | | | | | | | | | | prevented. BUG=270200 R=oshima@chromium.org, stevenjb@chromium.org TEST=new test case covers Review URL: https://chromiumcodereview.appspot.com/22908004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217143 0039d316-1c4b-4281-b951-d872f2087c98
* Crash fix: Remove MessageLoop from AudioPowerMonitor and instead use ↵miu@chromium.org2013-08-135-140/+103
| | | | | | | | | | | | | MessageLoopProxy in AudioOutputController. Root cause: AudioPowerMonitor held a reference to the audio thread's MessageLoop and erroneously assumed it would be valid until after the audio stream is closed. However, at browser shutdown, it's possible for audio streams to be closed by the correct thread, but *after* the MessageLoop associated with the thread is destroyed. BUG=268629 TEST=media_unittests and manual confirmation by running a browser with the --enable-audible-notifications command-line flag. Review URL: https://chromiumcodereview.appspot.com/22339024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217142 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Change to detach the web contents view when the panel is not taller ↵jianli@chromium.org2013-08-131-18/+25
| | | | | | | | | | | | | | than the titlebar. We used to hide the web contents view in such case but it seems to trigger some bad effect occasionally. BUG=265932 TEST=existing tests R=ccameron@chromium.org, dimich@chromium.org Review URL: https://codereview.chromium.org/22629009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217139 0039d316-1c4b-4281-b951-d872f2087c98
* This patch uses single BytesInstruction Courgette ops to point to long ↵paulgazz@chromium.org2013-08-132-6/+7
| | | | | | | | | | stretches of the binary file, instead of using one ByteInstruction op, which copies one byte at a time. This reduces memory usages for very large files, since less data is copied, and fewer Instruction classes are constructed. BUG=266068 Review URL: https://chromiumcodereview.appspot.com/22728002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217138 0039d316-1c4b-4281-b951-d872f2087c98
* Removing QUIC's VERSION_6, now that QUIC no longer needs to support thewtc@chromium.org2013-08-139-642/+93
| | | | | | | | | | | | | | | | | | | | older STREAM frames. Merge internal CL: 50558774 Add the QuicVersionMin() function. Change some unit tests to use QuicVersionMin(). Merge internal CL: 50630692 R=rch@chromium.org BUG=none TEST=net_unittests Review URL: https://chromiumcodereview.appspot.com/22311013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217137 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 217130 "On uninstall, delete shortcuts first, and then re..."nick@chromium.org2013-08-131-15/+7
| | | | | | | | | | | | | | | | | | | | | | [Reason for revert: compile failure on Win Aura (maybe due to merge conflict)] > On uninstall, delete shortcuts first, and then remove directory only if empty. > > Previously, ShellUtil::RemoveShortcuts() simply wipes out the entire directory if |location| is SHORTCUT_LOCATION_START_MENU or SHORTCUT_LOCATION_APP_SHORTCUTS, for efficiency. But we're now writing code to migrate shortcuts on the self-destruct flow. In this case, wiping out the directory would destroy our results. Therefore the new logic for deletion of these directories are: > - Use same code to remove Chrome-specific shortcuts (this is what's done for other diretories, e.g., Start Menu). > - If the directory becomes empty, then remove it; otherwise do nothing. > > The side effect is that if user creates any non-Chrome shortcuts in these directories, then these shortcuts (and the containing directory) will persist after Chrome uninstall. I think this is a pretty normal behavior. > > BUG=235857 > > Review URL: https://chromiumcodereview.appspot.com/22870004 TBR=huangs@chromium.org Review URL: https://codereview.chromium.org/22983003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217134 0039d316-1c4b-4281-b951-d872f2087c98
* Handle connecting to hidden networks correctlystevenjb@chromium.org2013-08-134-68/+95
| | | | | | | | | | | | The new network connect code does not handle hidden networks correctly. This fixes that, which also fixed the associated issue. BUG=270936, 166999 R=pneubeck@chromium.org Review URL: https://codereview.chromium.org/22674011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217133 0039d316-1c4b-4281-b951-d872f2087c98
* Improve debug logging for GetNameFromPropertiesstevenjb@chromium.org2013-08-134-9/+14
| | | | | | | | | | | Better logging to help debug a problem with non-asci ssids. BUG=chrome-os-partner:18659 R=gauravsh@chromium.org Review URL: https://codereview.chromium.org/22908005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217132 0039d316-1c4b-4281-b951-d872f2087c98
* Fix code formatting problems reported by PVS-Studio.wtc@chromium.org2013-08-131-4/+4
| | | | | | | | | | | | See http://www.viva64.com/en/b/0205/#ID0EXRFM R=rsleevi@chromium.org BUG=271530 TEST=none Review URL: https://chromiumcodereview.appspot.com/22883002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217131 0039d316-1c4b-4281-b951-d872f2087c98
* On uninstall, delete shortcuts first, and then remove directory only if empty.huangs@chromium.org2013-08-131-7/+15
| | | | | | | | | | | | | | Previously, ShellUtil::RemoveShortcuts() simply wipes out the entire directory if |location| is SHORTCUT_LOCATION_START_MENU or SHORTCUT_LOCATION_APP_SHORTCUTS, for efficiency. But we're now writing code to migrate shortcuts on the self-destruct flow. In this case, wiping out the directory would destroy our results. Therefore the new logic for deletion of these directories are: - Use same code to remove Chrome-specific shortcuts (this is what's done for other diretories, e.g., Start Menu). - If the directory becomes empty, then remove it; otherwise do nothing. The side effect is that if user creates any non-Chrome shortcuts in these directories, then these shortcuts (and the containing directory) will persist after Chrome uninstall. I think this is a pretty normal behavior. BUG=235857 Review URL: https://chromiumcodereview.appspot.com/22870004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217130 0039d316-1c4b-4281-b951-d872f2087c98
* [Android] Fix ime NPE after RWH is destroyedboliu@chromium.org2013-08-132-24/+24
| | | | | | | | | | | NULL check all access to RenderWidgetHost in ImeAdapterAndroid since RWH can be null after destruction. BUG=internal b/10143869 Review URL: https://chromiumcodereview.appspot.com/22764006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217129 0039d316-1c4b-4281-b951-d872f2087c98
* [InstantExtended] Update chromeactions.txt to correspond with the added ↵rlp@chromium.org2013-08-131-0/+5
| | | | | | | | | | | | actions for detecting a SRP on nav entry committed. See https://codereview.chromium.org/21395002/ for the CL which adds the actions. Note: this also includes any other updates to actions since the last time chromeactions.txt was updated. BUG=263644 Review URL: https://chromiumcodereview.appspot.com/22493016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217128 0039d316-1c4b-4281-b951-d872f2087c98
* Added JsonMessage to the control channel.jamiewalch@chromium.org2013-08-1320-2/+125
| | | | | | | | | | This adds the client plumbing needed to get an arbitrary JSON message from client to host, or vice versa. This will allow us to extend the protocol at short notice, without needing to wait for client plugin changes to be promoted to Stable. BUG= Review URL: https://chromiumcodereview.appspot.com/22477006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217127 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Telemetry based cold startup test.simonjam@chromium.org2013-08-136-21/+59
| | | | | | | | | | | | | | | | This shares most of its code with the startup_warm measurement. You must now specify either --warm or --cold to run the new startup measurement. Due to splitting up the original patch for this into many pieces, some of the earlier changes didn't all work together. There are also a couple of fixes for those in here. BUG=None Review URL: https://chromiumcodereview.appspot.com/22300013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217126 0039d316-1c4b-4281-b951-d872f2087c98
* Disable tabCapture API tests on Windows. Seem to be broken since a libjingle ↵justinlin@chromium.org2013-08-131-0/+6
| | | | | | | | | | | roll. BUG=263951 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/22940002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217125 0039d316-1c4b-4281-b951-d872f2087c98
* Use ARRAYSIZE_UNSAFE to find the number of painters in shader_bench.jbroman@chromium.org2013-08-131-2/+1
| | | | | | | | | | | | | Previously, a separate constant (kNumPainters) was used. This constant was incorrect (there were only two elements in the array). As described in http://www.viva64.com/en/b/0205/. BUG=271533 Review URL: https://chromiumcodereview.appspot.com/22920003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217124 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-27 18:34:35 +0000