| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7120010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88174 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7118001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88173 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bug introduced in change 87835.
BUG=84542
TEST=Try to log in using app-specific password on GAIA account. When entering
app-specific password, flow should continue normally.
Review URL: http://codereview.chromium.org/7054085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=mark
BUG=85213
TEST=Greener valgrind bots
Review URL: http://codereview.chromium.org/7129005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*Fixup about and chrome scheme URLs in URLFixerUpper::FixupURL.
*Update AboutSource to use the source_name of each about/chrome page.
*Make WillHandleBrowserAboutURL fix up schemes and handle chrome://foo/
-Redirect memory to memory-redirect (wasn't handling chrome://memory/).
-Catalog all kChromeUI*Hosts in url_constants.cc
-Simplify paths (credits, os-credits, ipc, settings, about/version).
-Nix web_ui_util::ChromeURLHostEquals (use scheme & host comparison).
-Favor GURL::SchemeIs and url_constants, update & expand tests.
-Add and fixup chrome://chrome-urls (the about:about page).
BUG=55771
TEST=Access about:, about://, chrome:, chrome:// pages.
Review URL: http://codereview.chromium.org/7068007
TBR=msw@chromium.org
Review URL: http://codereview.chromium.org/7064052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=mark
BUG=85213
TEST=Greener valgrind bots
Review URL: http://codereview.chromium.org/7129003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
88080. In the chrome frame net tests
environment extensions are not initialized which causes a crash while dereferencing a NULL extension service
pointer in the profile.
BUG=none
TEST=chrome frame net tests should pass.
TBR=creis
Review URL: http://codereview.chromium.org/7046020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason: PanelBrowserWindow dtor is now complex and cannot be inlined.
BUG=None
TEST=Verified WindowOpenPanel test now hits Panel destructor.
Review URL: http://codereview.chromium.org/7120011
TBR=jennb@chromium.org
Review URL: http://codereview.chromium.org/7003035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=dgrogan
BUG=85151
TEST=Greener memory bots
Review URL: http://codereview.chromium.org/6995056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Verified WindowOpenPanel test now hits Panel destructor.
Review URL: http://codereview.chromium.org/7120011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to go through the newly made ProfileKeyedServiceFactory subclass.
In addition, makes further modifications to the unit testing stuff because the TemplateURL tests change the active TemplateURLService on a profile during the test.
BUG=77155
TEST=unit tests
R=mirandac
Review URL: http://codereview.chromium.org/7056056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes are:
- all icons are 32x32. Previously icons were 26x26, 32x32 or some even bigger
- all icons are gray scale
- the chromium/google version of the translate icon has been replaced by a single common one
Once this is checked in there will be a few more changes coming:
- make the icon view in the infobar 32x32 with no scaling
- change the infobar background gradient to grayscale (currently it's blue on windows, yellow on mac, and gray in a translate)
Screenshots: http://www.dropmocks.com/mV7FH
Ran pngcrush -brute -reduce on new icons. chrome/app/themes size:
- before: 8602624 bytes
- after: 8605184 bytes
BUG=80432
TEST=Compiled and ran on Mac.
Review URL: http://codereview.chromium.org/7031069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88152 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
ObserverListBase::Iterator is on the stack and one of the observers deletes the object holding the list, Iterator's destructor will use the deleted list.
BUG=84919
Review URL: http://codereview.chromium.org/7127001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88151 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Make sure the keyboard owns the child views before making it unfocusable.
BUG=none
TEST=with --webui-login in touchui, focusing a textfield brings up the keyboard.
Review URL: http://codereview.chromium.org/7121015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88150 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove TextButton::has_normal_border(). Replaced it with some more generic functionality on TextButtonBorder to allow specifying a normal border.
* Simplify InfoBarButtonBorder by making it a subclass of TextButtonBorder so it could avoid overriding anything unnecessary. This also required changing TextButtonBorder's Paint() function to stretch rather than tile, which I don't think should produce a visual difference for any buttons using that base class.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7065073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dtseng
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88147 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7065053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=one
TBR=shess
Review URL: http://codereview.chromium.org/7131008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=no
TEST=no
Review URL: http://codereview.chromium.org/7083022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It turns out base/Version is really a value object but probably because of some serious accident or by
the machinations of a super villain, forgot his identity and now it thinks is a reference object,
only creatable in the heap and that could only spawn offsprings via cloning.
But fear not 'cause I've seen Version true nature; At its core is just a good 'ol vector<uint16>, which has
very respectable value semantics. Also I have removed the is_valid_ parasite as much as I could.
The old interface (GetVersionFromString and Clone) is kept so existing callers would not need to be modified.
BUG=none
TEST=included
Review URL: http://codereview.chromium.org/7105008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
*Update AboutSource to use the source_name of each about/chrome page.
*Make WillHandleBrowserAboutURL fix up schemes and handle chrome://foo/
-Redirect memory to memory-redirect (wasn't handling chrome://memory/).
-Catalog all kChromeUI*Hosts in url_constants.cc
-Simplify paths (credits, os-credits, ipc, settings, about/version).
-Nix web_ui_util::ChromeURLHostEquals (use scheme & host comparison).
-Favor GURL::SchemeIs and url_constants, update & expand tests.
-Add and fixup chrome://chrome-urls (the about:about page).
BUG=55771
TEST=Access about:, about://, chrome:, chrome:// pages.
Review URL: http://codereview.chromium.org/7068007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=dgrogan
BUG=85151
TEST=Greener valgrind/heapcheck bots
Review URL: http://codereview.chromium.org/7031077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
- mac-release-10.6/dhtml/times/t (from webkit roll at r87776)
TBR=nsylvain@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we calculate the dominant/representative color only for those favicons we need it for (i.e. the ones shown on the NTP). We don't do any caching either in memory or in the favicon db but that can be tacked on later if deemed suitable.
Code in color_analysis.* authored by dtrainor
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7099001
TBR=estade@chromium.org
Review URL: http://codereview.chromium.org/7125010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88139 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/7077038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we calculate the dominant/representative color only for those favicons we need it for (i.e. the ones shown on the NTP). We don't do any caching either in memory or in the favicon db but that can be tacked on later if deemed suitable.
Code in color_analysis.* authored by dtrainor
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7099001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88137 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- xp-release-dual-core/moz/vm_peak_b/vm_pk_b (expected regression, switch to tcmalloc from winheap at r85998)
- xp-release-dual-core/moz/total_op_b/IO_op_b (webkit roll at r85865)
- xp-release-dual-core/moz/total_byte_b/IO_b (from webkit roll at r85865)
- xp-release-dual-core/moz/total_op_r/IO_op_r (from webkit roll at r85865)
TBR=nsylvain@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=csilv@chromium.org
Review URL: http://codereview.chromium.org/6976052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=app_unittests --gtest_filter=TreeNodeModelTest.GetIndexOf
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7113015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88134 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
'Close Window' can be used even if a window has single tab.
NOTE: Cmd+w closes a window even if there is a single tab.
XIB Changes:
* Make the default key equivalent of 'Close Tab' Cmd+w
* Make the default key equivalent of 'Close Window' Cmd+Shift+w
* Remove the referencing outlets from 'Close Tab' and 'Close Window'
No other changes are made.
BUG=20569
TEST=press Cmd+Shift+w on a window having only one tab.
Review URL: http://codereview.chromium.org/7065054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ChromeOS clang bot should build.
Review URL: http://codereview.chromium.org/7132003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88132 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also fixed an regression that user list is not visible because we did
not trigger List.redraw when becoming visible.
BUG=chromium-os:16190,chromium-os:7160
TEST=Verify fix for chromium-os:16190 and chromium-os:7160.
Review URL: http://codereview.chromium.org/7031068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=84644
TEST=content_settings_pattern_unit_test.cc,
host_content_settings_map_unittest.cc,
content_settings_pref_provider_unittest.cc,
notification_exceptions_table_model_unittest.cc,
extension_content_settings_store_unittest.cc
Review URL: http://codereview.chromium.org/7031072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88130 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:16237
TEST=1. Switch to Japanese IME
2. Press the "a" key for a second (i.e., input 20-30 characters)
3. Press the backspace key for half a second (i.e., delete several characters
but keep some of them not deleted)
4. Repeat 2 and 3.
5. Verify the size of the window always fits the content.
Review URL: http://codereview.chromium.org/7124007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None.
TEST=German-readers don't laugh at me.
Review URL: http://codereview.chromium.org/7131003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The helper TabStripDragController is owned by the TabStripController. It
operates using the TabDraggingEventTarget protocol, which is used to pass the
mouse events from the TabView up through various controllers to the DragController.
This CL introduces no behavioral changes and is just preparatory work for being
able to drag multiple tabs.
BUG=78816
TEST=Drag tabs in and out of the tab strip. Everything works as before.
Review URL: http://codereview.chromium.org/7080064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7121011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88122 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7124009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Change NTP thumbnail to show web store theme gallery.
Change NTP favicons to new Chrome logo and new Web Store logo.
BUG=65930, 79588
TEST=theme links to web gallery, NTP displays web store gallery image.
Review URL: http://codereview.chromium.org/6999017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The functionality desired isn't entirely clear. This CL takes care of the bits that everyone agrees on: when a user deletes her browsing data "since the beginning of time" both persistent and temporary filesystems are removed entirely. What we do for other time periods is still up in the air.
BUG=63700
TEST=unit_tests
Review URL: http://codereview.chromium.org/7087020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=83626
TEST=none
Review URL: http://codereview.chromium.org/7125007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88118 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
prerender mode.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7054064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
run and to prevent hangs when we don't get a response back.
BUG=85074
TEST=None. Julia Tan had a machine where GPU process wouldn't start, causing a hang. That's the only test case I have so far (and this patch fixes it for about:flash)...
Review URL: http://codereview.chromium.org/7058058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first step towards removing --test-terminate-timeout completely.
In this CL --test-terminate-timeout becomes a synonym for
--ui-test-action-max-timeout.
This makes it possible to switch callers to --ui-test-action-max-timeout
and remove --test-terminate-timeout.
Removing number of different kinds of timeouts makes it easier to pick one.
BUG=none
Review URL: http://codereview.chromium.org/7111035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=Test cases provided.
Review URL: http://codereview.chromium.org/7056065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We'll be modifying these files so we can use the code from Chrome
without going through libcros. Before doing that, we check in the
code as-is, so we can track diffs.
% cp ~/chromeos/src/platform/cros/chromeos_input_method_ui.h ibus_ui_connection.h
% cp ~/chromeos/src/platform/cros/chromeos_input_method_ui.cc ibus_ui_connection.cc
TEST=none (the code is unused now)
BUG=16238
Review URL: http://codereview.chromium.org/7124005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88107 0039d316-1c4b-4281-b951-d872f2087c98
|