| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
pending.
BUG=362800
R=wtc@chromium.org, rch@chromium.org
Review URL: https://codereview.chromium.org/196343017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=351891
TBR=kinuko@chromium.org (c/b/sync_file_system)
TBR=hashimoto@chromium.org (c/b/chromeos/file_manager)
(No functional difference for either TBR)
Review URL: https://codereview.chromium.org/198053005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch implements the same mechanism of InvalidationLogger currently
in use in Ticl_invalidation_service. This provides a way to see incoming
invalidations in the Android client that couldn't be easily seen before.
BUG=263863
Review URL: https://codereview.chromium.org/195873018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
And do not enable accelerated canvas in webview if extensions are
missing.
BUG=332146
Review URL: https://codereview.chromium.org/196653019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=351872
TBR=zea@chromium.org (c/b/sync) (Just a name change)
TBR=erg@chromium.org (c/b/profiles) (Just a name change)
Review URL: https://codereview.chromium.org/197023010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Lion and greater. OSX's captive portal detection doesn't
seem to work in some cases where Chrome's does.
BUG=none
Review URL: https://codereview.chromium.org/200323003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For a more detailed design doc, see http://goo.gl/pZnbXS.
The previous attempt to add notifications (before this refactored design)
was issue 27360003.
Auth and sync errors currently show up in the wrench menu as GlobalErrors. This
CL removes auth errors from the wrench menu in Chrome OS and in Windows when
using the Ash shell, showing notifications instead.
The behavior when clicking these notifications should be the same: For sign-
in errors, we show a sign-in page (on Chrome OS, the user signs out).
SigninGlobalError responds to queries about the menu
item errors. Its error-checking logic has been refactored into the new
SigninErrorController, which now exposes the error status to the UI classes.
The UI class, SigninGlobalError and SigninErrorNotifier, are browser context-
keyed services instantiated by the UI which use the SigninErrorController
for information about errors, observing the OnErrorChanged method.
I tried using a lower similarity, please ignore false positives
for unrelated files.
========
Update: I've removed sync error UI changes. A follow-up CL will mirror the auth error logic for sync errors.
========
BUG=128948
TEST=unit_tests --gtest_filter=S*n*Error*
TBR=courage@chromium.org
big changes:
atwilson: signin, sync
ben: c/b/ui/views
derat: c/b/ui/ash
rogerta: signin, sync
small changes:
asvitkine: c/b/ui/cocoa
courage: c/b/extensions/api/identity
dbeam: c/b/ui/webui
stevenjb: ash/system
fyi (Feel free to review):
bauerb
blundell
dewittj
oshima
rsimha
Review URL: https://codereview.chromium.org/172853009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/195573005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=322664
TEST=net_unittests
Review URL: https://codereview.chromium.org/180243015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I broke this when removing WideToASCII.
TBR=sky
Review URL: https://codereview.chromium.org/197283023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=304341
TEST=no change
Review URL: https://codereview.chromium.org/194903008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1874: ninja/mac: Fix multiarch link regression caused by 1871.
BUG=352816
R=scottmg@chromium.org
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/196283024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Put them into InProcessDynamicServiceRunner, which implements
DynamicServiceRunner.
(This basically makes DynamicServiceLoader only "load", and separates
the "running" part into a separate class.)
R=ben@chromium.org
Review URL: https://codereview.chromium.org/200923003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The patch changes suggestion algorithm from a for loop that compared
prefixes to a trie. The performance impact on a debug build:
Old (for loop that compared prefixes):
- Build rulesets = 200 ms
- Each character typed = 500 ms
New (trie):
- Build rulesets = 200 ms
- First character typed = 220 ms (200 ms due to building trie)
- Each subsequent character typed = 20 ms
The performance for each character improves significantly. Building
rulesets and the trie still have room for optimization.
BUG=347383
Review URL: https://codereview.chromium.org/183793003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The beginnings of a new way to handle command-line options. In the future, all classes that add command-line options must implement ArgumentHandlerMixIn.
Usage: Subclass ArgumentHandlerMixIn. In AddCommandLineArgs, set the command-line options. In ProcessCommandLineArgs, store them in private static class variables. The class can retrieve its own arguments at any time - yes, it's global state, but command-line arguments are always global state anyway, and it's contained within that class.
- Keeps declaration and usage of options close to each other, by encapsulating them in the same class.
- Enforces that all arguments must be available at parse time without depending on other arguments, by making all methods @classmethods.
- The ProcessCommandLineArgs() method gives Handlers a place to validate their command-line options before performing more expensive setup work.
- Removes the need to pass the options parameter around everywhere.
- Allows us to gradually break down Finder/BrowserOptions. Smooths the transition to argparse.
BUG=163294, 350833
TEST=Unit tests, ran cloud_storage, run_benchmark, run_measurement, and run_gpu_tests with a bunch of different argument types.
Review URL: https://codereview.chromium.org/187413003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HandleWatcher was using a TickClock to get now but not
MessagePumpMojo. This meant if a test set a TickClock both places
would not use it, resulting in two different times being used.
BUG=none
TEST=none
R=viettrungluu@chromium.org
Review URL: https://codereview.chromium.org/196473024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In terms of previewing on hover, treat single-field autocomplete
the same as Autofill. Functions are introduced to handle when an
AutoComplete selection is hovered over and clear once preview is done.
This fix only handles autocomplete field. Preview support for password
autofill support mentioned in the bug descriptions will be handled in a
separate commit.
BUG=63421
R=estade@chromium.org, isherman@chromium.org
Review URL: https://codereview.chromium.org/148413002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Along the way, clean up some code in the AutofillDownloadManager class. Notably,
rename AutofillDownloadManager::AutofillRequestType to just
AutofillDownloadManager::RequestType.
BUG=352456
TEST=none
R=estade@chromium.org
TBR=joi@chromium.org
Review URL: https://codereview.chromium.org/196603015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
server_hostname, while creating QuicClientSession,
QuicCryptoClientStream, QuicCryptoClientConfig, etc objects.
QuicSessionKey is used as the key to access QUIC server
config information from all caches (disk and memory caches).
On Disk cache, the key for accessing QUIC server information is the
flattened version (scheme://hostname:port) of QuicSession.
scheme would be either http or https until we support other schemes.
R=rch@chromium.org, wtc@chromium.org
Review URL: https://codereview.chromium.org/192583004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without this change, the json {..., "optional": "false", ...} is interpreted
identically to the json {..., "optional": true, ...}.
BUG=none
TEST=none
R=yoz@chromium.org
Review URL: https://codereview.chromium.org/196343007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=335156
Review URL: https://codereview.chromium.org/200323004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The directory server omits the host "items" list entirely, instead of
sending an empty list.
BUG=352398,333131
NOTRY=true
Review URL: https://codereview.chromium.org/197313008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=169259:169273&mode=html
TBR=
BUG=
Review URL: https://codereview.chromium.org/199413017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the registration time of the DomDistillerViewerSource which
handles requests to the chrome-distiller:// scheme. Before this CL, the
URLDataSource was registered as soon as the BrowserContextKeyedService
was requested, which is too late when the user directly tries to distill a URL.
This changes it so that the scheme registration happens as soon as the
profile has been created.
Since the instantiation of the service causes the database for the
DomDistillerStore to load, an instance holder is created which causes the
service to be lazily created when it is needed.
BUG=319881
Review URL: https://codereview.chromium.org/188373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=318825
TEST=Middle-click the title bar.
Review URL: https://codereview.chromium.org/196343012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=351958
Review URL: https://codereview.chromium.org/199083006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
load_library_perf_tests measure time to load libraries.
The clearkeycdm test cases require the clearkeyadapter target to be built.
BUG=337674
Review URL: https://codereview.chromium.org/200553002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/199783002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Navigate or search using the selection clipboard text.
Sanitize the text as done through Omnibox pasting.
Expose PageInfoHelper's LocationBarView member.
BUG=349529
TEST=Selecting text and middle-clicking the location icon navigates or searches for the selection clipboard contents (unless the window is a popup) on Linux Aura.
R=pkasting@chromium.org
Review URL: https://codereview.chromium.org/198063008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
UrlRequestHttpJob would never send an error up to the UrlRequest, since it
assumed the lack of a transaction indicated the request had been cancelled.
This was causing sync to stop working during suspend. The NetworkLayer was
failing to create an HttpNetworkTransaction while suspended, so sync would end
up waiting indefinitely on a hung request which it would never time out.
This was only seen by sync because it has no HttpCache layer, and the cache
layer never fails to create an HttpTransaction.
BUG=348475
Review URL: https://codereview.chromium.org/196643003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
r1873: win: make msvs_shard work properly for static_library references
TBR=thakis@chromium.org
BUG=352495
Review URL: https://codereview.chromium.org/199743005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need it to have correct dependencies on protobufs.
This is a followup of https://chromiumcodereview.appspot.com/198003002/
Actually, most of the review was done in
https://chromiumcodereview.appspot.com/186663002/ that was later split.
R=nkostylev@chromium.org
TBR=stevenjb@chromium.org
Who was the reviewer of original CL
BUG=244472
Review URL: https://codereview.chromium.org/200463003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
if a browser tab loads an error page, and the error seems transient, the renderer process starts attempting to automatically reload the tab's contents with exponential backoff.
To NetErrorHelperCore, add a new delegate method: ReloadPage(), which kicks off
a reload of the page in the observed frame. Add a new class MockableOneShotTimer
which provides a mockable interface to the standard base::OneShotTimer and is
used in NetErrorHelperCore for the autoreload timer. Add an implementation of
MockableOneShotTimer.
Add new member variables 'auto_reload_count_', 'auto_reload_pending_', and
'auto_reload_enabled_' to NetErrorHelperCore. The first tracks how many attempts
we have made to auto-reload; the second tracks whether we should be attempting
auto-reloads (i.e., the last loaded page was an error, and the user did not hit
'Stop' since that load); the last controls whether autoreload is enabled or not
and defaults to false.
The autoreload logic itself exists in
NetErrorHelperCore::{AutoReload,MaybeStartAutoReloadTimer,StartAutoReloadTimer}.
StartAutoReloadTimer sets a timer (auto_reload_timer_) which calls AutoReload
when it fires, and AutoReload starts a fetch of the error URL. The timer is
started with a successively larger interval at each successive call to
StartAutoReload() to implement exponential backoff. The auto-reload count is
reset (thus restarting the backoff) when we get a non-reloadable error like an
ERR_ABORTED or when a non-error page loads successfully. Any pending auto-reload
attempts stop (but the timer is not reset) if the user manually presses 'stop'
or a cross-process navigation starts (handled in NetErrorHelperCore::OnStop).
MaybeStartAutoReloadTimer is the real entry point for auto-reload; it starts
auto-reload if the last load was a reloadable error page, the browser is online,
and the user hasn't stopped the error page.
Also, extend the existing hook in
ChromeContentRendererClient::ShouldSuppressErrorPage to call
NetErrorHelper::ShouldSuppressErrorPage, which plumbs the request through to
NetErrorHelperCore.
Right now, if there are many tabs displaying error pages, the code in
NetworkStateChange() can cause a "reload storm", in which dozens or even
hundreds of auto-reload attempts start at the same time, possibly saturating the
network. Our current design for resolving this involves a ResourceThrottle in
the browser process to throttle individual tab loading, but design work is still
ongoing.
There are unit tests in NetErrorHelperCoreTest covering the various behaviors of
auto-reload, and helper code and a mock MockableOneShotTimer implementation
added to NetErrorHelperCoreTest. There is a browser test in
ErrorPageAutoReloadTest.
TODO: solve the "reload storm" issue.
TEST=unit,browser,trybot
BUG=308233
Review URL: https://codereview.chromium.org/136203009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of r247966 that should be safe now that the dependencies on
X11 libraries are cleaned up (see bug 339518).
BUG=339518
R=piman@chromium.org
Review URL: https://codereview.chromium.org/159373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with invalid tasks.
RasterWorkerPoolDelegate can only avoid calls to RWP::ScheduleTasks
when no tasks are currently scheduled. Skipping the call when some
tasks are scheduled might leave the RWP instance with references to
deleted tasks.
This change makes sure we always schedule a new task queue unless no
tasks are currently scheduled.
BUG=350045,349135
Review URL: https://codereview.chromium.org/199083007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=322664
Review URL: https://codereview.chromium.org/184003002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke sizes: http://build.chromium.org/p/chromium/builders/Linux/builds/48243
> SpdyFramer now uses HPACK for SPDY4 headers
>
> SpdyFramer defers calling OnControlFrameHeadersData() until the entire HPACK
> headers block has been decoded. At that point, the block is re-encoded to
> legacy SPDY3 format and passed to the visitor.
>
> This is a temporary measure suitable for testing only, intended to allow
> a decoupled switch to HPACK prior to being fully wired for
> SpdyHeadersHandlerInterface.
>
> This lands server change 62461978 by jgraettinger.
>
> BUG=339578
>
> Review URL: https://codereview.chromium.org/195413002
TBR=jgraettinger@chromium.org
Review URL: https://codereview.chromium.org/197283020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This pulls in the following Native Client changes:
r12836: (bradnelson) Disable mutex_timedlock_test under qemu.
r12837: (jvoung) Use shutil.move instead of os.rename in pnacl-compress.
r12838: (sbc) Remove 'bundle_size' test.
r12839: (jfb) Update TOOL_REVISIONS for PNaCl r12832->r12834
r12840: (noelallen) Roll version of bionic src, fix test to always atleast compile.
r12841: (sbc) Add isatty syscall and IRT interface.
r12842: (mcgrathr) toolchain_build: Update binutils revision
r12843: (jvoung) Disable run_clock_cputime_test under qemu since it uses threads.
r12844: (jfb) PNaCl: Update Clang revision in pnacl/COMPONENT_REVISIONS
r12845: (dyen) Updated Once so that it remembers the list of all cached directories.
r12846: (noelallen) Add bionic build target to untrusted.gypi
r12847: (noelallen) Roll bionic source.
r12848: (jvoung) Clean up large_tests vs size='small', move some to small_tests.
r12849: (mcgrathr) Update ARM toolchain in TOOL_REVISIONS
r12850: (mseaborn) Remove the unused and non-functioning ioctl syscall
r12851: (dyen) Moved common python library files from build to pynacl.
r12852: (mseaborn) Disable the sysbrk() system call under PNaCl for security hardening
r12853: (yyanagisawa) Fixed bug on IsEnvFlagTrue.
r12854: (jfb) Update TOOL_REVISIONS for PNaCl r12834->r12851
r12855: (dyen) Fix for corpus_utils missing RemoveDir function.
r12856: (jvoung) Remove bots scripts for the old PNaCl merge bot.
r12857: (jvoung) Move varargs tests w/ aggregates out of known failures, since they pass.
r12858: (sbc) Update glibc version in TOOL_REVISIONS
r12859: (jfb) PNaCl: update deps_update.py for the new build
BUG=none
TEST=browser_tests and nacl_integration
R=bradnelson@google.com
Review URL: https://codereview.chromium.org/200423002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=ronghuawu@chromium.org
Review URL: https://codereview.chromium.org/198983004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=fsamuel@chromium.org, lazyboy@chromium.org
Review URL: https://codereview.chromium.org/199413014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
their extension has failed.
Change originally created by joshtrask@ in https://codereview.chromium.org/161053002 and updated, including adding functionality to reload the extension, by me.
BUG=345804
Review URL: https://codereview.chromium.org/175773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/196103003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=b/13250097
Review URL: https://codereview.chromium.org/198503003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allows history search suggestions to be deleted from the omnibox. The
implementation is the same as for psuggest except we don't need to
make a call to web server to delete the suggestion.
BUG=22641
Review URL: https://codereview.chromium.org/199803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257231 0039d316-1c4b-4281-b951-d872f2087c98
|