| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5104001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66540 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63505
TEST=n/a
Review URL: http://codereview.chromium.org/5203001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also change omnibox_keyword -> omnibox.keyword.
BUG=63448,63449
TEST=unit tests
Review URL: http://codereview.chromium.org/5172002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Unittests
Review URL: http://codereview.chromium.org/4946001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Renames device_management_backend_impl_mock.h to device_management_backend_mock.h.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5135003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
denied error.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5122004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Block chrome uninstallation until next reboot.
BUG=63345
TES=see bug.
Review URL: http://codereview.chromium.org/5134003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
detection service object.
BUG=63358
TEST=ClientSideDetectionServiceTest
Review URL: http://codereview.chromium.org/5029003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/5147002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NPVariant instead of a string, causing us to construct a std::string from an invalid pointer and length. This may have previously been "hidden" by a coincidence of stack layout that made the uninitialized length be 0, but it is now very reproducible.
Also fix a leaked ref count on the location object.
TEST=repro'ed the void location.href issue in Chrome 8.0.552.200 on Windows and verified no crash
BUG=none
Review URL: http://codereview.chromium.org/5092005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=63475
TEST=manual; see bug
Review URL: http://codereview.chromium.org/5103003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Someone moved the files in PPAPI around and hand-modified autogenerated files.
This CL moves the change to the .py file used to generate them.
BUG=none
TEST=generated files identical to hand-modified version.
Review URL: http://codereview.chromium.org/5147003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=antonm@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66519 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is not the actual list where the entry is stored.
This CL recognizes that case and hanldes removing
that entry from the lists, without saying that there
is critical corruption.
BUG=38859
TEST=net_unittests
Review URL: http://codereview.chromium.org/5119001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit f91a6836c6905908b481305eb49df7cfb39567c7.
This fix the compile failure in arm build that is using the views implementation
of MenuGtk instead of the Gtk implementation.
BUG=63073
TEST=see bug
Review URL: http://codereview.chromium.org/5026004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
initialization fails.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5186002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66514 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26339
TEST=sync_unit_tests
Review URL: http://codereview.chromium.org/5125001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66513 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed periods from error page headings
check/uncheck -> select/deselect
internet -> Internet
BUG=61144
TEST=manual
Review URL: http://codereview.chromium.org/5009004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
single-process mode.
BUG=None
TEST=Make sure select and autofill/autocomplete popups work
on Mac and other platforms.
Review URL: http://codereview.chromium.org/5160001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This broke the windows compile as I forgot to remove gyp file references to them.
BUG=none
TEST=it compiles
Review URL: http://codereview.chromium.org/5171002
TBR=siggi@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=build
Review URL: http://codereview.chromium.org/5127004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
that were breaking.
BUG=62880,39070,62880
TEST=sync_unit_tests
Review URL: http://codereview.chromium.org/5047002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66507 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Disable ErrorPageTest.Page404_GoBack on Mac Valgrind, hangs.
* Expand suppression for 60850.
* Add a suppression for 63513.
TBR=thestig
BUG=63514,63513,60850
TEST=none
Review URL: http://codereview.chromium.org/5146002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5096002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66505 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
external files.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5127002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66504 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=non
Review URL: http://codereview.chromium.org/5129001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66503 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is "single file" or "multiple files".
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/5109002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=it compiles
Review URL: http://codereview.chromium.org/5171002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Already got r+ from Ben on that issue.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
version of InFlightIO & Co.
BUG=55629
TEST=current tests.
Review URL: http://codereview.chromium.org/4956001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GDK event to KeyEvent, the case information is lost (see
keyboard_code_conversion_gtk.cc).
BUG=none.
TEST=none.
Patch from Varun Jain <varunjain@chromium.org>
Review URL: http://codereview.chromium.org/3226015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/4842001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
duplicate the whole suite for MAC
TBR=antonm@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66492 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
initialization fails.
BUG=none
TEST=run GPU process under valgrind on a machine w/no GPU
Review URL: http://codereview.chromium.org/5181002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium side of http://trac.webkit.org/changeset/72141, needed to pass Acid3.
Changes the default minimum font size from 1 to 0.
BUG=none
TEST=acid3
Review URL: http://codereview.chromium.org/4954002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66488 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionDOMUI::GetBrowser must return the browser in which the exension resides, not any browser matching the same profile.
BUG=60795
TEST=ExtensionApiTest.*,
Review URL: http://codereview.chromium.org/5057001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66486 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Guarded static members with an assertion that they are invoked on the right thread.
Guarded non-static members with an assertion that NonThreadSafe::CalledOnValidThread() is true.
GpuProcessHost automatically routes unhandled control messages to the UI shim.
Moved gpu_info to the UI shim, which is the thread it is accessed on.
TEST=webgl, CSS 3D locally, try
BUG=none
Review URL: http://codereview.chromium.org/5130001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=antonm@chromium.org
Review URL: http://codereview.chromium.org/5091003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
because logging instantiates objects, and under some compiler settings the two cannot coexist in the same function.
BUG=none
TEST=it compiles
Review URL: http://codereview.chromium.org/5104003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=57469
TEST=none
Review URL: http://codereview.chromium.org/5032004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:8618
TEST=Manual
Review URL: http://codereview.chromium.org/5142002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=56843
TEST=none
Review URL: http://codereview.chromium.org/5008004
Patch from James Maclean <wjmaclean@chromium.org>.
TBR=scottbyer@google.com
Review URL: http://codereview.chromium.org/5137002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a singleton settings window.
BUG=59889
TEST=none
Review URL: http://codereview.chromium.org/4145013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=56843
TEST=none
Review URL: http://codereview.chromium.org/5008004
Patch from James Maclean <wjmaclean@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=38859
TEST=none
Review URL: http://codereview.chromium.org/5112002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These appear to have been following the pattern of:
ScreenLocker::Show();
...
ui_test_utils::WaitForNotification(
NotificationType::SCREEN_LOCK_STATE_CHANGED);
I believe that this hangs until the test times out if the
notification is sent before we return from Show() (since we
won't yet be listening for the notification at the time).
I'm changing them to:
ScreenLocker::Show();
...
if (!chromeos::ScreenLocker::GetTester()->IsLocked())
ui_test_utils::WaitForNotification(
NotificationType::SCREEN_LOCK_STATE_CHANGED);
The old version looks like it started failing with my
r66287, which I don't understand -- I thought that we were
already generating the notification immediately as of
r66131, which fixed a bug where the initial attempt to grab
the pointer and keyboard always failed (thus ensuring that
the notifications wouldn't be sent until the next time that
the event loop was run).
BUG=none
TEST=all screen locker tests passed on my local machine
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66340
Review URL: http://codereview.chromium.org/5054004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
version.
Also fix a memory leak in the Chrome Frame automation code.
BUG=61609
TEST=Chrome.exe always loads the specified chrome.dll when run by Chrome Frame.
Review URL: http://codereview.chromium.org/5090001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=56449
TEST=none
Review URL: http://codereview.chromium.org/5124001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise, if it's already in its own window group, it won't
be able to break other widgets' grabs.
This also separates out the showing and grabbing code, so we
can show the widget before mapping the locker window and then
grab the pointer and keyboard afterwards.
BUG=chromium-os:8999,chromium-os:9200
TEST=opened a context menu and checked that screen locks immediately. also tested that the original problem with modal dialogs didn't regress
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66287
Review URL: http://codereview.chromium.org/5013003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66460 0039d316-1c4b-4281-b951-d872f2087c98
|