| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246042 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165445:165457&mode=html
TBR=
BUG=
Review URL: https://codereview.chromium.org/134153004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Maximum number of pod rows for sign-in screen is set to 2 when we have warning banner, so that it doesn't break the layout.
BUG=334414
Review URL: https://codereview.chromium.org/138903003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246039 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I managed to hit this problem locally by following reproduction steps in
bug 335031. My guess is that this might be causing data corruption and
several so-far unexplained crashes, so I think that a reasonable first step
is to upgrade the DCHECK to a CHECK.
Committing as TBR to get this in asap.
BUG=335031
TBR=agl@chromium.org
NOTRY=True
Review URL: https://codereview.chromium.org/143443002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=332499
Review URL: https://codereview.chromium.org/139543007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Add --gdb-browser to run the browser process inside gdb.
2. Any additional arguments after testcase are passed to chrome.
3. Re-runnable chrome command printout.
BUG=260848
Review URL: https://codereview.chromium.org/141483003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=xiyuan@chromium.org
Review URL: https://codereview.chromium.org/138903004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There are several problems with wallpaper loading:
1) WallpaperLoader is asynchronous, but exposes synchronous API. Therefore callers do not know when request is finished and whether it is completed or not.
2) WallpaperLoader doesn't have "rate limit" on SetWallpaper requests, therefore it is implemented outside of it (currently in JS). Taking into account the fact that caller has no way to know the result of request, this mechanism leads to stuck wallpaper, or even to blocked UI.
This CL introduces:
1) A callback is passed along with load request to WallpaperLoader to get "Finished" event.
2) Wallpaper load scheduler in WallpaperManager to "rate limit" load requests. It has automatic load delay management so that most SetUserWallpaper() requests would become immediate. But delay is automatically adjusted to the average of several last load attempts.
BUG=333809
TEST=manual
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245925
Review URL: https://codereview.chromium.org/88263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Broke the clang cros build:
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20%28Clang%20dbg%29&number=42928
> apps: Install the shaped window-targeter on the app windows.
>
> Previously in chromium, a ShapedNativeAppWindowTargeter was introduced in
> r245757 to make sure hit-testing for events work correctly for windows with
> custom shapes. However, the targeter was never actually installed on any
> window, causing it to not function properly. In this episode, we install
> the shaped targeter on the window, and add a test (with some relevant
> refactoring) to make sure it functions correctly.
>
> BUG=318879
> R=benwells@chromium.org
>
> Review URL: https://codereview.chromium.org/134733004
TBR=sadrul@chromium.org
Review URL: https://codereview.chromium.org/131023007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165441:165444&mode=html
TBR=
BUG=
Review URL: https://codereview.chromium.org/143963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is an experimental fix, as it is difficult to repro actual bug.
BUG=254545
R=cpu
TBR=nduca
Review URL: https://codereview.chromium.org/142253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The bug is that a request is deleted if it has no opened devices regardless if this request has anything to do with the device we are trying to stop.
The fix is to make sure a request is only deleted if the request actually used the device that we are closing.
BUG=332386
Review URL: https://codereview.chromium.org/143373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=333554,323847
Review URL: https://codereview.chromium.org/142933006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246026 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously in chromium, a ShapedNativeAppWindowTargeter was introduced in
r245757 to make sure hit-testing for events work correctly for windows with
custom shapes. However, the targeter was never actually installed on any
window, causing it to not function properly. In this episode, we install
the shaped targeter on the window, and add a test (with some relevant
refactoring) to make sure it functions correctly.
BUG=318879
R=benwells@chromium.org
Review URL: https://codereview.chromium.org/134733004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously quiet progress items which don't have progress bar were wrongly
regarded as they have a progress bar and the bar is animated. The items marked
as animated wait for the CSS transition-end event but it never happens.
This CL fix the condition to determine if an item should be animated or not.
BUG=336309
TEST=manually
Review URL: https://codereview.chromium.org/135573003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246024 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL introduces the TranslateDriver and a content implementation of it
(ContentTranslateDriver), and moves LanguageState to the translate component.
LanguageState gets information from the content driver through the
TranslateDriver API.
BUG=335092
Review URL: https://codereview.chromium.org/133273029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This fixes possible test bugs when can_dock is false.
BUG=none
Review URL: https://codereview.chromium.org/133383003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246021 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the internal repository, several Mac- and Windows-specific icon files
have been moved into 'mac' and 'win' subdirectories in
chrome/app/theme/google_chrome. This updates the references to those
icons to refer to their new location.
BUG=333751
Review URL: https://codereview.chromium.org/138553005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The perf results didn't change after reverting this CL so I am going to
bring it back in.
> Revert profile cleanup temporarily to verify regression is really caused by it.
>
> BUG=310934
> TEST=Let's see what the chrome-rel-mac6 bot has to say about this.
>
> Review URL: https://codereview.chromium.org/128413003
TBR=pastarmovj@chromium.org
Review URL: https://codereview.chromium.org/134733006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=jkummerow@chromium.org
Review URL: https://codereview.chromium.org/143943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The list of OWNERS added is the same as that of //components/signin/OWNERS.
R=joi@chromium.org
Review URL: https://codereview.chromium.org/142973006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL caused massive UAF/invalid free reports on the Valgrind bot
BUG=336360
> [GCM] Introduce GCMClientFactory to create GCMClient for GCMProfileService
>
> We used to call GCMClient::Get() to get the single instance. This did not
> work when we need to pass some initialization data from browser to it.
> GCMClientFactory is introduced such that GCMClient instance can be
> created, initialized and used in GCMProfileService::IOWorker.
>
> BUG=284553
> TEST=existing tests
>
> Review URL: https://codereview.chromium.org/135903005
TBR=jianli@chromium.org
Review URL: https://codereview.chromium.org/134083006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246013 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allow specifying the window size that is used for transmitting data,
ie. client_max_window_size.
Add tests WindowBits8 and WindowBits10 to verify that the parameter is
effective.
BUG=280910
TEST=net_unittests --gtest_filter=WebSocketDeflateStream*
Review URL: https://codereview.chromium.org/143823002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165427:165440&mode=html
TBR=
BUG=
Review URL: https://codereview.chromium.org/142903005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246010 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
-- exclude NTPUserDataLoggerTest.TestLogging under all tools (issue 336349)
-- exclude AutoclickTest.UserInputCancelsAutoclick under Memcheck (issue 336351)
BUG=336349,336351
TBR=eugenis@chromium.org
Review URL: https://codereview.chromium.org/143883004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Renamed DeviceImageFormatHack to BuggyDeviceHack and extended
to hold a list of (1) devices listed by Model+Device for which minimum
width and height are given.
That is used to check for model etc and if necessary to overwrite
capture sizes smaller than that.
Test it via f.i. [1] and making sure 320x240 resolution is not
excessively zoomed in w.r.t. 640x480 or higher.
[1] http://webrtc.googlecode.com/svn/trunk/samples/js/demos/html/constraints-and-stats.html
BUG=305294
Review URL: https://codereview.chromium.org/138063004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=336349
TBR=eugenis@chromium.org
Review URL: https://codereview.chromium.org/143953002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
-- suppress more races on command line switches, include former suppressions from issue 268946 (issue 334140)
BUG=268946,334140
TBR=satorux@chromium.org
Review URL: https://codereview.chromium.org/143103003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246004 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LauncherContextMenuTest.NewIncognitoWindowMenuIsDisabledWhenIncognitoModeOff
under DrMemory on Windows
BUG=336343
TBR=eugenis@chromium.org
Review URL: https://codereview.chromium.org/143883003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246003 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=336328
TEST=Navigate to a site that negotiates
TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305 (eg: https://www.gmail.com )
and, if TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305 is negotiated, confirm
that the key exchange algorithm is listed as ECDHE_ECDSA with the
encryption/authentication alg as CHACHA20_POLY1305
Review URL: https://codereview.chromium.org/139743003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246001 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously we switched from the localStorage to the chrome.storage.local, but
one flag is still stored into localStorage. We can no longer use the local
storage from the pack app. This CL completely removes usage of the localStorage.
BUG=336143
TEST=manually
Review URL: https://codereview.chromium.org/135183007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will make it explicit that the counters are accessed without synchronization and will also suppress TSan v2 warnings.
BUG=46840
R=jar@chromium.org,kaiwang@chromium.org
Review URL: https://codereview.chromium.org/116983004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Mavericks with the "Displays have separate Spaces" option, OSX has
stopped switching out of the fullscreen space when activating a window
in the non-active application, other than by clicking its Dock icon.
Since the app launcher Dock icon is not Chrome, this can leave a user in
fullscreen with the app launcher window obscured.
This CL overrides a private method, -[NSWindow
_allowedInOtherAppsFullScreenSpaceWithCollectionBehavior:] to allow the
app launcher to appear on top of other applications in fullscreen. Then,
since clicking that window will make Chrome active, subsequent window
activations will successfully switch the user out of the fullscreen
space.
BUG=326405
Review URL: https://codereview.chromium.org/143753002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=165425:165426&mode=html
TBR=
BUG=
Review URL: https://codereview.chromium.org/143793002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently the localized name of Downloads directory is not used. This CL fixes it.
BUG=336182
TEST=manually
Review URL: https://codereview.chromium.org/143273002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
BUG=333038
Review URL: https://codereview.chromium.org/136853008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
/inspector-enabled/ test
Clearing the devtools' localStorage when showing its window is wrong, since this makes it
impossible to execute subsequent openings of the devtools with retained settings in a single test.
R=pfeldman
BUG=335893
Review URL: https://codereview.chromium.org/130703005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245991 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
player.
Converting from URLs to Entries required permissions, which are granted asynchronously by the volume manager. Therefore, we have to call ensureInitialized() before trying to resolve them.
TEST=Tested manually.
BUG=336301
Review URL: https://codereview.chromium.org/143463003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch removes web extents from bookmark apps and stops them from
using the launch url as the web extent by default. This was preventing
creation of bookmark apps for any page that was in an overlapping extent
(e.g it wasn't possible to create a bookmark app for drive.google.com/keep
while the default Google Drive app was installed).
This doesn't affect the hosted app security model because bookmark apps
don't use the hosted app process model and have no permissions.
BUG=318607
TBR=dbeam@chromium.org
Review URL: https://codereview.chromium.org/137513003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add FileCache::UpdateMd5().
Stop setting MD5 with FileCache::ClearDirty().
Remove UpdateOperation::ContentCheckMode. (Instead, use FileCacheEntry::md5 to determine whether content check is needed or not.)
MD5 of a FileCacheEntry changes as follows:
(md5.empty()==true means MD5 is unknown)
1. FileCache::Initialize clears MD5 of all dirty entries for backward compatibility.
2. FileCache::OpenForWrite clears MD5.
3. FileCache::UpdateMd5 calculates MD5.
4. FileCache::ClearDirty does nothing for MD5.
UpdateOperation behaves in the following way:
- Before upload, UpdateMD5() is called if FIleCacheEntry::MD5 is empty. IsOpenedForWrite() is used to prevent unneeded upload from starting.
- After upload, ResourceEntry's MD5 is checked against FileCacheEntry::MD5. If it doesn't match, it means someone has opened the file (i.e. clearing MD5) so shouldn't clear the dirty bit.
BUG=326054
TEST=unit_tests
R=kinaba@chromium.org
Review URL: https://codereview.chromium.org/114953003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245981 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This brings in proper svn:executable properties for Syzygy binaries, fixing Cygwin support.
BUG=none
TEST=No more "access denied" on the swapimport step of the build on a clean
Cygwin checkout
R=pkasting@chromium.org
Review URL: https://codereview.chromium.org/142453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and re-enable.
Threaded animations are crashy on Snow Leopard. Since there's not much
test coverage for Lion either, this CL falls back to non-threaded
animations for Snow Leopard and Lion for showing the Mac App Launcher.
BUG=335550
Review URL: https://codereview.chromium.org/142873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245976 0039d316-1c4b-4281-b951-d872f2087c98
|