summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Green the layout test bots by marking some new failures.estade@chromium.org2009-03-181-0/+3
| | | | | | | | TBR=jkhawkins Review URL: http://codereview.chromium.org/42347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11992 0039d316-1c4b-4281-b951-d872f2087c98
* Implement GTK dropdown menus.estade@chromium.org2009-03-184-23/+108
| | | | | | | | These are used for <select> html items, for example. Review URL: http://codereview.chromium.org/48054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11991 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mac build break.estade@chromium.org2009-03-181-1/+0
| | | | | | | | tbr=avi Review URL: http://codereview.chromium.org/48139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11988 0039d316-1c4b-4281-b951-d872f2087c98
* Autocomplete now uses the input field id when no name is available to ↵jcampan@chromium.org2009-03-183-9/+31
| | | | | | | | | | | | perform autocomplete. This matches FF behavior. BUG=6310 TEST=See bug. Review URL: http://codereview.chromium.org/48033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11987 0039d316-1c4b-4281-b951-d872f2087c98
* Let checkdeps ignore #if 0 blocks. Also strip lines of leading/trailing ↵thestig@chromium.org2009-03-182-4/+14
| | | | | | | | whitespaces before checking. Review URL: http://codereview.chromium.org/42316 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11986 0039d316-1c4b-4281-b951-d872f2087c98
* Rolling forward cygwin version to include hermetic python when including ↵bradnelson@google.com2009-03-181-1/+1
| | | | | | | | hermetic cygwin in setup_env.bat Review URL: http://codereview.chromium.org/48137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11985 0039d316-1c4b-4281-b951-d872f2087c98
* Removes LayoutTests/fast/events/click-count.html from the flakey winsky@google.com2009-03-181-1/+1
| | | | | | | | | | | | list. This test hasn't failed in a long time. BUG=none TEST=none TBR=tc Review URL: http://codereview.chromium.org/42342 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11984 0039d316-1c4b-4281-b951-d872f2087c98
* Fix underflow that would cause either an access violation or an infinite ↵robertshield@google.com2009-03-181-2/+3
| | | | | | | | loop if we were ever to get a "chrome_config" node back in metrics response data. Review URL: http://codereview.chromium.org/42335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11983 0039d316-1c4b-4281-b951-d872f2087c98
* Remove BrowserWindow::Init().estade@chromium.org2009-03-187-111/+99
| | | | | | | | This belongs as a private method of BrowserView. Neither mac nor linux uses it. Review URL: http://codereview.chromium.org/42298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11982 0039d316-1c4b-4281-b951-d872f2087c98
* Fix errors detected by coverity.paulg@google.com2009-03-181-6/+6
| | | | | | Review URL: http://codereview.chromium.org/48136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11981 0039d316-1c4b-4281-b951-d872f2087c98
* Adds Get(Root)WindowRect handlers for the Mac.avi@google.com2009-03-188-65/+120
| | | | | | | | Fixes http://crbug.com/8829 . Review URL: http://codereview.chromium.org/42336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11980 0039d316-1c4b-4281-b951-d872f2087c98
* Make Linux use the same user agent style sheet as Windows.levin@chromium.org2009-03-184-8/+3
| | | | | | Review URL: http://codereview.chromium.org/48122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11978 0039d316-1c4b-4281-b951-d872f2087c98
* Reland the changes to use command line switch to turn on worker feature.jianli@chromium.org2009-03-184-0/+10
| | | | | | Review URL: http://codereview.chromium.org/48106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11975 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded uses of base/ref_counted.h.thestig@chromium.org2009-03-1820-22/+10
| | | | | | Review URL: http://codereview.chromium.org/48105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11974 0039d316-1c4b-4281-b951-d872f2087c98
* Fix dragging a Chrome window which has a single tab by the tab itself.idanan@chromium.org2009-03-181-7/+1
| | | | | | | | | | | | | | | | | | | A change in 9953 made a tab of a single chrome-window with a single tab part of the client area so that double-clicks on it are not treated as non-client double-clicks and that the tab context-menu appears instead of the system context menu (see issue 3787). That change also solved issue 2827 (which is not restructed to the close button of the right-most tab). Change 10929 reverted 9953 partially, keeping the sinle-tab of a single-window as part of the client area but removed the double-click swallowing code that was needed to fix 2827. In doing so, dragging a single-tabbed single chrome window by the tab (not the tabstrip) no longer worked. This small changes only fixes that behavior. It turns out that there was a use case where some users want double-clicks to be considered as two single-clicks (see issue 8287) and swallowing the double-click breaks this. Review URL: http://codereview.chromium.org/46033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11973 0039d316-1c4b-4281-b951-d872f2087c98
* Style issues:patrick@chromium.org2009-03-181-4/+6
| | | | | | | | | - Fix indentation. - Reorder typedefs according to style guide. - Add DISALLOW_COPY_AND_ASSIGN. Review URL: http://codereview.chromium.org/42322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11971 0039d316-1c4b-4281-b951-d872f2087c98
* Base class for audio and video decoders, plus a test audio and video decoder ↵ralphl@chromium.org2009-03-1812-0/+599
| | | | | | | | | | implementation. Note that the FFmpeg decoder classes are declared, but are completely non-functional at this time. This is the first step towards getting actual, functional media decoders checked into the Chrome project. Review URL: http://codereview.chromium.org/43060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11970 0039d316-1c4b-4281-b951-d872f2087c98
* When looking for the test shell binary in linux, try src/webkit/Hammertc@google.com2009-03-182-2/+6
| | | | | | | | | | then src/chrome/Hammer. This is needed to allow --target=Debug to work in linux on the buildbot. Review URL: http://codereview.chromium.org/42310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11969 0039d316-1c4b-4281-b951-d872f2087c98
* Reland the changes to enable building worker.jianli@chromium.org2009-03-182-2/+2
| | | | | | | | | | | I reuse this CL to reland the changes. The change to src/DEPS is not needed any more since my change to third_party/WebKit is not reverted and src/DEPS has already been bumped up to pick up my changes. This is exactly like what are in the original code review: http://codereview.chromium.org/41029 Review URL: http://codereview.chromium.org/42287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11968 0039d316-1c4b-4281-b951-d872f2087c98
* Unfork WebInspector frontend take 2: New DEPS and webkit/...pfeldman@chromium.org2009-03-186-3/+18
| | | | | | Review URL: http://codereview.chromium.org/48132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11967 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an assertion I added in my DOM UI change. It looks like this happens inbrettw@chromium.org2009-03-181-5/+0
| | | | | | | some cases and doesn't represent an actual problem. Review URL: http://codereview.chromium.org/48134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11966 0039d316-1c4b-4281-b951-d872f2087c98
* Add a handle scope to V8Proxy::initContextIfNeeded.ager@chromium.org2009-03-181-1/+4
| | | | | | | | | | | | initContextIfNeeded can be called without a handle scope in place which will lead to a renderer crash when creating the first handle. Also V8Proxy::initContextIfNeeded creates a number of local handles that should be deallocated on exit. BUG=8922 Review URL: http://codereview.chromium.org/48131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11965 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing a few minor issues found during static analysis of the Chromium codebase.finnur@chromium.org2009-03-184-7/+7
| | | | | | | | | | | | | | | | | | | | | | find_bar_controller.cc: Unused local variable created. hwnd_view.cc: The local definition of parent overshadows param passed in. google_update.cc: Uninitialized member variable. webframe_impl.cc: The if was overly constrained. At the top of the function there is an if (reset) { ... return; } so we don't need to check for !reset in the next if statement. This functionality is covered by a ui_test, which passes with this change. Review URL: http://codereview.chromium.org/42321 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11964 0039d316-1c4b-4281-b951-d872f2087c98
* Make startup_tests print results on Linux.phajdan.jr@chromium.org2009-03-187-160/+161
| | | | | | | | Switch from wstring to string where needed. Review URL: http://codereview.chromium.org/42303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11963 0039d316-1c4b-4281-b951-d872f2087c98
* Port DirectoryWatcher to Linux using inotify.phajdan.jr@chromium.org2009-03-188-50/+493
| | | | | | Review URL: http://codereview.chromium.org/42037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11962 0039d316-1c4b-4281-b951-d872f2087c98
* Change the stub for file_util::EvictFileFromSystemCachethomasvl@chromium.org2009-03-181-3/+4
| | | | | | | | | | I don't think there is a way to get something out of the UBC once it's in, so for now I'm just making this api return true so it won't fail unittests. I have email out to Amit incase he has any ideas. Review URL: http://codereview.chromium.org/42333 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11961 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the src/webkit part of r11958 since it broke the build.maruel@chromium.org2009-03-185-17/+2
| | | | | | | TBR=pfeldman Review URL: http://codereview.chromium.org/42332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11960 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize module_handle_ in IATPatch's constructor.deanm@chromium.org2009-03-181-1/+2
| | | | | | | | | The uninitialized value wasn't used since it was guarded by other members, but it is still better to initialize the member explicitly. Review URL: http://codereview.chromium.org/48130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11959 0039d316-1c4b-4281-b951-d872f2087c98
* Unfork WebInspector frontend.pfeldman@chromium.org2009-03-185-2/+17
| | | | | | Review URL: http://codereview.chromium.org/48063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11958 0039d316-1c4b-4281-b951-d872f2087c98
* Make Rpc dispatch in DevTools static, remove redundant JSON parsing.pfeldman@chromium.org2009-03-186-28/+31
| | | | | | Review URL: http://codereview.chromium.org/44007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11957 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an unused bool member variable "opened_" from StatsTable.deanm@chromium.org2009-03-181-6/+6
| | | | | | | Review URL: http://codereview.chromium.org/48129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11956 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 11946 since it is causing a build breakage on full rebuild. The maruel@chromium.org2009-03-183-6/+128
| | | | | | | | | | sandbox project wasn't copying wow_helper.exe anymore, causing a build breakage on x64 platforms only. TBR=bnelson Review URL: http://codereview.chromium.org/42328 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11955 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11953.hbono@chromium.org2009-03-1815-241/+1
| | | | | | Review URL: http://codereview.chromium.org/48121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11954 0039d316-1c4b-4281-b951-d872f2087c98
* A tricky fix for Issue 1845.hbono@chromium.org2009-03-1815-1/+241
| | | | | | | | | | | | | | | | | This change is a very tricky fix for Issue 1845 in chromium: cant alignt text to the right using right shift and right ctrl.This change consists of two parts listed below. 1. Emulating the implementation of Safari that changes the text-direction of an input element. Safari uses context menus to change the text direction. This change adds an IPC message 'ViewMsg_SetTextDirection', which notifies the new text direction. Also, it adds two functions: RenderWidgetHost::UpdateTextDirection() and RenderWidgetHost::NotifyTextDirection(). They encapsulate the new IPC message so that we can use them both when we presses a set of keys and when we add context-menu items which change the text direction. 2. Calling the above interface when pressing right-shift and right-control keys, or when left-shift and left-control keys. This modifies the RenderWidgetHostViewWin::OnKeyEvent() function and call the above text-direction interfaces when a user finishes pressing the keys. As you can imagine, if we send an IPC message every time when we receive a WM_KEYDOWN event, we continue sending IPC messages while a user is pressing the keys. BUG=1845 Review URL: http://codereview.chromium.org/39252 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11953 0039d316-1c4b-4281-b951-d872f2087c98
* Make worker constructor return error if it is enabled by the flag.jianli@chromium.org2009-03-184-1/+23
| | | | | | | This is to move corresponding files out of http://codereview.chromium.org/48106/ so that this can be checked in before the change to enable worker. The reason for doing this is to avoid build break since the already checked-in third_party/WebKit/WebKit/chromium/src/WebKit.cpp has the ifdef guarded code depend on this. Review URL: http://codereview.chromium.org/42313 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11952 0039d316-1c4b-4281-b951-d872f2087c98
* Quick fix to prevent double launch of chrome at install.cpu@google.com2009-03-181-1/+3
| | | | | | | | | | | - According to docs we should not be writing InstallerSuccessLaunchCmdLine - Might affect gcapi BUG=1719600 Review URL: http://codereview.chromium.org/48120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11950 0039d316-1c4b-4281-b951-d872f2087c98
* Moving sbox to gyp on windows.bradnelson@google.com2009-03-183-128/+6
| | | | | | | | | (Also fixing missing property on sdch.) Review URL: http://codereview.chromium.org/42317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11946 0039d316-1c4b-4281-b951-d872f2087c98
* - Modify DOM checker automation to use DOM Automation Controller instead ofpatrick@chromium.org2009-03-1810-143/+737
| | | | | | | | | | | | | | | | | cookie values to get results back to the test executable. This fixes an issue where the test could not be automated to run from local disk - that required file cookies, which causes the DOM checker test to fail. This is also a cleaner approach. - Add test to run DOM checker automation from local disk. - Add code to optionally disable file cookies in UI tests. Disable them in the DOM checker tests. - Add a function to the UITest class that allows a test to wait for a JavaScript condition in the test page. BUG=6274 Review URL: http://codereview.chromium.org/48055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11945 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing subtle dependency on client name on my last change to chrome.sln.bradnelson@google.com2009-03-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/48119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11944 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline fail. Marking LayoutTests/fast/forms/searchfield-heights.html fixableaa@chromium.org2009-03-181-0/+1
| | | | | | | | | again. TBR Review URL: http://codereview.chromium.org/42315 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11943 0039d316-1c4b-4281-b951-d872f2087c98
* Switching net over to use gyp on windows.bradnelson@google.com2009-03-1815-2353/+1752
| | | | | | Review URL: http://codereview.chromium.org/48108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11942 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leak in GetCertSubjectAltNamesOfType(). Found by valgrind.dkegel@google.com2009-03-181-0/+1
| | | | | | | | | | | | ERROR:root:Leak_DefinitelyLost malloc (ome/kcc/depot2-kcc-ts_valgrind-client/google_vendor_src_branch/valgrind/trunk/coregrind/m_replacemalloc/vg_replace_malloc.c:207) ... CERT_FindCertExtension (/usr/lib32/libnss3.so.1d) net::(anonymous namespace)::GetCertSubjectAltNamesOfType(CERTCertificateStr*, CERTGeneralNameTypeEnum, std::vector<std::string, std::allocator<std::string> >*) (net/base/x509_certificate_nss.cc:134) Review URL: http://codereview.chromium.org/48097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11941 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline LayoutTests\fast\forms\searchfield-heights-expected. Text input boxesaa@chromium.org2009-03-184-3/+2
| | | | | | | seem to be off by a tiny bit. Review URL: http://codereview.chromium.org/42304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11940 0039d316-1c4b-4281-b951-d872f2087c98
* Remove bogus DCHECKabarth@chromium.org2009-03-181-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11938 0039d316-1c4b-4281-b951-d872f2087c98
* SSLPolicy Fix: Step 8.abarth@chromium.org2009-03-184-144/+267
| | | | | | | | | | | Cleanup the SSLPolicy API. This should be the last reorganization patch. The next step should be the substantive changes. R=jcampan BUG=8706 Review URL: http://codereview.chromium.org/48091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11937 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark work. jrg@chromium.org2009-03-1832-240/+815
| | | | | | | | | | | | | | | | | | | | | - The bookmark menu is populated dynamically with bookmarks, including subfolders --> submenus. E.g. star something --> shows up in menu. Menu items are disabled but always present and current. - Always Show Bookmarks" menu now live; reads from / writes to preference, and shows correct "toggle state". - Bookmark bar on each tab, present if requested. (Currently an empty box). - Random stuff; e.g. bookmark prefs init moved to a x-plat location. This CL does not contain Cole's views. Bried english description of the nib file changes: - add a new view for the bookmark bar in the tab; hook it up to the controller - Many tag sets (e.g. View-->Always Show Bookmarks Bar now 40009) - Remove dummy bookmark menu items Review URL: http://codereview.chromium.org/46078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11936 0039d316-1c4b-4281-b951-d872f2087c98
* Pre-upstream cleaning of files - changing them to follow WebKit coding style.dimich@google.com2009-03-174-448/+416
| | | | | | Review URL: http://codereview.chromium.org/42308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11935 0039d316-1c4b-4281-b951-d872f2087c98
* Mark LayoutTests/svg/custom/foreignObject-crash-on-hover.xml as DEFER.patrick@chromium.org2009-03-171-5/+5
| | | | | | Review URL: http://codereview.chromium.org/48104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11933 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r11926 which accidentally enabled workers.dimich@google.com2009-03-171-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11931 0039d316-1c4b-4281-b951-d872f2087c98
* Get v8_collection.h to match webkit coding standards inlevin@chromium.org2009-03-172-237/+205
| | | | | | | | preparation for upstreaming. Review URL: http://codereview.chromium.org/42294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11930 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 01:21:38 +0000