| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
This CL adds a getStatus method to UrlRequest.
Design doc: https://docs.google.com/a/google.com/document/d/1P6GWBwvuzC9J6DmI7xtwuO1PZBJOkMmgrNfMx0FzcMs/edit?usp=sharing
Review URL: https://codereview.chromium.org/1182443004
Cr-Commit-Position: refs/heads/master@{#335794}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The first time we run a build on a GN builder, it's possible
that MB will run and the build directory (//out/Release) may not
exist yet; in that case, we need to create the directory before
trying to write the list of runtime_deps that GN will need to read.
R=maruel@chromium.org
BUG=480053
Review URL: https://codereview.chromium.org/1204793002
Cr-Commit-Position: refs/heads/master@{#335793}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We had it disabled, pending crash due to ShGetFolderPath() while checking if it is system install.
The crash should get fixed as we will use environment variable with CL https://codereview.chromium.org/1193023002/.
This CL can only be submitted after https://codereview.chromium.org/1193023002/ goes through.
BUG=501975
R=jschuh@chromium.org,jam@chromium.org,wfh@chromium.org
Review URL: https://codereview.chromium.org/1198513004
Cr-Commit-Position: refs/heads/master@{#335792}
|
|
|
|
|
|
|
|
| |
BUG=503312,450423
Review URL: https://codereview.chromium.org/1200933003
Cr-Commit-Position: refs/heads/master@{#335791}
|
|
|
|
|
|
|
|
| |
BUG=490836
Review URL: https://codereview.chromium.org/1199593006
Cr-Commit-Position: refs/heads/master@{#335790}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Optimized 161/381 files in 00:37:22s
Result: 51329 => 44617 bytes (6712 bytes: 13%)
BUG=503732
TBR=jamescook@chromium.org
Review URL: https://codereview.chromium.org/1202863002
Cr-Commit-Position: refs/heads/master@{#335789}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 2: Implementing a task-manager representation of WebContents owned
by the prerender manager.
R=nick@chromium.org
BUG=470990
TEST=browser_tests --gtest_filter=PrerenderBrowserTest.TaskManagement*
Review URL: https://codereview.chromium.org/1185183008
Cr-Commit-Position: refs/heads/master@{#335788}
|
|
|
|
|
|
|
|
|
|
|
|
| |
sent via window.postMessage. Now all messages sent will contain a 'source' field so that the dispatcher can dispatch to the registered handler.
I also turned MessageWindowManager into an object.
BUG=
Review URL: https://codereview.chromium.org/1195953003
Cr-Commit-Position: refs/heads/master@{#335787}
|
|
|
|
|
|
|
|
|
| |
BUG=503299
TBR=plundblad
Review URL: https://codereview.chromium.org/1203803002
Cr-Commit-Position: refs/heads/master@{#335786}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using flag --touch-devices=device id or not using it, touch screen should work on Linux,
but now only the touch screens with the ids after the this flag will be set as
touch screens, and we only use touch inputs from master pointer not from the
slave devices, so we are only receiving touch inputs if we set touch-devices equal to
the master pointer id.
BUG=486492
Review URL: https://codereview.chromium.org/1186833005
Cr-Commit-Position: refs/heads/master@{#335785}
|
|
|
|
|
|
|
|
|
|
|
| |
This reduces number of ashmem allocations on in-process webview, which
prevents going over the file descriptor limit.
BUG=503632, 503724
Review URL: https://codereview.chromium.org/1199243004
Cr-Commit-Position: refs/heads/master@{#335784}
|
|
|
|
|
|
|
|
|
| |
BUG=464797
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/1202843002
Cr-Commit-Position: refs/heads/master@{#335783}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1203613006
Cr-Commit-Position: refs/heads/master@{#335782}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The method returns true if we are in --site-per-process. Using a function
like this (instead of consulting the switch directly in so many places)
documents the fact that these --site-per-process checks are related,
makes them easier to rip out when the time comes, and simplifies
the implementation of bug 481066.
BUG=481066
Review URL: https://codereview.chromium.org/1195393007
Cr-Commit-Position: refs/heads/master@{#335781}
|
|
|
|
|
|
|
|
|
|
|
| |
This is compatible to other IPC::Channel implementations.
R=agl@chromium.org,viettrungluu@chromium.org
BUG=488291
Review URL: https://codereview.chromium.org/1181083003
Cr-Commit-Position: refs/heads/master@{#335780}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HistoryClient exposed methods accessed by UI or History thread. Split
the object in two only exposing method accessed by a single thread.
The HistoryClient methods can only be invoked from UI thread while the
HistoryBackendClient methods can only be invoked from History thread.
This separation is required before the History code can be refactored
not to create it's own thread.
BUG=459548,477975
Review URL: https://codereview.chromium.org/1198373002
Cr-Commit-Position: refs/heads/master@{#335779}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bad revisions are same.
For bisect mode = return_code, there is no point in bisecting revision which returned same return code,
in such cases we abort bisect early.
BUG=502433
Review URL: https://codereview.chromium.org/1205663002
Cr-Commit-Position: refs/heads/master@{#335778}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This experiment attempts to measure form submissions with no autofill. But the previous version disabled autofill completely which disabled metrics also, rendering the experiment useless.
This version just suppresses autofill suggestions when the experiment is running (i.e. autofill disabled) so the same metrics will be collected in either case.
Clarifies the meaning of the "non-fillable form" metric. I didn't realize this also included cases of non matching data and found this surprising.
BUG=503253
Review URL: https://codereview.chromium.org/1193843005
Cr-Commit-Position: refs/heads/master@{#335777}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The WebViewFocusTest class is based on WebViewTest, which is currently
disabled on the Site Isolation FYI bots. Therefore there's no real
chance of it working until WebViewTest is fixed for those bots.
This CL adds TODOs to both test classes, as well as disabling
WebViewFocusTest on the Site Isolation FYI bots as well.
BUG=none
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/1201213002
Cr-Commit-Position: refs/heads/master@{#335776}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
warning: [unchecked] unchecked conversion
return section;
^
required: List<Object>
found: List
BUG=None
Review URL: https://codereview.chromium.org/1200383002
Cr-Commit-Position: refs/heads/master@{#335775}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Large changes:
* There are no filters in 1.0, that's why 'i18n' filters were replaced with
'i18n-content' ({{'searching' | i18n}} -->
i18n-content="login_ControllerPairingScreen_searching")
* <oobe-screen> wath replaced with OobeScreenBehavior, as 1.0 doesn't support
inheritance.
* In 1.0 Polymer doesn't observe changes in properties which are Objects. That's
why all context bindings ({{C.foo}}) stopped working. Created workaround for
that problem (OobeScreenBehavior.registerBoundContextField).
Before and after versions are not totally equivalent: some styles and minor
issues were fixed.
(no presubmit because CSS checker doesn't understand CSS mixins)
BUG=489843
NOPRESUBMIT=true
TEST=existing tests
Review URL: https://codereview.chromium.org/1179323005
Cr-Commit-Position: refs/heads/master@{#335774}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
0de4753 Fix Javascript tests after commit f55771af6429.
6ea0123 Cleanup: Get rid of CPDF_Reference::Create().
5ab3fc6 Cleanup: Remove more checks for new returning NULL.
06864f7 Cleanup: Remove CFX_MapPtrToPtr from fpdfppo.cpp.
f55771a Delete dead code for deleting pages and icons.
f2d3911 Cleanup: Remove dead formfiller code.
59d60a5 Cleanup: Remove dead CPDF_InlineImages code.
e8d3691 Replace CFX_MapPtrTemplate with std::map.
cfac954 Cleanup: Do not check pointers before deleting them.
df55851 Small cleanup of CPDF_TextObject and other CPDF_PageObject subclasses.
012ada6 Disintermediation.
959eb05 Move zlib to third_party/
e295819 Move libopenjpeg to third_party/
aa23c86 Fix CPDF_ICCBasedCS::GetDefaultValue heap-buffer-overflow.
fe85afa Revert "Move libopenjpeg to third_party/"
c7a17bf Move libopenjpeg to third_party/
ff8347a Replace some Release() calls with virtual destructors.
c4d9f6a Run GYP after gclient sync.
13c1272 Move libjpeg to third_party/
16a0b24 Move lcms2 into third_party
TBR=tsepez@chromium.org
BUG=501889
Review URL: https://codereview.chromium.org/1199253004
Cr-Commit-Position: refs/heads/master@{#335773}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the screen is showed for the first time, it's possible that the "dinosaur"
image is not loaded yet. This lead to incorrect screen's size calculation in
DisplayManager.updateScreenSize. Fixed by setting image's size explicitly.
BUG=496909,488176
TEST=manually
Review URL: https://codereview.chromium.org/1196213008
Cr-Commit-Position: refs/heads/master@{#335772}
|
|
|
|
|
|
|
|
|
|
| |
TESTED=verified screen cast works from the Hangouts Call app, using the enable_hangout_services_extension flag.
BUG=415228, 500001
Review URL: https://codereview.chromium.org/1178063006
Cr-Commit-Position: refs/heads/master@{#335771}
|
|
|
|
|
|
|
|
|
|
| |
https://crrev.com/310945: Improve inferring labels from div/td tags.
BUG=427614
Review URL: https://codereview.chromium.org/1199033004
Cr-Commit-Position: refs/heads/master@{#335770}
|
|
|
|
|
|
|
|
|
|
|
| |
Finch will controll the distiller feedback form so it is
displayed for some users on beta and no users on stable.
BUG=499541
Review URL: https://codereview.chromium.org/1180943005
Cr-Commit-Position: refs/heads/master@{#335769}
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3958abc..336ca2b
TBR=schenney@chromium.org,falken@chromium.org
Review URL: https://codereview.chromium.org/1201293002
Cr-Commit-Position: refs/heads/master@{#335768}
|
|
|
|
|
|
|
|
|
|
|
| |
Domain reliability uses 400k+ of memory on the heap. Disabling it until it's
refactored when running on low memory devices.
BUG=495342
Review URL: https://codereview.chromium.org/1203573002
Cr-Commit-Position: refs/heads/master@{#335767}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First landed in: http://crrev.com/7c5be3b
Reverted due to crashing in: http://crrev.com/df8814b
This patch has the original patch and the fix for the crash. The fix is
tested in AutofillProfileSyncableServiceTest.IgnoreServerProfileUpdate.
BUG=481595
Review URL: https://codereview.chromium.org/1172133002
Cr-Commit-Position: refs/heads/master@{#335766}
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's tedious to write CL description manually. Make manage.py make the CL
description for me.
R=dpranke@chromium.org
BUG=98637
Review URL: https://codereview.chromium.org/1203753002
Cr-Commit-Position: refs/heads/master@{#335765}
|
|
|
|
|
|
|
|
|
|
|
| |
Will only send if available.
BUG=484229
TEST=FormStructure
Review URL: https://codereview.chromium.org/1192763003
Cr-Commit-Position: refs/heads/master@{#335764}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some code could not be touched earlier since iOS code still uses them.
Now that the iOS side has been fixed, we can remove or change the
autofill JS code to better match the C++ copy.
BUG=427614
Review URL: https://codereview.chromium.org/1205593002
Cr-Commit-Position: refs/heads/master@{#335763}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support the following error checks:
1) Check if the token to be deleted exist in the cache first.
2) Check error in DeleteToken response.
BUG=501627
TEST=new tests
Review URL: https://codereview.chromium.org/1191653012
Cr-Commit-Position: refs/heads/master@{#335762}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebRTC 9488:9489
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/1cd8906..81e601b
Libjingle 9485:9490
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/dad7ebd..8c44aac
TBR=
BUG=
Review URL: https://codereview.chromium.org/1207513002
Cr-Commit-Position: refs/heads/master@{#335761}
|
|
|
|
|
|
|
|
|
|
| |
After this CL, CloseSession works end-to-end.
BUG=459007
Review URL: https://codereview.chromium.org/1192733002
Cr-Commit-Position: refs/heads/master@{#335760}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit c2b81c9fca4abc10cafdc75d2e7b4f15314e2e5b.
We missed the cutoff for M45. We'll try again post-branch in M46.
TBR=thestig@chromium.org, xiyuan@chromium.org, oshima@chromium.org, mpearson@chromium.org, sky@chromium.org
BUG=492454, 486198, 498565, 405317
Review URL: https://codereview.chromium.org/1202923002.
Cr-Commit-Position: refs/heads/master@{#335759}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Was already running on 3 configurations on Swarming. 3 were missing.
Ran:
./manage.py --convert components_browsertests
New configs:
- chromium.win.json: Win 7 Tests x64 (1)
- chromium.win.json: Win7 Tests (1)
R=dpranke@chromium.org
BUG=98637
Review URL: https://codereview.chromium.org/1197343004
Cr-Commit-Position: refs/heads/master@{#335758}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
20 configs used to already run on Swarming
10 used to run locally and were converted:
- chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1)
- chromium.fyi.json: Browser Side Navigation Linux
- chromium.fyi.json: CrWinAsan tester
- chromium.fyi.json: CrWinAsan(dll) tester
- chromium.fyi.json: Linux Trusty
- chromium.fyi.json: Linux Trusty (dbg)
- chromium.linux.json: Cast Linux
- chromium.memory.fyi.json: Linux ChromeOS MSan Tests
- chromium.memory.fyi.json: Linux MSan Tests
- chromium.webkit.json: Linux ChromiumOS Tests (1)
Ran:
./manage.py --convert content_unittests
R=dpranke@chromium.org
BUG=98637
Review URL: https://codereview.chromium.org/1200263002
Cr-Commit-Position: refs/heads/master@{#335757}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using a delegated constructor had us depending on undefined
behaviour - we require the clock to be created first, but the calls
can be made in any order.
BUG=
Review URL: https://codereview.chromium.org/1203763002
Cr-Commit-Position: refs/heads/master@{#335756}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/da57105..b607767
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=fmalita@google.com
Review URL: https://codereview.chromium.org/1200293002
Cr-Commit-Position: refs/heads/master@{#335755}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify SpdyFramer to parse stream dependency values present in HTTP/2 headers
frames, and pass them to SpdyFramerVisitorInterface::OnHeaders() via two newly
added parameters, |parent_stream_id| and |exclusive|. Modify existing
implementations of SpdyFramerVisitorInterface::OnHeaders() to accept and ignore
the new arguments.
This CL lands server change 95217891 by mpw.
BUG=500673
Review URL: https://codereview.chromium.org/1196473003
Cr-Commit-Position: refs/heads/master@{#335754}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change ExtensionMsg_MessageInvoke to use RenderFrames instead of RenderViews.
This also makes it easy to change ScriptContextSet to implement a ForEach with
RenderFrames.
BUG=455776
TBR=thestig@chromium.org (micro chrome_content_renderer_client change)
Review URL: https://codereview.chromium.org/1198203003
Cr-Commit-Position: refs/heads/master@{#335753}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Includes the change at
https://codereview.chromium.org/1194063002/
BUG=503635
TEST=none
Review URL: https://codereview.chromium.org/1202763002
Cr-Commit-Position: refs/heads/master@{#335752}
|
|
|
|
|
|
|
|
|
| |
The next thing this function does is call Paint() which has the same
early out.
Review URL: https://codereview.chromium.org/1197323002
Cr-Commit-Position: refs/heads/master@{#335751}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When targetViewport is true, skip the hit test and always
scroll the viewport layer.
This is to support the WebView#flingScroll API, which has been
implemented to always target at viewport scroll layer.
Accompanying blink change that adds 'targetViewport':
https://codereview.chromium.org/1187633003/
BUG=493765
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1189603004
Cr-Commit-Position: refs/heads/master@{#335750}
|
|
|
|
|
|
|
|
| |
BUG=503718
Review URL: https://codereview.chromium.org/1196183004
Cr-Commit-Position: refs/heads/master@{#335749}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tested on Linux with the following command lines:
$ gn gen out-gn/Debug
$ gn check out-gn/Debug //components/autofill/*
BUG=367595, 376000
TEST=see above
R=brettw@chromium.org,isherman@chromium.org
Review URL: https://codereview.chromium.org/1206643002
Cr-Commit-Position: refs/heads/master@{#335748}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Saver is enabled.
The download manager should not use the cached image and
should bypass Data Saver.
BUG=499941
Review URL: https://codereview.chromium.org/1182293002
Cr-Commit-Position: refs/heads/master@{#335747}
|
|
|
|
|
|
|
|
| |
BUG=503718
Review URL: https://codereview.chromium.org/1197733008
Cr-Commit-Position: refs/heads/master@{#335746}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Blacklist 'Linux GN (dbg)'.
Ran:
./manage.py --convert base_unittests
R=dpranke@chromium.org
BUG=98637
Review URL: https://codereview.chromium.org/1199813007
Cr-Commit-Position: refs/heads/master@{#335745}
|