summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* GN: Get os="chromeos" use_ozone=true to compiledpranke2014-11-0515-29/+84
| | | | | | | | | | | | | | There were a number of ozone targets that had rusted or never been implemented in the GN build for Chrome OS. Fix it! R=cmasone TBR=brettw BUG=424334 TEST=build chrome with os=chromeos use_ozone=true use_clang=true Review URL: https://codereview.chromium.org/705623004 Cr-Commit-Position: refs/heads/master@{#302752}
* ServiceWorker: Disable ServiceWorkerMicroBenchmarkPerfTestnhiroki2014-11-051-1/+2
| | | | | | | | | | | many-registration.html is failing due to out-of-memory error. BUG=430232 TBR=dtu@chromium.org Review URL: https://codereview.chromium.org/704693002 Cr-Commit-Position: refs/heads/master@{#302751}
* Delete UiUtils.runOnUiThread().newt2014-11-054-42/+12
| | | | | | | | | | | This method is identical to ThreadUtils.runOnUiThreadBlocking(), and ThreadUtils has a variety of helpful variations. BUG=430226 Review URL: https://codereview.chromium.org/700013002 Cr-Commit-Position: refs/heads/master@{#302750}
* Adding app_shim executable on Windows.mgiuca2014-11-057-0/+129
| | | | | | | | | | | | | This is a small binary that runs Chrome with the given command-line arguments. It is intended for use with Chrome apps, so that file types can be associated with the shim, having a custom name (and in some cases, icon) rather than simply the name of the Chrome binary. BUG=130455 Review URL: https://codereview.chromium.org/179223003 Cr-Commit-Position: refs/heads/master@{#302749}
* Fix infinite loop causing iterator to go out of bounds.rsadam2014-11-052-7/+18
| | | | | | | | BUG=430252 Review URL: https://codereview.chromium.org/703703004 Cr-Commit-Position: refs/heads/master@{#302748}
* Deprecate CAST1 payload.hshi2014-11-052-7/+0
| | | | | | | | | | | BUG=430323 TEST=trybot and manual testing of tab casting R=hclam@chromium.org TBR=dalecurtis@chromium.org Review URL: https://codereview.chromium.org/695643003 Cr-Commit-Position: refs/heads/master@{#302747}
* Fix DCHECK when shutting down safe browsing DownloadMetadataManager.grt2014-11-052-19/+26
| | | | | | | | | | | | | Chrome announces that a DownloadManager is going down before it destroys its items. This change makes the unit test behave more like chrome does and makes the metadata manager handle this shutdown order properly. BUG=389123, 386915, 389643 R=robertshield@chromium.org Review URL: https://codereview.chromium.org/703463006 Cr-Commit-Position: refs/heads/master@{#302746}
* Add a new command to summarize memory usage by function addresses in dmprofwensheng.he2014-11-053-0/+90
| | | | | | | | | | | | | | | | | The output format is: vss1;rss1;addr1;symbol1 vss2;rss2;addr2;symbol2 ... The symbol is related to the addr. If the binary file has symbols, it just same as before:function@sourcefile. Otherwise it will show the pathname the addr belongs to (mainly it's the library). This new command could be helpful for lcation leaks. R=kouhei@chromium.org BUG=427393 Review URL: https://codereview.chromium.org/700773002 Cr-Commit-Position: refs/heads/master@{#302745}
* Revert of Roll src/third_party/skia 7a10fb6:a30b2ee (patchset #1 id:1 of ↵dcheng2014-11-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/690283003/) Reason for revert: Likely broke fast/events/hit-test-counts.html layout test. Original issue's description: > Roll src/third_party/skia 7a10fb6:a30b2ee > > Summary of changes available at: > https://chromium.googlesource.com/skia/+log/7a10fb6..a30b2ee > > CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg > TBR=egdaniel@google.com > > Committed: https://crrev.com/365da31903bcebe7d6d49b802701f7c1a9e112f5 > Cr-Commit-Position: refs/heads/master@{#302662} TBR=egdaniel@google.com,skia-deps-roller@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/701003002 Cr-Commit-Position: refs/heads/master@{#302744}
* Fixed crash caused from invalid URLs in the PageInfo dialogsashab2014-11-051-60/+110
| | | | | | | | | | | | | | | | Cleaned up WebsiteSettingsPopup::updatePageDetails in the PageInfo dialog and fixed a crash from invalid URLs. When a malformed URL is accessed, the PageInfo dialog will still display the URL, but won't apply any custom coloring (this only applies to well-formed URLs). TEST=Visit a malformed URL, such as 'data:html,foo<script', and open the PageInfo dialog by long-pressing on the URL. The URL should be displayed (but not colored), and Chrome should not crash. BUG=427566 Review URL: https://codereview.chromium.org/690343003 Cr-Commit-Position: refs/heads/master@{#302743}
* Add correct asset for visa card.estade2014-11-051-0/+0
| | | | | | | | | | NOTRY=true TBR=dtrainor@chromium.org BUG=400904 Review URL: https://codereview.chromium.org/701983002 Cr-Commit-Position: refs/heads/master@{#302742}
* fix RLZ crasher in process_info.cccpu2014-11-051-75/+8
| | | | | | | | | | | | | | | RLZ is using a very convoluted and fragile way to check for code running as NT/SYSTEM. - It can fail, which causes a crash - It is quite slow on domains - It is incorrect because "SYSTEM" is not the string in some locales. BUG=428944 Review URL: https://codereview.chromium.org/691913003 Cr-Commit-Position: refs/heads/master@{#302741}
* ignore /win/ files in presubmit for wstringscottmg2014-11-051-1/+2
| | | | | | | | R=cpu@chromium.org Review URL: https://codereview.chromium.org/697053005 Cr-Commit-Position: refs/heads/master@{#302740}
* Use MediaFormat's crop rectangle when available instead of width/height.gunsch2014-11-051-4/+20
| | | | | | | | | | | | Per Android media team, width/height is not always reliable. See: https://github.com/google/ExoPlayer/blob/a7b88cd6a9bac4de5ef47b23e0d7fb50c570b3a6/library/src/main/java/com/google/android/exoplayer/MediaCodecVideoTrackRenderer.java#L319 R=qinmin@chromium.org BUG=internal b/18224769 Review URL: https://codereview.chromium.org/698273003 Cr-Commit-Position: refs/heads/master@{#302739}
* Revert of Implement getPermissionStatus in MockWebPushClient (patchset #3 ↵tkent2014-11-052-19/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | id:40001 of https://codereview.chromium.org/677073002/) Reason for revert: Broke a layout test, push_messaging/push-messaging-api-surface.html. Original issue's description: > Implement getPermissionStatus in MockWebPushClient > > Required for hasPermission LayoutTests > > BUG=401424 > > Committed: https://crrev.com/84b57b28f4766c4e411e6cc7125fc3400626a9f9 > Cr-Commit-Position: refs/heads/master@{#302722} TBR=mvanouwerkerk@chromium.org,dcheng@chromium.org,miguelg@chromium.org NOTREECHECKS=true NOTRY=true BUG=401424 Review URL: https://codereview.chromium.org/700993002 Cr-Commit-Position: refs/heads/master@{#302738}
* Try to resuscitate the builds needed to do official GN builds.dpranke2014-11-052-15/+16
| | | | | | | | | R=brettw@chromium.org BUG= Review URL: https://codereview.chromium.org/699263002 Cr-Commit-Position: refs/heads/master@{#302737}
* Set android_browser_finder.psutil to None in ↵nednguyen2014-11-051-0/+3
| | | | | | | | | | tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py to avoid flakiness BUG=426604 Review URL: https://codereview.chromium.org/667423003 Cr-Commit-Position: refs/heads/master@{#302736}
* Include chrome_elf.dll and ffmpegsumo.dll in Windows isolate for Chromoting ↵anandc2014-11-051-0/+8
| | | | | | | | | | tests. BUG=425176 Review URL: https://codereview.chromium.org/698203005 Cr-Commit-Position: refs/heads/master@{#302735}
* Make UserActivityDetector a singletonpkotwicz2014-11-0517-87/+70
| | | | | | | | | BUG=426561,408752 TEST=None Review URL: https://codereview.chromium.org/693643004 Cr-Commit-Position: refs/heads/master@{#302734}
* cros: Fix unit_tests crashes in GetBrand() on official buildersjamescook2014-11-051-1/+3
| | | | | | | | | | | | | | | | unit_tests do not have prefs, but branded builds on Chrome OS attempt to read the brand code out of a null g_browser_process->local_state(). Instead, we now return an empty brand code in tests. This reduces the number of crashing unit_tests on the official builders from ~300 to ~30. BUG=430266 Review URL: https://codereview.chromium.org/703623005 Cr-Commit-Position: refs/heads/master@{#302733}
* [telemetry] Fix typo in login error handling.dtu2014-11-051-1/+2
| | | | | | | | | BUG=None. TEST=None. Review URL: https://codereview.chromium.org/699203004 Cr-Commit-Position: refs/heads/master@{#302732}
* app_list: Moved FolderImageSource into folder_image.cc.mgiuca2014-11-057-188/+136
| | | | | | | | | | | | It is now a private implementation detail of the folder_image module. FolderImage now exposes GetTopIconsBounds to AppsContainerView. BUG=425444 Review URL: https://codereview.chromium.org/687913003 Cr-Commit-Position: refs/heads/master@{#302731}
* Re-land: cc: Make Overlay unit tests work when sync query extension is ↵reveman2014-11-051-0/+16
| | | | | | | | | | | | | | | | | | available. GLRenderer expects a BeginDrawingFrame before each FinishDrawingFrame call. This also makes sure GLRenderer::BeginDrawingFrame doesn't early out before creating the read lock fence. BUG=428071 R=danakj TEST=cc_unittests --gtest_filter=GLRendererWithOverlaysTest.ResourcesExportedAndReturned Review URL: https://codereview.chromium.org/669233003 Cr-Commit-Position: refs/heads/master@{#302730}
* Script to upload prebuilt network servicejamesr2014-11-053-23/+174
| | | | | | | | | | Also patches in https://codereview.chromium.org/668993002 R=eseidel@chromium.org Review URL: https://codereview.chromium.org/689153007 Cr-Commit-Position: refs/heads/master@{#302729}
* Add support for external video renderers in mojo.dalecurtis2014-11-0520-125/+554
| | | | | | | | | | | | | | - Extends RendererConfig to handle VideoDecoders. - Extends the MOJO interfaces for DemuxerStreams with VIDEO. - Adds the VideoFrame type plus converters to media types. - Extends DemuxerStreamProviderShim to handle multiple streams. BUG=410451 TEST=YouTube videos play with MOJO renderer! Review URL: https://codereview.chromium.org/684963003 Cr-Commit-Position: refs/heads/master@{#302728}
* Update permissions to include all supported domains, and remove ↵amistry2014-11-051-7/+4
| | | | | | | | | | | | externally_connectable. externally_connectable is unused in this extension. BUG=397019 Review URL: https://codereview.chromium.org/687803003 Cr-Commit-Position: refs/heads/master@{#302727}
* gpu: Associate all GpuMemoryBuffers with unique IDs.reveman2014-11-0554-425/+472
| | | | | | | | | | | | | | This makes the GpuMemoryBufferManager instance on the browser side allocate ids. The result is that each id is unique and that makes management much easier. This also allows some more concrete handling of the client id used for GPU service side allocation of buffers. BUG= Review URL: https://codereview.chromium.org/685983005 Cr-Commit-Position: refs/heads/master@{#302726}
* Log exception info when failing to provision a deviceperezju2014-11-051-2/+2
| | | | | | | | BUG=429248 Review URL: https://codereview.chromium.org/703643003 Cr-Commit-Position: refs/heads/master@{#302725}
* Add advanced details to the SSL clock interstitial.lgarron2014-11-052-12/+17
| | | | | | | | BUG=414843 Review URL: https://codereview.chromium.org/704623002 Cr-Commit-Position: refs/heads/master@{#302724}
* Move more extension action cocoa logic into the platform delegate.rdevlin.cronin2014-11-058-147/+145
| | | | | | | | | | | | Move the logic for extension action context menus and close-popup activate-action observations into the cocoa platform delegate. BUG=429810 Review URL: https://codereview.chromium.org/703443002 Cr-Commit-Position: refs/heads/master@{#302723}
* Implement getPermissionStatus in MockWebPushClientmiguelg2014-11-052-0/+19
| | | | | | | | | | Required for hasPermission LayoutTests BUG=401424 Review URL: https://codereview.chromium.org/677073002 Cr-Commit-Position: refs/heads/master@{#302722}
* Handle failed GpuMemoryBuffer allocations properly.alexst2014-11-053-6/+18
| | | | | | | | | | | It is possible for an allocation to fail on the gpu side, we should handle it gracefully. Currently we DCHECK that it succeeded in the browser, which in release leads to unexpected behaviour and NOTREACHED hit during destruction on the gpu side. BUG= Review URL: https://codereview.chromium.org/701873005 Cr-Commit-Position: refs/heads/master@{#302721}
* Automated the definitions of webview attributes as properties on the webview ↵paulmeyer2014-11-052-65/+21
| | | | | | | | node. Review URL: https://codereview.chromium.org/706473002 Cr-Commit-Position: refs/heads/master@{#302720}
* Experimental app list: "All apps" button has a folder-like icon.mgiuca2014-11-0511-95/+407
| | | | | | | | | | | The icon shows the first four icons of the apps grid view, much like a folder would show the first four icons inside the folder. BUG=425444 Review URL: https://codereview.chromium.org/682843004 Cr-Commit-Position: refs/heads/master@{#302719}
* Create watchlist for content_bluetooth. Add scheib.scheib2014-11-051-0/+4
| | | | | | Review URL: https://codereview.chromium.org/703743002 Cr-Commit-Position: refs/heads/master@{#302718}
* cc: Fix WeakPtrFactory::GetWeakPtr() race when using multiple raster worker ↵reveman2014-11-051-42/+41
| | | | | | | | | | | | | | | threads. This prevents multiple threads from being able to call GetWeakPtr() at the same time by making sure the lock is acquired when this is called. R=vmpstr@chromium.org BUG= Review URL: https://codereview.chromium.org/700843004 Cr-Commit-Position: refs/heads/master@{#302717}
* Allow extension function call quota to be un-throttled.kalman2014-11-053-33/+28
| | | | | | | | | | | | | For example, previously if chrome.storage.sync.set was called more than 1000 times in an hour it would be throttled forever (until Chrome restart). Now that quota is restored every hour. BUG=406406 R=zea@chromium.org Review URL: https://codereview.chromium.org/704453002 Cr-Commit-Position: refs/heads/master@{#302716}
* Fix unreachable code bug caused by anding with zero, per finnur@.brucedawson2014-11-051-19/+20
| | | | | | | | | | | | | | | | | VC++'s /analyze pointed out that an incorrect operator was being used. The warning was: src\chrome\browser\enumerate_modules_model_win.cc(898) : warning C6313: Incorrect operator: zero-valued flag cannot be tested with bitwise-and. Use an equality test to check for zero-valued flags. This bug dates back to the original code in November 2010. Fixed to 'and' with the INVESTIGATING value, as intended, after discussion with finnur@. BUG=427616 Review URL: https://codereview.chromium.org/700713002 Cr-Commit-Position: refs/heads/master@{#302715}
* cast channel error cleanup.vadimgo2014-11-046-10/+190
| | | | | | | | BUG=429005 Review URL: https://codereview.chromium.org/690383002 Cr-Commit-Position: refs/heads/master@{#302714}
* Only load platform specific architecture plugins from the correct registry hive.wfh2014-11-041-5/+3
| | | | | | | | | | | | | | | This fixes a regression in r298758 where if a 64-bit plugin was loaded after a 32-bit plugin, and the versions were the same, then the 32-bit plugin would be removed from the list, the 64-bit plugin plugin would be removed and neither plugin would successfully load. Solution is to only load the correct architecture plugins from the registry. BUG=428549 Review URL: https://codereview.chromium.org/674073003 Cr-Commit-Position: refs/heads/master@{#302713}
* Fix tests and enable virtual viewport on Android WebView.aelias2014-11-042-80/+3
| | | | | | | | | | | | | | | In pinch virtual viewport mode, the viewport visible to Javascript is sized to the width of the content and its height is that width multiplied by the aspect ratio of the true viewport. So I changed the Android WebView tests to only do vertical scrolling, and also changed the width of the test page to not be larger than the viewport (so that vertical scrolling also behaves as expected). NOTRY=true BUG=148816 Review URL: https://codereview.chromium.org/694113002 Cr-Commit-Position: refs/heads/master@{#302712}
* Make aborted commits inform the scroll delegate.aelias2014-11-042-13/+21
| | | | | | | | | | | | | | | | | | | | This way of writing it was considered in https://codereview.chromium.org/19106007#msg30 but the direct scroll_delta_ was felt to be slightly cleaner and with no behavior difference unless "you had some weird stateful scroll offset delegate." Pinch viewport mode indeed introduced state inside LayerScrollOffsetDelegateProxy to buffer the values provided by the inner and outer viewports before calling the delegate, so this is now more correct. Specifically, it's now necessary to echo back to the delegate the values forced by its getter, or they may be clobbered with older values later. NOTRY=true BUG=426891 Review URL: https://codereview.chromium.org/665233004 Cr-Commit-Position: refs/heads/master@{#302711}
* Add error indicators to always-on andno-dsp hotword checkboxes.kcarattini2014-11-044-27/+59
| | | | | | | | | | | | | | Also shows the indicator regardless of pref status. (For always-on, the opt-in process requires that there are no errors, so if something goes wrong it is better that the user know why.) Screenshot in attached bug. BUG=390086 Review URL: https://codereview.chromium.org/693393004 Cr-Commit-Position: refs/heads/master@{#302710}
* Fix double subtraction of sent_delta on sync tree activation.bokan2014-11-042-3/+34
| | | | | | | | | | | | | When PushPropertiesTo sets the active layer's delta to delta - sent_delta, LayerImpl attempts to mirror this to the pending twin. However, in doing so it again subtracts pending_delta. This patch saves the sent_delta and clears it before setting the scroll offset and delta on the active layer. BUG=428327 Review URL: https://codereview.chromium.org/698003006 Cr-Commit-Position: refs/heads/master@{#302709}
* c++11: Allow lambdas, with some restrictions.thakis2014-11-043-28/+28
| | | | | | | | | | | Thanks to David Michael <dmichael@chromium.org> for condensing the discussion thread to a recommendation! BUG=none Review URL: https://codereview.chromium.org/699283002 Cr-Commit-Position: refs/heads/master@{#302708}
* Remove flag to disable ignore autocomplete='off' for password forms.jww2014-11-0415-202/+3
| | | | | | | | | | | | | | This CL removes the plumbing for the flag to disable the ignoring of autocomplet='off' for password fields. This plumbing was always intended to be temporary in case something disastrous happened and we needed to re-enable autocomplete='off' via Finch. The time we set for this has past, so this CL makes this a permanent change. BUG=346708 Review URL: https://codereview.chromium.org/697233002 Cr-Commit-Position: refs/heads/master@{#302707}
* Remote assistance on Chrome OS Part V - It2MeHost Continue Windowkelvinp2014-11-044-7/+274
| | | | | | | | | | | | | | | | | | | This CL implements the ContinueWindow on ChromeOS, which will be shown to the user for confirmation after 10 minutes into a Remote Assistance session. To implement the ContinueWindow, this CL introduces a new class MessageBox, which is a re-usable component built on top of the widget framework. BUG=424908 Committed: https://crrev.com/6410d7ad4937a4a86e9ad28b9ecf99f961305b2d Cr-Commit-Position: refs/heads/master@{#302657} Review URL: https://codereview.chromium.org/690183002 Cr-Commit-Position: refs/heads/master@{#302706}
* Update WebRTC to r7617niklase2014-11-041-2/+2
| | | | | | | | | NOTRY=true BUG= Review URL: https://codereview.chromium.org/700893003 Cr-Commit-Position: refs/heads/master@{#302705}
* For multiline text use the maximum of the string height and the line height ↵ananta2014-11-041-1/+3
| | | | | | | | | | | | | | | while calculating the height of the text being displayed. The current code in the Canvas::SizeStringFloat function uses the passed in line_height while calculating the total height for multiline text. This works for all cases except for DirectWrite where in the text height is a touch bigger leading to it getting clipped. Example where this breaks is in the message center notifications where the line height is hardcoded to 18. We could fix notification views. However it seems like fixing canvas_skia would be better. BUG=429108 Review URL: https://codereview.chromium.org/692803004 Cr-Commit-Position: refs/heads/master@{#302704}
* [Autofill] Autofill fails to show suggestions for suggested input for forms ↵pritam.nikam2014-11-042-5/+70
| | | | | | | | | | having credit card number split across multiple fields. BUG=420323 Review URL: https://codereview.chromium.org/622773002 Cr-Commit-Position: refs/heads/master@{#302703}
generated by cgit v1.1 at 2025-02-01 04:10:17 +0000