| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=83684
TEST=1. On Linux Chrome, load some PPAPI plugin (e.g., ppapi/example)
2. Focus the plugin element
3. Turn on IME and type some text
4. Verify composition text is drawn on the IME candidate panel.
This is the second step for enabling off-the-spot IME on Pepper on ChromeOS/Linux,
continuing from the first step r87215. This patch includes
[many places]
Add a boolean flag to indicate inline composition is supported or not.
(WebKit should also be updated for supporting this kind
of information for the final complete version of Pepper
IME API, but not in this patch)
[chrome/browser/renderer_host/render_widget_host_view_gtk.cc]
Control IME context to show composition text on candidate window.
(In this patch, only RenderWidgetHostViewGtk, i.e., Linux and ChromeOS
is considered. On Windows and Mac, the behavior stays unchanged.)
[content/renderer/render_view.cc]
Turn the flag off when Pepper is focused.
and not yet include
- Enhancement of ChromeOS candidate window to have composition text area.
- Proper placement of the candidate window.
Review URL: http://codereview.chromium.org/7041003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixed gen_keyboard_overlay_data.py in order not to generate duplicated entries in cc and grd files and using it to create this patch.
This reverts commit 8f5c2e9ed0cd58b1106f60de012a1eaba03d33bd.
BUG=none
TEST=Built chrome with the generated data.
Review URL: http://codereview.chromium.org/7189010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=85922
TEST=none
Review URL: http://codereview.chromium.org/7193020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89449 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=86237
TEST=NONE
Review URL: http://codereview.chromium.org/7184023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New in this range:
* ObjC type warnings based on the cocoa naming conventions
* A warning about memset(a, 0, sizeof(a)) originally by me,
significantly improved by chandlerc
* A warning about sizeof() on an array function parameter
* ObjC ARC stuff
Bugs found by the new warnings were addressed in:
http://codereview.chromium.org/7068017/
http://codereview.chromium.org/7185019/
http://codereview.chromium.org/7104133/
http://codereview.chromium.org/7129072/
http://codereview.chromium.org/7003140/
http://codereview.chromium.org/7003152
http://codereview.chromium.org/7167009
BUG=none
TEST=none
TBR=hans
Review URL: http://codereview.chromium.org/7191031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test hasn't been failing lately (the recent failures you do see on the
flakiness dashboard are times when something broke all browser tests):
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ExtensionWebstorePrivateApiTest.InstallAccepted&testType=browser_tests
BUG=80606
TEST=none
Review URL: http://codereview.chromium.org/7193023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89445 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change, webkit/plugins/ppapi (and proxy) code does not need to use any precompiler defines, and instead refers to each version by its versioned name.
BUG=80696
TEST=Manually run PDF plugin.
Review URL: http://codereview.chromium.org/7197001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the salt is stored on disk, also increase the db version number. This will cause a rebuild of the history database.
I added the following warning to clang to make sure we don't make this mistake anywhere else in the codebase:
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/visitedlink/visitedlink_master.cc:968:30: error: argument to 'sizeof' in 'memcpy' call is the same expression as the source; did you mean to provide an explicit length? [-Werror,-Wsizeof-pointer-memaccess]
memcpy(salt_, salt, sizeof(salt));
~~~~ ^~~~
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/browser/visitedlink/visitedlink_master.cc:964:17: note: declared here
const uint8 salt[LINK_SALT_LENGTH])
^
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/common/visitedlink_common.cc:84:31: error: sizeof on array function parameter will return size of 'const uint8 *' (aka 'const unsigned char *') instead of 'const uint8 [8]' [-Werror,-Wsizeof-array-argument]
MD5Update(&ctx, salt, sizeof(salt));
^
/Volumes/MacintoshHD2/src/chrome-git/src/chrome/common/visitedlink_common.cc:79:17: note: declared here
const uint8 salt[LINK_SALT_LENGTH]) {
^
BUG=25629
TEST=none
Review URL: http://codereview.chromium.org/7068017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Cleanup some stuff. Remove unused files.
- Provide links to docs in some failure conditions and add make some error
messages better.
R=dtu@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7172032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=PPAPI UI tests
BUG=none
Review URL: http://codereview.chromium.org/7192012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89439 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=86361
TEST=toolbar importer tests work.
Review URL: http://codereview.chromium.org/7184025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
methods.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7172028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=86361
TEST=omnibox works in multiprofile environment
Review URL: http://codereview.chromium.org/7199002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89436 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a regression introduced in http://codereview.chromium.org/7058015 whereby the browser would ask for 0.4 first, which breaks any plugins that have ported to the 0.5 version. The fact that the version was omitted in both places kept 0.4 versions working (sometimes two wrongs do make a right!).
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7184030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* chrome/browser/extensions/extension_service.cc:
Register virtual keyboard extension's URL and layout names to the IME library.
* chrome/browser/ui/touch/frame/:
Register a callback function which is called when IME is switched. The callback function sends a notification to the current virtual keyboard extension.
* chrome/browser/resources/keyboard/main.js:
Handles window.onhashchange event.
This change depends on http://codereview.chromium.org/7096001/ .
All-in-one CL for testing is also available at http://codereview.chromium.org/7074008/ .
BUG=chromium-os:14241
TEST=ran browser_test
Review URL: http://codereview.chromium.org/7042033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
add myself to it.
BUG=none
TEST=Ran watchlist.py and confimed it worked.
Review URL: http://codereview.chromium.org/7193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:14241
TEST=ran browser_test
Review URL: http://codereview.chromium.org/7187004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=62811, we'll suddenly need it. For now
this won't have any effect, as we don't do any escaping of control characters.
BUG=78860
TEST=none; this code can't be triggered yet
Review URL: http://codereview.chromium.org/7193017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:16162
TEST=Verify fix for chromium-os:16162 in webkit area.
Review URL: http://codereview.chromium.org/7184026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
fix comparator in VideoCaptureContollerID
BUG=none
TEST=try bots
Review URL: http://codereview.chromium.org/7187002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The CrOS network menu shows the associated network in bold face and non-associated networks in regular face. The size of these fonts matches for non-touch builds but are different for touch builds.
BUG=none
TEST=on touch build, open network menu and check if all items are the same size
Review URL: http://codereview.chromium.org/7044121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
PrerenderBrowserTests on test failure.
BUG=none
TEST=PrerenderBrowserTest.*
Review URL: http://codereview.chromium.org/7190011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in both places.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=86226
BUG=86226
Review URL: http://codereview.chromium.org/7193024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=81624
TEST=notification tests will pass
Review URL: http://codereview.chromium.org/7190018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=views_unittests
R=sky@chromium.org
Review URL: http://codereview.chromium.org/7191028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/7184002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
No extension code seems to be using this (extension_process_bindings.js used to
call goog.* functions, but they were removed in r17269).
R=asargent@chromium.org
BUG=86333
TEST=no
Review URL: http://codereview.chromium.org/7192014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
browser window, instead of the default profile, which will no longer be a valid concept in a multi-profile environment.
BUG=83792
TEST=SelectFileDialog operation doesn't change.
Review URL: http://codereview.chromium.org/7150015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's probably due to a bad webkit roll, but I need to confirm
BUG=86397
R=dennisjeffrey@chromium.org
TEST=
Review URL: http://codereview.chromium.org/7193022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89418 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also add OVERRIDE where it's missing.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/7184019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Media types and file extensions from RFC 5751 Section 3.2.1.)
BUG=70095
TEST=manual
Review URL: http://codereview.chromium.org/7152003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the BuildUserAgent function.
The BuildUserAgent function has been deleted from user_agent.cc. The implementation of this function
in content\renderer_glue.cc calls the GetUserAgent API in ContentClient which is implemented by the embedder (Chrome).
Added implementations of the BuildUserAgent function for test_shell and DumpRenderTree. To build the user agent
string we need the webkit major and minor versions. Added getters for them in the webkit_glue namespace in the
user_agent.h/.cc files.
This helps reduce the implicit dependency of content on chrome.
BUG=82454
Review URL: http://codereview.chromium.org/7166004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/7190005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split DirectoryChangeListener into DirectoryChangeDelegate and
TransactionObserver classes. This removes a remove/notify race
condition with the DirectoryChange events.
Make syncable::{Read,Write}Transaction take Locations instead of
file/line pairs.
Move construction of sync_manager_ into sync thread.
Add logging utils in sync/logging.{h,cc}.
Add overloads to ObserverListThreadSafe::Notify for 2, 3, and 4
arguments.
Fixed 'Inital' misspelling in SyncBackendHost (finally).
BUG=85656
TEST=
Review URL: http://codereview.chromium.org/7190001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
functions were duplicated for both SkCanvas and SkDevice instances.
This CL unifies these calls to only make use of the SkCanvas entries.
This is CL part of a larger goal to remove the PlatformDevice class.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7168022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
future, I have made the GetWidget methods on WidgetDelegate pure virtual. This will cause classes that don't define them to fail compile instead of crashing at run time.
http://crbug.com/86119
TEST=none
Review URL: http://codereview.chromium.org/7189019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Add touch pressure information to the views::TouchEvent.
The pressure is normalized to be in [0, 1] to conform with
W3C Touch Event standard (draft)'s definition on pressure.
2. Augment TouchFactory with the ability to save/query the range of TouchParam.
In this patch, the max value of pressure is used to normalize the
absolute pressure value extracted from the touch device.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7149002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The old name violated cocoa's create rule -- and clang warns about
violations now.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7185019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
cross-origin test doesn't properly check for an error, and the custom-referrer change broke cross-origin requests as a result. Also, there was confusion with some errors being reported as PP_ERROR_FAILED and others as PP_ERROR_NOACCESS. After conversations with WebKit folks, it seems unlikely that a consistent system of error codes can be added, so instead, have PPB_URLLoader_Impl::didFail report PP_ERROR_NOACCESS for unknown error domains (WebKit) and switch on net::kErrorDomain errors from our lower level WebURLLoader.
Review URL: http://codereview.chromium.org/7046091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=88976
TEST=
Review URL: http://codereview.chromium.org/7185002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=86343
TEST=none
Review URL: http://codereview.chromium.org/7184024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89403 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=86252
TEST=Special WM_APPCOMMAND keys function with Chrome focused.
Review URL: http://codereview.chromium.org/7190013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7003160
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
host_content_settings_map and
migrate single pattern preferences.
BUG=YYY
TEST=host_content_setttings_map_unittest.cc, content_settings_pref_provider_unittest.cc
Review URL: http://codereview.chromium.org/6982038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
IOSurfaces and textures by forcing the IOSurface and its associated
texture to have a minimum width and height of 1.
Lie to callers about this fact since such accelerated surfaces'
contents will never be displayed to the screen.
Tested with Gmail; no more warnings. Also tested YouTube with both
Flash and HTML5 videos.
BUG=86326
TEST=none
Review URL: http://codereview.chromium.org/7191025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The UMA_HISTOGRAM_ENUMERATION macro declares a static object, so we need to explode the macro.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7184003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change eliminates parts of html test suite not related to <form> elements in an attempt to speed up the tests.
Before:
real 0m58.920s
user 1m4.858s
sys 0m15.006s
After:
real 0m46.897s
user 0m50.286s
sys 0m12.361s
A subsequent patch will attempt to re-enable these tests on Windows in the hopes that we're under the wire now with respect to timeouts.
BUG=85276
TEST=FormStructureBrowserTest.*
Review URL: http://codereview.chromium.org/7190012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(and renderer process) in the same share group.
This is work towards allowing offscreen canvas contexts to be allocated before compositor view contexts are created. This is a problem because a canvas might be created before the window it will be displayed in exists.
This does not fix the bug on its own.
BUG=80703
Review URL: http://codereview.chromium.org/7104148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Delegate a few implemented BrowserWindow methods via NativePanel.
In preparation to removing BrowserWindow inheritance on a native Panel implementation.
Review URL: http://codereview.chromium.org/7192013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89394 0039d316-1c4b-4281-b951-d872f2087c98
|