| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds a new DeferredSequencedtaskRunner that queues up tasks
until a first call to Start is issued. It creates such a task runner for the
execution of bookmarks I/O operations. At profile creation, the bookmarks
task runner is stopped and its execution is started after the profile has
finished loading.
BUG=NONE
Review URL: https://chromiumcodereview.appspot.com/12952005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Only change focus in FocusController::WindowFocusedFromInputEvent
if window hierarchy is focusable.
BUG=225851
Review URL: https://codereview.chromium.org/14298013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194954 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=danno@chromium.org
Review URL: https://chromiumcodereview.appspot.com/13987009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Mark a few tests as flaky to have the bots run them so we can
get new data on the flakiness dashboard from them.
BUG=150084
Review URL: https://codereview.chromium.org/14057011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the Profile is NULL.
This was otherwise firing a DCHECK (see https://code.google.com/p/chromium/issues/detail?id=231710#c3) that blocked new (yet to be committed) tests for issue 219419).
BUG=231710, 219419
TEST=Fixes yet to be committed tests for issue 219419.
Review URL: https://chromiumcodereview.appspot.com/14232019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The description now mentions that it controls only Google Drive feature integrated in Files App.
BUG=220006
TEST=None, doc update only.
Review URL: https://chromiumcodereview.appspot.com/13878012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I accidentally enabled this on Mac in r181965. However on Mac this has an unintended consequence of changing the page zoom when the user starts inertial scrolling and presses control right after.
BUG=178972
Review URL: https://codereview.chromium.org/14327014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The steps are:
* wait for the index to come up
* pull the key hashes from the index according to the time range
* go to the worker pool and delete all the corresponding entry files
BUG=230306
Review URL: https://chromiumcodereview.appspot.com/14295013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=178009
TEST=none
Review URL: https://chromiumcodereview.appspot.com/14341009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac 10.8 started caching prefs so even though iossim writes the SimulatorDevice
value to the .plist on disk, the iPhone Simulator may not see that change and
therefore not respect the -d (device) parameter passed to iossim.
Using the CFPreferences API to set and sync the pref fixes the issue.
BUG=224892
Review URL: https://chromiumcodereview.appspot.com/14308003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL trims down the UserManager interfaces by moving the *UserLogged
methods that are really just implementation details to UserManagerImpl.
BUG=None
TEST=Manual and browser/unit tests
Review URL: https://chromiumcodereview.appspot.com/14069017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fix should make valgrind bots green (or at least remove one of sources of unhappiness).
BUG=233153
TBR=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/13811056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bring in symlink path case fix for OSX.
NOTRY=true
TBR=csharp@chromium.org
BUG=
Review URL: https://codereview.chromium.org/14087015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Autogenerated with:
(in an elevated prompt)
python tools\swarm_client\isolate.py trace \
-s out\Release\interactive_ui_tests.isolated -- \
--gtest_filter=SSLClientCertificateSelectorTest.SelectNone
(in a normal prompt)
python tools\swarm_client\isolate.py merge \
-s out\Release\interactive_ui_tests.isolated
The tool automatically cleaned up a duplicate entry I had introduced in
r194483. Yay for automation.
NOTRY=true
TBR=csharp@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/14258010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=223923, 226855, 230227
TBR=sky@chromium.org
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/13331007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL changes:
- Moving localization related function into delegate class.
- Removing GetLanguageDisplayNameFromCode and GetLanguageNativeDisplayNameFromCode from InputMethodUtil because they are just thin wrapper function of l10n_util and only used from CrosLanguageOptionHandler.
This CL does not change any test expectations except TestGetLanguageNativeDisplayNameFromCode for checking regressions.
And I'm going to refactor strings related stuff to more appropriate location.
So let me keep tests as is.
BUG=164375
TEST=ran unit_tests and also checked there is no regression with this CL on actual devices.
Review URL: https://chromiumcodereview.appspot.com/14200032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This method will be used a new utility method in drive_api_util. As its
preparation, this CL moves it to the drive_api_util with unittest.
BUG=232352
TEST=Ran unit_tests
Review URL: https://chromiumcodereview.appspot.com/14013005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
are served out of caches. Add a PersistentObjectStore to make that work.
BUG=226625
Review URL: https://codereview.chromium.org/14218004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes some method names and comments for ImageData caching. Other APIs could reuse
this machinery.
BUG=230980
TEST=none
Review URL: https://chromiumcodereview.appspot.com/14126004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove options which won't be configurable
* Allow empty passphrases
* Use WebUI stylesheet in passphrase dialog
* JS style cleanup.
BUG=231909
Review URL: https://chromiumcodereview.appspot.com/14325003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The outstanding issues with mac are fixed. Re-enable generation of mac
host makefiles by reverting r188715.
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/13878016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds the flags to chrome://flags to make it possible to enable it on chromebooks without tricks.
TEST=Enable the Files.app new UI feature. Check if the Files.app launches with the new ui.
BUG=226904
Review URL: https://chromiumcodereview.appspot.com/14345002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194920 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The desktop platform policy loaders now report basic UMA stats on policy load
status, such as missing policy, policy read errors etc.
BUG=chromium:186445
TEST=Perform a couple policy loads, look at about:histograms to check the results.
TBR=jochen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14294008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bubble is opea and a settings was changed.n
BUG=173204
TEST=(1) Visit apprtc.appspot.com and allow the website to capture you mic and cam.
(2) Click on the camera icon on the right side of the omnibox to open the media settings bubble.
(3) Change the media settings to block, but don't close the bubble
(4) Close the tab with the open bubble
(5) Verify that Chrome does not crash.
Review URL: https://chromiumcodereview.appspot.com/14326003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=ygorshenin@chromium.org
BUG=231331
TBR=ben@chromium.org (API usage adjustements in chrome/browser/automation)
Review URL: https://chromiumcodereview.appspot.com/14063017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-screen capture tickbox added with constraints
-added buttons for resizing the video tag
-added video tag & stream size printout
-removed video tag resize after getUserMedia and adding remote stream
-Fixed some comments
TEST=Tested calling with audio/video/screencapture. Ran gjslint and will create separate CL for errors due to high error count. Mostly comments missing.
BUG=None
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/12472032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This requires another annotation:
"always_set_output_parameters"
This annotation ensures that the thunk implementation will zero-out the value of all output parameters on failure.
Tested:
Built chrome and browser_tests.
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194613
Review URL: https://codereview.chromium.org/14007010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=229036
Review URL: https://codereview.chromium.org/14244011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
search.
BUG=
TEST=unittests, Open Files App and verify a search for Drive works.
Review URL: https://chromiumcodereview.appspot.com/14076007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=content_unittests and manual tests using different WebRTC clients in combination with 192kHz native sample rate on Win7
Review URL: https://chromiumcodereview.appspot.com/14347002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
233149)
BUG=233149
TBR=oshima
Review URL: https://codereview.chromium.org/14354005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The content_browser test suite has been recently graduated to the main
waterfall and a few tests are failing.
BUG=233118
TBR=nileshagrawal@chromium.org
Review URL: https://codereview.chromium.org/14057009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Using a std::queue<Closure>, it serializes the operations and runs each operation in the correct order.
Review URL: https://chromiumcodereview.appspot.com/14130015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Motivation: Make test file name match test name on bots.
BUG=None
TBR=tonyg,thakis
Review URL: https://chromiumcodereview.appspot.com/14352002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
First landed as r193674, reverted due to breaking tests skipped by the try bots. This CL fixes the breakage too.
NativeTextfieldViews: Show the drop cursor when dragging text. Enables RenderText users to draw cursors at specified positions through RenderText::DrawCursor. Uses this method to implement the drop cursor in NativeTextfieldViews.
BUG=229661
TEST=Use Views Textfield; select text in omnibox; drag it around the omnibox; a cursor should be displayed at where the text will be dropped
Review URL: https://chromiumcodereview.appspot.com/14264004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://chromiumcodereview.appspot.com/14051004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When RenderText::SelectWord is called while the cursor is on a boundary, the word to the right is selected. This patch specially handles the case where the cursor is at the rightmost position to select the word to the left.
BUG=232023
TEST=See repro steps at http://crbug.com/232023
Review URL: https://chromiumcodereview.appspot.com/13972015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This patch only grants JS and Image permissions to Instant processes.
BUG=225758
TEST=InstantTest.ContentSettingsWhitelist
Review URL: https://chromiumcodereview.appspot.com/13516002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=233148
Review URL: https://codereview.chromium.org/14149008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
operation has happened.
This will mitigate the need to recover from enumerating all files on disk.
BUG=173394
Review URL: https://chromiumcodereview.appspot.com/14230009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=229829
Review URL: https://chromiumcodereview.appspot.com/13932008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=230746
Review URL: https://codereview.chromium.org/14053015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Modify AccessibilityTreeFormatter to build up an internal representation of the tree in the form of DictionaryValue et al. This may be used at a later stage to create a JSON representation of the tree.
>
> Also modify the Mac platform implementation to use the NSAccessibility attribute names rather than method names.
>
> BUG=
>
> Review URL: https://chromiumcodereview.appspot.com/13479003
TBR=aboxhall@chromium.org
Review URL: https://codereview.chromium.org/14354004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Next step: merge WebUILoginDisplayHost into LoginDisplayHostImpl (separate CL).
BUG=124218
Review URL: https://codereview.chromium.org/14200033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Building with _FORTIFY_SOURCE=2 and NDEBUG set makes glibc complain that the
call to memset() in TestGraphics2D::TestInitToZero() can have a 0-byte size
argument.
Avoid the warning by asserting that the image does have a valid area before
using its height in the call to memset().
R=brettw, yzshen
BUG=
Review URL: https://chromiumcodereview.appspot.com/14087009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194893 0039d316-1c4b-4281-b951-d872f2087c98
|