| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is trigger a latent issue in views which results in a memory leak
each time a Widget is destroyed.
> Update scoped_ptr<T>::reset() to more closely match std::unique_ptr<T>.
>
> Remove the no-op behavior of a scoped_ptr "self-reset", and update the
> reset() method to detect problematic dependencies on the sequence of
> events. Eventually, reset() will be updated to exactly match the
> implementation of std::unique_ptr<T> by setting data_.ptr to the new
> value before deleting the old value.
>
> However, this will expose latent bugs where a destructor invoked
> transitively by reset() attempts to dereference the same scoped_ptr.
> Relying on the value of get() in this instance will dispatch calls to
> the incorrect object. As a temporary measure to detect this class of
> bugs, set data_.ptr to NULL during deletion so that it results in a
> crash.
>
> BUG=162971,176091
>
> Review URL: https://codereview.chromium.org/12223113
TBR=dcheng@chromium.org
Review URL: https://codereview.chromium.org/12317084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=164206
Review URL: https://chromiumcodereview.appspot.com/11896017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=138275
Review URL: https://chromiumcodereview.appspot.com/12321085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
"Upstreaming" of a test that lived in the Android port.
Checks if a page is successfully reloaded.
BUG=152022
Review URL: https://chromiumcodereview.appspot.com/12313070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch partially reverts a change in revision 178954 that changed
the focus when the menu was displayed from a menu button. This focus
change was done to resolve the following display issue:
1) In the NTP, tab until Other Devices is highlighted (clicking on
this control will not highlight it, you have to tab)
2) Click on Recently closed.
3) Notice the Other Devices is highlighted but the Recently Closed
menu is displayed.
The change of focus resolved the issue in NTP but causes the
associated bug in the Bookmark Manager.
The problem is that the second click to select a menu item results
in a focus change that did not happen before. The focus change
happens because of pre-existing code in context_menu_button.js that
explicitly sets the focus to the parent of the menu (the bookmark
list in this case).
case 'mousedown':
// Menu buttons prevent focus changes.
var target = getContextMenuTarget(this);
if (target)
target.focus();
The focus change is picked up by the menu button and interprets this
as the user moving away from the menu and so it closes the menu
before the menu action is executed.
Since the problem that r178954 was trying to resolved is trivial
(and not actually reported in a issue) while the problem it
introduced is a blocker I am providing a patch to revert the focus
change and will log the original issue.
Contributed by: tom.cassiotis@gmail.com
BUG=177392
TEST=Follow reproduction steps
Review URL: https://chromiumcodereview.appspot.com/12320066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=kkania@chromium.org
BUG=
Review URL: https://codereview.chromium.org/12340039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix 'clean' target when OUTBASE is set.
Make newlib and glibc valid toolchains by default.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/12317074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This data is already stored in the root render pass's output_rect.
R=piman
BUG=123444
Review URL: https://chromiumcodereview.appspot.com/12335046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Blocking of URL loads in the browser process cannot be as extensive as the one done in the renderer process, as we don't have the frame URL and page URL at resource load time. I've tried to do a similar check with the data available on the browser side.
The main part which I'm not entirely happy about is the check for DevTools pages. Currently, if an extension has DevTools page, all of its resources can be loaded by a compromised renderer. I think this can be tightened up with a follow up CL, if we find a good way of distinguishing DevTools processes or permissioning those requests.
BUG=173688
Review URL: https://chromiumcodereview.appspot.com/12218064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Fix use of undefined variable.
2) The content security policy doesn't allow changing the src
of an iframe, so switch to using an anchor to start the download.
R=eroman@chromium.org
BUG=177778
Review URL: https://chromiumcodereview.appspot.com/12340034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
being empty when deciding whether to NotifyAppTerminating() in BrowserList::RemoveBrowser().
This was probably not causing issues as is because other desktops still held a refcount on g_browser_process, but this feels more correct if anything.
R=sky@chromium.org
BUG=129187
Review URL: https://chromiumcodereview.appspot.com/12330080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also add the touchDragDropEnabled setting to webpreferences.
This will make fast/events/touch tests pass.
BUG=111316
R=tony@chromium.org,creis@chromium.org
TEST=touch tests pass
Review URL: https://chromiumcodereview.appspot.com/12314032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=171370
Review URL: https://chromiumcodereview.appspot.com/12310058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Speculative fix for DeviceLocalAccountTest.PolicyDownload failing on CrOS
> Extend the CloudPolicyValidator to support ExternalPolicyData.
>
> The CloudPolicyValidator verifies that policy downloaded from the cloud server
> is valid and checks its signature. This CL specializes the template to parse
> ExternalPolicyData protobufs, which are used for extensions policy.
>
> BUG=163318
>
>
> Review URL: https://chromiumcodereview.appspot.com/12334013
TBR=joaodasilva@chromium.org
Review URL: https://codereview.chromium.org/12321095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids generating commit events for the wrong entry if the pending
entry differs from the navigation that committed.
BUG=177769
TEST=Go back fast across iframe navigations to the NTP.
Review URL: https://codereview.chromium.org/12340035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
|waveout_| and |wavein_| are NULL when we call FreeBuffers() in their
respective implementations, which means the unprepareheader calls never
succeed.
BUG=145725
TEST=none
Review URL: https://chromiumcodereview.appspot.com/12330063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://trac.webkit.org/log/?rev=143784&stop_rev=143751&verbose=on
TBR=
BUG=
Review URL: https://chromiumcodereview.appspot.com/12328062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/12326079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The fix is to call aura::Window::set_hit_test_bounds_override_inner such that the inner area could be used for resizing purpose.
BUG=177347
TEST=Manual test by launching panel and resizing it by mouse
Review URL: https://chromiumcodereview.appspot.com/12314022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebContentsImpl calls into WebContentsView when a new render-view gets created
(via RenderViewCreated). When navigating in history, a render-view can become
active without having to be recreated first. So introduce a callback that gets
triggered in these cases. Instead of adding to the public interface in
WebContentsView, introduce WebContentsViewPort that all platform implementations
inherit from, and add the callback to that interface.
Use this new interface to make sure the navigation overlay is observing the
correct RenderWidgetHost for paint updates.
BUG=177554
Review URL: https://codereview.chromium.org/12320058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
URLFetcher's default behavior is to cancel connection when it's presented with a certificate request. This flag allows it to try to connect with a NULL certificate instead. This allows them to connect to servers that have optional SSL client authentication, like test servers. As with other test server flags, it's only enabled in debug builds.
For more details, see the CL the flag was introduced on:
https://chromiumcodereview.appspot.com/12095075/
BUG=
Review URL: https://chromiumcodereview.appspot.com/12320070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The test needed to wait for the bookmarking system earlier than
it did, as invoking a bookmark command will simply be ignored
until it is loaded.
BUG=163733
Review URL: https://chromiumcodereview.appspot.com/12319057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=176057,174094
Review URL: https://chromiumcodereview.appspot.com/12319050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Trying to fix ImeTest flake on ImeTest$TestAdapterInputConnection.access.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/12314082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
If an existing notification is not present in the next batch of cards received from the server, we delete it.
The set activeNotifications is now rebuild from scratch on every batch, which eliminates the risk of infinite growth. This also allowed to NOT delete notifications from this set upon closing the notification, which eliminated a risk of race conditions (for 'activeNotifications' data) between creating and deleting/closing notifications. This also allowed to not wait for successful notification creation before we add notification to the map upon creation, with a similar race conditions-related benefit.
BUG=164227
Review URL: https://chromiumcodereview.appspot.com/12260047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
To check whether impl-side painting is enabled, two command line flags are checked, with the disabling flag taking precedence over the one that enables it.
BUG=173303
Review URL: https://chromiumcodereview.appspot.com/12221005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(renderer or worker) processes
and put a getter for an instance on ChildThread. Also massage (aka refactor) ChildThread::AllocateSharedMemory
such that it may be called on any thread.
BUG=174200
Review URL: https://chromiumcodereview.appspot.com/12218003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The app installation dialog that pops up when WebstoreInlineInstaller is used may or may not contain a 'View Details' link, depending on the WebstoreInlineInstaller parameters. When it does, a WebContents object is necessary to navigate to the link's target, and the consumer must provide that object. However when a link is turned off (e.g. when an app gets installed using --install-from-webstore command line option), WebContents is logically unnecessary. However, a dummy one is still technically required, but the consumer shouldn't know about or have to create and pass one. This fix makes WebContents optional for this use case by allowing the corresponding constructor argument to be NULL and moving the dummy object construction into the internals of WebstoreStandaloneInstaller.
BUG=149039
Contributed by sergeygs@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12212097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=rogerta@chromium.org
Review URL: https://chromiumcodereview.appspot.com/12330075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=177798
TBR=dimich@chromium.org
Review URL: https://codereview.chromium.org/12335049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=172135
Review URL: https://chromiumcodereview.appspot.com/12321066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=175558
Review URL: https://codereview.chromium.org/12317060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
falkiness.
BUG=177733
Review URL: https://codereview.chromium.org/12314075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Child process launch - Record process creation times.
>
> Added MPArch.ChildProcessLaunchFirst and MPArch.ChildProcessLaunchSubsequent
> histograms to ltrack all child process creation times.
>
> This replaces MPArch.RendererLaunchFirst and MPArch.RendererLaunchSubsequent
> histograms that were there earlier.
> https://code.google.com/p/chrome-browser/source/browse/trunk/src/chrome/browser/renderer_host/browser_render_process_host.cc?spec=svn27589&r=27589
>
> BUG=167326
> R=sky@chromium.org
>
> Review URL: https://chromiumcodereview.appspot.com/12255086
TBR=rtenneti@chromium.org
Review URL: https://codereview.chromium.org/12328066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=isherman@chromium.org
BUG=170467
Review URL: https://chromiumcodereview.appspot.com/12212178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It seems chrome in linux bot doesn't like switch enable-stats-table.
But for local test, chrome needs enable-stats-table.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/12310073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=174943
TEST=Can't post message to CWS. See bug for repro steps.
Review URL: https://chromiumcodereview.appspot.com/12301013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/12326078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The managed user settings page will be shown with every control disabled. A click on the button "Unlock" shows the passphrase dialog. After a successful authentication, the controls of the settings page are enabled. The authentication is reset when the settings page
is closed.
BUG=171370
TEST=browser_tests
Review URL: https://chromiumcodereview.appspot.com/11783008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mask and replica layers hang off of another layer in the tree. They are
not strictly children of the layer but they are attached to it. This
patch lets them find the layer they are hanging off, and calls that
the layer's parent. We then call them a "dependent" of the layer rather
than a "child" to distinguish them but still denote a bidirectional
relationship.
This will allow us to early out for entire subtrees in the push-properties
tree walk (and potentially other tree walks as well), to greatly speed up
commit.
Tested by LayerTest.maskAndReplicaHasParent
BUG=177756
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/12334046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/12330037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=noelallen@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/12301034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/12340016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Right now, we leave the socket in an indeterminate state -- to the rest of the
methods, it looks like Connect succeeded, but to the caller, it doesn't.
Review URL: https://chromiumcodereview.appspot.com/12259034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
B=177609
Review URL: https://chromiumcodereview.appspot.com/12316059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The new switch enable-net-benchmarking needs to passed explicitly to browser
child processes. Otherwise, child processes such as extension pages won't be
able to access to methods exposed by net benchmarking.
TEST=python chrome/test/functional/pyauto_functional.py -v perf.PageCyclerNetSimTest.test2012Q2
Review URL: https://chromiumcodereview.appspot.com/12317073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Revert https://codereview.chromium.org/12255006/ to check if it fixes the performance regression.
>
> BUG=177044
> TEST=It compiles.
>
> Review URL: https://chromiumcodereview.appspot.com/12330022
TBR=akuegel@chromium.org
Review URL: https://codereview.chromium.org/12334050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If PKG_CONFIG_PATH is set, then prepend these paths to those generated
by the wrapper. This allows cross-compilation using sysroots with pkgconfig
directories in non-standard locations.
This change is safer than the original patch (https://codereview.chromium.org/12320047/), which was reverted (https://codereview.chromium.org/12317063/) due to what appears to be a chromeos builder with PKG_CONFIG_PATH set to an incomplete value (should probably be unset).
Add Opera Software to the AUTHORS file
BUG=
Review URL: https://chromiumcodereview.appspot.com/12340023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Basically a throbber animation that cycles over a number of
frames on a bitmap. Currently only 6 frames, which is too little
but good enough for testing.
Note that the tab.cc logic should make it so that the audio indicator
is low on the priority. That is, if the tab is recording or broadcasting and
playing sounds that should show instead of the audio animation.
BUG=3541
TEST=see bug
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183977
Review URL: https://codereview.chromium.org/12328027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184183 0039d316-1c4b-4281-b951-d872f2087c98
|