| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=30572
TEST=none, just make sure tab selection isn't broke.
Review URL: http://codereview.chromium.org/6646050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=trybots
Review URL: http://codereview.chromium.org/6656016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directory.
This is gtk only because ui/views already does this.
BUG=None
TEST=trybots
Review URL: http://codereview.chromium.org/6627042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=75525
TEST=none
Review URL: http://codereview.chromium.org/6657013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
set Alpha to 255 when reading an RGB backbuffer as RGBA.
TEST=unit tests
BUG=72598
Review URL: http://codereview.chromium.org/6646006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
doesn't have the keyEncipherment bit should be reported
as CERT_STATUS_INVALID.
Map more NSS certificate errors.
R=rsleevi
BUG=70293
TEST=net_unittests --gtest_filter=X509CertificateTest.InvalidKeyUsage
Review URL: http://codereview.chromium.org/6626033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manually on the notebook
Review URL: http://codereview.chromium.org/6656027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6621058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
vipul.bhasin@gmail.com, original change at http://codereview.chromium.org/6651017/
BUG=3333
Review URL: http://codereview.chromium.org/6657026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds Valgrind suppression for SessionBackend::AppendCommands errors.
BUG=75641
TEST=Valgrind on CrOS
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/6657036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
DOM operation observer with one per message. Also merge the two DOM operation
observers for the different automation calls into one.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6623071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR: eagle-eyed arv
Review URL: http://codereview.chromium.org/6661027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
these tests should work now for M9 and earlier and M11 builds, M10 build still does not work due to another bug (74561)
BUG=74041
Test=NONE
Review URL: http://codereview.chromium.org/6588097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6656004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implemented in FindBarCocoaController instead of
FindBarBridge.MoveWindowIfNecessary, since the move is triggered there and the
rects required are also there.
Enabled the FindInPageControllerTest.FindMovesWhenObscuring test on mac.
Also tested with scaled resolutions, should handle that correctly.
Manual test: open $CHROMIUM_SRC/chrome/test/data/find_in_page/find_test.txt,
and start find in page for some text under the find bar (e.g. "New").
BUG=22036,11084
TEST=FindInPageControllerTest.FindMovesWhenObscuring in browser_tests.
Review URL: http://codereview.chromium.org/6574014
Patch from Joao da Silva <joaodasilva@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:12743
TEST=Load settings and About; both should load in a reasonable amount of time. Verify that About / update works properly. Test that a failed update (e.g. disconenct network while in progress) behaves as expected.
Depends on: http://codereview.chromium.org/6648007/
Review URL: http://codereview.chromium.org/6648009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds Valgrind suppression for CrOS / JSONWriter errors.
BUG=75634
TEST=Valgrind on CrOS
TBR=adamk@chromium.org
Review URL: http://codereview.chromium.org/6659036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
being lower-cased. Added unit tests for page title matching as well as unit tests for various static functions and other areas not previously unit tested.
BUG=58958,57853,58559,60107,75245
TEST=Many unit tests added.
Review URL: http://codereview.chromium.org/6652008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Set the page range information in order to render only the required pages.
BUG=none
TEST=printing works after code changes.
Review URL: http://codereview.chromium.org/6656011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles with use_openssl=1
Review URL: http://codereview.chromium.org/6657033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This caused profile import to fail and crash Chromium on startup.
BUG=75526
TEST=Remove all the profile data, then start Chromium. It crashes immediately
during profile import. (only tested on mac).
Review URL: http://codereview.chromium.org/6650026
Patch from Joao da Silva <joaodasilva@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6623089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Safe browsing doesn't need to be on for prefetch requests, since they go directly to cache.
BUG=56582
TEST=SafeBrowsingServiceTest.Prefetch
Review URL: http://codereview.chromium.org/6334131
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=74311
TEST=NTP background updates immediately on theme install.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77517
Review URL: http://codereview.chromium.org/6653001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I found in some prefetching safe browsing tests that chrome went so
awesomely fast that events went by before NavigateToURL started
observing them. And so I adapted the Windowed.... model to the
NavigationNotificationObserver, and use that now in NavigateToURL in
the current_tab case.
BUG=75507
TEST=see http://codereview.chromium.org/6334131/
Review URL: http://codereview.chromium.org/6662001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6646048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77637 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Prepend Notify prefix to ImportStarted, ImportItemStarted, ImportItemEnded,
ImportEnded to avoid confusion with the ImporterProgressObserver interface methods.
- Reorder some methods in this class (not everything, otherwise the diff will looks crazy).
- Move ImporterProgressObserver data member to the private section (I think more
data members can be made private, but I think it's better to do in progressive patches).
- Remove virtual from the above methods as they are not intended to be overridden.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6659024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=dhollowa,adamk
TEST=TSan/UI go green
BUG=75607
Review URL: http://codereview.chromium.org/6656024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SkClipStack::restore
BUG=75582
R=morrita
TEST=Green tree
Review URL: http://codereview.chromium.org/6656023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77632 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Regression was introduced in r76322 dated Mar 1 00:26:03 2011 +0000
We should not fall to any parent page in menu=off mode
(In menu=off mode (used for proxy settings in login screen:
chrome://settings/proxy?menu=off) we want to hide any parent pages and navbar.)
BUG=chromium-os:12732
TEST=Manual
Review URL: http://codereview.chromium.org/6624043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72758
TEST=existing unit_tests
Review URL: http://codereview.chromium.org/6658030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none (ExtensionEventRouterForwarderTest unit tests should continue to work)
Review URL: http://codereview.chromium.org/6601002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/6651020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:12925
TEST=manual, used locale specific help files.
Review URL: http://codereview.chromium.org/6659031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replace width/height pairs with gfx::Size objects.
Avoid overloading Capturer::InvalidateFullScreen.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6635039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=unit_tests - ConfigurationPolicyPref*, ConfigDir*
Review URL: http://codereview.chromium.org/6592037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:12929
TEST=StartupCustomizationDocumentTest.Basic
Review URL: http://codereview.chromium.org/6657030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
green
Please note: this is a VERY wide ignore which may probably hide some unrelated
data races, so please remove this as soon as the races are fixed
TBR=jochen,adamk
TEST=TSan/UI bots go green
BUG=75589
Review URL: http://codereview.chromium.org/6659032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42716
TEST=interactive_ui_tests --gtest_filter=AutoFillTest.OnChangeAfterAutoFill
Review URL: http://codereview.chromium.org/6649015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Only the regular profile should be allowed to modify the user pref store.
BUG=74466
TEST=Execute new PrefProviderTest.ObserverIncognito
Review URL: http://codereview.chromium.org/6635014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents browser from crashing.
BUG=chromium-os:12374
TEST=no crashes
Review URL: http://codereview.chromium.org/6650027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
backoff
Currently, we retry immediately if we lose a registration, which can
cause problems if the failure is permanent. Exponential backoff should
avoid killing our notification servers.
BUG=75209
TEST=
Review URL: http://codereview.chromium.org/6649010
TBR=akalin@chromium.org
Review URL: http://codereview.chromium.org/6646043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=Andrei Popescu, Steve Block
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Append is only used for tests, so this is non-critical code.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6626077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Original author is rdsmith (http://codereview.chromium.org/6660014/) -- I am just checking this in so gets picked up in time for canary build tommorow.
BUG=74585
TEST=Try bots, Cookie monster unit tests that have checker added, tab_specific_contents unit tests.
Review URL: http://codereview.chromium.org/6659029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, we retry immediately if we lose a registration, which can
cause problems if the failure is permanent. Exponential backoff should
avoid killing our notification servers.
BUG=75209
TEST=
Review URL: http://codereview.chromium.org/6649010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change just removes the suppresion rule for Bug 75332 because it has been fixed by mpcomplete's r77354 <http://crrev.com/77354>.
TBR=timurrrr,robertshield
BUG=75332
TEST=net_unittests
Review URL: http://codereview.chromium.org/6658033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77602 0039d316-1c4b-4281-b951-d872f2087c98
|