| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
...\re2\util\logging.h(85) : warning C4722: 'LogMessageFatal::~LogMessageFatal' : destructor never returns, potential memory leak
R=cpu@chromium.org
BUG=143646
Review URL: https://codereview.chromium.org/11232022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=sky
Review URL: https://codereview.chromium.org/11233013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also remove the commented out LayoutTests references.
TBR=csharp@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11234009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Merge CreateNewTab and CreateNewWindow into OnBrowserShortcutClicked and make it to
refocus the last used browser window and create one if there is no last used window;
- Use ChromeLauncherController code to "open" Chrome app from app list;
- Add context menu for Chrome app in app list;
BUG=154523
TEST=Verify both chrome icons refocus last used browser window and have similar context menus.
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11190057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add instrumentation to capture input in mini-dumps, in case the crashes observed don't correspond to violations of the added checks.
BUG=156107
Review URL: https://chromiumcodereview.appspot.com/11193054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
namespace.
Review URL: https://codereview.chromium.org/11240003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=154451
TEST=cc_unittests
R=enne@chromium.org,jamesr@chromium.org
Review URL: https://codereview.chromium.org/11228012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instant extended API mode doesn't instantiate the keyword provider, so
it may be NULL. Check for that before using.
BUG=156872
R=pkasting@chromium.org
TEST=Steps to reproduce in bug shouldn't cause a crash anymore.
Review URL: https://chromiumcodereview.appspot.com/11189098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163081 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107201
TEST=no visible change
Review URL: https://chromiumcodereview.appspot.com/11187057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=141780
TEST=
Review URL: https://chromiumcodereview.appspot.com/11144011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A new Encryption Options section is now part of the sync advanced
settings UI, and replaces the previous two Encrypted Types and Passphrase
Settings section. The new Encryption Settings provide two encryption options:
1. Encrypt just passwords with a key derived from the google password
2. Encrypt all datatypes with a key derived from a custom passphrase
Note that this new ui is behind the --sync-keystore-encryption switch.
Without the switch, the old UI is displayed and the old behavior remains.
BUG=129665
Review URL: https://codereview.chromium.org/10907270
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163078 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently this only has one member, but I anticipate adding several more
as we add support for local acknowledgements.
BUG=124149
Review URL: https://codereview.chromium.org/11229015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=mark@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11187061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Otherwise, third_party/libmtp has to #include ../../third_party/libusb/libusb.h or add '../..' as an includes directory.
Review URL: https://codereview.chromium.org/11183078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=107201
TEST=no visible change
Review URL: https://codereview.chromium.org/11138010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163073 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=107201
TEST=no visible change
Review URL: https://codereview.chromium.org/11236010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163071 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SafeBrowsingService::DestroyURLRequestContextOnIOThread assumes that
SafeBrowsingURLRequestContextGetter is already destroyed on IO thread.
Although this destructor is scheduled to be executed on IO thread before
DestroyURLRequestContextOnIOThread, they may execute in reverse order since
SequencedTaskRunner schedules destructors with PostNonNestableTask but
DestroyURLRequestContextOnIOThread is scheduled with PostTask. If there is
a nested IO message loop, nestable tasks are executed there but non nestable
tasks wait for nested IO message loop to quit.
BUG= none
TEST= none
Review URL: https://chromiumcodereview.appspot.com/11188077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that OWNERS supports per-file owners, we can limit the scope of the
top-level wildcard to just DEPS, and make darin and ben owners for
everything else and remove the broad use of "set noparent".
R=ben@chromium.org, darin@chromium.org
BUG=88315
Review URL: https://codereview.chromium.org/11191038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously we'd always return 255. This allows us to return 0 so that it can
pass when run by the buildbots.
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/11189077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directory contents.
This is helpful for Linux distributions that remove contents
of many third_party directories to ensure no unwanted bundled
copies of libraries are used.
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11231010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This restores the option to use system libvpx.
TBR=hclam
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11232007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163064 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Test=BrowserPluginHostTest.*, BrowserPluginTest.*, BrowserTagTest.*
Review URL: https://codereview.chromium.org/11234003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and without the embedded DevTools window.
R=sky@chromium.org
BUG=128941
Review URL: https://codereview.chromium.org/11193053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163062 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11232014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163061 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/11226008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit 184fac5add06d5f4670fa6be4a4d3b39232d51bb.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=bruening@chromium.org
Review URL: https://codereview.chromium.org/11204004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163058 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163056 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
errors)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=107201
TEST=no visible change
Review URL: https://codereview.chromium.org/11184013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163053 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=155413
Review URL: https://codereview.chromium.org/11189043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=152295
TEST=covered by tests
R=ben@chromium.org
Review URL: https://codereview.chromium.org/11232005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The handler can cause gesture handling regressions for targets that haven't
implemented browser-side handling yet. Currently the only platform supporting
it is Android.
BUG=156702
Review URL: https://chromiumcodereview.appspot.com/11189079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add C...Service::Observer to log BUBBLE_SHOWN.
Add C...Service::SnapshotGenerated to log SNAPSHOT_[GENERATED|ERROR].
Nix C...Service::LogMetric, move enum to code file.
Remove metrics logging from Views, Cocoa, and GTK bubbles.
Cleanup CL; no observable behavior change.
BUG=102709,120941
TEST=none
R=sky@chromium.org,sail@chromium.org,erg@chromium.org
Review URL: https://codereview.chromium.org/11195061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163046 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Updated close icons from sgabriel.
BUG=156711
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/11233010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=154024
Review URL: https://codereview.chromium.org/11028030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163043 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=enne
Review URL: https://codereview.chromium.org/11233008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=136247
R=sky@chromium.org
Review URL: https://codereview.chromium.org/11228003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163038 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
logical pixels
All scrolling is in logical pixels. Input to CCLayerTreeHostImpl::scrollBy
should be logical pixels also, either relative to the viewport, or relative
to the layer being scrolled.
This is a forward-port of https://bugs.webkit.org/show_bug.cgi?id=96328
Tests:
cc_unittests:CCLayerTreeHostTestScrollChildLayerNormalDpi
cc_unittests:CCLayerTreeHostTestScrollChildLayerHighDpi
cc_unittests:CCLayerTreeHostTestScrollRootScrollLayerNormalDpi
cc_unittests:CCLayerTreeHostTestScrollRootScrollLayerHighDpi
BUG=154833
Review URL: https://codereview.chromium.org/11189066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=116317
TEST=browser_tests
Review URL: https://codereview.chromium.org/11190037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163036 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also increase the dialog width from 250px to 350px.
BUG=137469
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/11183070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Merge internal change 35487529
Review URL: https://chromiumcodereview.appspot.com/11189070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These operators are making it super difficult to gradually port cc/ over to use
gfx types. We are currently using IntRects in cc/ which have platform-specific
cast operators. We subclass IntRect to make a cast operator to gfx::Rect, so that
we can transition everything from IntRect to gfx::Rect in pieces instead of the
entire codebase in one go.
But then, when you write
IntRect i;
gfx::Rect r = i;
the compiler is not sure if it should cast IntRect=>Rect and assign, or cast
IntRect=>CGRect and assign.
Since there are explicit constructor for these types anyhow, you can change
CGRect cg;
gfx::Rect r = cg;
to be
CGRect cg;
gfx::Rect r(cg);
or
gfx::Rect r = gfx::Rect(cg);
and retain the same functionality. But by being explicit we don't confuse the
compiler.
BUG=152473
R=sky
Review URL: https://chromiumcodereview.appspot.com/11195056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test checks a policy that maps to two different prefs. Looping
through the prefs and repeating the same testing steps triggers some
kind of race on the Linux precise bot. This CL disables the test for
one of the pref mappings to unbreak the bot.
TBR=bartfab@chromium.org
BUG=
Review URL: https://codereview.chromium.org/11230010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
With this change and http://codereview.chromium.org/11194044/
you get some keyboard love in metro ash, like delete and tab work
but no regular text input.
BUG=151718
TEST=see bug
Review URL: https://codereview.chromium.org/11183049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome can still be uninstalled from the Control Panel.
R=robertshield@chromium.org
BUG=156825
TEST=Uninstall link no longer installed and deleted from current installs.
Chrome can still be uninstalled from the Control Panel.
Review URL: https://chromiumcodereview.appspot.com/11234004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163029 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Exception: Missing input files:
c:\b\build\slave\cr-win-rel\build\src\cc\CCTextureUpdateQueue.h
Relanding with this file removed as well.
BUG=155413
TEST=cc_unittests
TBR=enne@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11227005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hit-testing code.
The point given to these functions is meant to be applied to the inverse
screenSpaceTransform. That point must be in the device-viewport, ie.
screen space.
The current name makes it sound like the point is in logical pixels rather than
device pixels, which is incorrect.
Just renaming variables, no new tests.
R=enne
Review URL: https://codereview.chromium.org/11191076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move the API out of experimental and into the normal chrome namespace.
BUG=156517
Review URL: https://chromiumcodereview.appspot.com/11194046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163025 0039d316-1c4b-4281-b951-d872f2087c98
|