summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add language_prefs namespace to language_preferences.h.satorux@chromium.org2010-08-2026-284/+379
| | | | | | | | | | | | language_preferences.h exports lots of constants hence polutes chromeos namespace. TEST=compiles. try bots. BUG=chromium-os:5848 Review URL: http://codereview.chromium.org/3132023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56803 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use const char kFoo[] in the stack place.tfarina@chromium.org2010-08-201-4/+4
| | | | | | | | | | | | It creates a variable and copy the value all around. Instead use pointer so the other places where the variable is used just point to the orignal variable instead of copying the value. BUG=None TEST=out/Debug/base_unittests --gtest_filter=EnvironmentTest.* Review URL: http://codereview.chromium.org/3186017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56802 0039d316-1c4b-4281-b951-d872f2087c98
* NSS cert database cleanupsmattm@chromium.org2010-08-202-50/+48
| | | | | | | | | | | | | | Use ScopedPK11Slot. Move common test functionality into functions. Move common test conditions into SetUp/TearDown. Move common test variables into attributes of the test class. BUG=19991 TEST=tests still pass Review URL: http://codereview.chromium.org/3189014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56801 0039d316-1c4b-4281-b951-d872f2087c98
* Adding debugging info for sync integration tests.rsimha@chromium.org2010-08-203-9/+50
| | | | | | | | | | | | | The sync integration test logs do not reveal when different sync events occur on the ProfileSyncServiceTestHarness objects. This checkin adds logging for sync events so that failures are easier to debug. BUG=52761 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/3169028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56800 0039d316-1c4b-4281-b951-d872f2087c98
* Move nsNSSCertTrust from chrome/third_party to net/third_party.mattm@chromium.org2010-08-205-7/+17
| | | | | | | | | BUG=19991 TEST=builds Review URL: http://codereview.chromium.org/3104022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56799 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 56796 - Sbox IPC fixcpu@chromium.org2010-08-203-72/+39
| | | | | | | | | | | | | | | Tests failing on vista BUG=52682 TEST=included Review URL: http://codereview.chromium.org/3142022 TBR=cpu@chromium.org Review URL: http://codereview.chromium.org/3122031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56798 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 56790 - Update webkit to 65710johnnyg@chromium.org2010-08-201-1/+1
| | | | | | | | | | | | | BUG=none TEST=none TBR=rolandsteiner Review URL: http://codereview.chromium.org/3119029 TBR=johnnyg@chromium.org Review URL: http://codereview.chromium.org/3111021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56797 0039d316-1c4b-4281-b951-d872f2087c98
* Sbox IPC fixcpu@chromium.org2010-08-203-39/+72
| | | | | | | | | | BUG=52682 TEST=included Review URL: http://codereview.chromium.org/3142022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56796 0039d316-1c4b-4281-b951-d872f2087c98
* Make the extension install UI de-dupe hosts after disregarding scheme and path.aa@chromium.org2010-08-204-10/+108
| | | | | | | | BUG=52723 Review URL: http://codereview.chromium.org/3126023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56795 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Reload can't be disabled. (This change matches views and GTK.)pkasting@chromium.org2010-08-201-4/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3169029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56794 0039d316-1c4b-4281-b951-d872f2087c98
* Fix GTK unittest failurepkasting@chromium.org2010-08-201-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56792 0039d316-1c4b-4281-b951-d872f2087c98
* Update webkit to 65710johnnyg@chromium.org2010-08-201-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=rolandsteiner Review URL: http://codereview.chromium.org/3119029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56790 0039d316-1c4b-4281-b951-d872f2087c98
* New downloads hooks for pyauto. BUG=35284alyssad@google.com2010-08-206-37/+390
| | | | | | | | New hooks allow the user to pause/resume/cancel/remove downloads and more. Review URL: http://codereview.chromium.org/3176016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56789 0039d316-1c4b-4281-b951-d872f2087c98
* Add code to support options for TTS speak.chaitanyag@chromium.org2010-08-202-3/+68
| | | | | | Review URL: http://codereview.chromium.org/3116019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56788 0039d316-1c4b-4281-b951-d872f2087c98
* ResourceBundle is loading a wrong resource on Windows for synchclam@chromium.org2010-08-203-2/+2
| | | | | | | | | | | | | | | | | | In browser_resources.grd, both IDR_SYNC_SETUP_FLOW_HTML and IDR_REMOTING_SETUP_FLOW_HTML are point to setup_flow.html although they are different files in different folders. ResourceBundle gets confused and always return the later one when asked for IDR_SYNC_SETUP_FLOW_HTML. This problem only happens on Windows but not Linux. This patch tries to avoid this problem by renaming remoting files with a remoting_ prefix. BUG=52777, 52625 TEST=Setup sync now loads the correct setup_flow.html Review URL: http://codereview.chromium.org/3191013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56787 0039d316-1c4b-4281-b951-d872f2087c98
* linux: add UMA stat for the file system where the prefs are storedevan@chromium.org2010-08-204-2/+96
| | | | | | | | | | | | | I'd like to see how common it is to use a network file system for your home directory. This would help evaluate how important it is to support these users. See also: http://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/b43d2905f079fa1c Review URL: http://codereview.chromium.org/3187011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56786 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Add the basic HTML for the 'Edit Address' AutoFill overlay.jhawkins@chromium.org2010-08-2012-3/+216
| | | | | | | | | BUG=49094 TEST=none Review URL: http://codereview.chromium.org/3157027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56785 0039d316-1c4b-4281-b951-d872f2087c98
* Fix check_perms failurepkasting@chromium.org2010-08-191-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56781 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 56738 - Fix CheckFalseTest.CheckFails on Linux after my change to ↵rvargas@google.com2010-08-195-51/+27
| | | | | | | | | | | | | | | | | | ui_test. This makes PathService clear its cache after overriding a path. We have many paths depending on each other, so this is necessary to avoid inconsistencies. TEST=ui_tests in Release mode BUG=49838 Review URL: http://codereview.chromium.org/2805100 TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3169031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56778 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile failurepkasting@chromium.org2010-08-191-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56776 0039d316-1c4b-4281-b951-d872f2087c98
* Give keys friendly names in NSS and OS Xdavidben@chromium.org2010-08-198-12/+69
| | | | | | | | | | | | | | | | This will make them browsing them easier in Keychain Access and certutil. It also gives them a more useful name in Keychain permission dialogs. The friendly name is currently just the hostname which requested the key. It would be nice to have some surrounding text with localization, but this works for now. BUG=none TEST=none Review URL: http://codereview.chromium.org/2806045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56774 0039d316-1c4b-4281-b951-d872f2087c98
* Add disabled reload button image so trybots can try upcoming change.pkasting@chromium.org2010-08-191-0/+0
| | | | | | | | | BUG=46981 TEST=none TBR=glen Review URL: http://codereview.chromium.org/3108035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56773 0039d316-1c4b-4281-b951-d872f2087c98
* Convert FormatBytes to string16.evan@chromium.org2010-08-1911-85/+83
| | | | | | | | | | I considered ASCII, but it's producing what is intended to be a human-readable string. For example, in theory the "bytes/s" annotation could be localized into a language where the "b" is non-ASCII. Review URL: http://codereview.chromium.org/3107021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56771 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in setting event masks.pkasting@chromium.org2010-08-191-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3146024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56769 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Put signal handlers in alphabetical order. Group a couple other ↵pkasting@chromium.org2010-08-192-21/+20
| | | | | | | | | | things in a way that seems better to me. BUG=none TEST=none Review URL: http://codereview.chromium.org/3135034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56767 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove dead code, use early returns to reduce indenting, shorten.pkasting@chromium.org2010-08-192-112/+70
| | | | | | | | | | This makes one behavioral change: a mouse release with a successful HitTest and |canceled| true will set the state to HOT instead of NORMAL. This seemed more correct to me. BUG=none TEST=none Review URL: http://codereview.chromium.org/3175027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56766 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up unnecessary TODO comments in sync integration tests.rsimha@chromium.org2010-08-191-3/+0
| | | | | | | | | | | | There were a bunch of TODO comments whose action items were already completed. Removing said comments. BUG=50306 TEST=none Review URL: http://codereview.chromium.org/3143031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56765 0039d316-1c4b-4281-b951-d872f2087c98
* Several small extensions docs system fixesasargent@chromium.org2010-08-1962-166/+387
| | | | | | | | | | | | | -Allow automagic links to types in API descriptions, using "$ref:TYPE_ID" -Fix syntax error in callback code -Fix a couple other small nits BUG=52616 TEST=none Review URL: http://codereview.chromium.org/3117029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56764 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up ExtensionMessageService.mpcomplete@chromium.org2010-08-1910-262/+132
| | | | | | | | | | | | | - Remove debugging cruft from an old bug that has been closed. - Make it UI-thread only. This complicates ResourceMessageFilter a little, but makes the EMS lifetime a lot easier to reason about. BUG=no TEST=covered by unit tests Review URL: http://codereview.chromium.org/3117024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56761 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build due to conflictoshima@chromium.org2010-08-193-20/+10
| | | | | | | | | | TBR=phajdan.jr@chromium.org, BUG=none TEST=none Review URL: http://codereview.chromium.org/3149026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56757 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 56742 - A new field to describe the sources of history urls(visits) ↵brettw@chromium.org2010-08-1950-670/+145
| | | | | | | | | | | | | | | | | | | is added. This field is recorded in visit_database. So far, it can tell imported, synchronized, entension added or other(mainly testing) entries from user browsed entries. In the future, history extension API may allow queries to combinate with this criterion. BUG=none TEST=Unit tests are already included. Please test the web browser with history from previous versions to make sure the migration could be done properly. Also try to import or sync some history and inspect the sources added to the visit_source table in hitory database are correct. Original review=http://codereview.chromium.org/2906004/show Patch by weili@google.com TBR=brettw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56754 0039d316-1c4b-4281-b951-d872f2087c98
* Remove terrible cross-app navigation handling code that never reallyaa@chromium.org2010-08-191-85/+0
| | | | | | | | | | | | | | | worked correctly. I think there might still be a place for this, but it is in Browser::AdjustWindowOpenDispositionForTab(), which is a much more constrained use case, and also isn't working correctly, because it lacks knowledge of apps. BUG=52442 Review URL: http://codereview.chromium.org/3199004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56752 0039d316-1c4b-4281-b951-d872f2087c98
* Switch some LOG(ERROR)s to DLOG(INFO) in PhishingDOMFeatureExtractor.bryner@chromium.org2010-08-191-3/+3
| | | | | | | | | | It turns out to be reasonably common not to have a host for some URLs, such as data: URLs, and the extra logging actually slows down feature extraction significantly. Review URL: http://codereview.chromium.org/3198003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56751 0039d316-1c4b-4281-b951-d872f2087c98
* Undo user gesture detection added to NavigationController by r18373, since mihaip@chromium.org2010-08-194-40/+3
| | | | | | | | | | | | | | | | WebKit now has this logic as of http://trac.webkit.org/changeset/65340. I couldn't remove ViewHostMsg_DocumentLoadedInFrame/ NavigationController::DocumentLoadedInFrame since it accumulated other usages since then. (second attempt of r56693, this time with updated unit tests) BUG=40395 TEST=manual testing with hp.com and keyboard shortcut search experiment, history_uitest Review URL: http://codereview.chromium.org/3124035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56750 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI callback to notificationoshima@chromium.org2010-08-1911-18/+223
| | | | | | | | | | | | | | | | This is to (but not limited to) allow system update notification to have "restart" button. * BalloonHost::EnableDOMUI() to enable DOMUI in notification page. * chromeos::BalloonCollectionImpl::AddDOMUIMessageCallback to add a callback for given DOMUI message. * Added two tests cases (see below) BUG=chromium-os:5810 TEST=TestAddDOMUIMessageCallback and TestDOMUIMessagCallback are added to notification_browsertest Review URL: http://codereview.chromium.org/3186016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56749 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromedriver for multi-dll build.victorw@chromium.org2010-08-191-2/+7
| | | | | | | | | | R=jmikhail@google.com BUG=none TEST=chromdriver pass on multi-dll build Review URL: http://codereview.chromium.org/3167025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56746 0039d316-1c4b-4281-b951-d872f2087c98
* Miscellaneous changes, mostly related to the gallery.kathyw@chromium.org2010-08-1912-21/+71
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3186018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56743 0039d316-1c4b-4281-b951-d872f2087c98
* A new field to describe the sources of history urls(visits) is added. This ↵brettw@chromium.org2010-08-1950-145/+670
| | | | | | | | | | | | | | | | | field is recorded in visit_database. So far, it can tell imported, synchronized, entension added or other(mainly testing) entries from user browsed entries. In the future, history extension API may allow queries to combinate with this criterion. BUG=none TEST=Unit tests are already included. Please test the web browser with history from previous versions to make sure the migration could be done properly. Also try to import or sync some history and inspect the sources added to the visit_source table in hitory database are correct. Original review=http://codereview.chromium.org/2906004/show Patch by weili@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56742 0039d316-1c4b-4281-b951-d872f2087c98
* DOM UI: Change DOMMessageHandler callback arg type to ListValue.estade@chromium.org2010-08-1969-1136/+647
| | | | | | | | | | | The parameter describes a list of Values that act as parameters to the callback. It is always a ListValue. It should be typed as such. BUG=none TEST=compile; manual testing Review URL: http://codereview.chromium.org/3146019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56740 0039d316-1c4b-4281-b951-d872f2087c98
* Added CursorControl Pepper interface.neb@chromium.org2010-08-194-21/+111
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3145024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56739 0039d316-1c4b-4281-b951-d872f2087c98
* Fix CheckFalseTest.CheckFails on Linux after my change to ui_test.phajdan.jr@chromium.org2010-08-195-27/+51
| | | | | | | | | | | | | This makes PathService clear its cache after overriding a path. We have many paths depending on each other, so this is necessary to avoid inconsistencies. TEST=ui_tests in Release mode BUG=49838 Review URL: http://codereview.chromium.org/2805100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56738 0039d316-1c4b-4281-b951-d872f2087c98
* Fix numerous alignment problems, both horizontal and vertical, in drawing ↵pkasting@chromium.org2010-08-1924-358/+390
| | | | | | | | | | | | the browser chrome. This doesn't fix problems with the NTP background image offsets (see bug 51853). This also makes sure the OTR avatar is reversed in RTL mode, and clipped as usefully as possible when there isn't enough room for the full image. BUG=44157 TEST=Frame, toolbar, bookmark bar, and find bar all look lined up with default and custom themes, restored and maximized, LTR and RTL, side tabs and normal tabs, and in popup and app windows Review URL: http://codereview.chromium.org/3137019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56737 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Remove TryKillingOldServer from testserver.py, it's broken.phajdan.jr@chromium.org2010-08-191-14/+0
| | | | | | | | | | | | | | | Sometimes TryKillingOldServer fails with an exception we don't catch, which is even worse because then the new server fails to start. We should rely on the C++ code to kill the server in a reliable way, rather than this Python hack. TEST=net_unittests, unit_tests, ui_tests, ... BUG=52644 Review URL: http://codereview.chromium.org/3110025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56736 0039d316-1c4b-4281-b951-d872f2087c98
* Disable failing test.brettw@chromium.org2010-08-191-1/+1
| | | | | | | BUG=52750 Review URL: http://codereview.chromium.org/3171020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56735 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for the new IPC system on gcc 4.5 and greater.erg@google.com2010-08-191-0/+8
| | | | | | | | | | | | | | We need the new noclone attribute since gcc tries to specialize many of the ::Read() members for the subtypes since they're only invoked from Log(). Reported by some dude named flo on IRC. BUG=none TEST=none Review URL: http://codereview.chromium.org/3133025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56734 0039d316-1c4b-4281-b951-d872f2087c98
* Remove suppressions for ProfileSyncServiceSessionsTest.tim@chromium.org2010-08-192-24/+0
| | | | | | | | | TBR=thestig BUG=52552 Review URL: http://codereview.chromium.org/3180018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56733 0039d316-1c4b-4281-b951-d872f2087c98
* dom-ui options: Invoke Linux certs webpage in a new tab instead of a new window.csilv@chromium.org2010-08-191-1/+1
| | | | | | | | BUG=none TEST=Verify that the linux certs webpage is displayed in a new tab (--enable-tabbed-options). Review URL: http://codereview.chromium.org/3116022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56731 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix leak in tabpose.thakis@chromium.org2010-08-193-11/+3
| | | | | | | | | BUG=51786 TEST=valgrind stays green Review URL: http://codereview.chromium.org/3183019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56730 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r56571:estade@chromium.org2010-08-1912-311/+56
| | | | | | | | | | | | | | ------------ Make the saved passwords tab work. BUG=49093 TEST=None ------------ TBR=sargrass Review URL: http://codereview.chromium.org/3108034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56729 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the negative field trial from prefetching histogramsgavinp@chromium.org2010-08-192-24/+3
| | | | | | | | | | | | We shouldn't have people in the NO group of the field trial generating prefetching histograms. This CL removes them. BUG=none TEST=none Review URL: http://codereview.chromium.org/3132016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56728 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 23:04:31 +0000