summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Move RenderViewHost management out of WebContents into a newbrettw@google.com2008-08-1216-1226/+1645
| | | | | | | | | | | | | | RenderViewHostManager object. The goal for this patch is to change no logic or APIs, just move the code. So there are some not very clean callback functions and no new unit tests for this file (although is is still covered by the same WebContents unit tests). This should make the actual cleanup in a later pass much easier to follow. I changed the ordering of only a few operations (like WebContents shutdown), and checked that this shouldn't matter. I had to change the "source" for several notifications since they are no longer sent from the WebContents. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@716 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate symbol visibility warnings produced when linking a unit test ↵mmentovai@google.com2008-08-121-18/+12
| | | | | | target against libgtest. Make a few other changes to gtest.xcodeproj to bring it in line with the rest of our project files. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@715 0039d316-1c4b-4281-b951-d872f2087c98
* Additional cleanups for PRTimeTest. We already have a ↵mmentovai@google.com2008-08-121-18/+11
| | | | | | microseconds-per-milliseconds constant, use it. Do less per-OS #ifdeffing. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@714 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup a few files, reduce the number of includes.maruel@google.com2008-08-1216-485/+591
| | | | | | | | Applied glint. No code change, just moving around. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@713 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ToUnsigned for 4-byte wchar_t platforms.mmentovai@google.com2008-08-121-0/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@712 0039d316-1c4b-4281-b951-d872f2087c98
* Change the ProxyService to work with ASCII strings.darin@google.com2008-08-1212-121/+121
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@711 0039d316-1c4b-4281-b951-d872f2087c98
* Fiddle with destruction order of the dragged tab controller to ensure that ↵beng@google.com2008-08-122-3/+3
| | | | | | | | | there's still a TabStrip available for it. B=1145714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@708 0039d316-1c4b-4281-b951-d872f2087c98
* The tab dragging test ended up on interactive_ui, not ui_tests.sgk@google.com2008-08-122-1/+1
| | | | | | TBR: bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@706 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce timeout to 500ms.beng@google.com2008-08-121-3/+3
| | | | | | | TBR=mal git-svn-id: svn://svn.chromium.org/chrome/trunk/src@704 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash due to race condition in ImportingProgressView.finnur@google.com2008-08-121-1/+1
| | | | | | | | | | | | What is happening is that the ImporterView creates an ImportingProgressView to show the progress of the import but the ImportingProgressView receives the Cancel event before ImportStarted, so importing_ is not set to true. Cancel will think import is done and returns true (allowing the view to be destroyed) and then the ImporterView will try to communicate with a dead observer. By initializing importing_ to true this crash is avoided (we wouldn't be creating the view unless we were about to import, right?). BUG=1320194 TEST=Open Import dialog, press Enter and then Esc really quickly and Chrome should not crash (try it 10 times to be sure). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@702 0039d316-1c4b-4281-b951-d872f2087c98
* Fix command_line unit test now that argv is no longer const. (Doh!) Remove ↵mmentovai@google.com2008-08-122-12/+11
| | | | | | a technically illegal zero-length array. Fix a couple of warnings for good measure as long as I'm in here. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@701 0039d316-1c4b-4281-b951-d872f2087c98
* Link tab_dragging_test.cc with the proper test executable.sgk@google.com2008-08-122-1/+1
| | | | | | TBR: bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@696 0039d316-1c4b-4281-b951-d872f2087c98
* Updating the SafeBrowsing database version to 3, to reset everyone's databaseifette@google.com2008-08-121-1/+1
| | | | | | after we had database corruption last week from bad data being served git-svn-id: svn://svn.chromium.org/chrome/trunk/src@695 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build breakage on Windows.evanm@google.com2008-08-121-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@692 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling sync_channel in the browser to allow accessibility code making ↵jcampan@google.com2008-08-1217-42/+254
| | | | | | | | | blocking calls. This replaces my previous CL that was somehow duplicating some of these functionalities. BUG=None TEST=Run the unit tests. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@691 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the command-line hacks for posix platforms.evanm@google.com2008-08-123-22/+26
| | | | | | | (They didn't work at all on Linux anyway.) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@690 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily add 1s sleep to see if waiting before quitting the browser helps ↵beng@google.com2008-08-121-0/+3
| | | | | | | | | reduce TabSelectedAt crashes. B=1145714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@689 0039d316-1c4b-4281-b951-d872f2087c98
* SCons build updates:sgk@google.com2008-08-124-8/+21
| | | | | | | | | | | | | * Add base\file_util_linux.cc. * Add unit tests base\{idletimer,string_escape}_unittest.cc. * Add chrome\browser\views\hwnd_html_view.cc. * Add chrome\browser\tabs\tab_dragging_test.cc. * Add chrome\browser\views\bookmark_bar_view_test.cc * Add chrome\test\ui\view_event_test_base.cc. * Only define on Windows build of base: _Win32_WINNT=0x0600, WINVER=0x0600, _HAS_EXCEPTIONS=0. TBR: bradnelson git-svn-id: svn://svn.chromium.org/chrome/trunk/src@688 0039d316-1c4b-4281-b951-d872f2087c98
* Instead of returning false we should default to en-us when we fail to get ↵rahulk@google.com2008-08-121-2/+4
| | | | | | locale. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@687 0039d316-1c4b-4281-b951-d872f2087c98
* include and turn on more base unit tests.pinkerton@google.com2008-08-121-0/+32
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@686 0039d316-1c4b-4281-b951-d872f2087c98
* Don't terminate the process when a tab becomes unresponsive during ojan@google.com2008-08-114-24/+14
| | | | | | | | | | | | | unload/beforeunload. Instead, just call close on it. If two tabs are in the same process, then terminating the process is totally wrong. This also avoids the bugs where we show sad tab, or don't remove the tab from the tabstrip. Also, remove a couple of bogus DCHECKS. BUG=1314995,1301757 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@685 0039d316-1c4b-4281-b951-d872f2087c98
* bustage fix, include build_config for platform defines.pinkerton@google.com2008-08-111-0/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@684 0039d316-1c4b-4281-b951-d872f2087c98
* Set the svn:eol-style to LF.tc@google.com2008-08-111-76/+76
| | | | | | TBR=evanm git-svn-id: svn://svn.chromium.org/chrome/trunk/src@683 0039d316-1c4b-4281-b951-d872f2087c98
* Expand an internal-only URL to its destination.evanm@google.com2008-08-111-4/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@682 0039d316-1c4b-4281-b951-d872f2087c98
* Stub out defines on non-windows platforms.pinkerton@google.com2008-08-111-0/+14
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@681 0039d316-1c4b-4281-b951-d872f2087c98
* Fix unit tests for posix, fix up mac implementation to work correctly. Add ↵pinkerton@google.com2008-08-112-10/+61
| | | | | | prtime unit test to mac project. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@680 0039d316-1c4b-4281-b951-d872f2087c98
* If a sync message can't be routed, respond immediately with an error.ojan@google.com2008-08-111-2/+7
| | | | | | | This will allow us to process alerts correctly if they happen after the tab has been closed in the browser process. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@679 0039d316-1c4b-4281-b951-d872f2087c98
* I came across this when looking at MessageLoop recently.sky@google.com2008-08-111-6/+0
| | | | | | | BUG=none TEST=none; this is just a doc change. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@678 0039d316-1c4b-4281-b951-d872f2087c98
* git-svn-id: svn://svn.chromium.org/chrome/trunk/src@677 ↵dglazkov@google.com2008-08-112-3/+3
| | | | 0039d316-1c4b-4281-b951-d872f2087c98
* git-svn-id: svn://svn.chromium.org/chrome/trunk/src@676 ↵glen@google.com2008-08-111-0/+0
| | | | 0039d316-1c4b-4281-b951-d872f2087c98
* Move Tab Drag Tests inside Project interactive_ui_testssidchat@google.com2008-08-113-11/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@675 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all the C-style string munging, making this easier to port to Linux.evanm@google.com2008-08-111-55/+42
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@674 0039d316-1c4b-4281-b951-d872f2087c98
* If the user runs chrome with a language on the command line ontc@google.com2008-08-111-4/+11
| | | | | | | | | | | | | first-run, make sure we pass that language to the importer process. The code for this is basically a copy of what is in chrome/browser/render_process_host.cc:291. TEST=Run "chrome --lang=ko --first-run" and import settings during first run. Make sure the importer dialog is in Korean. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@673 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes word_iterator to actually compile. Next time, never just paste code in ↵avi@google.com2008-08-112-6/+9
| | | | | | that _should_ fix things without actually compiling :( git-svn-id: svn://svn.chromium.org/chrome/trunk/src@672 0039d316-1c4b-4281-b951-d872f2087c98
* Per discussion with Brian/Mark/Ben, set the renderer timeout to 20 seconds ↵jabdelmalek@google.com2008-08-111-1/+1
| | | | | | | | | | | | but keep the plugin at 10. Not too ideal because the plugin dialog will come up incorrectl if webkit is hung, but let's try it out for the next release and see if we're still getting complaints. TBR=beng git-svn-id: svn://svn.chromium.org/chrome/trunk/src@671 0039d316-1c4b-4281-b951-d872f2087c98
* User the "v8.exe" binary from the V8 SCons-based release build instead of ↵sgk@google.com2008-08-111-24/+11
| | | | | | | | the "v8_shell.exe" binary generated by the Visual Studio build. TBR: sgjesse,ager git-svn-id: svn://svn.chromium.org/chrome/trunk/src@670 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an illegal const.paulg@google.com2008-08-111-5/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@669 0039d316-1c4b-4281-b951-d872f2087c98
* Small fix to remove a pixel gap between the client edge of the toolbars and ↵beng@google.com2008-08-111-7/+11
| | | | | | | | | the client edge of the content area. B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@668 0039d316-1c4b-4281-b951-d872f2087c98
* Move Ranges to std::vector<Sample>, as <const Sample> is invalid if you want ↵deanm@google.com2008-08-111-1/+1
| | | | | | to assign to elements of the vector. This now compiles under GCC. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@667 0039d316-1c4b-4281-b951-d872f2087c98
* We should not initialize the crash callback for non-browser processes sincensylvain@google.com2008-08-111-2/+3
| | | | | | it's used only to display the "Whoa, chrome has crashed". git-svn-id: svn://svn.chromium.org/chrome/trunk/src@666 0039d316-1c4b-4281-b951-d872f2087c98
* Set the hung renderer and plugin timeout to 10 seconds.jabdelmalek@google.com2008-08-112-3/+3
| | | | | | BUG=1314703 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@665 0039d316-1c4b-4281-b951-d872f2087c98
* Make POSIX time routines work on Linux by providing a POSIX-conformant ↵mmentovai@google.com2008-08-115-59/+76
| | | | | | version of TimeTicks::Now() to replace the Mach-specific one used on the Mac. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@664 0039d316-1c4b-4281-b951-d872f2087c98
* Replace a todo with NOTIMPLEMENTED().ericroman@google.com2008-08-111-2/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@663 0039d316-1c4b-4281-b951-d872f2087c98
* Increase the height of the options dialog in zh-TW to matchtc@google.com2008-08-112-2/+2
| | | | | | | | | | | that of zh-CN. When using Simsum, the default font on Chinese Windows, text was getting cut off. Also increase the height for ro. BUG=1311445,1219515 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@662 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the ChromeViews' Menu to wrap the Windows system menu and insert items ↵beng@google.com2008-08-112-35/+136
| | | | | | | | | | | | into it. Basically adds an alternate ctor for Menu that takes an existing HMENU, and then provides variants of most of the APIs that allow insertion of an item at a specified index. I will use this in the new frames to add the task manager and app frame menu items. B=1293995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@661 0039d316-1c4b-4281-b951-d872f2087c98
* Another Frame Grab-Bagbeng@google.com2008-08-1120-201/+209
| | | | | | | | | | | | | | | - makes more stuff in Browser object only happen if you're using the old frames- rename BrowserWindow::Update to BrowserWindow::UpdateToolbar since that's what it does - add window position save/restore handling to Browser- remove BrowserWindow::BrowserDidPaint - relic from HaloFrame days- remove BrowserWindow::GetRootView - unused and exposes impl details- remove BrowserWindow::DetachFromBrowser - unused - store BrowserView2* on HWND's property list so infobubbles can access it later- both frames (Opaque and AeroGlass) notify the BrowserView2 when they're moved so BrowserView2 can reposition the status bubble and close the autocomplete popup - remove BrowserView2::ShowTabContents - no longer used - remove BrowserView2::ShelfVisibilityChanged - no longer used - remove BrowserView2::SetWindowTitle - never used - remove BrowserView2::ProfileChanged - now called from TabSelectedAt- properly unhook infobars etc when a tab is detached B=1031854 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@660 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for ChromeViews::Windows to disable inactive rendering. This is ↵beng@google.com2008-08-115-14/+67
| | | | | | | | | for the new frames to make it so when infobubbles are activated the window frame isn't deactivated. B=1318343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@659 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome strings ('it' translation clean ups).tc@google.com2008-08-112-22/+22
| | | | | | TBR=mal git-svn-id: svn://svn.chromium.org/chrome/trunk/src@657 0039d316-1c4b-4281-b951-d872f2087c98
* A simple view that wraps a RenderViewHost in an HWNDView, to facilitatetimsteele@google.com2008-08-113-0/+168
| | | | | | | | rendering HTML as an arbitrary browser view. DOMView currently does something like this, but it uses TabContents and is hence pretty heavyweight. We may be able to replace DOMView with HWNDHtmlView. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@656 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup setup.exe:rahulk@google.com2008-08-117-96/+20
| | | | | | | | | - Remove various migration code for shortcuts (now 149.13 has been pushed to everybody) - Cleanup error messages that will show up in log file with the default logging level - Remove junk error messages that haven't been helpful at all (delete registry key/valye errors) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@655 0039d316-1c4b-4281-b951-d872f2087c98