| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
| |
but we don't care.
BUG=28179
TEST=none
Review URL: http://codereview.chromium.org/404036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32437 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=10342
TEST=none
Review URL: http://codereview.chromium.org/399091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
on Linux.
Some crashers on window close have been fixed so let's try running this again. I was unable to repro from running the test in a loop for a few hours.
TBR=erikkay
Review URL: http://codereview.chromium.org/408016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/404035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32433 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28179
TEST=valgrind bot goes green.
TBR=tony
Review URL: http://codereview.chromium.org/406008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Enable bookmarks on Linux. The dialog should no longer be too large.
Review URL: http://codereview.chromium.org/402070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
and fix includes so service side and compile
with system GL and client side can compile
with Command Buffer GL.
Review URL: http://codereview.chromium.org/407006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/373001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
URLRequestContext it was using for downloads is destroyed.
This avoids the possibility of accessing freed memory when sharing ProxyService amongst request context, and the main context is destroyed first.
BUG=25338
Review URL: http://codereview.chromium.org/387065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/405022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also mostly fix the placement of the "For quick access, place your bookmarks here [...]" message (when there are no bookmarks). It's not quite right in the new animation (detached <-> normal).
BUG=25600, 27692, 27693
TEST=Go to NTP and press Cmd-Shift-B a few times while watching closely. The detached bar should "morph" smoothly to the normal bar and vice versa. Switch themes and repeat; please test at least the default theme and the Brushed theme.
Review URL: http://codereview.chromium.org/400020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
when you lstrcat a NULL string (in the case where there are no
additional parameters).
BUG=none
TEST=windbg mini_installer.exe, should see no first-chance access violation
Review URL: http://codereview.chromium.org/408012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32424 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=28179
TEST=none
Review URL: http://codereview.chromium.org/406007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32423 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r32410. Stupid tests.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/402067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32420 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
to send an NPN_SetException back to the correct renderer if necessary. BUG=26764 TEST=none
Review URL: http://codereview.chromium.org/375005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
newest cache.
TEST=test added to catch bug
BUG=none
Review URL: http://codereview.chromium.org/399078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32417 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27103
TEST=Use xfce-stellar theme. There shouldn't be an inner box in the location bar and typing shouldn't cause text to move up and down.
Review URL: http://codereview.chromium.org/399087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We currently throw an error when loading the extension,
which is overly aggressive.
BUG=28158
TEST=Specify matches=file://* in the manifest for a
content script and make sure the extension still loads.
Review URL: http://codereview.chromium.org/402069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* SplitUrlAndTitle() can't fail, so it doesn't need to return a bool.
* assign() can do substrings in one shot
* Half the code used "*str =" and half "str->assign()", often right next to each other; pick one for consistency
* No need to calculate array sizes when we're the ones declaring them
* Use early return in a few places
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/405023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Don't show promo for extensions on Mac, as they're not available yet. Decrement promo counter even when NTP is not home page, and do not remove puzzle piece when promo line is closed. When message bar is closed, make it zip off bottom of screen instead of just disappearing.
BUG= 27814, 25258, 27815
TEST= see various bugs.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32176
Review URL: http://codereview.chromium.org/385135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/403020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We don't want to ever go out to disk when looking for data after
startup, since they can be changed by an update.
We *should* just be using the zygote, but the zygote is sandboxed-only
for now, and fixing that has a lengthy dependency graph. In the
interim, /proc/self/exe is the correct executable and exec'ing it should
work as long as the subprocess doesn't need any other files from the
Chrome directory.
BUG=22703
TEST=Start Chrome. Move away the entire Chrome directory; plugins
should still work.
Review URL: http://codereview.chromium.org/403018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/399082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
given the current design and triggers a crash. I'm also effectively
disabling DockInfo for ChromeOS as that triggers a crash. I don't
believe we'll hit the code after my first change, but I'm going for
completeness.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/399083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32408 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
How did this happen?
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/402068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Forward exceptions in child processes to Apple's Crash Reporter
BUG=22659
TEST=none
Review URL: http://codereview.chromium.org/406006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This involves implementing row-at-a-time and line-at-a-time repainting of the backing store.
R=darin
BUG=21510
TEST=LayoutTests/fast/repaint/shadow-multiple*
Review URL: http://codereview.chromium.org/397027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/405021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=28159
TEST=Flash 10.1 pre-release should use Cocoa event model (which currently means playback stalls when there are no mouse events coming in).
Review URL: http://codereview.chromium.org/399079
TBR=amanda@chromium.org
Review URL: http://codereview.chromium.org/402064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28159
TEST=Flash 10.1 preview should work reasonably well.
Review URL: http://codereview.chromium.org/399079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=22210 (this is not a partial mitigation, not a fix)
Review URL: http://codereview.chromium.org/399043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on out of memory.
BUG=27222
TEST=new base unittests
Review URL: http://codereview.chromium.org/391044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The difference in upstream repaint areas as compared to upstream results is due the difference in repaint logic.
Safari/Mac port uses NSView's native rectangle collection/unification, and we just unify all into one damage rect.
R=jparent
BUG=8630
TEST=none
Review URL: http://codereview.chromium.org/400024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Change your password after logging into bookmark sync, then restart your browser. There should be a warning button on the bookmark bar now.
Review URL: http://codereview.chromium.org/387054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Run chrome with --enable-sync. While bookmark sync is disabled, click on Wrench Menu->Sync My Bookmarks
Review URL: http://codereview.chromium.org/402059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
return an undefined value.chrome.experimental.extension.getPopupView() may return undefined if no pop-up is currently displayed.chrome.experimental.popup.getParentWindow() may return undefined if called from a non-popup view.BUG=28045TEST=extension_popup_apitest.cc
Review URL: http://codereview.chromium.org/400023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
GYP changes to allow test_shell be buildable on ARM so we can
use it as a minimal browser for testing purpopse.
Review URL: http://codereview.chromium.org/399077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note that, per Apple's HIG, the context menu alternates between Pin/Unpin Tab instead of toggling a checkmark.
Changes to TabView.xib:
- add Pin Tab item (to match Windows)
Still to do:
- dragging/dropping tabs needs visual feedback to indicate how pinned state will change (need input from UI team)
- on Windows, you can pin a tab by dragging it slightly to the right of the rightmost pinned tab; this needs to be done
BUG=25481
TEST=not yet
Review URL: http://codereview.chromium.org/375010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=browser_tess --gtest_filter=BrowserActionTest* should pass on linux/view build.
Review URL: http://codereview.chromium.org/404021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The fix is to add --ignored=" --type=renderer " to the command line of
non-renderer, non-plugin subprocesses, tricking GD into not injecting its DLL.
BUG=25580
Review URL: http://codereview.chromium.org/400026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
linux/views.
see http://crbug/28098 for more details about the root cause of the issue.
BUG=28098
TEST=brower_tests passes with this hack, but we need real solution.
Review URL: http://codereview.chromium.org/397037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This test will allow us to know when the tests fail because the http server failed to start and not due to a NaCl problem
This CL depends on http://codereview.chromium.org/394016/show
TEST=this CL
BUG=none
Review URL: http://codereview.chromium.org/385113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This removes the two-state purge/reset code (no longer necessary), and the hooks to the power monitor (not ready to turn those on without more work and testing).
BUG=23400
TEST=Run Chrome with --purge-memory-button, use it for awhile, open the Task Manager, and click "Purge Memory". You should still be able to use the program normally, and hopefully we dumped some memory out too (varies by usage).
Review URL: http://codereview.chromium.org/399028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=27884
TEST=see bug.
Review URL: http://codereview.chromium.org/385148
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/407004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=abarth
BUG=25133
TEST=none. A cosmetic change.
Review URL: http://codereview.chromium.org/403011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/404030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/406003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/406004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32370 0039d316-1c4b-4281-b951-d872f2087c98
|