summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Added a new case in unit test, and fixed some post-commit commentsgspencer@chromium.org2010-10-293-60/+87
| | | | | | | | | | | from last review. BUG=none TEST=ran unit test. Review URL: http://codereview.chromium.org/3848001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64512 0039d316-1c4b-4281-b951-d872f2087c98
* Added the execute command will will run javascript on the remotejmikhail@google.com2010-10-299-15/+329
| | | | | | | | | | | client. BUG=none TEST=webdriver_remote_tests.py Review URL: http://codereview.chromium.org/3618018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64511 0039d316-1c4b-4281-b951-d872f2087c98
* Added check in page click tracker to ensure events passed in are mouse eventscdn@chromium.org2010-10-291-1/+3
| | | | | | | | | BUG=61255 TEST=None Review URL: http://codereview.chromium.org/4120011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64510 0039d316-1c4b-4281-b951-d872f2087c98
* Build fix horror show.zelidrag@chromium.org2010-10-291-1/+0
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/4119019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64507 0039d316-1c4b-4281-b951-d872f2087c98
* Yet another build break fix. zelidrag@chromium.org2010-10-291-0/+1
| | | | | | | | | | TEST=none BUG=none TBR=chocobo Review URL: http://codereview.chromium.org/4158012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64504 0039d316-1c4b-4281-b951-d872f2087c98
* Disable PDF tests on Mac.jam@chromium.org2010-10-291-0/+3
| | | | | | | BUG=61258 Review URL: http://codereview.chromium.org/4220006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64503 0039d316-1c4b-4281-b951-d872f2087c98
* Build break fix for the official build.zelidrag@chromium.org2010-10-291-7/+8
| | | | | | | | | | TEST=none BUG=chromium-os:7619 TBR=chocobo Review URL: http://codereview.chromium.org/4184011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64501 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Adjust the profile labels when updating a specific profile.jhawkins@chromium.org2010-10-291-0/+3
| | | | | | | | | BUG=61013 TEST=none Review URL: http://codereview.chromium.org/4089013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64499 0039d316-1c4b-4281-b951-d872f2087c98
* Resolve three unrelated issues:scherkus@chromium.org2010-10-296-18/+49
| | | | | | | | | | | | | | | | | | -- Added support for detection of the browse's locale; TODO: need to localize end user messages. -- Fixed a script tag leak in case the user is off-line and made reconnecting more reliable. -- Added support for focusing individual chat widget, when one selects contact in the chat manager. Needs additional support from the supermoles (separate check-in). Patch by ivaylobakalov@chromium.org: http://codereview.chromium.org/4186010/show BUG=chromium-os:3846 TEST=See http://code.google.com/p/chromium-os/issues/detail?id=3846 [PROCEDURE] git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64497 0039d316-1c4b-4281-b951-d872f2087c98
* Re-landing issue 4202006 (http://codereview.chromium.org/4202006/show) which ↵sanjeevr@chromium.org2010-10-2915-573/+1047
| | | | | | | | | | | was reverted because of a Valgrind leak. Fixed the memory leak in the unit-test. BUG=None. TEST=Unit-tests, Valgrind bots. Review URL: http://codereview.chromium.org/4165013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64496 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Add Ctrl-/ accelerator for help app.derat@chromium.org2010-10-293-2/+19
| | | | | | | | | | | | | | This adds Ctrl-/ and Ctrl-Shift-/ (Ctrl-?) accelerators for the help command in Views GTK, updates the help URL for Chrome OS, and makes us print "/" explicitly in accelerator descriptions instead of "slash" (the string we get from GDK). BUG=chromium-os:7835 TEST=built and ran it Review URL: http://codereview.chromium.org/4156004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64495 0039d316-1c4b-4281-b951-d872f2087c98
* Removing stack from known crashes, fixed in 64194ace@chromium.org2010-10-291-3/+0
| | | | | | | | BUG=56747 Review URL: http://codereview.chromium.org/4161008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64494 0039d316-1c4b-4281-b951-d872f2087c98
* These are files need to be added to benchmarks extension.lzheng@chromium.org2010-10-293-0/+580
| | | | | | | | | | | | | These files should be part of http://codereview.chromium.org/4123001/, but were missed during the original patch. Contributed by Jianxia Ning <jning@google.com>. BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64493 0039d316-1c4b-4281-b951-d872f2087c98
* Change LOG(INFO) to VLOG(1).gene@google.com2010-10-292-9/+9
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4105007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64491 0039d316-1c4b-4281-b951-d872f2087c98
* Moved private functions into it's own seperate utils file for commonly used ↵nirnimesh@chromium.org2010-10-292-24/+50
| | | | | | | | functions. Review URL: http://codereview.chromium.org/4148012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64490 0039d316-1c4b-4281-b951-d872f2087c98
* Make plugin requests retrievable from the appcache for nplugins and pepper.michaeln@chromium.org2010-10-292-0/+17
| | | | | | | | | BUG=61146 TEST=thinking about how to make a test for this? Review URL: http://codereview.chromium.org/4158007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64489 0039d316-1c4b-4281-b951-d872f2087c98
* Add collapsible sections to the Chrome extension documentation sidebar.kurrik@chromium.org2010-10-2964-65/+412
| | | | | | | | | | | | | * Adds a new "toggle" sprite to the documentation images. * Adds CSS classes for the toggles. * Includes "sidebar.js" for documentation pages which implements the toggles in JavaScript. BUG=49239 TEST=None Review URL: http://codereview.chromium.org/4005003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64488 0039d316-1c4b-4281-b951-d872f2087c98
* Remove BrowserInitTest.BlockBadURLsjschuh@google.com2010-10-291-30/+0
| | | | | | | | | | It's not a necessary test and it consistently fails due to timing issues on the bots. BUG=60026 TEST=None. Review URL: http://codereview.chromium.org/4113005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64486 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] force standard font size on infobars.estade@chromium.org2010-10-291-1/+8
| | | | | | | | | | | As usual, we'd ideally like to obey the system application font size, but the rest of the UI doesn't scale so it looks bad. BUG=61132 TEST=manual Review URL: http://codereview.chromium.org/4110007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64482 0039d316-1c4b-4281-b951-d872f2087c98
* Crash fix due to uninitialized pointers.zelidrag@chromium.org2010-10-292-14/+5
| | | | | | | | | BUG=chromium-os:7619 TEST=none Review URL: http://codereview.chromium.org/4110009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64481 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily silence fast/images/svg-as-background.html on mac webkit bots.dimich@chromium.org2010-10-291-1/+1
| | | | | | | | | | TBR=nirnimesh BUG=none TEST=none Review URL: http://codereview.chromium.org/4194006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64480 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flaky notification.NotificationsTest.testCancelNotification test.kkania@chromium.org2010-10-292-12/+22
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4140010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64479 0039d316-1c4b-4281-b951-d872f2087c98
* BrowserThemePacks can do IO during shutdown, so delete them on the FILE thread.erg@google.com2010-10-291-3/+11
| | | | | | | | | BUG=61135 TEST=none Review URL: http://codereview.chromium.org/4213005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64478 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64454 - Revert 64441 - Mac cloud print proxy work.scottbyer@google.com2010-10-295-14/+39
| | | | | | | | | | | | | | | | | | | Turn on use_cups for the Mac, add in the required library, and tweak the code to get it linking. There is still more work to do; this is just a gyp-oriented change to get things started. BUG=none TEST=All targets still build on all platforms. Review URL: http://codereview.chromium.org/4167006 TBR=scottbyer@chromium.org Review URL: http://codereview.chromium.org/4136011 TBR=scottbyer@google.com Review URL: http://codereview.chromium.org/4137013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64477 0039d316-1c4b-4281-b951-d872f2087c98
* Print Preview: Don't build print preview tests on ChromeOS.thestig@chromium.org2010-10-291-0/+6
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4133009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64476 0039d316-1c4b-4281-b951-d872f2087c98
* Make icon-text spacing configurable.oshima@chromium.org2010-10-292-7/+15
| | | | | | | | | | | | This is to implement shutdown button on login/locker screen, which has wider icon-text spacing 10 than 5. See crosbug.com/974 for the mock. BUG=chromium-os:974, chromium-os:5763 TEST=none Review URL: http://codereview.chromium.org/4192004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64475 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI Cert Manager: Disable delete button on readonly certs.mattm@chromium.org2010-10-294-1/+14
| | | | | | | | | | BUG=19991 BUG=chromium-os:7946 TEST=delete button should be disabled on built-in certs, and enabled on user-imported certs Review URL: http://codereview.chromium.org/4130002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64473 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Skip past intervening empty TDs when parsing labels.jhawkins@chromium.org2010-10-293-14/+88
| | | | | | | | | BUG=57107 TEST=FormStructure.LabelsInferredFromTableEmptyTDs Review URL: http://codereview.chromium.org/4146014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64470 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64466 - Language tag for speech.nirnimesh@chromium.org2010-10-2914-42/+28
| | | | | | | | | | | | | | | | | | | | | This is the 3rd in a 4-sided patch to add language attribute support to speech input. The other patches can be found here: 1st - http://codereview.chromium.org/3615005/show 2nd - https://bugs.webkit.org/show_bug.cgi?id=47089 4th - https://bugs.webkit.org/show_bug.cgi?id=47420 This patch will be submitted once the webkit change has been rolled into chromium DEPS. Also, a last webkit cleanup patch will be submitted at any point after the 2nd patch. BUG=53598 TEST= Review URL: http://codereview.chromium.org/3595018 TBR=leandrogracia@chromium.org Review URL: http://codereview.chromium.org/4163005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64469 0039d316-1c4b-4281-b951-d872f2087c98
* Disable print preview DOMUI on ChromeOS. It was enabled by accident.thestig@chromium.org2010-10-291-2/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4119018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64467 0039d316-1c4b-4281-b951-d872f2087c98
* Language tag for speech.leandrogracia@chromium.org2010-10-2914-28/+42
| | | | | | | | | | | | | | | | | | This is the 3rd in a 4-sided patch to add language attribute support to speech input. The other patches can be found here: 1st - http://codereview.chromium.org/3615005/show 2nd - https://bugs.webkit.org/show_bug.cgi?id=47089 4th - https://bugs.webkit.org/show_bug.cgi?id=47420 This patch will be submitted once the webkit change has been rolled into chromium DEPS. Also, a last webkit cleanup patch will be submitted at any point after the 2nd patch. BUG=53598 TEST= Review URL: http://codereview.chromium.org/3595018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64466 0039d316-1c4b-4281-b951-d872f2087c98
* Fix tabbing into web area not focusing first element.avi@chromium.org2010-10-295-1/+47
| | | | | | | | | BUG=49738 TEST=as in bug Review URL: http://codereview.chromium.org/3153039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64465 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill deprecate unique_ids in favor of guids for WebDataServicedhollowa@chromium.org2010-10-296-114/+684
| | | | | | | | | | | Provides GUID-based APIs for Add, Update, Remove for both Autofill credit cards and profiles. New Autofill change notifications for these GUID-based APIs. BUG=58813 TEST=WebDataServiceAutofillTest.* Review URL: http://codereview.chromium.org/4102012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64464 0039d316-1c4b-4281-b951-d872f2087c98
* For add network, if password is empty, we search for a hidden network with ↵chocobo@chromium.org2010-10-291-2/+3
| | | | | | | | | | no security. BUG=chromium-os:8193 TEST=manual Review URL: http://codereview.chromium.org/4142012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64461 0039d316-1c4b-4281-b951-d872f2087c98
* Update status menu button positions.chocobo@chromium.org2010-10-296-4/+15
| | | | | | | | BUG=chromium-os:8135 TEST=manual Review URL: http://codereview.chromium.org/4219002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64460 0039d316-1c4b-4281-b951-d872f2087c98
* Put some thought into appropriate verbosity level for cookie DVLOGS.rdsmith@google.com2010-10-291-14/+25
| | | | | | | | | BUG=None TEST=None (trybots). Review URL: http://codereview.chromium.org/4196001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64459 0039d316-1c4b-4281-b951-d872f2087c98
* New shockwave security update.panayiotis@google.com2010-10-291-2/+2
| | | | | | | | | | http://www.adobe.com/support/security/bulletins/apsb10-25.html BUG=61152 TEST=test_shell_tests Review URL: http://codereview.chromium.org/4209004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64455 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 64441 - Mac cloud print proxy work.scottbyer@google.com2010-10-295-39/+14
| | | | | | | | | | | | | | | | Turn on use_cups for the Mac, add in the required library, and tweak the code to get it linking. There is still more work to do; this is just a gyp-oriented change to get things started. BUG=none TEST=All targets still build on all platforms. Review URL: http://codereview.chromium.org/4167006 TBR=scottbyer@chromium.org Review URL: http://codereview.chromium.org/4136011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64454 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use last_access_time vs. Now() comparison to mean "all cookies".rdsmith@google.com2010-10-292-3/+2
| | | | | | | | | BUG=60015 TEST=net_unittests CookieMonsterTest.* (flakiness was rare enough that the only real test will be committing and seeing if the problem is fixed). Review URL: http://codereview.chromium.org/4131001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64453 0039d316-1c4b-4281-b951-d872f2087c98
* New background images from Nicholas.sky@chromium.org2010-10-293-0/+0
| | | | | | | | | | BUG=none TEST=none TBR=davemoore@chromium.org Review URL: http://codereview.chromium.org/4098009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64450 0039d316-1c4b-4281-b951-d872f2087c98
* Minor change to context menu doc, to fix a problem noticedkathyw@chromium.org2010-10-292-2/+2
| | | | | | | | | | | | by PhistucK. (I tested the code this time, to make sure it was correct.) BUG=none TEST=none Review URL: http://codereview.chromium.org/4184009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64449 0039d316-1c4b-4281-b951-d872f2087c98
* Build break fix.zelidrag@chromium.org2010-10-291-3/+3
| | | | | | | | | | TEST=none BUG=chromium-os:7619 TBR=gspencer Review URL: http://codereview.chromium.org/4165012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64447 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid the use of wow_helper for Windows7cpu@chromium.org2010-10-291-2/+5
| | | | | | | | | | | | | | | In Windows7 64-bit the wow subsystem maps the 32 bit ntdll from the get go, so there is no need to use wow_helper at all. This also should speed process creation for chrome. BUG=60854 TEST=existing validation and integration tests suffice. Review URL: http://codereview.chromium.org/4185004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64446 0039d316-1c4b-4281-b951-d872f2087c98
* Rewritten parts of NetworkLibrary to work around memory corruption that ↵zelidrag@chromium.org2010-10-2926-877/+1015
| | | | | | | | | | | | | | | prevented proper dbus functioning for 3G actrivation. The principle behind this change is pretty simple - there is only one instance of chromeos::Network specialization representing a network service at the time. Please note that there are parts of obsolete UI elements where object copies were still made. The cellular plan part is still work in progress, but there is enough to be reviewed now so I want to get an early start right now. BUG=chromium-os:7619 TEST=none Review URL: http://codereview.chromium.org/4169001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64445 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 70882:70891 to fix expectationsmnaganov@chromium.org2010-10-291-1/+1
| | | | | | | | | | TBR=dimich@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/4175010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64444 0039d316-1c4b-4281-b951-d872f2087c98
* Mac cloud print proxy work.scottbyer@chromium.org2010-10-295-14/+39
| | | | | | | | | | | | | Turn on use_cups for the Mac, add in the required library, and tweak the code to get it linking. There is still more work to do; this is just a gyp-oriented change to get things started. BUG=none TEST=All targets still build on all platforms. Review URL: http://codereview.chromium.org/4167006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64441 0039d316-1c4b-4281-b951-d872f2087c98
* Fix positioning of first run bubble.mirandac@chromium.org2010-10-292-1/+25
| | | | | | | | BUG=60576 TEST= trigger first run bubble by running Chrome with --first-run on an empty profile. Note that bubble points to a spot just to the right of the magnifying glass icon, where the user would begin typing a search term. Review URL: http://codereview.chromium.org/4143008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64440 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for: Google chrome consuming internet upload bandwidth - protecting ↵georgey@chromium.org2010-10-294-14/+301
| | | | | | | | | | ourselves from malformed forms BUG=60422 TEST=unit-tested Review URL: http://codereview.chromium.org/4128011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64437 0039d316-1c4b-4281-b951-d872f2087c98
* Add optional close button for BubbleWindow.dilmah@chromium.org2010-10-297-16/+96
| | | | | | | | | | | Use this for proxy settings dialog at OOBE. BUG=http://crosbug.com/8235 TEST=Manual Review URL: http://codereview.chromium.org/4124005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64436 0039d316-1c4b-4281-b951-d872f2087c98
* [ChromeOS] Use maxmized logic for fullscreen browser window.xiyuan@chromium.org2010-10-291-1/+8
| | | | | | | | | | | This should avoid accidental SetVisible on min/max/restore buttons. BUG=chromium-os:8261 TEST=Verify fix for chromium-os:8261. Review URL: http://codereview.chromium.org/4206003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64435 0039d316-1c4b-4281-b951-d872f2087c98