summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Added validation for non-emptiness of the label.georgey@chromium.org2010-02-052-1/+55
| | | | | | | | TEST=If any label (in address or credit card) is empty, the save button is disabled. Otherwise it is enabled. BUG=33026 Review URL: http://codereview.chromium.org/575027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38245 0039d316-1c4b-4281-b951-d872f2087c98
* Minor unittest cleanup.eroman@chromium.org2010-02-051-24/+21
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/561082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38244 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the HostResolver::Shutdown() method.eroman@chromium.org2010-02-057-17/+9
| | | | | | | | | | | While this doesn't entirely remove the hack, it limits the scope of it to HostResolverImpl. Hopefully in the future HostResolver will not be refcounted so this can go away altogether. BUG=18373 Review URL: http://codereview.chromium.org/569035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38243 0039d316-1c4b-4281-b951-d872f2087c98
* Don't crash when a theme specifies a non-existant image.erg@chromium.org2010-02-054-6/+31
| | | | | | | | | | | Fixes the current TopCrasher. BUG=31719 TEST=BrowserThemePackTest.TestNonExistantImages Review URL: http://codereview.chromium.org/572039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38242 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed the following issues with SPDY server push.cbentzel@chromium.org2010-02-054-15/+48
| | | | | | | | | | | | | * A NULL stream was added to pushed_streams_ * FlipStream had a NULL HttpResponseInfo pointer. In non-server-push paths, this pointer references a member of the associated FlipNetworkTransaction. In this case, I just leak memory - needs a better solution. * io_state_ was set to NONE on a server push, which DCHECK'ed in the first state machine loop. Changed it to jump to READ_HEADERS state. BUG=NONE TEST=Manual Review URL: http://codereview.chromium.org/551006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38241 0039d316-1c4b-4281-b951-d872f2087c98
* skia is absolute coords for rectsdavemoore@chromium.org2010-02-054-126/+236
| | | | | | Review URL: http://codereview.chromium.org/575017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38240 0039d316-1c4b-4281-b951-d872f2087c98
* Add an extension API test to catch cookie regressions.mpcomplete@chromium.org2010-02-054-0/+49
| | | | | | | | BUG=34649 Review URL: http://codereview.chromium.org/573032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38239 0039d316-1c4b-4281-b951-d872f2087c98
* Add a test executable to allow verifying which minidump flag configurations ↵siggi@chromium.org2010-02-052-0/+444
| | | | | | | | | | | work on which OSen. BUG=32441 TEST=none Review URL: http://codereview.chromium.org/578003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38238 0039d316-1c4b-4281-b951-d872f2087c98
* Yet more tab strip model changes. I'm hoping this is the last ofsky@chromium.org2010-02-058-79/+287
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | it. I'm now going with: // . Mini-tab. Mini tabs are locked to the left side of the tab strip and // rendered differently (small tabs with only a favicon). The model makes // sure all mini-tabs are at the beginning of the tab strip. For example, // if a non-mini tab is added it is forced to be with non-mini tabs. Requests // to move tabs outside the range of the tab type are ignored. For example, // a request to move a mini-tab after non-mini-tabs is ignored. // You'll notice there is no explcit api for making a tab a mini-tab, rather // there are two tab types that are implicitly mini-tabs: // . App. Corresponds to an extension that wants an app tab. App tabs are // identified by TabContents::is_app(). // . Pinned. Any tab can be pinned. A pinned tab is made phantom when closed. // Non-app tabs whose pinned state is changed are moved to be with other // mini-tabs or non-mini tabs. I'm going with a more neutral name like mini-tabs so that we can change the meaning if we need to without changing around all the UI code. I'll convert the UI code next. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/570043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38237 0039d316-1c4b-4281-b951-d872f2087c98
* Worked around bug in 32-bit Safari 4 on Mac OS X 10.6 where thekbr@chromium.org2010-02-051-0/+6
| | | | | | | | | | browser sends O3D a spurious NPP_SetWindow with an invalid window after first sending it a valid one. Tested this on both 10.6 and 10.5; no ill effects on 10.5, including in multiple tab case. Review URL: http://codereview.chromium.org/572027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38236 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed build problem on Mac OS X 10.6. precompile.h is inferred by namekbr@chromium.org2010-02-051-0/+2
| | | | | | | | | | | | to be a C file, but it includes C++ headers like <vector> and <algorithm>. In order for the compiler to find these headers it was necessary to force it to treat this as a C++ header. This fix was determined to be necessary on multiple machines running Xcode 3.2.1. It has also been tested on 10.5 with no ill effects. Review URL: http://codereview.chromium.org/572026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38235 0039d316-1c4b-4281-b951-d872f2087c98
* Tab strip model: Fix an off by one error where we do not check the first tab.thestig@chromium.org2010-02-051-15/+10
| | | | | | | | BUG=33323 TEST=see bug Review URL: http://codereview.chromium.org/561066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38234 0039d316-1c4b-4281-b951-d872f2087c98
* Enable onhttpequiv again. The difference this time around is that wetommi@chromium.org2010-02-053-136/+83
| | | | | | | | | | | | | perform the switch in onhttpequiv when done==false. Also, we don't rely on having access to the already existing moniker but instead create our own and DCHECK that it is IsRunning() (see comments). TEST=The double loading effect we were seeing before should be gone. BUG=33332 Review URL: http://codereview.chromium.org/576017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38232 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call View::DidChangeBounds() when the bounds didn't changedavemoore@chromium.org2010-02-051-6/+7
| | | | | | | | | Bug: None Test: Views based UI should still layout correctly Review URL: http://codereview.chromium.org/574013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38231 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the URLRequestTest.CookiePolicy_ForceSession test to the list of ↵ananta@chromium.org2010-02-051-0/+1
| | | | | | | | | | | | disabled tests as it does not apply to the host network stack. TBR=amit Review URL: http://codereview.chromium.org/572040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38230 0039d316-1c4b-4281-b951-d872f2087c98
* Don't need ipc_message.h any morecmasone@google.com2010-02-052-16/+0
| | | | | | Review URL: http://codereview.chromium.org/577025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38229 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds support for displaying Chrome InfoBars in pages rendered via ↵ananta@chromium.org2010-02-056-26/+88
| | | | | | | | | | | | | | | | | | ChromeFrame. To achieve this the ExternalTabContainer now creates a view which comprises of the InfoBarContainer and the TabContentsContainer view. It uses the GridLayout manager to layout this view. The InfoBarContainer no longer depends on the BrowserView. It now passes notifications to the InfoBarContainerDelegate interface which is implemented by the BrowserView and the ExternalTabContainer. Fixes bug http://code.google.com/p/chromium/issues/detail?id=24051 Bug=24051 Review URL: http://codereview.chromium.org/573022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38228 0039d316-1c4b-4281-b951-d872f2087c98
* Add Single Sign On support to HTTP Authentication handlers.cbentzel@chromium.org2010-02-0521-185/+457
| | | | | | | | | | | | | | | Currently this is implemented on Windows for the NTLM and Negotiate schemes. This CL does not introduce the hooks to actually use Single Sign On in response to a 401/407 request - that will come in a later CL. This behavior is disabled for now as well. BUG=29862 TEST=Ran unittests, and Chrome against a server with authentication challenges. Review URL: http://codereview.chromium.org/555174 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38227 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crasher in LocationBarView when browser is closed with page action ↵mirandac@chromium.org2010-02-054-19/+31
| | | | | | | | | | install bubble showing. BUG= 34282 TEST= in release version, create a page action. close browser window while page action install bubble is showing. no crash, ever. Review URL: http://codereview.chromium.org/561028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38225 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak the crash dump flags to make sure we get PEB/TEB and the unloaded ↵siggi@chromium.org2010-02-051-1/+20
| | | | | | module list where available. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38224 0039d316-1c4b-4281-b951-d872f2087c98
* Show the filebrowse ui rather than the download shelf in chromeos.xiyuan@chromium.org2010-02-058-26/+95
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This cl displays the filebrowse ui rather than download shelf for downloads in chrom(e|ium) os. It conditionally replaces (with preprocessor macros) the Browser::OnStartDownload method to do this. The cl adds a static FileBrowseUI::OpenPopup(profile, hashArgument), which opens the file browse ui and passes it the provided hash argument. This is invoked directly from Browser::OnStartDownload. The USBMountObserver code was changed to call this static method, rather than open the popup by hand as it had been doing. I'm not sure about ownership of the Browser* returned by OpenPopup, but based on other code in the tree I assume chrome will deal with freeing it when appropriate. Before this change, USBMountObserver would add the window to registrar_ *before* showing it. Now that FileBrowseUI::OpenPopup returns a which which is already visible, this is no longer the case. I assume this won't be a problem. Commit this for rginda. Original review: http://codereview.chromium.org/555167 BUG=none TEST=none Review URL: http://codereview.chromium.org/564022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38222 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare for running nacl_ui_test on Mac and Linux.gregoryd@google.com2010-02-051-0/+6
| | | | | | | | This is the NaCl-Chrome integration test that runs in Chrome waterfall, currently on Windows only. I am working on starting new bots that will run it on Mac and Linux. Review URL: http://codereview.chromium.org/563021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38218 0039d316-1c4b-4281-b951-d872f2087c98
* Update my watchlist.finnur@chromium.org2010-02-051-0/+9
| | | | | | | | | BUG=None TEST=None (no code change) Review URL: http://codereview.chromium.org/577023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38217 0039d316-1c4b-4281-b951-d872f2087c98
* Make Carbon plugin idle event source robust against changes during iterationstuartmorgan@chromium.org2010-02-051-57/+62
| | | | | | | | | | | | | Ensure that removing any plugin from the idle event source during iteration is safe (not just the currently-firing plugin). Also bullet-proofs against the possibility of nested iteration. Refactors the idle event source to use a helper class, to reduce duplicate code. BUG=33467 TEST=Scroll rapidly on a page with multiple instances of a Cabon plugin. Review URL: http://codereview.chromium.org/575023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38216 0039d316-1c4b-4281-b951-d872f2087c98
* Makes example.com resolve to localhost for test.sky@chromium.org2010-02-051-0/+2
| | | | | | | | | | BUG=32845 TEST=none TBR=erikkay Review URL: http://codereview.chromium.org/573029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38215 0039d316-1c4b-4281-b951-d872f2087c98
* Mark inspector\console-log-before-inspector-open.html as flaky.yurys@chromium.org2010-02-051-0/+1
| | | | | | | | | BUG=34759 TBR=pfeldman Review URL: http://codereview.chromium.org/577022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38214 0039d316-1c4b-4281-b951-d872f2087c98
* Split out of reverted change ↵joth@chromium.org2010-02-053-13/+23
| | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=38207 Commit fixes to code under test, whilst tests themselves are still pending. BUG=http://crbug.com/11246 TEST=see http://codereview.chromium.org/578006 Review URL: http://codereview.chromium.org/571014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38213 0039d316-1c4b-4281-b951-d872f2087c98
* Wires TabContents to app extensions.sky@chromium.org2010-02-0511-58/+174
| | | | | | | | | BUG=32845 TEST=none Review URL: http://codereview.chromium.org/566032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38212 0039d316-1c4b-4281-b951-d872f2087c98
* Add bugs, update, and remove TODOs that are no longer validpinkerton@chromium.org2010-02-0517-77/+20
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/577021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38211 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid out-of-bounds array access.cevans@chromium.org2010-02-051-1/+2
| | | | | | | | | TEST=NONE BUG=34710 Review URL: http://codereview.chromium.org/572031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38209 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 38207 - bah. still can't work out why this passes fine on local ↵joth@chromium.org2010-02-055-416/+13
| | | | | | | | | | | | | | | | | | | | | machine & try bots. Reattempt at http://src.chromium.org/viewvc/chrome?view=rev&revision=37989 (asserts tidy up slit out into its own change http://codereview.chromium.org/578013/show) Add tests for the geolocation network provider. Also some small tidy up a few other files. BUG=http://crbug.com/11246 TEST=unit_tests.exe gtest_filter=NetworkLocationProvider* gtest_break_on_failure Review URL: http://codereview.chromium.org/578006 TBR=joth@chromium.org Review URL: http://codereview.chromium.org/575021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38208 0039d316-1c4b-4281-b951-d872f2087c98
* Re-attempt at http://src.chromium.org/viewvc/chrome?view=rev&revision=37989 joth@chromium.org2010-02-055-13/+416
| | | | | | | | | | | | | | | (asserts tidy up slit out into its own change http://codereview.chromium.org/578013/show) Add tests for the geolocation network provider. Also some small tidy up a few other files. BUG=http://crbug.com/11246 TEST=unit_tests.exe --gtest_filter=NetworkLocationProvider* --gtest_break_on_failure Review URL: http://codereview.chromium.org/578006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38207 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit side is in https://bugs.webkit.org/show_bug.cgi?id=34524jeremy@chromium.org2010-02-055-1/+105
| | | | | | | | | BUG=NONE TEST=Right clicking on a text input field in Web content on OS X should now show a Writing Direction submenu. Clicking on "Left To Right" should align the input to the left, and "Right To Left" should do the opposit. The "Default" menu item should always be disabled. Review URL: http://codereview.chromium.org/566031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38204 0039d316-1c4b-4281-b951-d872f2087c98
* Split out of reverted change ↵joth@chromium.org2010-02-055-9/+10
| | | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=37989 Tidy up assertions to use CHECKs (Already reviewed as part of above change) BUG=none TEST=none Review URL: http://codereview.chromium.org/578013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38203 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 318.0 to 319.0chrome-release@google.com2010-02-051-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38202 0039d316-1c4b-4281-b951-d872f2087c98
* Remove context accessor crash from known crashes after pushing V8ager@chromium.org2010-02-051-3/+0
| | | | | | | fix to chromium. Review URL: http://codereview.chromium.org/578012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38201 0039d316-1c4b-4281-b951-d872f2087c98
* Enable JAVASCRIPT_DEBUGGER flag. JSC-dependent parts of WebCore were guarded ↵mnaganov@chromium.org2010-02-051-1/+0
| | | | | | | | | | | | | with USE(JSC). TBR=pfeldman@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/572032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38200 0039d316-1c4b-4281-b951-d872f2087c98
* Update V8 to version 2.1.0.ager@chromium.org2010-02-056-6/+21
| | | | | | | | | This version contains a number of bugfixes including wrapping of values when calling user-defined functions and a stricter JSON parser. Review URL: http://codereview.chromium.org/572033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38199 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable a unittest which failed on valgrind thread sanitizer.eroman@chromium.org2010-02-051-1/+5
| | | | | | | | | | | | | TSAN had reported a race on the bool |should_block_|, between BlockableProxyResolver::GetProxyForURL() and BlockableProxyResolver::Unblock(). I avoided the problem by calling WaitUntilBlocked() before Unblock(), which is the same pardigm used by the other tests. Really, the best fix is to remove that limitation from BlockableProxyResolver... left that as a future TODO. TBR=willchan Review URL: http://codereview.chromium.org/561083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38195 0039d316-1c4b-4281-b951-d872f2087c98
* Disable a test which is causing an error under valgrind TSAN.eroman@chromium.org2010-02-051-1/+1
| | | | | | | | | | It looks like there is a problem with the test setup (BlockableProxyResolver tests a bool outside of a lock). I will fix that next. TBR=willchan Review URL: http://codereview.chromium.org/578011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38194 0039d316-1c4b-4281-b951-d872f2087c98
* Remove size_t from audio IPC code.jam@chromium.org2010-02-0540-404/+401
| | | | | | | The change got to this size because I had to modify the surrounding code (I didn't want to just cast at the last minute). Review URL: http://codereview.chromium.org/577006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38192 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak some things to be compatible with libpng 1.4.craig.schlenter@chromium.org2010-02-051-9/+4
| | | | | | | | | | | libpng 1.2 should still work too. BUG=32805 TEST=compiles on tryservers and locally against libpng 1.4 Review URL: http://codereview.chromium.org/569009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38188 0039d316-1c4b-4281-b951-d872f2087c98
* Support app menu and double-click close on upper left corner of window, part ↵pkasting@chromium.org2010-02-0517-192/+31
| | | | | | | | | | | | one. This makes things work right for windows that have an icon. The behavior of the main window is unchanged because right now it never returns HTSYSMENU anywhere. Part two of this change will be figuring out how to return that at the right place, which will make things Just Work. BUG=6961 TEST=Open an app or popup window. Single click the icon. The app menu should appear. Close it, then click-and-drag into the app menu. The item you release on should execute. Double-click the icon. The window should close. Review URL: http://codereview.chromium.org/577018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38187 0039d316-1c4b-4281-b951-d872f2087c98
* PGL was relying on pthread_key_create not returning zero, which does notsehr@google.com2010-02-051-6/+9
| | | | | | | | | seem to conform to the documented interface. I have added an allocated flag. This is needed to fix NaCl PGL. Review URL: http://codereview.chromium.org/576002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38186 0039d316-1c4b-4281-b951-d872f2087c98
* Implement launch disposition for extension-apps.rafaelw@chromium.org2010-02-0513-19/+150
| | | | | | | | | | | | This change adds an --app-id command switch that signifies that the extension-app with the given id should be launched according to its configuration. It also adds parsing for app.window_type in the manifest and the behavior that when installed and a desktop shortcut is created, the --app-id switch is used rather than the --app switch. BUG=32361 Review URL: http://codereview.chromium.org/573016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38184 0039d316-1c4b-4281-b951-d872f2087c98
* Add a timing measurement to LoadLog that shows how long a proxy resolve ↵eroman@chromium.org2010-02-053-3/+90
| | | | | | | | | request was stalled waiting to be scheduled to a thread. TEST=SingleThreadedProxyResolverTest.UpdatesLoadLogWithThreadWait Review URL: http://codereview.chromium.org/570019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38181 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some tests that are now living upstream, and eliminatedarin@chromium.org2010-02-055-876/+33
| | | | | | | | | | | | some usage of glue_util.h. R=yaar BUG=none TEST=none Review URL: http://codereview.chromium.org/572013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38180 0039d316-1c4b-4281-b951-d872f2087c98
* Implement backend support for forcing cookies to be saved asdarin@chromium.org2010-02-057-12/+91
| | | | | | | | | | | | | | session cookies. Introduces a new CookiePolicy result code OK_FOR_SESSION_ONLY. R=eroman BUG=34571 TEST=none Review URL: http://codereview.chromium.org/577013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38179 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash when extensions try to set cookies. It is valid fordarin@chromium.org2010-02-051-15/+21
| | | | | | | | | | | | | the cookie policy to be NULL, in which case we should default to allowing cookies to be set. R=eroman BUG=34649 TEST=Try to install extension AniWeather from official gallery site Review URL: http://codereview.chromium.org/578007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38178 0039d316-1c4b-4281-b951-d872f2087c98
* Add unittest for r37566 (on PAC failure, should fallback to DIRECT).eroman@chromium.org2010-02-054-51/+26
| | | | | | | | | | | | To make it more testable, I had to move the fallback code in question from HttpNetworkTransaction to ProxyService. Although I think this is a better fit for that code anway, so it should be an overall readability improvement. BUG=32316 TEST=ProxyServiceTest.ProxyFallback_BadConfig, ProxyServiceTest.ProxyResolverFails Review URL: http://codereview.chromium.org/556087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38177 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 04:52:24 +0000