summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Support specified JSON as argument to setSuggestions().tonyg@chromium.org2011-01-145-21/+165
| | | | | | | | | | | Maintain backwards compatibility with the array of strings. TEST=interactive_ui_tests --gtest_filter=InstantTest.* BUG=None Review URL: http://codereview.chromium.org/6310003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71450 0039d316-1c4b-4281-b951-d872f2087c98
* Remove FLAKY for test PrintPreviewUITest.PrintCommandDisabled (rebooting the ↵joi@chromium.org2011-01-141-2/+1
| | | | | | | | | | | builder per thestig's suggestion fixed the flakiness). BUG=69389 TEST=none Review URL: http://codereview.chromium.org/6289002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71449 0039d316-1c4b-4281-b951-d872f2087c98
* Improve validation of external extesnion ids.skerner@chromium.org2011-01-146-22/+57
| | | | | | | | | BUG=68478 TEST=ExtensionServiceTest.ExternalPrefProvider, add an extension key to the windows registry with a typo in the id. Review URL: http://codereview.chromium.org/6053008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71448 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing reliability crash. If the AutomationProvider goessky@chromium.org2011-01-143-5/+2
| | | | | | | | | | | | | | | away while waiting for the right notification then we could crash when attempting to send the message. If this is it I'll update the other observers that have a similar problem. BUG=63647 TEST=none Review URL: http://codereview.chromium.org/6291002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71447 0039d316-1c4b-4281-b951-d872f2087c98
* Move models from app to ui/base/modelsben@chromium.org2011-01-14252-1145/+1242
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71446 0039d316-1c4b-4281-b951-d872f2087c98
* net: measure theoretical delay of waiting for DNS cert information.agl@chromium.org2011-01-143-2/+31
| | | | | | | | | | | | | This patch adds a histogram to measure what the delay would have been, had we waited for information from DNS in order to make a certificate verification decision. BUG=none TEST=none http://codereview.chromium.org/6329001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71445 0039d316-1c4b-4281-b951-d872f2087c98
* net: don't assume that we have an SSLHostInfo.agl@chromium.org2011-01-141-3/+3
| | | | | | | | | | | | sync doesn't run an HttpCache and therefore sync's requests don't pickup an SSLHostInfo. BUG=69522 TEST=don't crash on startup http://codereview.chromium.org/6355003/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71444 0039d316-1c4b-4281-b951-d872f2087c98
* Roll skia 673:690thakis@chromium.org2011-01-141-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6360001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71443 0039d316-1c4b-4281-b951-d872f2087c98
* Set Browser::app_name_ in a reasonable way for extension apps.skerner@chromium.org2011-01-148-24/+116
| | | | | | | | | BUG=67702 TEST=BrowserTest.OpenAppWindowLikeNtp,BrowserTest.AppIdSwitch,manually open a few apps and see that windows taskbar hilights the right window. Review URL: http://codereview.chromium.org/6086004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71442 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command line flag to specify the minimum flash version implementing ↵bauerb@chromium.org2011-01-143-2/+11
| | | | | | | | | | | the NPP_ClearSiteData API. BUG=58235 TEST=none Review URL: http://codereview.chromium.org/6242002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71441 0039d316-1c4b-4281-b951-d872f2087c98
* Fix and re-enable slide-in/slide-out of infobars.erikwright@chromium.org2011-01-142-7/+4
| | | | | | | | | BUG=None TEST=chrome_frame_unittests --gtest_filter=InfobarsInfobarWindowTest.SlidingTest Review URL: http://codereview.chromium.org/6231006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71440 0039d316-1c4b-4281-b951-d872f2087c98
* Additional logging for LoginPromptBrowserTest.IncorrectConfirmationasanka@chromium.org2011-01-141-6/+17
| | | | | | | | | | | | This test runs into intermittent timeouts. Logging is being added to help track down causes. BUG=69266 TEST=none Review URL: http://codereview.chromium.org/6156008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71439 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71437 - WebKit roll 75765:75785hayato@chromium.org2011-01-141-1/+1
| | | | | | | | | | | | | BUG=none TEST=none TBR=jschuh Review URL: http://codereview.chromium.org/6351002 TBR=hayato@chromium.org Review URL: http://codereview.chromium.org/6275002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71438 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 75765:75785hayato@chromium.org2011-01-141-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=jschuh Review URL: http://codereview.chromium.org/6351002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71437 0039d316-1c4b-4281-b951-d872f2087c98
* Clear plugin data together with cookies on shutdown.bauerb@chromium.org2011-01-1410-14/+36
| | | | | | | | | BUG=58235 TEST=none Review URL: http://codereview.chromium.org/6260003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71436 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Port about:sync to DOMUIakalin@chromium.org2011-01-1419-51/+306
| | | | | | | | | | | | | | | | | Write chrome://sync-internals DOMUI page which is like about:sync but automatically updates on sync events. Make about:sync{,-internals} aliases for chrome://sync-internals. More diagnostic capabilities will be added to chrome://sync-internals in future CLs. BUG=69500 TEST=Manual Review URL: http://codereview.chromium.org/6299002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71435 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in reading audio capture device name.satish@chromium.org2011-01-141-0/+3
| | | | | | | | | | | Relevant crash report: http://crash/reportdetail?reportid=c48906f8d604a9d5#crashing_thread BUG=69608 TEST=none Review URL: http://codereview.chromium.org/6333005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71434 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes OpenSSL build following http://codereview.chromium.org/5686002/bulach@chromium.org2011-01-141-1/+8
| | | | | | | | | BUG=none TEST=compiles with use_openssl=1 Review URL: http://codereview.chromium.org/6307001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71433 0039d316-1c4b-4281-b951-d872f2087c98
* Use the new WebViewClient::createView signature.jochen@chromium.org2011-01-144-0/+30
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6304003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71432 0039d316-1c4b-4281-b951-d872f2087c98
* Clang: enable -Wbool-conversions and -Wunused-variables on Linux.hans@chromium.org2011-01-1428-194/+178
| | | | | | | | | | | | | | | -Wbool-conversion warns about EXPECT_EQ(false, blah), so replace that with EXPECT_FALSE(blah). Do the same with EXPECT_EQ(true, blah) for good measure (even though that doesn't generate warnings). Also remove the one instance of an unused variable. BUG=69421 TEST=buildbots all compile and all tests pass Review URL: http://codereview.chromium.org/6300001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71431 0039d316-1c4b-4281-b951-d872f2087c98
* Disables all MultiProcessNotificationTests.hbono@chromium.org2011-01-141-0/+7
| | | | | | | | | | | This change just disables all MultiProcessNotificationTests added by r71418 <http://crrev.com/71418>. It seems this crash happens in the code used by all MultiProcessNotificationTests, i.e. this crash probably happens on all MultiProcessNotificationTests. (I may be wrong.) TBR=dmaclach,thestig,glider BUG=69641 TEST=make the "Chromium Mac (valgrind)" bot green. Review URL: http://codereview.chromium.org/6269005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71428 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up threading model of external extension providersgfeher@chromium.org2011-01-1428-719/+898
| | | | | | | | | | | Move blocking IO of loading the lists of external extensions from the UI thread to the FILE thread. Remove the ExternalPolicyExtensionProvider-specific parts from ExtensionsService. Side-effects: reduce the number of PostTask operations from 9 to 4. Trigger uninstall of external extensions immediately after they are removed from a policy. BUG=65107,63667 TEST=ExtensionManagementTest.ExternalPolicyRefresh for the new functionality, lot of other extension tests are updated Review URL: http://codereview.chromium.org/5742008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71427 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 639.0 to 640.0chrome-release@google.com2011-01-141-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71425 0039d316-1c4b-4281-b951-d872f2087c98
* Disables MultiProcessNotificationTests.hbono@chromium.org2011-01-141-0/+5
| | | | | | | | | | | This change just disables MultiProcessNotificationTests added by r71418 <http://crrev.com/71418> because they always crash on the "Chromium Mac (valgrind)" bot. (We also disable other MultiProcessNotificationTests?) TBR=dmaclach,thestig,timurrrr BUG=69641 TEST=make the "Chromium Mac (valgrind)" bot green. Review URL: http://codereview.chromium.org/6321004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71423 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ChromeFrame net tests which have broken since revision 70089 which added ↵ananta@chromium.org2011-01-142-4/+2
| | | | | | | | | | | | | | | | | | a named testing interface to the automation provider. The testing automation provider was incorrectly assuming that the tab handle would be a parameter in the TabLoaded message. This changed with jam's change to clean up the automation messages used by chrome frame. The other bug was with the AutomationMsg_Hello message which was passing an incorrect protocol version to chrome frame. BUG=none TEST=ChromeFrame net tests should run. TBR=amit Review URL: http://codereview.chromium.org/6324002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71422 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate user strings into the JSON policy template filegfeher@chromium.org2011-01-1432-1814/+1943
| | | | | | | | | | | The new concept is the following: policy_templates.json contains all the data necessary to generate templates: policy names, English captions, descriptions, etc. This gets translated the following GRIT gatherer: policy_json.py. The text of the translated JSON file is then picked up, parsed, and passed to the writers by template_formatter.py. BUG=64898 TEST=PolicyJsonUnittest.* Review URL: http://codereview.chromium.org/6134006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71421 0039d316-1c4b-4281-b951-d872f2087c98
* Disable CrashRecoveryBrowserTest.Reload, flakily times outphajdan.jr@chromium.org2011-01-141-9/+2
| | | | | | | | | | TBR=creis BUG=69637 TEST=browser_tests Review URL: http://codereview.chromium.org/6290003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71420 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of revert 69309 - switch handles to 32 bit in PPAPI.neb@chromium.org2011-01-1445-62/+55
| | | | | | | | | | | | | David Sehr helped me get the NaCl side working so I'll try to land this again. Previous CL at http://codereview.chromium.org/5837001 BUG=69474 TEST=compiles Review URL: http://codereview.chromium.org/6231003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71419 0039d316-1c4b-4281-b951-d872f2087c98
* Add multi-process notification class.dmaclach@chromium.org2011-01-148-0/+1170
| | | | | | | | | | | | | | This is a platform abstraction for a notification that can be sent between processes. Currently only implemented on Mac. Windows and Linux will be done in a future CL. BUG=NONE TEST=BUILD Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70629 Review URL: http://codereview.chromium.org/5970015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71418 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 75733:75765hayato@chromium.org2011-01-141-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=jschuh Review URL: http://codereview.chromium.org/6306002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71417 0039d316-1c4b-4281-b951-d872f2087c98
* WebDragSource: Added a guard for null [contentView_ window]morrita@chromium.org2011-01-141-2/+6
| | | | | | | | | BUG=69095 TEST=manual Review URL: http://codereview.chromium.org/6203005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71416 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71377 - Added loading of nested BHO.vitalybuka@chromium.org2011-01-145-65/+1
| | | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6106004 TBR=vitalybuka@chromium.org Review URL: http://codereview.chromium.org/6313002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71415 0039d316-1c4b-4281-b951-d872f2087c98
* This is to try and get the mac official builder to go green. BUG=none TEST=nonekerz@chromium.org2011-01-141-1/+464
| | | | | | Review URL: http://codereview.chromium.org/6301004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71411 0039d316-1c4b-4281-b951-d872f2087c98
* Show remoting host status on the advanced options page.sergeyu@chromium.org2011-01-1410-5/+159
| | | | | | | | | BUG=67218 TEST=Remoting status is shown on the advanced options page. Review URL: http://codereview.chromium.org/6214003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71410 0039d316-1c4b-4281-b951-d872f2087c98
* We forgot to call Associate in case of local changes for autofill.lipalani@chromium.org2011-01-142-4/+5
| | | | | | | | | | When a local profile is created we create the corresponding sync node and we need to associate the sync node with profile. We forgot to make the call and that is fixed in this cl. BUG=68912, 69173 TEST= sync_integration_tests Review URL: http://codereview.chromium.org/6323001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71409 0039d316-1c4b-4281-b951-d872f2087c98
* Add option for url_fetch_test to wait for a JS expressiontfarina@chromium.org2011-01-141-3/+45
| | | | | | | | | | | | | | | | | | | | | | This option extends url_fetch_test to support waiting for a JavaScript expression to evaluate to true. This is used in the Chrome OS desktopui_GmailLatency test. The browser goes to the test URL and then runs the test to completion. BUG=chromium-os:10869 TEST=test on my workstation on Ubuntu, x86-mario, qemu using a web page which sets a JS value after a period. Original Review URL: http://codereview.chromium.org/6249003/ Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-by: Anton Sargent <asargent@chromium.org> Reviewed-by: William Chan <willchan@chromium.org> Reviewed-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/6288003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71408 0039d316-1c4b-4281-b951-d872f2087c98
* Add two new autofill browser tests.isherman@chromium.org2011-01-141-67/+136
| | | | | | | | | | | | * Test that autofill can be initiated by pressing the down arrow in a fillable field. * Test that autofill works after reloading the page. BUG=69219 TEST=interactive_ui_test --gtest_filter=AutoFillTest.* Review URL: http://codereview.chromium.org/6316001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71406 0039d316-1c4b-4281-b951-d872f2087c98
* webkit_support_common should depend on ↵tkent@chromium.org2011-01-141-0/+7
| | | | | | | | | | setup_third_party.gyp:third_party_headers. BUG=none TEST=none Review URL: http://codereview.chromium.org/6251007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71405 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed initial rendering of toolbar.vitalybuka@chromium.org2011-01-142-34/+31
| | | | | | | | | | | IE will create empty properly rendered toolbar instead of white box. Then chrome frame will be placed above. BUG=none TEST=none Review URL: http://codereview.chromium.org/6245001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71404 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling sync stress tests since they occasionally time outrsimha@chromium.org2011-01-143-8/+6
| | | | | | | | | | | | | | | | The sync stress tests (that use 10 sync clients) occasionally time out on the sync builders. The cause is not fully apparent at this time, and it doesn't make sense to arbitrarily increase the test timeout. Disabling tests until a long term fix is found. TBR=tim@chromium.org BUG=69604 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6265003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71403 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71334 - Fix Pepper URL Loader callbacks.viettrungluu@chromium.org2011-01-145-141/+45
| | | | | | | | | | | | | | | | | [Not applying the "obvious" fix, since it might lead to callbacks being called incorrectly.] Add some tests (for aborting calls). BUG=none TEST=ppapi_tests Review URL: http://codereview.chromium.org/6220006 TBR=viettrungluu@chromium.org,jam@chromium.org,brettw@chromium.org Review URL: http://codereview.chromium.org/6254003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71400 0039d316-1c4b-4281-b951-d872f2087c98
* Followup to http://codereview.chromium.org/5967003/dtu@chromium.org2011-01-143-9/+9
| | | | | | | | | | | UITestBase now creates its ProxyLauncher instance in SetUp() rather than its constructor. LaunchState no longer contains references. BUG=none TEST=none Review URL: http://codereview.chromium.org/6111011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71398 0039d316-1c4b-4281-b951-d872f2087c98
* Move chrome/browser/gtk/ to chrome/browser/ui/gtk/msw@chromium.org2011-01-14383-13021/+14433
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (moved *.cc using 'svn mv' to preserve history) (copied *.h using 'svn cp' to preserve history and stub out originals) Stubbed out original headers in chrome/browser/gtk/ Update header guards & copyright dates in chrome/browser/ui/gtk/ Update .gypi files Remove chrome/chrome_browser.gypi:4228 reference to nonexistant: ['include', '^browser/gtk/pk11_password_dialog.h'], Remove stray header guard in: chrome/browser/ui/gtk/bookmark_bar_instructions_gtk.cc Add #pragma once to the following files: chrome/browser/ui/gtk/instant_confirm_dialog_gtk.h chrome/browser/ui/gtk/infobar_arrow_model.h Ran the following to appease presubmit: 'svn pset svn:eol-style LF \ chrome/browser/ui/gtk/info_bubble_accelerators_gtk.cc \ chrome/browser/ui/gtk/gtk_custom_menu.cc \ chrome/browser/ui/gtk/info_bubble_accelerators_gtk.h \ chrome/browser/ui/gtk/gtk_custom_menu.h \ chrome/browser/ui/gtk/options/managed_prefs_banner_gtk.h \ chrome/browser/ui/gtk/chrome_gtk_frame.h \ chrome/browser/ui/gtk/chrome_gtk_frame.cc \ chrome/browser/ui/gtk/gtk_custom_menu_item.h \ chrome/browser/gtk/info_bubble_accelerators_gtk.h \ chrome/browser/gtk/gtk_custom_menu.h \ chrome/browser/gtk/options/managed_prefs_banner_gtk.h \ chrome/browser/gtk/chrome_gtk_frame.h \ chrome/browser/gtk/gtk_custom_menu_item.h' BUG=69289 TEST=Compile&Trybots Review URL: http://codereview.chromium.org/6251001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71397 0039d316-1c4b-4281-b951-d872f2087c98
* Fix passphrase unit test.johnnyg@chromium.org2011-01-141-1/+2
| | | | | | | | | | BUG=62103 TEST=none TBR=tim Review URL: http://codereview.chromium.org/6341001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71396 0039d316-1c4b-4281-b951-d872f2087c98
* Fix touch compile.sadrul@chromium.org2011-01-141-1/+1
| | | | | | TBR=gspencer@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71394 0039d316-1c4b-4281-b951-d872f2087c98
* Sync: Clean up fake URLFetcher factory prior to browser shut downrsimha@chromium.org2011-01-141-4/+4
| | | | | | | | | | | | | | | | | | | Revision 71253 introduced a fake URLFetcher factory to the sync tests. The clean up step of reverting to the default URLFetcher was added to LiveSyncTest::TearDown(), which is run after browser shut down. The correct place to add the clean up step is the method LiveSyncTest::TearDownInProcessBrowserTestFixture(), which is run prior to browser shut down. This patch merely moves the clean up step to the right spot. TBR=akalin@chromium.org BUG=69184, 56729, 53931 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6251004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71392 0039d316-1c4b-4281-b951-d872f2087c98
* Another attempt to fix the ChromeFrame InstallFlowTest failures. We need to ↵ananta@chromium.org2011-01-141-8/+9
| | | | | | | | | | | | | | refresh the user agent before invoking SetSite on the ChromeFrame BHO to ensure that the protocol sink patch is not disabled. BUG=none TEST=Covered by existing ChromeFrame InstallFlowTest. Review URL: http://codereview.chromium.org/6252004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71391 0039d316-1c4b-4281-b951-d872f2087c98
* EGL contexts reference count the EGL surfaces they share.apatrick@chromium.org2011-01-132-46/+66
| | | | | | | | | | | This fixes the case where a NativeViewEGLContext and a SecondaryEGL context are backed by the same EGL surface and the native one, which previously owned the surface, is destroyed first. TEST=try BUG=none Review URL: http://codereview.chromium.org/6296004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71390 0039d316-1c4b-4281-b951-d872f2087c98
* Rolled ANGLE to r531.apatrick@chromium.org2011-01-131-1/+1
| | | | | | | | | | | This will pull in a fix for the bugs below. TEST=try BUG=69470,69573 Review URL: http://codereview.chromium.org/6248005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71389 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at fixing crash in ProcessPendingTabs. This differs from thesky@chromium.org2011-01-133-18/+36
| | | | | | | | | | | | | | | | | | | | | | | | | | one you reviewed in that I changed a DCHECK in ProcessPendingTabs to an if. See the comments there for details (this was triggering a failure on chromeos). Description from last attempt: With the current code, during closing a window with unload handlers if a tab is disconnected then we delay cleanup by way of PostTask with the tab being disconnected. During the time between when the disconnect happens and the task is run the unloader handler sets still maintain a reference to the tab. If ProcessPendingTabs is invoked during this window and the tab is deleted, then we can crash. I'm fixing it by making disconnect remove from the sets immediately, but delay the call to ProcessPendingTabs. I'm also doing a similar thing in TabDetachedAt. BUG=15620 TEST=none Review URL: http://codereview.chromium.org/6321001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71388 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-16 08:23:32 +0000