summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Accumulated SCons changes for Windows chrome build and othersgk@google.com2008-10-3016-96/+109
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | recent additions (doesn't fix everything, but gets significant pieces back on track). * New/additional library dependencies in various test executables (too many to be worth listing). * Portability: put library base names in $LIBS instead of explicitly listing .lib files. * Have interactive_ui re-use various object files from test/ui instead of (re-)listing the .cc files. * Add new files: chrome\browser\bookmarks\bookmark_drag_data.cc chrome\browser\bookmarks\bookmark_drag_utils.cc chrome\browser\bookmarks\bookmark_table_model.cc chrome\browser\browser_trial.cc chrome\browser\download\download_request_manager_unittest.cc chrome\browser\greasmonkey_master.cc chrome\browser\spellcheck_unittest.cc chrome\browser\views\find_bar_view.cc chrome\browser\views\find_bar_win.cc chrome\renderer\greasemonkey_slave.cc * Remove old files: chrome\browser\find_in_page_controller.cc chrome\browser\find_in_page_view.cc chrome\renderer\spellcheck_unittest.cc * Remove relative reference to ../../app/google_update_settings$OBJSUFFIX. * Get rid of by-hand /IMPLIB and /MAP flags. * Prefix / suffix portability in the jscre library. * Rename $LIBXML_DIR/scons => $LIBXML_DIR/DerivedSources. * Add $CHROME_DIR/app/resources to CPPPATH. * Add icu38 directories to CPPPATH for building chrome/views files. Review URL: http://codereview.chromium.org/8725 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4205 0039d316-1c4b-4281-b951-d872f2087c98
* Changes session restore to account for apps and popups. If you havesky@google.com2008-10-3011-81/+182
| | | | | | | | | | | | | | | | | | | | | session restore enabled any time you transition from no tabbed browsers to a tabbed browser (in the same profile) we restore your last session, where the last session was any previously open tabbed browsers. For example, if you start Chrome from an installed app shortcut then create a new tabbed browser (by any means) we'll restore your last session. This gives the illustion that apps are running in their own process. I would love to have test coverage of this, but I'm loathe to write anymore flakey UI tests. Need to revisit post 1.0. BUG=1883 TEST=thoroughly test session restore, especially with application shortcuts and popups. Review URL: http://codereview.chromium.org/8856 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4202 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure titles and bodies of web pages that come into the history system verybrettw@google.com2008-10-305-32/+139
| | | | | | | | | late are indexed. Very slow pages (>20 seconds) would previously not get indexed. BUG=3835 Review URL: http://codereview.chromium.org/8899 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4201 0039d316-1c4b-4281-b951-d872f2087c98
* Remove downloads from the completed dangerous downloads listpaulg@google.com2008-10-301-0/+6
| | | | | | | | | | | | | | | | when they are deleted via "Clear browsing data". There was definite crash a shutdown, and sporadic crashes when idling (but after a dangerous download was complete but not yet confirmed) after a user cleared their browsing data, since the dangerous list kept around a pointer to a download that had been deleted elsewhere. BUG=3498 (http://code.google.com/p/chromium/issues/detail?id=3498) Review URL: http://codereview.chromium.org/8728 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4200 0039d316-1c4b-4281-b951-d872f2087c98
* Moving to scons 1.1.0bradnelson@google.com2008-10-30172-443/+1138
| | | | | | Review URL: http://codereview.chromium.org/8900 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4197 0039d316-1c4b-4281-b951-d872f2087c98
* Add compatible version support since it was only halfway in place, and try ↵pkasting@chromium.org2008-10-3010-55/+97
| | | | | | | | | | | | | and make our database versioning code and logging more similar across various consumers. The compatible version support isn't really used yet. It was going to be used for my cookie change until we decided that the old code was too busted to be forward-compatible. It seems worthwhile to put this in but maybe I am wrong. The logging similarity stuff is fairly useful. In a couple consumers in the old code, we DLOGed instead of LOGing, which meant that most people would get nothing in the log at all. I think it's a little weird that in a lot of these consumers, logging is all we do; for example, if you use a too-new cookie DB, you get output in the log, but no actual dialog box while the browser is running -- your cookies just silently don't get saved to disk. Seems bad, but I'm not prepared to try and do major surgery to address that (and add translated strings, etc.). At least now we'll actually get log messages in release builds instead of nothing at all. Because my last-access change touches this code, I'm considering asking that this change be merged back to the branch. Review URL: http://codereview.chromium.org/8712 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4195 0039d316-1c4b-4281-b951-d872f2087c98
* The strings required for the upcoming autofill UI.jcampan@chromium.org2008-10-301-0/+11
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/8714 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4194 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes resizing of single split view for RTL case.sky@google.com2008-10-301-2/+1
| | | | | | | | | BUG=674 TEST=none Review URL: http://codereview.chromium.org/8210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4193 0039d316-1c4b-4281-b951-d872f2087c98
* Add more UMA collection to the New Tab Pageglen@chromium.org2008-10-293-31/+137
| | | | | | | | BUG=1450986 Review URL: http://codereview.chromium.org/8686 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4192 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at the bookmark manager. There are still a fair number ofsky@google.com2008-10-2937-854/+2934
| | | | | | | | | | | | | | | | | | | | | | | | | rough edges, but I'm at a good point where I want to land what I have. Here's what is left: . Flicker on show, likely the result of restoring window placement. . tree flickers when dragging splitter. . table/tree need to autoscroll when drop cursor held at bottom of view. . prompts for deleting. . When you move an item the table snaps to the top, this is because I'm sending out model changed. need a better notification. . Operations in menu to add need to change selection. . Remember split location. I would have preferred to split this up into a couple of reviews, but everything is intertwined now. Sorry. BUG=674 TEST=don't test the bookmark manager yet, but make sure bookmark bar still works. Review URL: http://codereview.chromium.org/8197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4191 0039d316-1c4b-4281-b951-d872f2087c98
* Fix more problems with search providers.pkasting@chromium.org2008-10-291-5/+5
| | | | | | | | | | | onet.pl apparently moved their search service out of beta, and changed the URLs accordingly, since the time I put the original list together. In the other two cases, changing encodings to UTF-8 seemed to fix issues with words in the local languages, and who am I to argue with the results. BUG=3804,3809,3816 Review URL: http://codereview.chromium.org/8719 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4190 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing use of built_component from SConstructs.bradnelson@chromium.org2008-10-291-1/+1
| | | | | | Review URL: http://codereview.chromium.org/8724 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4189 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing some windows scons build breaks.bradnelson@chromium.org2008-10-294-12/+4
| | | | | | Review URL: http://codereview.chromium.org/8723 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4186 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the dashboard_compatibility_mode member from the WebPreferenceswtc@google.com2008-10-293-4/+0
| | | | | | | | | | structure. The member is no longer used. R=tony,avi BUG=3834 Review URL: http://codereview.chromium.org/8705 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4183 0039d316-1c4b-4281-b951-d872f2087c98
* Split test_shell.cc into test_shell.cc and test_shell_win.cc.tc@google.com2008-10-296-729/+760
| | | | | | | | | | | | This currently moves too much code out of test_shell.cc, but I wanted to be able to just move code now and I'll refactor stuff back into test_shell.cc I also tried to make test_shell_win.cc conform to google style. Review URL: http://codereview.chromium.org/8209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4182 0039d316-1c4b-4281-b951-d872f2087c98
* Fix throb animation - a change to Animation::Start meant that Run() in a ↵glen@chromium.org2008-10-294-6/+14
| | | | | | | | | | derived class was never being called. Throb animation depended on this. BUG=3516 Review URL: http://codereview.chromium.org/8896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4181 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing handling of absolute paths in site_init.py to handle windows correctly.bradnelson@chromium.org2008-10-291-1/+2
| | | | | | Review URL: http://codereview.chromium.org/8897 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4180 0039d316-1c4b-4281-b951-d872f2087c98
* Only show the language restart warning once, and only if needed.glen@chromium.org2008-10-292-3/+10
| | | | | | | | BUG=2835 Review URL: http://codereview.chromium.org/8195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4179 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for Save Page downloads not notifying their observers on completion.glen@chromium.org2008-10-291-0/+1
| | | | | | | | BUG=3417 Review URL: http://codereview.chromium.org/8804 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4177 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustage - remove reference to exported_sybmols file.jeremy@chromium.org2008-10-291-3/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4175 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary code instrumentation to gather info on a crash.ericroman@google.com2008-10-292-3/+32
| | | | | | | | | | | | The idea is to see where in DidReadResponseHeaders() things blow up (if at all). This hack adds a value at ebp+8 (parent's frame) which indicates where we were. TBR=wtc Review URL: http://codereview.chromium.org/8890 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4174 0039d316-1c4b-4281-b951-d872f2087c98
* The SharedMemory is owned by the GreasemonkeyMaster, not the unit test. My ↵evanm@google.com2008-10-291-5/+5
| | | | | | | | | previous attempt at fixing the purify problem was overzealous; I just needed to fix the uninitialized boolean that my previous "fix" did. This change halfway-reverts to before that state. Review URL: http://codereview.chromium.org/8893 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4172 0039d316-1c4b-4281-b951-d872f2087c98
* Add testing to main DEPSjeremy@chromium.org2008-10-291-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4170 0039d316-1c4b-4281-b951-d872f2087c98
* 1) Add a new MULTIPROCESS_TEST_MAIN macro to store child process namesjeremy@chromium.org2008-10-2913-59/+134
| | | | | | | | | | | | | | in a lookup table. Previously we were using different mechanisms on each platform to look up child process names at runtime. This broke on OS X where we strip the symbol table on release executables. 2) Enable process_util_unittest on OS X. Review URL: http://codereview.chromium.org/8864 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4165 0039d316-1c4b-4281-b951-d872f2087c98
* Free memory in unit test, so purify doesn't complain.evanm@google.com2008-10-292-5/+6
| | | | | | | Review URL: http://codereview.chromium.org/8405 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4163 0039d316-1c4b-4281-b951-d872f2087c98
* remove svg tests from the "skip" list because they no longer timeoutpinkerton@google.com2008-10-291-5/+0
| | | | | | Review URL: http://codereview.chromium.org/8713 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4162 0039d316-1c4b-4281-b951-d872f2087c98
* Added strings to support Spellchecker operations in the context menu.sidchat@google.com2008-10-291-0/+12
| | | | | | Review URL: http://codereview.chromium.org/8710 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4160 0039d316-1c4b-4281-b951-d872f2087c98
* adjust for our "toolbar" when resizing the window and content area, as it is ↵pinkerton@google.com2008-10-291-2/+5
| | | | | | | | part of the content (it's not a real toolbar) Review URL: http://codereview.chromium.org/8711 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4159 0039d316-1c4b-4281-b951-d872f2087c98
* Forgot this file in CL 4153.bradnelson@google.com2008-10-291-1/+8
| | | | | | | It does weird things on buildbot without it. Review URL: http://codereview.chromium.org/8886 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4157 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a couple of tab related bugs:ben@chromium.org2008-10-293-0/+13
| | | | | | | | | | | | - moving the window while a tab is animating to its final resting position disembodies the tab - it's possible to make a tab disappear while clicking on another tab while a tab is animating to its final resting position http://crbug.com/2388 http://crbug.com/1142 Review URL: http://codereview.chromium.org/8689 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4155 0039d316-1c4b-4281-b951-d872f2087c98
* Add command line option to suppress Chrome launch after successful installkuchhal@chromium.org2008-10-297-1066/+1090
| | | | | | | | BUG=1443250 Review URL: http://codereview.chromium.org/8644 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4154 0039d316-1c4b-4281-b951-d872f2087c98
* Adding in BuildComponents to allow things like Defer and publishing.bradnelson@google.com2008-10-292-146/+174
| | | | | | Review URL: http://codereview.chromium.org/8666 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4153 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various Gears build breaks caused by latest Hammer changes.mpcomplete@google.com2008-10-295-35/+47
| | | | | | Review URL: http://codereview.chromium.org/7999 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4151 0039d316-1c4b-4281-b951-d872f2087c98
* remove svn:executablekuchhal@chromium.org2008-10-291-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4147 0039d316-1c4b-4281-b951-d872f2087c98
* Trivial patch: add whitespace to some SQL statements to turn "INSERT INTO ↵pkasting@chromium.org2008-10-295-15/+13
| | | | | | | | | foo(bar,baz)VALUES(?,?)" into "INSERT INTO foo (bar, baz) VALUES (?,?)" (which is the way we have it in most of our code). This was annoying me while I tried to track down cases where we omitted the appropriate fieldnames from our SQL statements. Review URL: http://codereview.chromium.org/8855 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4145 0039d316-1c4b-4281-b951-d872f2087c98
* remove svn:executable propertykuchhal@chromium.org2008-10-291-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4143 0039d316-1c4b-4281-b951-d872f2087c98
* remove svn:executable propertykuchhal@chromium.org2008-10-293-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4142 0039d316-1c4b-4281-b951-d872f2087c98
* System includes need to use angle brackets for check_depsagl@chromium.org2008-10-291-1/+1
| | | | | | | | | TBR=tc Review URL: http://codereview.chromium.org/8706 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4141 0039d316-1c4b-4281-b951-d872f2087c98
* Add option to disable/enable Spell Check. In addition, remove additional ↵sidchat@google.com2008-10-2913-151/+132
| | | | | | | | | | code in resource message filter, which was initilaizing spellchecker in the filter if it was NULL. This part of the code is not required since the resource message filter should not initialize spellchecker; it is up to the profile to give the spellchecker to the resource message filter. Issue = 120 Review URL: http://codereview.chromium.org/7935 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4140 0039d316-1c4b-4281-b951-d872f2087c98
* Move the windows-only dependencies to deps_os['win'].maruel@chromium.org2008-10-291-9/+16
| | | | | | Review URL: http://codereview.chromium.org/8874 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4138 0039d316-1c4b-4281-b951-d872f2087c98
* Start writing the GTK code for test_shell.agl@chromium.org2008-10-298-35/+233
| | | | | | | Review URL: http://codereview.chromium.org/8000 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4136 0039d316-1c4b-4281-b951-d872f2087c98
* An experimental change to help us diagnose a crashwtc@google.com2008-10-291-0/+1
| | | | | | | | | | | | | | in DoReadHeadersComplete. Add an unused state, STATE_UNUSED, at the old value of STATE_READ_HEADERS_COMPLETE (15 = 0xF) to see if that value has any significance in the crash. TBR=eroman BUG=3772 Review URL: http://codereview.chromium.org/8701 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4133 0039d316-1c4b-4281-b951-d872f2087c98
* Add fieldnames to SQL statements for better forward-compatibility. Had we ↵pkasting@chromium.org2008-10-291-2/+8
| | | | | | | | | had this code in place already, I wouldn't have needed to rev the compatible version number in my upcoming database change >:( I checked the rest of our sourcebase's INSERT and SELECT statements, but these were the only ones that needed to have fieldnames added (in a few cases SELECT * was appropriate). Review URL: http://codereview.chromium.org/8684 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4130 0039d316-1c4b-4281-b951-d872f2087c98
* Add --port and --root options to the command-line interface to allow runningpamg@google.com2008-10-291-7/+22
| | | | | | | | | | | this server for more general purposes than only layout tests. (In particular, I've found it helpful when testing perf plots.) BUG=none TEST=none Review URL: http://codereview.chromium.org/8668 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4129 0039d316-1c4b-4281-b951-d872f2087c98
* Removed magic number for owner rights, avoid to call close(-1).brettw@google.com2008-10-291-2/+2
| | | | | | Patch committed for mendola@gmail.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4128 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a string that we'll need when importing bookmarks.sky@google.com2008-10-292-0/+6
| | | | | | | | | BUG=674 TEST=none Review URL: http://codereview.chromium.org/8862 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4124 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where we would allow the user to spell check words intc@google.com2008-10-291-1/+4
| | | | | | | a readonly textarea. This triggered lots of asserts. Review URL: http://codereview.chromium.org/8860 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4119 0039d316-1c4b-4281-b951-d872f2087c98
* When right clicking in a text area that is scrolled, the wrongtc@google.com2008-10-291-8/+19
| | | | | | | | | | | | | | | | | word is selected. This is because we use the wrong node when getting the selection. We want to use the shadow inner node, but the hit test result provided to the ContextMenu is not the shadow node. To work around this, we recompute the hit test result. BUG=613 TEST=Go to a page with a text area, add text until a scroll bar appears, scroll the text area and right click on a word. The word under the cursor should be highlighted. Review URL: http://codereview.chromium.org/8853 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4118 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a minor memory leak.paulg@google.com2008-10-294-8/+6
| | | | | | | | | BUG=1340229 Review URL: http://codereview.chromium.org/8690 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4117 0039d316-1c4b-4281-b951-d872f2087c98
* The "extra view" used by the DialogClientView must not be retrieved before ↵ben@chromium.org2008-10-292-8/+17
| | | | | | | | | the contents view has been attached to the view hierarchy. http://crbug.com/2751 Review URL: http://codereview.chromium.org/8681 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4116 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-06 13:09:24 +0000