summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Adjust histograms to only collect non-cache stats for SDCH.jar@chromium.org2009-05-157-47/+67
| | | | | | | | | | | | | | | | I also changed the name of all the SDCH histograms so that there would be no confusion about the data. I also added one new problem code, but that recordation doesn't have any semantic impact. I added it to help make it easier to diagnose dictionary specification errors in SDCH. bug=12012 R=wtc Review URL: http://codereview.chromium.org/115377 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16138 0039d316-1c4b-4281-b951-d872f2087c98
* Update French spellcheck dictionary to 1.4.jungshik@google.com2009-05-151-1/+1
| | | | | | | | | | | | | | This is to fix bug 8551. http://crbug.com/8551 TEST=Launch Chrome with '--lang=fr' (or switch your spellcheck language to French). In an textarea, type a paragraph of random text. Quit chrome or change the spellcheck language to English. Chrome should not crash. TBR=sidchat Review URL: http://codereview.chromium.org/115390 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16137 0039d316-1c4b-4281-b951-d872f2087c98
* Test fails on linux, not sure why. Disable while I investigate.tc@google.com2009-05-151-0/+3
| | | | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/112027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16136 0039d316-1c4b-4281-b951-d872f2087c98
* Switch from using an iframe to using a JSON URL and dynamically generating ↵erikkay@google.com2009-05-151-26/+119
| | | | | | | | the content. Review URL: http://codereview.chromium.org/109031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16135 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue where the star in the history page could be hidden by longarv@chromium.org2009-05-151-3/+50
| | | | | | | | | | | | | | | entry titles or by making the window narrow enough to truncate the text. BUG=9712 TEST=Bookmark a page and go to the history page. Resize the window so that it is narrow enough to truncate the entry title of the page you just bookmarked. You still be able to see the star icon. Review URL: http://codereview.chromium.org/113434 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16132 0039d316-1c4b-4281-b951-d872f2087c98
* Change the way button width is calculated for the button. Currently, for the ↵jshin@chromium.org2009-05-151-2/+4
| | | | | | | | | | | | | | | | | | | | default button (for which GetDialogButtonLabel returns an empty string), the width is always set to kDialogMinButtonWidth. It's sufficiently large for 'Ok', 'Close' and 'Cancel' in most languages, but not large enough for some languages. For those languages, this CL sets the button width to max(preferred_width, kDialogMinButtoWidth), the former of which is calculated using the translated strings for Ok/Close/Cancel. This needs to be merged to 2.0 branch (the location of views has moved from under chrome\ to the top-level source directory in the trunk) http://crbug.com/11710 TEST: Start Chrome with '--lang=ml' cmd line flag. Open up the option dialog and see 'Close' button at the bottom is large enough for the label ('Close' in Malayalam) and some space around it. Review URL: http://codereview.chromium.org/113250 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16131 0039d316-1c4b-4281-b951-d872f2087c98
* Remove mac failure.tc@google.com2009-05-151-5/+1
| | | | | | | | | | | | The linux crash fix to test shell (r16119) seems to have fixed this crash on the mac. TBR=evan Review URL: http://codereview.chromium.org/113429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16130 0039d316-1c4b-4281-b951-d872f2087c98
* fix my retardation and the buildbeng@google.com2009-05-152-62/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16129 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline 2 tests that are new from the merge.tc@google.com2009-05-145-3/+2
| | | | | | | | | | | | | | | | | | | These are testing the opacity values of iframes. E.g., the first test loads a lime green background (#00ff00). Over the background, it loads a black iframe with 50% opacity. With skia, we end up with a green color of (#008000). The upstream expected result has a different green (#0e6c00) with an embedded color profile. When I load the png in the gime and appy the color profile, I get (#007c00). I think the difference is just the color profile and that skia is doing the right thing. BUG=11933 Review URL: http://codereview.chromium.org/115386 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16128 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a trailing slash in BrowserView. gcc doesn't like these.sky@chromium.org2009-05-141-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/114030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16127 0039d316-1c4b-4281-b951-d872f2087c98
* Fix reversed arguments to EXPECT_EQ() in mime_util_unittest.thestig@chromium.org2009-05-141-4/+4
| | | | | | Review URL: http://codereview.chromium.org/113426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16126 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 16124.beng@google.com2009-05-1413-53/+151
| | | | | | Review URL: http://codereview.chromium.org/115387 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16125 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 16122.beng@google.com2009-05-1411-27/+53
| | | | | | Review URL: http://codereview.chromium.org/113427 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16124 0039d316-1c4b-4281-b951-d872f2087c98
* Change the host() method of ProxyServer to strip thewtc@chromium.org2009-05-144-6/+51
| | | | | | | | | | | | | | | | | | | | | square brackets around an IPv6 literal address. Rename the method HostNoBrackets() to be consistent with GURL's new HostNoBrackets() method. When resolving an address, use the new HostNoBrackets() method instead of host(). Part of this changelist was contributed by Paul Marks of Google. Original review: http://codereview.chromium.org/115342 R=eroman http://crbug.com/12005 TEST=covered by new test cases in unit test Review URL: http://codereview.chromium.org/114029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16123 0039d316-1c4b-4281-b951-d872f2087c98
* Move bitmap conversion function from chrome/common/gtk_utils.h into ↵beng@google.com2009-05-1411-53/+27
| | | | | | | | | | app/gfx/gtk_utils.h http://crbug.com/11387 Review URL: http://codereview.chromium.org/115382 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16122 0039d316-1c4b-4281-b951-d872f2087c98
* Baseline some layout tests for linux. These differ in the pixels along text, ↵eroman@chromium.org2009-05-145-3/+2
| | | | | | | | but the rest is unchanged. Review URL: http://codereview.chromium.org/115384 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16121 0039d316-1c4b-4281-b951-d872f2087c98
* Fix document-location-click-timeout.html crash on linux.tc@google.com2009-05-142-2/+2
| | | | | | | | | | | | A rare combination of events results in there being no last committed entry. Adding a NULL check prevents the crash. BUG=11935 Review URL: http://codereview.chromium.org/113419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16119 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Clear Data dialog wider on Filipino locale.finnur@chromium.org2009-05-141-2/+2
| | | | | | | | | | BUG=http://crbug.com/11915 TEST=Verify that no truncation occurs when opening the Clear Browsing Data dialog in the Filipino locale (fil) on XP and Vista. Review URL: http://codereview.chromium.org/113420 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16118 0039d316-1c4b-4281-b951-d872f2087c98
* Make convert_dict work again by adding AtExitManager in stack in main().jshin@chromium.org2009-05-141-0/+2
| | | | | | | | TEST=Build convert_dict and run it with 'en_US' as a cmd line argument where en_US.dic and en_US.aff are present in the same directory. It should create en_US.bdic. Review URL: http://codereview.chromium.org/113414 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16116 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash in Hunspell : jshin@chromium.org2009-05-148-70242/+89454
| | | | | | | | | | | | | | | 1) initializes cond.utf8 part of affentry and checking whether its elements are populated before calling |free|. 2) Downgrade the French dictionary from 3.0.1 (Jan 2009) to 2.3.2 (Apri, 2008). 3.0.1 has aff entries with more than 8 conditions. Our version of Hunspell only supports up to 8 conditions per Affentry. Newer versions support more than8 conditions. When we update our copy of Hunspell, we'll update our dictionary again. http://crbug.com/8551 TEST=1. Launch Chrome with '--lang=fr' (or set your spellcheck language to French in a textarea) and type random text into a textarea and quit Chrome. Chrome should quit without crashing. 2. In text area, type random text with spell checker set to French and switch to English and switch back to French. Chrome should not Crash. Review URL: http://codereview.chromium.org/115228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16115 0039d316-1c4b-4281-b951-d872f2087c98
* Setup.exe now tries to uncompress patch using courgette.sra@chromium.org2009-05-142-2/+16
| | | | | | Review URL: http://codereview.chromium.org/113412 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16114 0039d316-1c4b-4281-b951-d872f2087c98
* Use the Mac omnibox field's font as the basis for the fonts used in the ↵shess@chromium.org2009-05-144-51/+77
| | | | | | | | | | | | | field and popup. NSAttributedString has fixed default font, unless overridden, this basically makes the font used consistent with the field size. Theming will most likely change this again, but we can be prettier in the meanwhile. Review URL: http://codereview.chromium.org/115334 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16112 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fix issue 11907 -- RTL: Focus is not on the text after checking ↵xji@chromium.org2009-05-141-2/+11
| | | | | | | | | | | "Delete all profile data" Since the text_bounds computed in Label::CalculateDrawStringParams() are different for mutl-line text and single line text. Draw focus rectangle need to be handled differently (mirroring or no mirroring) as well. BUG=http://crbug.com/11907 Review URL: http://codereview.chromium.org/115370 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16111 0039d316-1c4b-4281-b951-d872f2087c98
* Remove pixel results for a bunch of http navigation tests.tc@google.com2009-05-1497-3005/+0
| | | | | | | | | | In r43677, these tests were all changed to dumpAsText tests so we don't need separate baselines. http://trac.webkit.org/changeset/43677 Review URL: http://codereview.chromium.org/115380 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16110 0039d316-1c4b-4281-b951-d872f2087c98
* Unfork and remove generate-bindings.pl from our tree.dglazkov@chromium.org2009-05-143-71/+2
| | | | | | | | | | R=levin BUG=3319 TEST=0 Review URL: http://codereview.chromium.org/115375 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16109 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage... some more traces of always-on-top I forgot to remove.beng@google.com2009-05-142-6/+0
| | | | | | | TBR=jcampan Review URL: http://codereview.chromium.org/114028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16108 0039d316-1c4b-4281-b951-d872f2087c98
* Move Always On Top setting out of Window/WindowDelegate and into task ↵beng@google.com2009-05-1415-180/+134
| | | | | | | | | manager. It's the only one who uses this setting and the UI for exposing it is very specific to the task manager. Window retains a setter to set always on top state, but persistence and the system menu is Task Manager's responsbility. This allows us to sever the second-to-last chrome dependency from views. http://crbug.com/11674 Review URL: http://codereview.chromium.org/115378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16107 0039d316-1c4b-4281-b951-d872f2087c98
* Add some baselines for mac, and remove some passing tests.ericroman@google.com2009-05-147-6/+81
| | | | | | Review URL: http://codereview.chromium.org/113411 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16103 0039d316-1c4b-4281-b951-d872f2087c98
* Make the options reset confirm dialog a little wider in ML.mal@chromium.org2009-05-141-1/+1
| | | | | | | BUG= http://crbug.com/11267 Review URL: http://codereview.chromium.org/115343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16102 0039d316-1c4b-4281-b951-d872f2087c98
* Add error handling to PageAction extension API.finnur@chromium.org2009-05-142-13/+29
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/113415 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16101 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors menus so that I can create a MenuGtk implementation, and moves it intosky@chromium.org2009-05-1427-779/+910
| | | | | | | | | | | | the namespace views. BUG=none TEST=make sure I haven't broken any menus. This impacts all menus in Chrome, except bookmark ones. Review URL: http://codereview.chromium.org/113410 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16100 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the empty 'merge' directory from webkit/tools.tc@google.com2009-05-140-0/+0
| | | | | | | | | | I originally removed the files from git, which doesn't manage directories. Using an svn client this time to remove the dir. TBR=evan git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16099 0039d316-1c4b-4281-b951-d872f2087c98
* Extend the chrome.tabs API to allow relative paths.finnur@chromium.org2009-05-141-5/+26
| | | | | | | | BUG=None TEST=In an extension, use chrome.tabs.create(...) to create a tab using a relative path ("foo/bar.html"). It should resolve that path by prepending the extension path ("chrome-extension://0000000000000000000000000000000000000042/foo/bar.html). Review URL: http://codereview.chromium.org/113374 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16098 0039d316-1c4b-4281-b951-d872f2087c98
* Rebaseline on mac too.tc@google.com2009-05-141-1/+1
| | | | | | | | | | | | I forgot that this is a V8 test and needs to be rebaselined on mac too. The windows/linux fix was in r16091. TBR=dglazkov Review URL: http://codereview.chromium.org/113413 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16097 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the fast BMPImageDecoderTest tests under Purify.thestig@chromium.org2009-05-141-2/+3
| | | | | | | BUG=9177 Review URL: http://codereview.chromium.org/115373 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16096 0039d316-1c4b-4281-b951-d872f2087c98
* Add #include <string> to fix building with gcc 4.3.thestig@chromium.org2009-05-141-0/+1
| | | | | | Review URL: http://codereview.chromium.org/115372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16095 0039d316-1c4b-4281-b951-d872f2087c98
* Add basic checkbox support for GTK.brettw@chromium.org2009-05-144-2/+36
| | | | | | | | This also makes the Checkbox check for the native wrapper just like NativeButton does, to prevent crashes if it hasn't been initialized yet. Review URL: http://codereview.chromium.org/113408 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16094 0039d316-1c4b-4281-b951-d872f2087c98
* Mark tests as failing while I investigate.tc@google.com2009-05-141-0/+17
| | | | | | | | | | | Due to merge. TBR=ojan Review URL: http://codereview.chromium.org/116003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16093 0039d316-1c4b-4281-b951-d872f2087c98
* A few quick fixes to SimpleDataSource.scherkus@chromium.org2009-05-142-12/+13
| | | | | | | | | Total bytes and buffered bytes weren't being set and a DCHECK was firing when loading files when it really shouldn't have. Review URL: http://codereview.chromium.org/113385 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16092 0039d316-1c4b-4281-b951-d872f2087c98
* Merge webkit from r43671 to r43715.tc@google.com2009-05-143-3/+3
| | | | | | | | | | | One test started to fail, but it's just a line number change due to r43707. This also pulls in a layout test fix for chromium mac (content-opacity-2 timeout). Review URL: http://codereview.chromium.org/115368 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16091 0039d316-1c4b-4281-b951-d872f2087c98
* Add star icon for bookmarked results in the omnibox2 popup view.beng@google.com2009-05-142-6/+18
| | | | | | | | No, I'm not adding any more ternaries. Review URL: http://codereview.chromium.org/115336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16090 0039d316-1c4b-4281-b951-d872f2087c98
* valgrind: re-enable some tests.evan@chromium.org2009-05-141-5/+0
| | | | | | | | | | Dan and I were unable to reproduce the errors. Perhaps they've been fixed. BUG=9046,9170 Review URL: http://codereview.chromium.org/113357 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16089 0039d316-1c4b-4281-b951-d872f2087c98
* Remove even more ATL dependencies.maruel@chromium.org2009-05-1463-192/+241
| | | | | | Review URL: http://codereview.chromium.org/115309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16088 0039d316-1c4b-4281-b951-d872f2087c98
* Change VideoRendererImpl to use VideoThread as opposed to VideoRendererBase.scherkus@chromium.org2009-05-142-17/+34
| | | | | | | | Now with less jitter! Review URL: http://codereview.chromium.org/115358 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16087 0039d316-1c4b-4281-b951-d872f2087c98
* Split BMPImageDecoderTest.* tests into fast and slow tests. Enable fast ↵thestig@chromium.org2009-05-144-12/+72
| | | | | | | | | tests under Valgrind. BUG=9177 Review URL: http://codereview.chromium.org/113384 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16086 0039d316-1c4b-4281-b951-d872f2087c98
* Example script to run all tests under valgrinddkegel@google.com2009-05-141-0/+75
| | | | | | Review URL: http://codereview.chromium.org/113365 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16085 0039d316-1c4b-4281-b951-d872f2087c98
* Add another missing dep for getting resource headers generated.thomasvl@chromium.org2009-05-141-0/+1
| | | | | | Review URL: http://codereview.chromium.org/115369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16084 0039d316-1c4b-4281-b951-d872f2087c98
* Add a separate cookie store that's used for extensions.mpcomplete@google.com2009-05-1414-50/+175
| | | | | | | Modify CookieMonster to support overriding the "cookieable schemes". Review URL: http://codereview.chromium.org/115204 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16083 0039d316-1c4b-4281-b951-d872f2087c98
* linux: we actually already had a bug on file for this NOTIMPLEMENTED.evan@chromium.org2009-05-141-1/+4
| | | | | | Review URL: http://codereview.chromium.org/115367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16082 0039d316-1c4b-4281-b951-d872f2087c98
* linux: more NOTIMPLEMENTED bugs.evan@chromium.org2009-05-141-1/+1
| | | | | | Review URL: http://codereview.chromium.org/115366 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16080 0039d316-1c4b-4281-b951-d872f2087c98