| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FencedAllocator to manage the transfer buffer
with less waiting.
Also updates glBufferData to use glBufferSubData
to send data as well as glTexImage2D to use
glTexSubImage2D. These make it possible to
pass any size image or buffer data.
Review URL: http://codereview.chromium.org/436020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/418042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32948 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/437039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
description fields.
BUG=28664
TEST=none
TBR=nickbaum
Review URL: http://codereview.chromium.org/436027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
FlipIOBuffer::release() was broken. It called release() on scoped_refptrs which does not decrease refcount, hence it leaked IOBuffers and FlipStreams.
Redo the memory management for FlipSession. Stop using raw pointers in FlipSessionPool to hold onto FlipSession. FlipSessionPool uses scoped_refptr now to track Fli
pSessions. Instead of having FlipSession call Release() on itself, it now calls FlipSessionPool to remove itself from the pool when the tcp connection is closed.
In FlipStreamTest, manually call FlipSessionPool::Remove() since there is no tcp connection event to trigger FlipSession to remove itself.
BUG=http://crbug.com/28493
Review URL: http://codereview.chromium.org/438014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ananta
BUG=28662
Review URL: http://codereview.chromium.org/435023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
chromeos.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/431029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32942 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28646
TEST=none
Review URL: http://codereview.chromium.org/437029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32940 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Ok" buttons are always on the right on OS X.
Nib change: I only switched the two buttons.
BUG=28638
TEST=Download a dmg, confirm "Save" botton is on the right.
Review URL: http://codereview.chromium.org/438019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was made non-flaky upstream in http://trac.webkit.org/changeset/51150.
See http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/layout_tests/flakiness_dashboard.html#tests=zero-duration-with-non-zero-delay-end.html for visual of flakiness.
BUG=10418
TEST=none
Review URL: http://codereview.chromium.org/424007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32938 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
appcache entry URL.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/431022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
don't get a drop shadow and centered on screen.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/431021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/24177
TEST=no visible change
Review URL: http://codereview.chromium.org/361006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also a few wording changes.
TEST=none
BUG=none
TBR=aa
Review URL: http://codereview.chromium.org/437027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I more or less implemented things as per discussion with Cole and Glen. (This
does not re-create the appearance on Win Chrome, which is not exactly right
either.)
BUG=28477
TEST=Load various themes (in particular, "Karim Rashid") and make sure bookmark bar buttons look good and legible in hover and pressed states.
Review URL: http://codereview.chromium.org/440001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
load faster, and not take so much space visually.
TEST=none
BUG=none
TBR=aa
Review URL: http://codereview.chromium.org/434037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
--enable-extension-toolstrips
BUG=24475
TEST=Extension*Toolstrip*
Review URL: http://codereview.chromium.org/434026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
unittest.
SyncSocket provides a blocking send/receive that can be used for synchronization.
Review URL: http://codereview.chromium.org/418004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Apparently there are still issues with DevTools on Windows.
TBR=sgjesse@chromium.org
Review URL: http://codereview.chromium.org/436023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
auto-opened.
BUG=http://crbug.com/28215
TEST=as in bug
Review URL: http://codereview.chromium.org/431019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This time it really should fix the problems we have been seeing with
dev tools and V8 version 2.0.x.
Review URL: http://codereview.chromium.org/434036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32924 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Bot build with updated generator:
http://build.chromium.org/buildbot/waterfall.fyi/builders/Chromium%20Mac%20GYP/builds/4673
BUG=none
TEST=everything still builds and hopefully rebuilds better.
Review URL: http://codereview.chromium.org/435008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32923 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I sort out better sizing with some of the other changes needed.
TEST=see bug
BUG=28410
Review URL: http://codereview.chromium.org/437037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28657
TEST=none
Review URL: http://codereview.chromium.org/440005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32919 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=13572
TEST=none
Review URL: http://codereview.chromium.org/399068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dir instead of
stderr and stdout. This seems to have broken the builder.
BUG=none
TEST=none
R=ukai@chromium.org
Review URL: http://codereview.chromium.org/435006
TBR=dpranke@google.com
Review URL: http://codereview.chromium.org/437035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tested by:
- highlighting omnibox text
- switching to a different tab
- highlighting some other text
- switching back to the first tab
- confirming that the omnibox highlighting was restored
but PRIMARY didn't get updated when switching back
BUG=20674
TEST=see above
Review URL: http://codereview.chromium.org/440003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
of partial writes.
For example, suppose the application under test is doing a write
such as:
Write("foobar", 6); // 6 bytes
Normally you could test this with
MockWrite(true, "foobar", 6);
Now you can also test this with:
WriteList {
MockWrite(true, "foo", 3);
MockWrite(true, "bar", 3);
}
BUG=none
TEST=this is the test!
Review URL: http://codereview.chromium.org/437031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
a new test that was added in WebKit recently, which checks the behavior of submitting a form to about:* pages. As per discussions at issue 20570, we are not going to support this functionality.BUG=20570TEST=none
Review URL: http://codereview.chromium.org/401024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32912 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
stderr and stdout.
BUG=none
TEST=none
R=ukai@chromium.org
Review URL: http://codereview.chromium.org/435006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it as flaky
Bug=25045
TBR=phajdan
Review URL: http://codereview.chromium.org/435017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32908 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It caused New Tab Warm on Windows to regress to the speed before adding
the cache on Windows.
This reverts commit r32899.
TBR=arv
Review URL: http://codereview.chromium.org/431024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window manager bug. While we're at it, change dialog's default size to match that of Chrome on Windows.
BUG=28230
TEST=see bug
Review URL: http://codereview.chromium.org/425016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/431023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implementation of the Menu2Model::GetGroupIdAt() interface seems to be ignored.
This change is necessary in order to implement the menu for Chrome OS Text Input:
https://sites.google.com/a/google.com/chromium-developer-central/chromiumos-1/chromiumos-design-docs/text-input/input.png?attredirects=0
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/414031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32903 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
trip to the UI thread later. Not sure if this will make a
difference.
Move the NTP and CSS handler init to after adding the MostVistedHandler.
This should allow an earlier db fetch for the cases when the HTML/CSS
are not in the cache (e.g., browser startup).
Review URL: http://codereview.chromium.org/439013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
described in http://crbug.com/27944.
BUG=28530
TEST=Open chrome://extensions, select 'Pack Extension', select an extension folder, press OK. Should pack the extension instead of crash.
Review URL: http://codereview.chromium.org/436008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/435011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
implicitly follows redirects.
When Chrome receives a notification about a redirect it also attempts to follow the redirect request. While
this works in most cases, some sites actually returned an error for the second request initiated by Chrome.
Fix is to abort the request in urlmon, when we receive a notification about a redirect. I also fixed the
IsRedirectResponse function in the UrlRequestAutomationJob class to only treat 301, 302, 303 and 307 as
redirect codes on the same lines as the default http job.
Test=covered by existing network tests.
I also verified that http://code.google.com/p/chromium/issues/detail?id=25643 works with this CL.
Fixes http://code.google.com/p/chromium/issues/detail?id=28296
Bug=28296
Review URL: http://codereview.chromium.org/402107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
rid of the notion of an entryId.
TEST=existing tests apply
BUG=none
Review URL: http://codereview.chromium.org/432012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32895 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=26342
TEST+exist
Review URL: http://codereview.chromium.org/429003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32894 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/437030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32893 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it work without a browser window being present.
Moved menu verification code into sync_status_ui_helper_mac{.h,.mm,_unittest.mm}.
BUG=27995
TEST=tested that the main menu item worked with or without a browser window. tested that the main menu item didn't show up unless --enable-sync was passed in.
Review URL: http://codereview.chromium.org/423004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
This excersized more code and found several
bugs.
Review URL: http://codereview.chromium.org/437020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/432011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Landing this on for pam. Original issue: http://codereview.chromium.org/425011/show.
Disable showing JS alerts from popups, because doing so makes the popup
disappear immediately, which has all sorts of unfortunate side effects for the
poor orphaned alert (see bug for details).
BUG=27758
TEST=create extension with popup, put link with |onclick="alert('test');"| in
it; install extension, open popup, and click link; see no crash (nor popup)
Review URL: http://codereview.chromium.org/435010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32889 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=levin
BUG=28027
Review URL: http://codereview.chromium.org/434029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32888 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GTK:
- set default size of contents, rather than window as a whole---this gets line wrapping right.
All:
- change title string to Title Case instead of Sentence case
- fix Connection text for mixed/unsafe content
BUG=28507
Review URL: http://codereview.chromium.org/437026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The async notification via OnReadComplete was still posting
a callback through this message loop. This makes it difficult
to write tests, as callbacks already scheduled will go in
front of the OnReadComplete(). Treat the notifications through
OnReadComplete as synchronous always.
This doesn't effect existing tests, but makes my new tests
possible.
BUG=none
TEST=this is the test!
Review URL: http://codereview.chromium.org/436014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32886 0039d316-1c4b-4281-b951-d872f2087c98
|