summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* valgrind: Suppress 2 leaks under PluginLib::ReadWebPluginInfo.thakis@chromium.org2011-05-141-0/+19
| | | | | | | | | | | | It's not clear to me where these leaks come from. BUG=82682 TEST=none TBR=bauerb Review URL: http://codereview.chromium.org/7022003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85391 0039d316-1c4b-4281-b951-d872f2087c98
* chrome_dll.gypi left out of CL at r85322.tsepez@chromium.org2011-05-141-0/+1
| | | | | | | | | BUG=82648 TEST=open chrome://settings on mac, verify non-blank. TBR=tony Review URL: http://codereview.chromium.org/7025001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85390 0039d316-1c4b-4281-b951-d872f2087c98
* valgrind: Update suppression.thakis@chromium.org2011-05-141-1/+1
| | | | | | | | | | | | | http://src.chromium.org/viewvc/chrome?view=rev&revision=85242 removed the second bool parameter from BrowserRendererProcessHost::Init() but didn't update suppressions. BUG=73299 TEST=none TBR=aa,jam Review URL: http://codereview.chromium.org/7027001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85389 0039d316-1c4b-4281-b951-d872f2087c98
* valgrind: Suppress leak in _ZN36IPCChannelTest_ChannelProxyTest_Test8TestBodyEvthakis@chromium.org2011-05-141-0/+11
| | | | | | | | | | BUG=82680 TEST=none TBR=jam Review URL: http://codereview.chromium.org/7024002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85388 0039d316-1c4b-4281-b951-d872f2087c98
* valgrnd: Suppress leak in ↵thakis@chromium.org2011-05-141-0/+15
| | | | | | | | | | | _ZN4base5debug47TraceEventTestFixture_DataCapturedOnThread_Test8TestBodyEv BUG=82679 TEST=none Review URL: http://codereview.chromium.org/7022002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85387 0039d316-1c4b-4281-b951-d872f2087c98
* valgrind: Update suppressions after function interface change.thakis@chromium.org2011-05-141-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | http://codereview.chromium.org/6976006 added a few parameters to OnLookupComplete but didn't update suppressions for this. Valgrind complained: Suppression (error hash=#0000000050AE2EBC#): { <insert_a_suppression_name_here> Memcheck:Leak fun:_Znw* fun:_ZN9__gnu_cxx13new_allocatorISt13_Rb_tree_nodeISt4pairIKN3net9HostCache3KeyE13scoped_refptrINS4_5EntryEEEEE8allocateEjPKv fun:_ZNSt8_Rb_treeIN3net9HostCache3KeyESt4pairIKS2_13scoped_refptrINS1_5EntryEEESt10_Select1stIS8_ESt4lessIS2_ESaIS8_EE11_M_get_nodeEv fun:_ZNSt8_Rb_treeIN3net9HostCache3KeyESt4pairIKS2_13scoped_refptrINS1_5EntryEEESt10_Select1stIS8_ESt4lessIS2_ESaIS8_EE14_M_create_nodeERKS8_ fun:_ZNSt8_Rb_treeIN3net9HostCache3KeyESt4pairIKS2_13scoped_refptrINS1_5EntryEEESt10_Select1stIS8_ESt4lessIS2_ESaIS8_EE9_M_insertEPSt18_Rb_tree_node_baseSG_RKS8_ fun:_ZNSt8_Rb_treeIN3net9HostCache3KeyESt4pairIKS2_13scoped_refptrINS1_5EntryEEESt10_Select1stIS8_ESt4lessIS2_ESaIS8_EE16_M_insert_uniqueESt17_Rb_tree_iteratorIS8_ERKS8_ fun:_ZNSt3mapIN3net9HostCache3KeyE13scoped_refptrINS1_5EntryEESt4lessIS2_ESaISt4pairIKS2_S5_EEE6insertESt17_Rb_tree_iteratorISA_ERKSA_ fun:_ZNSt3mapIN3net9HostCache3KeyE13scoped_refptrINS1_5EntryEESt4lessIS2_ESaISt4pairIKS2_S5_EEEixERS9_ fun:_ZN3net9HostCache3SetERKNS0_3KeyEiRKNS_11AddressListEN4base9TimeTicksE fun:_ZN3net16HostResolverImpl13OnJobCompleteEPNS0_3JobEiiRKNS_11AddressListE fun:_ZN3net16HostResolverImpl3Job16OnLookupCompleteERKNS_11AddressListERKN4base9TimeTicksEjii fun:_Z16DispatchToMethodIN3net16HostResolverImpl3JobEMS2_FvRKNS0_11AddressListERKN4base9TimeTicksEjiiES3_S7_jiiEvPT_T0_RK6Tuple5IT1_T2_T3_T4_T5_E fun:_ZN14RunnableMethodIN3net16HostResolverImpl3JobEMS2_FvRKNS0_11AddressListERKN4base9TimeTicksEjiiE6Tuple5IS3_S7_jiiEE3RunEv fun:_ZN49_GLOBAL__N_base_message_loop.cc_00000000_1A64750618TaskClosureAdapter3RunEv fun:_ZN4base8internal8Invoker1INS0_15InvokerStorage1IMN49_GLOBAL__N_base_message_loop.cc_00000000_1A64750618TaskClosureAdapterEFvvEPS4_EES6_E8DoInvokeEPNS0_18InvokerStorageBaseE fun:_ZNK4base8CallbackIFvvEE3RunEv fun:_ZN11MessageLoop7RunTaskERKNS_11PendingTaskE fun:_ZN11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE fun:_ZN11MessageLoop6DoWorkEv fun:_ZN4base19MessagePumpLibevent3RunEPNS_11MessagePump8DelegateE fun:_ZN11MessageLoop11RunInternalEv fun:_ZN11MessageLoop10RunHandlerEv } BUG=44385,22450 TEST=none TBR=rtenneti,eroman Review URL: http://codereview.chromium.org/7026001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85386 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 85277 - This change might have caused ~200 new test failures in ↵nsylvain@chromium.org2011-05-148-135/+53
| | | | | | | | | | | | | | | | | | | | | browser tests and interactive ui tests on the chromiumos bots only. Original CL: Show the arcs icons when it's a wifi connection. Also change the animation to have a constant fade, instead of pulsing it. BUG=chromium-os:15279 TEST=None Review URL: http://codereview.chromium.org/6973045 TBR=davemoore@chromium.org Review URL: http://codereview.chromium.org/7024001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85385 0039d316-1c4b-4281-b951-d872f2087c98
* tsan: Suppress a benign race in icu.thakis@chromium.org2011-05-141-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | TSAN reports: ==31254== INFO: T0 is program's main thread ==31254== INFO: T302 has been created by T0 at this point: {{{ ==31254== #0 (no symbols) /lib/tls/i686/cmov/libpthread-2.7.so ==31254== #1 pthread_create@@GLIBC_2.1 /lib/tls/i686/cmov/libpthread-2.7.so ==31254== #2 pthread_create@* /tmp/valgrind-src/tsan/tsan/ts_valgrind_intercepts.c:732 ==31254== #3 base::::CreateThread base/threading/platform_thread_posix.cc:109 ==31254== #4 base::PlatformThread::Create base/threading/platform_thread_posix.cc:204 ==31254== #5 base::Thread::StartWithOptions base/threading/thread.cc:74 ==31254== #6 base::Thread::Start base/threading/thread.cc:63 ==31254== #7 HistoryService::Init chrome/browser/history/history.cc:664 ==31254== #8 TestingProfile::CreateHistoryService chrome/test/testing_profile.cc:228 ==31254== #9 HistoryURLProviderTest::SetUpImpl chrome/browser/autocomplete/history_url_provider_unittest.cc:155 ==31254== #10 HistoryURLProviderTest::SetUp chrome/browser/autocomplete/history_url_provider_unittest.cc:112 ==31254== #11 testing::internal::HandleSehExceptionsInMethodIfSupported testing/gtest/src/gtest.cc:2090 ==31254== #12 testing::internal::HandleExceptionsInMethodIfSupported testing/gtest/src/gtest.cc:2142 ==31254== #13 testing::Test::Run testing/gtest/src/gtest.cc:2157 ==31254== }}} ==31254== WARNING: Possible data race during write of size 4 at 0xC159460: {{{ ==31254== T0 (L{}): ==31254== #0 ucln_registerCleanup_46 third_party/icu/source/common/ucln_cmn.c:89 ==31254== #1 uplug_init_46 third_party/icu/source/common/icuplug.c:824 ==31254== #2 u_init_46 third_party/icu/source/common/uinit.c:63 ==31254== #3 icu_46::RegexPattern::RegexPattern third_party/icu/source/i18n/repattrn.cpp:34 ==31254== #4 icu_46::RegexPattern::compile third_party/icu/source/i18n/repattrn.cpp:296 ==31254== #5 icu_46::RegexMatcher::RegexMatcher third_party/icu/source/i18n/rematch.cpp:136 ==31254== #6 net::::IsIDNComponentSafe net/base/net_util.cc:570 ==31254== #7 net::::IDNToUnicodeOneComponent net/base/net_util.cc:643 ==31254== #8 net::::IDNToUnicodeWithOffsets net/base/net_util.cc:705 ==31254== #9 net::::HostComponentTransform::Execute net/base/net_util.cc:856 ==31254== #10 net::::AppendFormattedComponent net/base/net_util.cc:899 ==31254== #11 net::FormatUrlWithOffsets net/base/net_util.cc:1644 ==31254== #12 net::FormatUrl net/base/net_util.cc:1727 ==31254== #13 history::InMemoryURLIndex::IndexRow chrome/browser/history/in_memory_url_index.cc:166 ==31254== #14 history::InMemoryURLIndex::UpdateURL chrome/browser/history/in_memory_url_index.cc:309 ==31254== #15 history::InMemoryHistoryBackend::OnTypedURLsModified chrome/browser/history/in_memory_history_backend.cc:134 ==31254== #16 history::InMemoryHistoryBackend::Observe chrome/browser/history/in_memory_history_backend.cc:100 ==31254== #17 NotificationService::Notify content/common/notification_service.cc:120 ==31254== #18 HistoryService::BroadcastNotifications chrome/browser/history/history.cc:772 ==31254== #19 DispatchToMethod base/tuple.h:558 ==31254== #20 RunnableMethod::Run base/task.h:332 ==31254== #21 ::TaskClosureAdapter::Run base/message_loop.cc:100 ==31254== #22 base::internal::Invoker1::DoInvoke base/bind_internal.h:487 ==31254== #23 base::Callback::Run base/callback.h:251 ==31254== #24 MessageLoop::RunTask base/message_loop.cc:462 ==31254== #25 MessageLoop::DeferOrRunPendingTask base/message_loop.cc:480 ==31254== #26 MessageLoop::DoWork base/message_loop.cc:670 ==31254== #27 base::MessagePumpForUI::HandleDispatch base/message_pump_glib.cc:284 ==31254== #28 ::WorkSourceDispatch base/message_pump_glib.cc:109 ==31254== #29 g_main_context_dispatch /build/buildd/glib2.0-2.16.6/glib/gmain.c:2012 ==31254== Concurrent write(s) happened at (OR AFTER) these points: ==31254== T302 (Chrome_HistoryThread) (L{}): ==31254== #0 ucln_registerCleanup_46 third_party/icu/source/common/ucln_cmn.c:89 ==31254== #1 uplug_init_46 third_party/icu/source/common/icuplug.c:824 ==31254== #2 u_init_46 third_party/icu/source/common/uinit.c:63 ==31254== #3 icu_46::RegexPattern::RegexPattern third_party/icu/source/i18n/repattrn.cpp:34 ==31254== #4 icu_46::RegexPattern::compile third_party/icu/source/i18n/repattrn.cpp:296 ==31254== #5 icu_46::RegexMatcher::RegexMatcher third_party/icu/source/i18n/rematch.cpp:136 ==31254== #6 net::::IsIDNComponentSafe net/base/net_util.cc:570 ==31254== #7 net::::IDNToUnicodeOneComponent net/base/net_util.cc:643 ==31254== #8 net::::IDNToUnicodeWithOffsets net/base/net_util.cc:705 ==31254== #9 net::::HostComponentTransform::Execute net/base/net_util.cc:856 ==31254== Address 0xC159460 is 0 bytes inside data symbol "gLibCleanupFunctions" ==31254== Race verifier data: 0x965D965,0x965D962 ==31254== }}} uplug_init_46() calls ucln_registerCleanup(UCLN_UPLUG, uplug_cleanup) concurrently on two threads, and both treads write uplug_cleanup into gLibCleanupFunctions. This should be safe. BUG=none TEST=none Review URL: http://codereview.chromium.org/7023002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85384 0039d316-1c4b-4281-b951-d872f2087c98
* valgrind: Widen existing suppression.thakis@chromium.org2011-05-141-0/+18
| | | | | | | | | | | | It is not clear what triggered these writes -- like the other suppressions on this bug. BUG=75714 TEST=none Review URL: http://codereview.chromium.org/7023001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85383 0039d316-1c4b-4281-b951-d872f2087c98
* Updating trunk VERSION from 765.0 to 766.0chrome-release@google.com2011-05-141-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85380 0039d316-1c4b-4281-b951-d872f2087c98
* Fix TestURLRequestContext leaks in MalwareDetailsTest.HTTPCache.willchan@chromium.org2011-05-141-1/+2
| | | | | | | | | | | Need to call ResetRequestContext() if we use it. BUG=none TEST=none Review URL: http://codereview.chromium.org/7016047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85378 0039d316-1c4b-4281-b951-d872f2087c98
* Valgrind: Suppress leak in _ZN5views6Widget21OnNativeWidgetCreatedEvthakis@chromium.org2011-05-141-0/+15
| | | | | | | | | | BUG=82642 TEST=none TBR=ben Review URL: http://codereview.chromium.org/7021022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85377 0039d316-1c4b-4281-b951-d872f2087c98
* Create a URLRequestJobFactory to replace the URLRequest globals.willchan@chromium.org2011-05-1438-206/+735
| | | | | | | | | | | | | | | | | | | | | | | | | | | | URLRequest::Interceptor and URLRequest::ProtocolFactory are globally registered. This causes a variety of problems. This provides a method for replacing them. It used to be the case that we used net::URLRequest::IsHandledProtocol()/net::URLRequest::IsHandledURL() to see if the request would be handled by Chrome, or deferred to an external protocol handler. This required that URLRequest be aware of all protocol handlers. We instead provide ProfileIOData::IsHandledProtocol(), which checks to see if there are any Chrome registered protocol handlers, and if not, checks the default ones in net::URLRequest. Note this doesn't work for custom handlers (registerProtocolHandler) because they are dynamic and profile-specific. We would have to add a member function to ProfileIOData and not use a global. This is problematic since we check ProfileIOData::IsHandledProtocol in the RenderViewContextMenu, which runs on the UI thread, whereas ProfileIOData lives on the IO thread. RenderViewContextMenu is using also using it synchronously, which makes it a pain to support. So, we don't support custom handlers in ProfileIOData::IsHandledProtocol(). This means that "save as" won't work for custom handlers. Seems ok for now. This also fixes the multiprofile/incognito bugs where if a profile registers a custom handler, and then a different profile / an incognito profile registers the same custom handler and then unregisters it, which globally unregisters it, so the original profile is now broken. By removing the use of the globals, we fix this. Also fixes a bunch of style guide violations in the ProtocolHandler/ProtocolHandlerRegistry code. This changelist replaces two existing URLRequest::ProtocolFactory uses: chrome-extension/user-script and custom handlers. Also improve the tests in ResourceDispatcherHost so we don't have to do as many NULL checks. Change the MockResourceContext to create a TestURLRequestContext. BUG=81979 TEST=none Review URL: http://codereview.chromium.org/6960006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85376 0039d316-1c4b-4281-b951-d872f2087c98
* Add comments explaining the IPv6 fallback logic in TransportConnectJob.willchan@chromium.org2011-05-141-7/+13
| | | | | | | | | BUG=81686 TEST=none. Review URL: http://codereview.chromium.org/7015056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85375 0039d316-1c4b-4281-b951-d872f2087c98
* grit: Don't parse <messages> and children in --inputs and --outputs mode.thakis@chromium.org2011-05-142-16/+35
| | | | | | | | | | | | | | | | This speeds up `gclient runhooks` by 2 seconds (~10%) on my system. `gclient runhooks` runs grit_info in inputs and outputs mode about 20 times each. Interestingly, the speedup comes from making a single invocation each about 1s faster (for the grd file that contains almost all our strings). BUG=82230 TEST=None Review URL: http://codereview.chromium.org/6973066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85374 0039d316-1c4b-4281-b951-d872f2087c98
* grit: When gathering input files, don't do full inlining.thakis@chromium.org2011-05-141-5/+26
| | | | | | | | | | | This speeds up `gclient runhooks` by 0.5s (2.5%) on my machine. BUG=82230 TEST=none Review URL: http://codereview.chromium.org/7015063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85373 0039d316-1c4b-4281-b951-d872f2087c98
* grit: Split the main() function into a pure DoMain() and an impure part.thakis@chromium.org2011-05-141-8/+13
| | | | | | | | | | | | | | | This allows gyp to call grit_info.DoMain() directly, without having to go through the trouble of launching grit_info in a subprocess (but that will happen in a different CL, in gyp land). No intended functionality change. BUG=82230 TEST=none Review URL: http://codereview.chromium.org/6973068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85372 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the Remoting Host plugin to be compatible with NPAPI on Linux.wez@chromium.org2011-05-141-13/+26
| | | | | | | | | | BUG= TEST=Remoting Host Web App's "Start Sharing" button causes a support-Id to be displayed. Review URL: http://codereview.chromium.org/6973046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85371 0039d316-1c4b-4281-b951-d872f2087c98
* Collect stats (how other threads are responding) if wertenneti@chromium.org2011-05-141-1/+6
| | | | | | | | | | | don't get response atleast 3 times. BUG=82336 TEST=thread watcher unit tests R=jar Review URL: http://codereview.chromium.org/6969049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85368 0039d316-1c4b-4281-b951-d872f2087c98
* Use callback pointers as implicit "pending" indicators.wez@chromium.org2011-05-142-18/+16
| | | | | | | | | | | | Check that Read and Write are passed callbacks in DEBUG builds. BUG= TEST=Existing tests should continue to work unchanged. Review URL: http://codereview.chromium.org/7012014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85365 0039d316-1c4b-4281-b951-d872f2087c98
* security_tests: Get rid of "using namespace sandbox;"tfarina@chromium.org2011-05-141-4/+6
| | | | | | | | | BUG=82078 TEST=None Review URL: http://codereview.chromium.org/7015062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85363 0039d316-1c4b-4281-b951-d872f2087c98
* Get the TabContents from the NavigationController instead of from the ↵sadrul@chromium.org2011-05-141-2/+4
| | | | | | | | | | Browser (which may not exist). BUG=none TEST=none TBR=varunjain@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85362 0039d316-1c4b-4281-b951-d872f2087c98
* Disabling testPopupsLaunchUponBrowserBackButton due to feature bug against ↵dyu@chromium.org2011-05-141-0/+2
| | | | | | | | | | 13.0.764.0. TEST=none BUG=none Review URL: http://codereview.chromium.org/7013066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85361 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate most CommandLine code across platforms.msw@chromium.org2011-05-1417-470/+473
| | | | | | | | | | | | | | | | | | | | | | Significant refactoring with some notable behavior changes: 1. Switches are appended preceding existing arguments (after other swtiches). 2. (Windows) command_line_string() is generated and properly quoted/escaped. 3. Appended switches will retain their (optional) included prefixes (--,-,/). Notable internal changes (shouldn't affect behavior): 1. (Windows) Generate the cl string, instead of storing&updating the original. 2. Explicitly retain switch prefixes (--,-,/) (was automatic in init*/ctor). Update (obvious) code expecting switches to be appended antecedent to args. Add Nico's test from: codereview.chromium.org/6728016/. An intermediary CL landed between patch set 3 and 4, see: http://codereview.chromium.org/6596020 BUG=73195,67764 TEST=Commandline usage. Review URL: http://codereview.chromium.org/6526040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85360 0039d316-1c4b-4281-b951-d872f2087c98
* Added release build assert on attempt to create a RunnableFunction for a ↵apatrick@chromium.org2011-05-141-0/+6
| | | | | | | | | | | | | | function pointer with address 1. This is actually happening. See http://crbug.com/81449. The generated code to invoke the callback puts the address of the function in the EAX register before doing CALL EAX. I see 0x00000001 in the EAX register when it crashes in the reported minidumps. I'll revert this after the next Canary. TEST=run locally and verify no assertion BUG=81449 Review URL: http://codereview.chromium.org/7013014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85359 0039d316-1c4b-4281-b951-d872f2087c98
* Support the AXRows and AXColumns attributes. We do this by examining the AX ↵dtseng@chromium.org2011-05-144-0/+56
| | | | | | | | | | | | | hieararchy exposed by webkit (specifically our own cache of it in BrowserAccessibility's). Table ax elements always have its associated rows and columns as immediate children. I also looked into passing this information over from WebKit with a sample patch. It would involve exposing AccessibilityTable accessors within WebAccessibilityObject, adding additional members to WebAccessibility to be shipped over (renderer id's or elements themselves. Presenting this alternative since it was easy to implement and can be generalized for Windows as well by pushing this up to BrowserAccessibility. BUG=66719 TEST=manually with VoiceOver. Review URL: http://codereview.chromium.org/5862004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85358 0039d316-1c4b-4281-b951-d872f2087c98
* Fix shared linking for touchuisadrul@chromium.org2011-05-142-3/+8
| | | | | | | | | BUG=none TEST=touch bot goes green Review URL: http://codereview.chromium.org/7021017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85357 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable DNS prefetch. This feature got disable accidentially in WebKitabarth@chromium.org2011-05-143-0/+7
| | | | | | | | | because it is off by default. In this patch, we explicitly turn the feature on. Review URL: http://codereview.chromium.org/7021008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85356 0039d316-1c4b-4281-b951-d872f2087c98
* Fix web-app nomenclature.jamiewalch@chromium.org2011-05-145-48/+61
| | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/7021010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85355 0039d316-1c4b-4281-b951-d872f2087c98
* Content: Define the content api for building content libs as dlls/ananta@chromium.org2011-05-142-0/+26
| | | | | | | | | | | CONTENT_API is the public interface for the module. CONTENT_TEST is intended to be used for symbols that have to be exported only in order to test them. BUG=82454 Review URL: http://codereview.chromium.org/7012043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85354 0039d316-1c4b-4281-b951-d872f2087c98
* Fix touch build for unit tests.sky@chromium.org2011-05-141-1/+1
| | | | | | | | | | | R=ben@chromium.org TBR=ben@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/7015060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85352 0039d316-1c4b-4281-b951-d872f2087c98
* Timer to drop in-memory databases when they're not in use.ericu@google.com2011-05-132-0/+15
| | | | | | | | | | | Advice on how best to test this is welcome. BUG=none TEST=parts tested via existing unit tests; I'm not sure how to test the rest Review URL: http://codereview.chromium.org/7011014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85351 0039d316-1c4b-4281-b951-d872f2087c98
* Fix touch build.sky@chromium.org2011-05-133-2/+3
| | | | | | | | | | BUG=none TEST=none R=ben@chromium.org Review URL: http://codereview.chromium.org/6969076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85350 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented threshold based trace events that only get added to the trace if ↵jbates@chromium.org2011-05-134-168/+479
| | | | | | | | | | | | | | | | | the elapsed time between begin and end is greater than a specified time. In order to reduce macro code duplication, created some additional internal helper macros. Improved performance on the critical trace-disabled code path by deferring some member initialization. Removed the unused __LINE__/__FILE__ data. Prefixed internal macros with "INTERNAL_" so that users ignore them. Moved all the internal macros below so that the user sees the relevant macros first. BUG=81565 TEST=base_unittests Review URL: http://codereview.chromium.org/7016012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85349 0039d316-1c4b-4281-b951-d872f2087c98
* Fix event dispatching for PPB_Messaging::PostMessage. I asked Adam about ↵dmichael@chromium.org2011-05-135-85/+176
| | | | | | | | | | | | | | | | the "plugin.onmessage = function(x){...}" style vs the 'plugin.addEventListener' style, and it seems that we should prefer supporting the addEventListener style. This breaks the ability to do "plugin.onmessage =" :-(. I expected dispatchEvent to do it for me, but it does not. To add that support (if desired), I could work on making dispatchEvent do it, or I could fake it out via the script in MessageChannel (Basically have the old path of invoking onmessage directly, plus the new dispatchEvent code). Brett, please focus on PPAPI-specific stuff. Adam, please focus on my event code (especially message_channel.cc and the JavaScript in test_post_message.cc). BUG=None TEST=test_post_message.cc Review URL: http://codereview.chromium.org/6901060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85348 0039d316-1c4b-4281-b951-d872f2087c98
* Workaround for menu crash.oshima@google.com2011-05-131-3/+5
| | | | | | | | | | | | | | | I don't fully understand how this can happen because handler should not exist if handler_id is 0. There may be some undocumented behavior in gtk. I couldn't reproduce this on my machine either (but i've seen on tester's machine) so this is hypothetical workaround that should fix this. BUG=chromium-os:15212 TEST=see bug for reprostep Review URL: http://codereview.chromium.org/7013058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85346 0039d316-1c4b-4281-b951-d872f2087c98
* Mark TestEncodingAliasMapping flaky on mac.atwilson@chromium.org2011-05-131-0/+4
| | | | | | | | BUG=82616 TEST=Watch test go green on mac build bots. TBR=jnd git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85345 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor Edit to have one Undo/Redooshima@google.com2011-05-135-289/+283
| | | | | | | | | | | Always use Redo() to modify the text. BUG=none TEST=new tests added Review URL: http://codereview.chromium.org/7011025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85344 0039d316-1c4b-4281-b951-d872f2087c98
* Remove MockWebFrame in favour of MockWebFrameClient and update corresponding ↵scherkus@chromium.org2011-05-137-727/+59
| | | | | | | | | | | | | tests. This should help reduce WebKit gardening pain since all WebFrame implementations will reside in WebKit itself. BUG=none TEST=test_shell_tests Review URL: http://codereview.chromium.org/6973051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85343 0039d316-1c4b-4281-b951-d872f2087c98
* Unmark the URLLoader test as flaky, it hasn't failed in a while.brettw@chromium.org2011-05-131-2/+1
| | | | | | | | TEST=this is BUG=57053 Review URL: http://codereview.chromium.org/6973060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85342 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 85330 - GTK: Bring global menu out of about:flags.rohitrao@chromium.org2011-05-136-2/+41
| | | | | | | | | | | | BUG=30213 TEST=memory bots, since they're now running w/ the code on. Review URL: http://codereview.chromium.org/6973037 TBR=erg@google.com Review URL: http://codereview.chromium.org/7011052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85341 0039d316-1c4b-4281-b951-d872f2087c98
* Removing 'using namespace' style violations in src/ipc/kushi.p@gmail.com2011-05-131-5/+8
| | | | | | | | | | BUG=82078 TEST=None Review URL: http://codereview.chromium.org/6973055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85340 0039d316-1c4b-4281-b951-d872f2087c98
* Include "base/string_util.h" in "base/string_util_posix.h".asvitkine@chromium.org2011-05-131-0/+1
| | | | | | | | | | | | Needed for declaration of IsWprintfFormatPortable() which is used by a DHECK() in vswprintf(). BUG=none TEST=none Review URL: http://codereview.chromium.org/6973039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85339 0039d316-1c4b-4281-b951-d872f2087c98
* Really fix chromium-os:14180 this time.ers@chromium.org2011-05-131-10/+12
| | | | | | | | | | | | | | | Add the device change property manager in the correct branch of the if statement. BUG=chromium-os:14180 TEST=Bring up the cellular device tab, and see that it is now populated with actual values instead of being blank. R=stevenjb@chromium.org Review URL: http://codereview.chromium.org/7011023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85338 0039d316-1c4b-4281-b951-d872f2087c98
* Created an IPC method to enable the cloud print proxy using robot OAuth2 ↵sanjeevr@chromium.org2011-05-139-48/+176
| | | | | | | | | | | | | | | credentials. Used this method in the browser. This will be used by the new login scheme for Cloud Print. BUG=None TEST=None Review URL: http://codereview.chromium.org/6969055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85337 0039d316-1c4b-4281-b951-d872f2087c98
* Move CertificateManagerModel and CertificateViewer back to chrome. Nothing ↵jam@chromium.org2011-05-1317-30/+25
| | | | | | | | uses them in content. Review URL: http://codereview.chromium.org/7021011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85335 0039d316-1c4b-4281-b951-d872f2087c98
* Roll skia. 1309:1322ctguil@chromium.org2011-05-131-1/+1
| | | | | | Review URL: http://codereview.chromium.org/7015028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85334 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the last content settings include from content.jam@chromium.org2011-05-1319-95/+122
| | | | | | | BUG=76793 Review URL: http://codereview.chromium.org/7011045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85333 0039d316-1c4b-4281-b951-d872f2087c98
* ObfuscatedFileSystemFileUtil classericu@google.com2011-05-1316-16/+1792
| | | | | | | | | | This is functional and reasonably well-tested, but we'll still have to adapt the system a bit in order to use it. BUG=none TEST=included unit tests Review URL: http://codereview.chromium.org/6955013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85332 0039d316-1c4b-4281-b951-d872f2087c98
* This CL increases the menu items size and the spacing between the status icons.saintlou@chromium.org2011-05-132-1/+14
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7013042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85331 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-10-30 03:17:59 +0000