| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
| |
The previous code printed to stderr, but since the logging code
already had logged to stderr we'd end up printing the message twice,
which was making me nervous.
BUG=29997,31243,37026
Review URL: http://codereview.chromium.org/660269
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dglazkov,dumi
Review URL: http://codereview.chromium.org/660271
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no leaks reported wrt utimes
Review URL: http://codereview.chromium.org/661269
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
disposal notification API.
TEST=None
BUG=None
Review URL: http://codereview.chromium.org/661270
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
This reverts commit r40261. Test breakage.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40262 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The previous code printed to stderr, but since the logging code
already had logged to stderr we'd end up printing the message twice,
which was making me nervous.
BUG=31243,37026
Review URL: http://codereview.chromium.org/661260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We use the GTK text direction in the browser process, but that
is not available in the renderer.
BUG=36624
TEST=Arabic error pages are properly RTL
Review URL: http://codereview.chromium.org/660176
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to get back candidate_window binary in the snapshots
of chromium for chromium os that can be found at
http://build.chromium.org/buildbot/snapshots/chromium-rel-linux-chromiumos/
TEST=manually
BUG=crosbug.com/1708
Review URL: http://codereview.chromium.org/660265
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no memory leak in valgrind test: net_unittests
Review URL: http://codereview.chromium.org/661266
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is a test case for my hunspell fix <http://codereview.chromium.org/650210/show>. This test fails without the change.
BUG=36523
TEST=unit_test.exe --gtest_filter=SpellCheckTest.SpellCheckSuggestions_EN_US
Review URL: http://codereview.chromium.org/652107
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
pywebsocket fails to serve it as cgi script.
BUG=37049
TEST=none
Review URL: http://codereview.chromium.org/661264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Just like what Mac port already did, this CL changes the method to determine if a keyboard event should be processed by the browser to use a boolean field instead of setting the keyval of os_event to GDK_VoidSymbol. Because in some cases, GDK_VoidSymbol might be valid key value, for example ctrl-b on Arabic keyboard.
BUG=35117 Emacs key binding ctrl-b doesn't work in web page when using Arabic keyboard layout.
TEST=Enable Emacs key theme and switch to Arabic keyboard layout, then try ctrl-b (move cursor backwards) in web page's text area.
Review URL: http://codereview.chromium.org/661149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=works as before.
Review URL: http://codereview.chromium.org/652019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=none
TEST=browser_tests ExtensionApiTest.FLAKY_WebSocket doesn't crash
Review URL: http://codereview.chromium.org/660259
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=darin
BUG=none
TEST=checkdeps.py passes
Review URL: http://codereview.chromium.org/660258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36780
TEST=Try to insert any special character into a web page from the "Characters" dialog.
Review URL: http://codereview.chromium.org/660076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Web Socket should send "HttpOnly" cookie when handshaking.
In WebKit/WebCore, WebSocketHandshake uses cookieRequestHeaderFieldValue() to
get cookies including HttpOnly cookie. However, Chrome doesn't trunk renderer
process, so we're not allowed to access HttpOnly cookie in WebCore.
Thus, we handle HttpOnly cookies in browser process.
Add SocketStreamJob as interface for protocol specific handling on
SocketStream.
WebSocketJob implements Web Socket specific handling. For now, it handles
cookies in Web Socket. It checks Web Socket handshake request message
from renderer process, and replaces Cookie: header to include HttpOnly cookies.
It also checks Web Socket handshake response message, sets cookies if any,
and strips Set-Cookie: header, so that renderer process couldn't see
Set-Cookie: header.
BUG=35660
TEST=net_unittests and layout_tests passes
Review URL: http://codereview.chromium.org/601077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18717
TEST=ExtensionApiTest.IsValidJson
Review URL: http://codereview.chromium.org/661132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Just random polish while I have a few minutes left today...
Review URL: http://codereview.chromium.org/660182
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=ananta
Review URL: http://codereview.chromium.org/661258
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Check validity of existing document soite before QI for
doc host handler.
BUG=37008
TEST=none
TBR=ananta
Review URL: http://codereview.chromium.org/660255
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=amit
TEST=fixes one of the top crashes in the lastest release.
BUG=36985
Review URL: http://codereview.chromium.org/661256
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=hclam
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/661254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
DecoderBaseTest.FlowControl is crashing on XP (dbg).
TBR=scherkus, nsylvain
Review URL: http://codereview.chromium.org/661253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=jiesun
Review URL: http://codereview.chromium.org/660248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Brings in a fix to some brittle dependencies.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/661189
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The scons generator currently does not correctly handle the case in which you
have a target with no sources (for instance all the mock targets used for the
bots). So far this has not been an issue because these mock targets were only
used for Windows and Mac. jiesun's recent addition of a chromeos_builder target
caused this issue to manifest itself.
BUG=None
TEST=None
TBR=jiesuN
Review URL: http://codereview.chromium.org/661249
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dumi
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/661250
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
utility lands upstream.
TBR=dglazkov
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=dumi
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/660246
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Original review: http://codereview.chromium.org/661247
TBR=loislo
Review URL: http://codereview.chromium.org/661248
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/661178
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
because the chrome's flaky ass tests that break
random builds
TEST=flaky
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
TBR=gman@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It sure would be nice if the trybots caught these issues :-(
TBR=apatrick@chromium.org
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/660238
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36964
TBR=huanr
Review URL: http://codereview.chromium.org/661243
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ResourceHandler::OnRequestClosed() so it doesn't inherit the default (unfortunately the base class doesn't define it as pure virtual).
BUG=36964
TBR=rvargas
Review URL: http://codereview.chromium.org/660240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/658001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manual
Review URL: http://codereview.chromium.org/660236
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=apatrick@google.com
TEST=none
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
for sxs install.
BUG=35574
TEST="setup.exe --chrome-sxs"
Review URL: http://codereview.chromium.org/660168
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
xib changes: Change ^IDS_CLOSE to ^IDS_DONE.
BUG=36959
TEST=Open bookmark bubble. Button should read "Done". Go to popuptest.com, click "popups blocked" icon. Button in bubble should read "Done".
Review URL: http://codereview.chromium.org/661235
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=eroman
BUG=none
TEST=No compilation errors.
Review URL: http://codereview.chromium.org/660223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=36964
TEST=none
Review URL: http://codereview.chromium.org/660234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cc.cc:50:warning: 'length' may be used uninitialized in this function"
Revert 40193 - Added support for glGetString, glGetShaderSource,
glGetProgramInfoLog and glGetShaderInfoLog
This turned up lots of issues.
* glGetShaderiv needed to be wrapped so it
returns the size of the shader the user passed
in. Not the munged shader sent to GL.
* Another issue that came up is that client
side validation is needed to ensure that
the client side GLES2Implementation does not
generate bad commands. For example, calling
glUniform1iv with a negative count would
generate a bad command. The service side
would see that and think the program was
malicious and stop processing commands.
So, that means I had to add some client side
validation and wrap glGetError on the client
side so I can synthisize GL errors there.
TEST=lots of unit tests.
BUG=none
Review URL: http://codereview.chromium.org/661220
TBR=gman@chromium.org
Review URL: http://codereview.chromium.org/660229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Check that we report that we wrote no more than we requested to write.
Remove some debugging.
BUG=27870
TEST=none
Review URL: http://codereview.chromium.org/660194
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40197 0039d316-1c4b-4281-b951-d872f2087c98
|