| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=80057
TEST=covered by unit tests, but see bugs for details.
R=pkasting@chromium.org
Review URL: http://codereview.chromium.org/6893140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:13393
TEST=After 24 hours of an unlimited plan, make sure that the options page for the cellular network shows no plans. See bug.
Review URL: http://codereview.chromium.org/6984001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
rescheduled.
This stops the renderer process from continusously sending synchronous flushes during the swapbuffers period on mac.
TEST=WebGL on windows and mac, trybots
BUG=none
Review URL: http://codereview.chromium.org/6929045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None.
TEST=Chromoting isn't broken.
Review URL: http://codereview.chromium.org/6956010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=touch the wrench menu, see it paint as pressed immediately.
Review URL: http://codereview.chromium.org/6928052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/6985005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84675 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6928051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84672 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac WebKit valgrind fails with:
quota_file_util_unittest.cc:75:warning: 'QuotaFileUtilTest' has a field 'QuotaFileUtilTest::quota_manager_' whose type uses the anonymous namespace
This is a quick fix to get the bot running again; it may be better to declare the field as a QuotaManager and do dynamic_cast to access usage().
TBR=kinuko
BUG=None
TEST=Mac WebKit valgrind bot compiles
Review URL: http://codereview.chromium.org/6976010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84671 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
V8 now has ECMAScript I18N API for collation. This CL uses that.
BUG=28596
TEST=1. Install a bunch of extensions in Swedish/Simplified Chinese Chrome 2. Go to the extension page and see if they sorted in Swedish / Simplified Chinese (pinyin) order.
Review URL: http://codereview.chromium.org/6955009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84668 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=zea@chromium.org,tim@chromium.org
Review URL: http://codereview.chromium.org/6932058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GetNativeImageNamed().
BUG=58030
TEST=None
R=evan@chromium.org
Review URL: http://codereview.chromium.org/6954007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84666 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The last icon drop didn't have the correct hover effect for the forward button. This change fixes that with the correct icon.
BUG=81920
TEST=None
Review URL: http://codereview.chromium.org/6980002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
payload handling in file browser.
BUG=chromium-os:14690
TEST=make sure file browser opens inserted SD cards in the appropriate mount folder
Review URL: http://codereview.chromium.org/6969007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in root dir
BUG=chromium-os:14855,chromium-os:14955
TEST=manual testing in chromeos-chrome on linux
Review URL: http://codereview.chromium.org/6969008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:14737
TEST=None
Review URL: http://codereview.chromium.org/6943001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also added an OWNERS file with myself and kbr.
TEST=build locally, try
BUG=none
Review URL: http://codereview.chromium.org/6931017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84661 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:14220
TEST=None
Review URL: http://codereview.chromium.org/6871042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
subdomains from turning on mode="strict" HSTS.
TEST=TransportSecurityStateTest.OverrideBuiltins
Review URL: http://codereview.chromium.org/6965001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Add IME UI related extension API. We will use it to show IME candidates in a chrome extension.
BUG=none
TEST=seaboard
Review URL: http://codereview.chromium.org/6869024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84658 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make contents margins of BorderContents configurable;
- Use half the corner radius as BrowserBubble's contents margins;
BUG=80416
TEST=Verify fix for issue 80416.
Review URL: http://codereview.chromium.org/6953005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=79113
TEST=On FutureCat, browse around for a few minutes, opening multiple tabs and switching applications. Try to quit Chromium. It quits.
Review URL: http://codereview.chromium.org/6971002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84655 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
In ZIP heuristic patter, there is "cp". But it is too short and it matches first/last name fiels. So I change it to "^cp$".
"secondname" was a specified as last name. So I added.
BUG=76332,76331
TEST=1, put yahoo and super shuttle grabber input files. 2.run browser_tests --gtest_filter=*.DataDrivenHeuristics and see the inferred results.
Review URL: http://codereview.chromium.org/6954010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
On current open source drivers (1.9.2.901 intel and radeon pulled from X-edgers PPA), glXGetFBConfigFromVisualSGIX is not working as expected even though glxinfo lists GLX_SGIX_fbconfig as a supported extension. Rather than abort when this function fails, this simple patch tries the second code path provided when glXGetFBConfigFromVisualSGIX is unsupported.
BUG=none
TEST=by hand on Linux with 3D CSS
Review URL: http://codereview.chromium.org/6969002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Supports DRAG_COPY to other views/windows.
Supports DRAG_MOVE within the same view.
Fix DropHelper coordinate translation (not used elsewhere).
Fix NativeTextfieldViewsTest.DoubleAndTripleClickTest.
This patch set depends on my changes at:
http://codereview.chromium.org/6893096/
BUG=72040
TEST=--enable-textfield-views drag and drop interaction.
Review URL: http://codereview.chromium.org/6902145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84652 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
functional change should be that DownloadItem::Completed() now effectively DCHECK()s that |all_data_saved_| is true before returning, which I think is a correct assertion.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6935031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=74841
TEST=QuotaFileUtilTest.*
Review URL: http://codereview.chromium.org/6903067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=81014
TEST=New DownloadHistoryCheck test.
Review URL: http://codereview.chromium.org/6911036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
doesn't want them drawn. This will hopefully fix a layout problem in Chrome Frame, which can't overlap the infobar container with anything above it the way Chrome can.
BUG=81749
TEST=Chrome frame infobars don't result in black gaps above them
Review URL: http://codereview.chromium.org/6956005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
InfoBarContainerController::removeAllInfoBars() does not necessarily close the infobars. Add comments to this effect and fix the test to not leak.
Along the way I found what looks like potential memory corruption if you start an infobar closing and then switch tabs away before it finishes closing, so fix that too. There may still be problems when closing the browser while closing an infobar but I don't care as much about those if so. Ultimately my infobar rewrite should fix those.
BUG=81652
TEST=none
Review URL: http://codereview.chromium.org/6928046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84646 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
::GetAvailableFieldTypes() to be clearer.
GetPossibleFieldTypes() -> GetMatchingTypes().
GetAvailableFieldTypes() -> GetNonEmptyTypes().
BUG=81767
TEST=None
R=dhollowa@chromium.org,isherman@chromium.org
Review URL: http://codereview.chromium.org/6970005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The dependencies should be OK here, because the parts that depend on
'<(PRODUCT_DIR)/nacl_irt_*' also depend on '<(PRODUCT_DIR)/chrome',
and this target has the side effect of installing 'nacl_irt_*' into
'<(PRODUCT_DIR)'.
BUG=http://code.google.com/p/nativeclient/issues/detail?id=1595
TEST=not sure how to test this, apart from manually testing the
install images that are produced after this is committed
Review URL: http://codereview.chromium.org/6970002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84644 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=80323
TEST=none
Review URL: http://codereview.chromium.org/6963004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84643 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6960005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
--rename-chrome-exe command lines.
BUG=79935
TEST=Install version N-1 w/ --verbose-logging --chrome --chrome-frame --multi-install --ready-mode --system-level, navigate to gcf:about:version in IE, then install version N with same args. Inspect chrome_frame_installer.log and note the lack of validation errors. Close IE and note that the update completes and all "opv" and "cmd" values are removed from the various ClientState keys.
Review URL: http://codereview.chromium.org/6951016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6970003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=80755
TEST=Just make sure chrome compiles.
Review URL: http://codereview.chromium.org/6948011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84638 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We can tell which error from stack trace.
BUG=chromium-os:15002
TEST=none
Review URL: http://codereview.chromium.org/6952013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84636 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6963001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The error messages shown to the user when the preview fails (plugin does not exist,
initiator tab closed) are shown at the same location where "Preview loading..." is shown.
Also the same fonts/style is being used.
BUG=NONE
TEST=Invoke one of the error cases and examine the error messages
Review URL: http://codereview.chromium.org/6952016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Leak occurred when changing host's screen resolution.
BUG=None
TEST=Valgrind bots stay green
Review URL: http://codereview.chromium.org/6951010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84633 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
- Use SkPDFDeviceFactory instead of duplicating it's functionaily (which changed in this roll).
BUG=79519
TEST=NONE
Review URL: http://codereview.chromium.org/6965009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
http://codereview.chromium.org/6975002/
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Recent changes to Autofill required some modifications to the input
data files for this pyauto test. The test should now pass, and is
being re-enabled.
BUG=77969
TEST=None
Review URL: http://codereview.chromium.org/6952002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=PrerenderBrowserTest.*
Review URL: http://codereview.chromium.org/6969001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it possible to build Chromium when download_nacl_irt.py has
not been run.
BUG=http://bugs.gentoo.org/show_bug.cgi?id=366413
TEST=none
Review URL: http://codereview.chromium.org/6968007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84627 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71097
TEST=compiles
Review URL: http://codereview.chromium.org/6953004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84626 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=81836
TEST=as in bug
Review URL: http://codereview.chromium.org/6956008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added SubmenuView::set_minimum_preferred_width() to put an optional
lower bound on menu width (default 0 for no lower bound) for
MenuItemView menus.
This CL originally included a minimum width setting for the ChromiumOS network status menu, but the network status menu conversion from Menu2 was reverted. Since the change is also needed for ComboBox I am handling it separately.
BUG=chromium-os:12988
TEST=none
Review URL: http://codereview.chromium.org/6900028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(now with correct base URL, so hopefully commit-bot will pick this up)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6961005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84623 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=run script when the "native_client" dir is not present; check warning
Review URL: http://codereview.chromium.org/6966012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84622 0039d316-1c4b-4281-b951-d872f2087c98
|