summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Migrate Event API methods to Google Style.ben@chromium.org2011-02-0949-229/+208
| | | | | | | | | BUG=72040 TEST=none Review URL: http://codereview.chromium.org/6480001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74377 0039d316-1c4b-4281-b951-d872f2087c98
* views: Move more layout constants to the views namespace. Part 2.tfarina@chromium.org2011-02-0926-57/+66
| | | | | | | | | | | The other constants will be moved in future patches. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6458014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74372 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit rev from r78092 to r78132.zmo@google.com2011-02-091-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=hamaji Review URL: http://codereview.chromium.org/6471007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74368 0039d316-1c4b-4281-b951-d872f2087c98
* Invalidate fullscreen when a new client connects to chromoting hosthclam@chromium.org2011-02-097-4/+31
| | | | | | | | | BUG=72252 TEST=Reconnect and screen looks right Review URL: http://codereview.chromium.org/6469004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74365 0039d316-1c4b-4281-b951-d872f2087c98
* BUG=71824rohitbm@google.com2011-02-091-0/+1
| | | | | | Review URL: http://codereview.chromium.org/6483005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74364 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from RVH's run Javascript command.avi@chromium.org2011-02-0929-120/+145
| | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6458013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74362 0039d316-1c4b-4281-b951-d872f2087c98
* Add --show-composited-layer-borders to about:flags.amarinichev@google.com2011-02-092-0/+13
| | | | | | | | | | BUG=60196 TEST=enabled composited-layer-borders entry in about_flags.cc and checked layer borders appear/disappear accordingly. Review URL: http://codereview.chromium.org/6458020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74361 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganized phone field parsing, fixing parsing for fax numbers in the ↵georgey@chromium.org2011-02-0912-211/+295
| | | | | | | | | | process - bug "Fax number is populated wrong" BUG=63736 TEST=Form in the bug + unit-tested. Review URL: http://codereview.chromium.org/6286127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74360 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of BaseTabStrip::GetPreferredHeightrjkroege@google.com2011-02-0910-22/+4
| | | | | | | | | | | | | | | | In an ongoing effort to simplify BaseTabStrip, I observed that GetPreferredHeight is an extra method of the BaseTabStrip base class that is only used to retrieve the height quantity of the GetPreferredSize. GetPreferredSize is a View method, so I changed the callers to call GetPreferredSize().height() instead and removed this method. In a subsequent CL, I plan to refactor so that the frames can interface to view::Views::GetPreferredSize instead of BaseTabStrip::GetPreferredHeight, thus generalizing the interface and reducing dependency on BaseTabStrip and its design. This first step just cleans up BaseTabStrip. The next CL will simplify the frame views. BUG=None TEST=None Review URL: http://codereview.chromium.org/6312196 Patch from Chad Faragher <wyck@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74356 0039d316-1c4b-4281-b951-d872f2087c98
* Display more information at chrome://net-internals/#spdyrch@chromium.org2011-02-097-4/+261
| | | | | | | | | | | | In particular, list the mapping from host:port to port:alternate-protocol and the global spdy configuration state. BUG=none TEST=chrome://net-internals/#spdy Review URL: http://codereview.chromium.org/6465001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74355 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 74344 - BackingStoreSkia: Use skia for painting in ↵rjkroege@google.com2011-02-0910-4/+22
| | | | | | | | | | | | | | | | | | | RenderWidgetHostViewViews. Instead of directly painting to X, paint to the skia canvas from RWHVV. This will make it easier to apply transformation to views in a uniform way, without requiring any special-casing for RWHVV. BUG=none TEST=none Review URL: http://codereview.chromium.org/6246129 Patch from Chad Faragher <wyck@chromium.org>. TBR=rjkroege@google.com Review URL: http://codereview.chromium.org/6476012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74352 0039d316-1c4b-4281-b951-d872f2087c98
* linux: hide more warnings in third-party codeevan@chromium.org2011-02-091-0/+5
| | | | | | | | | | | I was confused why we were getting warnings related to format strings, since they are off in gcc unless you use -Wall or explicitly enable it, but it turns out that the man page calls out that it is specially enabled on Ubuntu. Review URL: http://codereview.chromium.org/6469002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74351 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmarks manager: Fix add pagearv@chromium.org2011-02-091-10/+18
| | | | | | | | | | | | | | | This should have been part of r73377 which fixes this for "Add page" but I forgot to fix "Add folder" BUG=72476 TEST=Go to bookmarks manager Go to a folder with enough items to show a scrollbar Right click and "Add Folder" The folder should be editable. Review URL: http://codereview.chromium.org/6476003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74350 0039d316-1c4b-4281-b951-d872f2087c98
* Really don't show the set Adobe Reader by default infobar. Also don't show ↵jam@chromium.org2011-02-094-12/+36
| | | | | | | | it again if the user clicks No. Review URL: http://codereview.chromium.org/6476001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74346 0039d316-1c4b-4281-b951-d872f2087c98
* PhishingClassifierDelegate test cleanup, and fix a bug with session history ↵bryner@chromium.org2011-02-092-25/+9
| | | | | | | | | | | | | | | navigation. As of r74028, the RenderView will send notifications directly to the PhishingClassifierDelegate that we are using in the test. As a result, we don't need to explicitly send DidCommitProvisionalLoad notifications to the delegate; the RenderView is doing that for us. As a side-effect of replacing these one-off notifications with real navigations, I also noticed a problem where pending classifications are not cancelled on back/forward/reload because these are not new navigations. This CL fixes that as well. BUG=none TEST=PhishingClassifierDelegateTest Review URL: http://codereview.chromium.org/6425003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74345 0039d316-1c4b-4281-b951-d872f2087c98
* BackingStoreSkia: Use skia for painting in RenderWidgetHostViewViews.rjkroege@google.com2011-02-0910-22/+4
| | | | | | | | | | | | | | Instead of directly painting to X, paint to the skia canvas from RWHVV. This will make it easier to apply transformation to views in a uniform way, without requiring any special-casing for RWHVV. BUG=none TEST=none Review URL: http://codereview.chromium.org/6246129 Patch from Chad Faragher <wyck@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74344 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at: Splits ChromeURLDataManager into 2 chunks:sky@chromium.org2011-02-0960-856/+831
| | | | | | | | | | | | | | | | | | | | | | . ChromeURLDataManager is no longer a singleton and is always used on the UI thread. ChromeURLDataManager is now profile specific (you get from the profile). . ChromeURLDataManagerBackend handles the URLRequests and the DataSources. ChromeURLDataManagerBackend is created by ChromeURLRequestContext. All DataSources are now profile specific. There were two that wanted to be global, but have been converted. This differs from the version I landed in that there is now a NULL check in ChromeURLDataManager::DeleteDataSources. BUG=52022 71868 TEST=none TBR=willchan, evan, ahendrickson Review URL: http://codereview.chromium.org/6462036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74340 0039d316-1c4b-4281-b951-d872f2087c98
* Several bits of cleanup in FileSystem*URLRequestJob:adamk@chromium.org2011-02-095-21/+20
| | | | | | | | | | | | - Remove startup_error_ member and delayed error reporting; URLRequestJob properly enqueues NotifyDone calls so that they complete after Start() runs. - Remove origin_url_ members, replace with locals. - Re-organize .h file to call out FilterContext method. Review URL: http://codereview.chromium.org/6458011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74339 0039d316-1c4b-4281-b951-d872f2087c98
* Disable passwords tests failing because password infobar doesn't show upnirnimesh@chromium.org2011-02-091-1/+10
| | | | | | | | | | BUG=70694 TEST= Review URL: http://codereview.chromium.org/6246021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74336 0039d316-1c4b-4281-b951-d872f2087c98
* Reconcile the sync protos with the server-side version.albertb@chromium.org2011-02-091-1/+6
| | | | | | | | | BUG=68572 TEST=none Review URL: http://codereview.chromium.org/6461025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74335 0039d316-1c4b-4281-b951-d872f2087c98
* Blacklist ATI Radeon HD2400.zmo@google.com2011-02-091-1/+13
| | | | | | | | | | BUG=68859 TEST=none TBR=vangelis Review URL: http://codereview.chromium.org/6482003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74333 0039d316-1c4b-4281-b951-d872f2087c98
* Lower process priorities of backgrounded tabs on restoredavemoore@chromium.org2011-02-094-9/+21
| | | | | | | | | BUG=chromium-os:10876,chromium-os:10924 TEST=login (w/auto restore) with a large number of tabs. Verify that system is still responsive. Review URL: http://codereview.chromium.org/6459003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74332 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmarks manager: Fix show in folder to select the itemarv@chromium.org2011-02-091-1/+2
| | | | | | | | | | | | BUG=51056 TEST=Go to bookmarks manager Search for something Right click one of the items and click "Show in folder" The item should be selected after we have navigated to the folder. Review URL: http://codereview.chromium.org/6478002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74331 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup more test code.erg@google.com2011-02-0948-775/+1328
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6462015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74328 0039d316-1c4b-4281-b951-d872f2087c98
* They're no longer flaky according to flakiness dashboard.oshima@google.com2011-02-092-5/+2
| | | | | | | | | BUG=chromium-os:7306 TEST=the test is no longer flaky Review URL: http://codereview.chromium.org/6465015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74327 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Kill a zombie left by BookmarkAppleScriptTest.rsesek@chromium.org2011-02-092-2/+8
| | | | | | | | | | | | | In the ctor, |-[NSApp delegate]| is set to a test-local object but is not nil-ed at destruction, so a zombie is left as the app's delegate. This can ultimately lead to a crash. BUG=72446 TEST=Nondeterministic, but all unit_tests pass. Review URL: http://codereview.chromium.org/6458031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74326 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit rev from r78050 to r78092zmo@google.com2011-02-091-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=hamaji Review URL: http://codereview.chromium.org/6479001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74325 0039d316-1c4b-4281-b951-d872f2087c98
* Fix submenu arrow position for RTLoshima@google.com2011-02-095-18/+45
| | | | | | | | | | | | | Flip the direction of submenu arrow for RTL BUG=chromium-os:5593 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=74171 Review URL: http://codereview.chromium.org/6428001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74324 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes issue that if we don't simulate a disabledgman@chromium.org2011-02-091-4/+7
| | | | | | | | | | | | | vertex attrib 0 (as in the case of running on top of OpenGL ES 2.0 or ANGLE) then we actually have to disable it. TEST=updated webgl conformance tests. BUG=71960 Review URL: http://codereview.chromium.org/6456016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74323 0039d316-1c4b-4281-b951-d872f2087c98
* Change logic that decides when to switch processes when crossing extensionmpcomplete@chromium.org2011-02-091-10/+17
| | | | | | | | | | | | | | boundaries: - Add back in a check that allows switching on browser-initiated redirects (that I removed since it was unnecessary for the webstore). Turns out it is needed for legitimate cases. BUG=70943 TEST=no Review URL: http://codereview.chromium.org/6272020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74320 0039d316-1c4b-4281-b951-d872f2087c98
* Only show notification for low 3g data for the last data-based plan.chocobo@chromium.org2011-02-096-71/+207
| | | | | | | | BUG=chromium-os:10010 TEST=manual Review URL: http://codereview.chromium.org/6347044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74319 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for process handle leaks which occured while closing a tab. These ↵ananta@chromium.org2011-02-091-0/+1
| | | | | | | | | | | | | | | | | | handles are opened in the BrowserMessageFilter when the channel is connected and never closed. There are a number of handles leaked for every tab as there are a number of message filter objects in the browser process inheriting from the BrowserMessageFilter class. Fixes bug http://code.google.com/p/chromium/issues/detail?id=67429 BUG=67429 TEST=As described in the bug. Review URL: http://codereview.chromium.org/6456021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74317 0039d316-1c4b-4281-b951-d872f2087c98
* Streamline WebUI options string registration.estade@chromium.org2011-02-093-125/+144
| | | | | | | | | | | start with AdvancedOptionsHandler BUG=none TEST=none Review URL: http://codereview.chromium.org/6459016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74316 0039d316-1c4b-4281-b951-d872f2087c98
* GPU blacklist reporting to about:gpu page.nduca@chromium.org2011-02-092-0/+11
| | | | | | | | | | BUG=71879 TEST= Review URL: http://codereview.chromium.org/6460016 Patch from John Bates <jbates@chromiu.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74315 0039d316-1c4b-4281-b951-d872f2087c98
* Back out trunk r74303 - GYP goes back to r874 again. This caused the Windowsmark@chromium.org2011-02-091-1/+1
| | | | | | full builder to fail. Again. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74314 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome.google.com to the STS list.cevans@chromium.org2011-02-091-0/+1
| | | | | | | | | | | It's very sensitive and already resolutely https-only, but putting it on the list will defend against additional slip-ups such as some mixed-content errors. BUG=None TEST=None Review URL: http://codereview.chromium.org/6410113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74310 0039d316-1c4b-4281-b951-d872f2087c98
* Add PrerenderBrowserTest.PrerenderPopup.cbentzel@chromium.org2011-02-092-0/+22
| | | | | | | | | | | This validates that a prerendered page is canceled if it tries to create a popup through window.open() BUG=71212 TEST=browser_test --gtest_filter="PrerenderBrowserTest.PrerenderPopup" Review URL: http://codereview.chromium.org/6462011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74309 0039d316-1c4b-4281-b951-d872f2087c98
* Corrected plugin_check test for Windows Chromerohitbm@google.com2011-02-091-1/+10
| | | | | | Review URL: http://codereview.chromium.org/6462018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74307 0039d316-1c4b-4281-b951-d872f2087c98
* Blacklist ATI RadeonHD2600 on Mac.zmo@google.com2011-02-091-1/+13
| | | | | | | | | | BUG=68859 TEST=none TBR=vangelis Review URL: http://codereview.chromium.org/6461027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74306 0039d316-1c4b-4281-b951-d872f2087c98
* Move Event files into views/eventsben@chromium.org2011-02-0950-55/+55
| | | | | | | | | | BUG=none TEST=none TBR=sky Review URL: http://codereview.chromium.org/6459024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74305 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the histograms for prerendering to have thetburkard@chromium.org2011-02-091-8/+7
| | | | | | | | | | prefix Prerender BUG=none TEST=none Review URL: http://codereview.chromium.org/6462031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74304 0039d316-1c4b-4281-b951-d872f2087c98
* Update GYP to r882 to pick up r881:mark@chromium.org2011-02-091-1/+1
| | | | | | | | | | | | | | | | | | | | | The new postbuild step in Chromium's third_party/WebKit/Source/WebCore/WebCore.gyp/WebCore.gyp:webcore_svg is running before libwebcore_svg.a exists in clobber debug builds. Explicitly declaring a target's intended output (linkable or static library) as an input to the postbuild shell script action forces the postbuild to wait for the link step to complete. Because no outputs are declared, the postbuild step will still run each time the target is built, which is the desired behavior. This was previously attempted in r74191, but had to be reverted in r74198 because it caused Windows clobber build failures. The offending change to GYP, r880, was backed out at r882. BUG=none TEST=Clean Chromium build on Mac and Windows Review URL: http://codereview.chromium.org/6467001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74303 0039d316-1c4b-4281-b951-d872f2087c98
* Things required to support policy for login screen.dilmah@chromium.org2011-02-096-18/+66
| | | | | | | | | | | Added DLOGs to pref_service in order to detect pieces of code that still may not care about managed settings. BUG=chromium-os:11807 TEST=Manual Review URL: http://codereview.chromium.org/6447008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74302 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Don't let pages intercept top-row keys.derat@chromium.org2011-02-095-10/+39
| | | | | | | | | | | | | | | | This prevents keys F1 through F10 on Chrome OS devices (Back, Forward, Reload, and Fullscreen plus friends) from getting intercepted by web pages. These keys are explicitly labeled with icons for these functions, so it seems reasonable for users to expect that they'll work at all times. BUG=chromium-os:9605 TEST=went to a plexode page that had a "return false" handler for onkey{down,press,up} and checked that the top-row keys worked as intended Review URL: http://codereview.chromium.org/6312170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74301 0039d316-1c4b-4281-b951-d872f2087c98
* Fullscreen mode should disable some keyboard shortcuts, however we enter it.skerner@chromium.org2011-02-091-2/+7
| | | | | | | | | BUG=68800 TEST=Manual Review URL: http://codereview.chromium.org/6386031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74300 0039d316-1c4b-4281-b951-d872f2087c98
* Disable user whitelist when "Restrict sign-in..." checkbox is off.xiyuan@chromium.org2011-02-091-6/+30
| | | | | | | | | | | | User whitelist is only enabled when current user is owner and "Restrict sign-in.." checkbox is on. BUG=chromium-os:11840 TEST=Sign-in as owner and go to user settings page, the user list should be disabled when "Restrict sign-in..." checkbox is off and enabled when it is checked. Review URL: http://codereview.chromium.org/6462012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74299 0039d316-1c4b-4281-b951-d872f2087c98
* Remove expectations of failure, leftover from my gardening shift.dglazkov@chromium.org2011-02-091-3/+0
| | | | | | | | | | TBR=zmo TEST=none BUG=none Review URL: http://codereview.chromium.org/6458030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74298 0039d316-1c4b-4281-b951-d872f2087c98
* chrome.management.launchApp() should choose the window type for the app ↵skerner@chromium.org2011-02-0914-21/+271
| | | | | | | | | | | based on user prefs. BUG=70191 TEST=ExtensionManagementApiTest.Launch*App Review URL: http://codereview.chromium.org/6368139 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74297 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression where the wrong url was getting added for instantsky@chromium.org2011-02-094-2/+25
| | | | | | | | | | | navigations to the default search provider. BUG=72353 TEST=covered by test now, can also see bug for details. Review URL: http://codereview.chromium.org/6462023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74296 0039d316-1c4b-4281-b951-d872f2087c98
* Fix presentation of infobar for non-warning messages. Their colour isrogerta@chromium.org2011-02-093-0/+10
| | | | | | | | | | | | | | | currently yellow, but should be blue like other non-warning messages. The bug mentions 3 infobars: save passwords, did you mean..., and always restore. However, save passwords is already the correct colour, so I only needed to fix the two others. BUG=9037 TEST=Force the display of the corresponding infobar and look at the colour. Review URL: http://codereview.chromium.org/6312188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74295 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 21:45:41 +0000