summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Defer window.close(), window.resizeTo(), and window.moveTo()mbelshe@google.com2009-05-044-4/+71
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | actions by posting a task back to the message loop before notifying the RenderWidgetHost to perform these operations. Otherwise, the JS code races with the browser to use the modified window. BUG=http://crbug.com/6377 BUG=http://crbug.com/6192 Also, because window resizing is asynchronous between the renderer and browser, added a renderer-side cache of "pending window rect" to ChromeClientImpl. Before the change, calling setWindowRect() would schedule a call to the RenderViewHost to do the work, but a subsequent call to windowRect() would return the current size, as through the call to setWindowRect() had never happened. We cache a pending size and then schedule a task on the message loop to clear the cached size. This allows javascript which writes and reads the WindowRect sizes to work, and once we come out of JS and return to the message loop, we'll go back to asking the RenderViewHost for the true values. This pending_window_size is my only concern about this patch. It does pass all layout tests, and the ChromeClientImpl code is executed in the test_shell.exe code path. BUG=http://crbug.com/835 TEST=LayoutTests have tests which cover all of these actions. The problem is that we run layout tests using the test_shell, not Chrome. Review URL: http://codereview.chromium.org/101019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15214 0039d316-1c4b-4281-b951-d872f2087c98
* Remove "output=chrome" as the Suggest team has deprecated it server-side.pkasting@chromium.org2009-05-041-3/+2
| | | | | | | BUG=1660988 Review URL: http://codereview.chromium.org/102024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15212 0039d316-1c4b-4281-b951-d872f2087c98
* Reset the omnibox contents when the user reloads the page. Patch by Yusuke ↵pkasting@chromium.org2009-05-049-0/+25
| | | | | | | | Sato (see http://codereview.chromium.org/100198 ), r=me. BUG=2985 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15211 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Wire existing shortcutto out of process devtools.pfeldman@chromium.org2009-05-041-16/+20
| | | | | | Review URL: http://codereview.chromium.org/99345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15210 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the static next_id_ counter, to make construction of ProxyConfig ↵ericroman@google.com2009-05-044-19/+38
| | | | | | | | | on different threads safe. BUG=11323 Review URL: http://codereview.chromium.org/102023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15209 0039d316-1c4b-4281-b951-d872f2087c98
* Delete unused stuff from basictypes.h.willchan@chromium.org2009-05-041-13/+0
| | | | | | Review URL: http://codereview.chromium.org/99348 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15208 0039d316-1c4b-4281-b951-d872f2087c98
* Update known list based on WebContent->TabContenthuanr@chromium.org2009-05-041-3/+3
| | | | | | | | | | change. BUG=11408 Review URL: http://codereview.chromium.org/99347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15207 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Implement search in scripts.pfeldman@chromium.org2009-05-044-2/+57
| | | | | | Review URL: http://codereview.chromium.org/100332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15206 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two Linux canvas related bugs.sky@chromium.org2009-05-043-7/+33
| | | | | | | | | | | | | | | . The platform paint was allocating at a size bigger than necessary. . ChromeCanvas::DrawStringInt was not taking into account the matrix on the canvas, which means the text could be drawn at the wrong location. BUG=none TEST=none Review URL: http://codereview.chromium.org/99279 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15205 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some recently small size / position regressions in Linux Omnibox.deanm@chromium.org2009-05-042-2/+2
| | | | | | | Review URL: http://codereview.chromium.org/100343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15204 0039d316-1c4b-4281-b951-d872f2087c98
* Add a crash case of 10901 to known listhuanr@chromium.org2009-05-041-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15203 0039d316-1c4b-4281-b951-d872f2087c98
* Fix find in page. When fixing the conflict after updating, I accidentallybrettw@chromium.org2009-05-041-0/+5
| | | | | | | removed the code that updates the find in page commands. Review URL: http://codereview.chromium.org/100331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15202 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a regression that the sad tab favicon is not displayed when a tab crashes.brettw@chromium.org2009-05-042-2/+8
| | | | | | | | | | | | | | This regressed in my favicon/title updating change because the crashed state is not updated on the codepath, since it comes from the tab. The other approach would have been to make this call through the "update everything" codepath for tbe state changing, but that's executed on a timer, and it's nice to show the tab crash right away since the check is very inexpensive. BUG=http://crbug.com/10756 Review URL: http://codereview.chromium.org/99341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15201 0039d316-1c4b-4281-b951-d872f2087c98
* Now it's possible to evaluate expressions in the debugger console.yurys@google.com2009-05-043-37/+105
| | | | | | Review URL: http://codereview.chromium.org/99340 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15200 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: switch from CppBound* to pure v8 bindings in WebDevToolsClient ↵pfeldman@chromium.org2009-05-043-53/+110
| | | | | | | | host functions. Review URL: http://codereview.chromium.org/100254 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15199 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Support XmlHTTPRequests sniffing.pfeldman@chromium.org2009-05-043-3/+28
| | | | | | Review URL: http://codereview.chromium.org/100262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15198 0039d316-1c4b-4281-b951-d872f2087c98
* More linux build fixesbrettw@chromium.org2009-05-041-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15197 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux build.brettw@chromium.org2009-05-041-1/+1
| | | | | | Review URL: http://codereview.chromium.org/99339 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15196 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the mac build from my WebContents rename.brettw@chromium.org2009-05-042-3/+2
| | | | | | Review URL: http://codereview.chromium.org/100329 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15195 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all occurrances of WebContents with TabContents.brettw@chromium.org2009-05-04184-1423/+1219
| | | | | | Review URL: http://codereview.chromium.org/99177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15194 0039d316-1c4b-4281-b951-d872f2087c98
* linux: set the window icon (used in alt-tab list, etc.)evan@chromium.org2009-05-042-0/+13
| | | | | | | | BUG=11354 Review URL: http://codereview.chromium.org/100303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15192 0039d316-1c4b-4281-b951-d872f2087c98
* roll back r15177ben@chromium.org2009-05-04154-840/+218
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15191 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15178.ben@chromium.org2009-05-041-50/+0
| | | | | | Review URL: http://codereview.chromium.org/100325 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15190 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15179.ben@chromium.org2009-05-041-1/+0
| | | | | | Review URL: http://codereview.chromium.org/100324 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15189 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15180.ben@chromium.org2009-05-0412-225/+99
| | | | | | Review URL: http://codereview.chromium.org/100323 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15188 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15181.ben@chromium.org2009-05-041-2/+1
| | | | | | Review URL: http://codereview.chromium.org/100322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15187 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15182.ben@chromium.org2009-05-0479-238/+174
| | | | | | Review URL: http://codereview.chromium.org/101024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15186 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15183.ben@chromium.org2009-05-041-1/+1
| | | | | | Review URL: http://codereview.chromium.org/99336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15185 0039d316-1c4b-4281-b951-d872f2087c98
* linux: obey proxy environment variables in preference to gconfevan@chromium.org2009-05-042-1/+25
| | | | | | | | | | | This fixes a tiny bug, where we were consulting gnome's settings based on whether the DESKTOP_SESSION *wasn't* gnome. TEST=Covered by new unit test. Review URL: http://codereview.chromium.org/100318 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15184 0039d316-1c4b-4281-b951-d872f2087c98
* Only include views_resources.h on Windows, since it looks like Linux is ↵ben@chromium.org2009-05-041-1/+1
| | | | | | still building this file. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15183 0039d316-1c4b-4281-b951-d872f2087c98
* Bustage fix:ben@chromium.org2009-05-0479-174/+238
| | | | | | | | | | Add back these files which I removed earlier since Linux is using them. The resources are duplicate until I collapse them into src/app/ later this week. Review URL: http://codereview.chromium.org/100320 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15182 0039d316-1c4b-4281-b951-d872f2087c98
* Make the header include of views_strings.h here windows-only, temporarily ↵ben@chromium.org2009-05-041-1/+2
| | | | | | (we duplicate the strings in generated_resources.h) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15181 0039d316-1c4b-4281-b951-d872f2087c98
* Bustage fix for mac and linux:ben@chromium.org2009-05-0412-99/+225
| | | | | | | | | | Duplicate views strings and rename them to uniquify them to get mac and linux going again. TODO(beng): move these strings into the forthcoming app/ dependency so that mac linux and windows can rely on it. Review URL: http://codereview.chromium.org/99335 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15180 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage because of missing dep from theme_dll on views_resources.ben@chromium.org2009-05-041-0/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15179 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustage by establishing dependencies correctly.ben@chromium.org2009-05-041-0/+50
| | | | | | Review URL: http://codereview.chromium.org/99334 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15178 0039d316-1c4b-4281-b951-d872f2087c98
* Extract all views resources into:ben@chromium.org2009-05-04154-218/+840
| | | | | | | | | | | | | views_strings.[grd,vcproj] views_resources.[grd,vcproj] Moves views images (.png files) from app/theme to views/resources dir. http://crbug.com/11387 Review URL: http://codereview.chromium.org/100317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15177 0039d316-1c4b-4281-b951-d872f2087c98
* Blind fix for ChromeBot crashes.mal@chromium.org2009-05-031-1/+3
| | | | | | | | | | | | | | | | | | | | | A ChromeBot run for 172.17 was very top heavy (77/103 crashes) with: [vector:703] std::vector<PasswordManagerTableModel::PasswordRow *,std::allocator<PasswordManagerTableModel::PasswordRow *> >::size() [browser_init.cc:140] `anonymous namespace'::NotifyNotDefaultBrowserTask::Run() [message_loop.cc:308] MessageLoop::RunTask(Task *) I'm going to try a null check on |tab| before we invoke tab->infobar_delegate_count(). This applies the change made to 172 to trunk. TBR= jcampan,ben BUG= 11388 Review URL: http://codereview.chromium.org/99331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15176 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two bugs in the omnibox2 popup:ben@chromium.org2009-05-031-11/+12
| | | | | | | | | - popup frequently flashes white after being updated. This was because rows weren't being laid out after being added so they had zero size after async changes to the model. - text ran off the right side because DrawStringFragment wasn't clamping the output width to the available width. Does this now, and so eliding works. Review URL: http://codereview.chromium.org/101023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15171 0039d316-1c4b-4281-b951-d872f2087c98
* Fix multiple instances of first run dialog appearing when Chrome is started ↵robertshield@google.com2009-05-037-25/+55
| | | | | | | | | | again while a first run dialog is visible. Also cause the original first run dialog to come to foreground. BUG=http://crbug.com/10765 Review URL: http://codereview.chromium.org/99281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15170 0039d316-1c4b-4281-b951-d872f2087c98
* linux: fix shared build.evan@chromium.org2009-05-021-0/+9
| | | | | | Review URL: http://codereview.chromium.org/99316 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15144 0039d316-1c4b-4281-b951-d872f2087c98
* Fix more paint bugs in the transparent renderview code.aa@chromium.org2009-05-021-11/+4
| | | | | | | | This was causing the green glitchiness on mouseover. Review URL: http://codereview.chromium.org/100298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15143 0039d316-1c4b-4281-b951-d872f2087c98
* Allowing the client to handle escape and keyup events.tommi@google.com2009-05-025-17/+52
| | | | | | Review URL: http://codereview.chromium.org/99293 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15142 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the following CL (it was breaking the UI tests because ajcampan@chromium.org2009-05-027-3/+149
| | | | | | | | | | | | | | | | | | | | | | | | | NOTREACHED() would be triggered in that case). If Chrome is not the default browser, tell the user, unless: - it is the first run - the user already said not to warn him/her about it - an info-bar is already showing. BUG=9049 TEST=Run a new install of chrome, proceed through the first run flow, don't make Chrome your default browser. No info-bar warning about Chrome not being the default browser should be shown. Restart Chrome, such an info-bar should be shown. Click the x on the info-bar to close it. Restart Chrome. The info-bar should be shown. Select "Set as default". Restart Chrome, the info-bar should not be shown. Start IE, make it your default browser (Tools menu, 'Internet option', Programs tab). Restart Chrome, it should show the default browser info-bar. Select "Don't ask me again". Restart Chrome, the info-bar should not be shown. Review URL: http://codereview.chromium.org/100287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15137 0039d316-1c4b-4281-b951-d872f2087c98
* media player props.h file (properties)fbarchard@chromium.org2009-05-021-0/+314
| | | | | | Review URL: http://codereview.chromium.org/99114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15131 0039d316-1c4b-4281-b951-d872f2087c98
* Add suppressions for two mac audio bugs: http://crbug.com/11327dkegel@google.com2009-05-021-14/+34
| | | | | | | | | | broadened a few other suppressions, and split one bug out of 9563 into http://crbug.com/11333 Review URL: http://codereview.chromium.org/99303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15130 0039d316-1c4b-4281-b951-d872f2087c98
* Change names of SDCH related histograms.jar@chromium.org2009-05-023-37/+37
| | | | | | | | | | | | | | | I now have accumulated too many evolutions of histograms for SDCH, and it is getting harder to pull out the most recent set from the lengthly list (and confusing other folks). I've created a new prefix of "Sdch2." rather than "Sdch." for all the histogram names. I also include a few lint fixups on DCHECKs. r=rafaelw Review URL: http://codereview.chromium.org/100275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15129 0039d316-1c4b-4281-b951-d872f2087c98
* Yet more deprecation of the wstring version of PathService::Get() for UI tests.thestig@chromium.org2009-05-0229-161/+147
| | | | | | Review URL: http://codereview.chromium.org/99298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15127 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a gcc 4.3 warning in page_action.h.thestig@chromium.org2009-05-021-2/+2
| | | | | | | Patch from Livio Soares <liviobs@gmail.com>. Review URL: http://codereview.chromium.org/99309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15126 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome/chromium icons as PNGs.ben@chromium.org2009-05-026-7/+20
| | | | | | | | | | | | Also, add support to NativeButton for rendering as default independently of behaving as default. This will be used by the default browser infobar. Adds methods to the infobar delegate interface to allow the delegate to specify that it wants its Accept button to appear as the default button. http://crbug.com/9049 Review URL: http://codereview.chromium.org/100288 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15125 0039d316-1c4b-4281-b951-d872f2087c98
* Various fixes to gmail sample:aa@chromium.org2009-05-012-20/+32
| | | | | | | | | | - Handle the case where we never get a response, which happens if you're not logged in. - Lengthen the poll timeout to something reasonable. Review URL: http://codereview.chromium.org/100270 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15124 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-18 22:32:39 +0000