| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
o bookmark sync while offline.
BUG=19738
TEST=Attempt to log in to bookmark sync while offline. The error should be
"Connection Unavailable"
Review URL: http://codereview.chromium.org/455038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify the test_expectations module so it can still build up a set
of expectations with a test list even if the files don't exist locally.
This is needed by the LTTF dashboard app (which isn't checked in yet).
Also add test_expectations.GetOptions(), which is also needed by the LTTF app.
R=ojan@chromium.org
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/460152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I've long known I needed to fix this, but today I was annoyed enough by it
that I finally did it.
Review URL: http://codereview.chromium.org/477005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=wtc
Review URL: http://codereview.chromium.org/488008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
'Cause, guess what, they work now.
Review URL: http://codereview.chromium.org/492001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The current implementation of Windows-only hook simply calls FAIL.
According to http://code.google.com/p/googletest/issues/list?cursor=234
it is a misuse of FAIL macros (it may not shut down the process).
As a result, it was impossible to write death tests on windows.
BUG=24885
Review URL: http://codereview.chromium.org/482001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34273 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The changes are propagated across open chrome windows, but are not persisted between sessions yet.
BUG=26990
Review URL: http://codereview.chromium.org/463056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
requests in ResourceDispatcherHost until specified conditions are met.
Make UserScriptListener use ResourceQueue.
This is the first step toward waiting for the privacy blacklists to load.
TEST=Covered by unit_tests.
BUG=21541
Review URL: http://codereview.chromium.org/460108
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
it should be a string. Since we tried to get the pref as the wrong
type, we never set the value homepage_defined so it's always false.
Review URL: http://codereview.chromium.org/491008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34270 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Too much red.
BUG=None
TEST=None
TBR=maruel
Review URL: http://codereview.chromium.org/486018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34269 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
At least the format is specified... that's a good thing.
TEST=Covered by net_unittests.
BUG=25520, 29691
Review URL: http://codereview.chromium.org/479004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/479007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
tbr=kbr
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/487013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
they were added. Mark as so in test_expectations.
BUG=29944,29943
TEST=none
Review URL: http://codereview.chromium.org/486016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
renderer.
TEST=NONE
BUG=29828
Review URL: http://codereview.chromium.org/467061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34264 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If javascript code puts custom toJSON functions on Array.prototype, our
extension API code detects malformed requests and kills the offending renderer.
Also, the browser can crash if a browser action popup process dies (for various
reasons, including this json serialization problem).
BUG=29283
TEST=Create an extension with a browser action popup that loads prototype.js, and then calls chrome.tabs.update().
Before this change, the popup bubble will crash, and when you click away, crash the browser too.
Review URL: http://codereview.chromium.org/466065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
we need to inform the stream of the error so that we don't continue
processing through the loop.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/479013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
on the linux bots starting up Apache.
Review URL: http://codereview.chromium.org/487010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=15782
TEST=None
Review URL: http://codereview.chromium.org/418006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34258 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
geolocaiton features.
Once this is landed we can enable GEOLOCATION in WebKit at build time, allowing proper tests
to be written that utilize this flag.
BUG=29182
TEST=Manually enabled GEOLOCATION in WebKit and passed the command line flag.
Review URL: http://codereview.chromium.org/460020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/460020)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/466072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gyp files.
Retrying r34195, this time without libxslt, since we don't want to use the
system version of that if we're not also using system libxml (merged from
http://codereview.chromium.org/481011).
BUG=29738
Review URL: http://codereview.chromium.org/486012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=29994
TEST=none
TBR=albertb
Review URL: http://codereview.chromium.org/486013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/489003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
For Joi: http://codereview.chromium.org/434121
BUG=none
TEST=In privileged mode, set the src attribute to something like "data:text/html,Hello World".
Review URL: http://codereview.chromium.org/487009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Original CL by loislo: http://codereview.chromium.org/492004
Review URL: http://codereview.chromium.org/486011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
need to keep references to instances of the objects after that.
Review URL: http://codereview.chromium.org/491002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
stack traces (the InitHelper is removed now).
Committing this with TBR to fix the Webkit Linux Valgrind bot.
TBR=dank,timurrrr
Review URL: http://codereview.chromium.org/488005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34248 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
app_unittests
browser_tests
startup_tests
media_unittests
printing_unittests
net_unittests
googleurl_unittests
ipc_tests
unit_tests
ui_tests
This patch was originally reviewed as http://codereview.chromium.org/466089
TBR=willchan
Review URL: http://codereview.chromium.org/488004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
extract common utility functions into other files.
TEST=trybot and MacUtilTest in base_unittests
BUG=27310
Review URL: http://codereview.chromium.org/463028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
common_decoder
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/479008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34242 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The logic for creating the client handshake message is substantially
complex so it would be nice to have better test coverage, before it
gets more complex.
TEST=net_unittests
BUG=none
Review URL: http://codereview.chromium.org/473003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- recognize permission listing with ACL indicator as valid
- add one more test for non-ASCII encoding
TEST=Covered by net_unittests.
BUG=25520
Review URL: http://codereview.chromium.org/472003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clean-up suppressions: remove ones that appear to have been fixed,
clarify another to be a known leak by design.
BUG=26966,22923
TEST=valgrind tests (for ui and layout tests)
Review URL: http://codereview.chromium.org/465075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a very small time to live, since we want to be able to respond quickly when formerly unresolvable names become resolvable.
Even such a small time is still useful, since cache misses for unresolvable names can be extremely costly (order of several seconds).
For example, in our corp PAC script, the URL's host is resolved 3 times, so:
Without caching, total runtime is (2.5 seconds) * 3 --> 7.5 seconds.
Whereas with caching it would be: (2.5 seconds) * 1 --> 2.5 seconds
This time to live will need to be tuned as part of bug 25472.
BUG=11079
Review URL: http://codereview.chromium.org/464084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We used to be willing to sniff "safe" mime types from
application/octet-stream, but we ran into compatibility
problems with sites that wanted to use
application/octet-stream to trigger a download. To have
better compatibility with these sites, we've changed our
sniffing algorith to be slightly less agressive.
BUG=29354
Review URL: http://codereview.chromium.org/467035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
flakiness dashboard.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/485007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Added optional line stippling based on texCoords to the rotate1 line ring shader.
- Redesigned the CameraController and added the ability to zoom, dolly, dolly-zoom, and pan using the mouse.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/486003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderViewHostDelegate::View and TabContentsDelegate interfaces.
Significant changes made by this CL:
1. The keyboard event handling code has been moved from TabContentsView implementation classes into BrowserWindow implementation classes.
Please refer to this discussion thread: http://groups.google.com/group/chromium-dev/browse_thread/thread/e6e0b5cc105659b7/9953c4308bb0000c
This change makes the keyboard event flow comply with the relationship between TabContents/TabContentsView and TabContentsDelegate/BrowserWindow.
Besides it, the code is also simplified a lot, for example, the keyboard event handling code in chrome/browser/views/tab_contents/tab_contents_view_{gtk,win}.cc are now merged into one copy and moved into chrome/browser/views/frame/browser_view.cc.
2. A pre-handle phrase has been added into the keyboard event handling flow. A keyboard event will be first sent to the browser for pre-handling before being sent to the renderer. Then if the event was not handled by the renderer, it'll be sent to the browser again for post-handling.
3. The keyboard accelerator handling code of Windows and Linux ports have been optimized to get rid off extra command lookup.
4. The keyboard event message flow between the browser and the renderer is changed back to full async mode, all complex logics introduced by revision 29857 are removed.
BUG=24479, 26054, 26131, 28839
TEST=See bug reports.
Review URL: http://codereview.chromium.org/400012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=eroman
Review URL: http://codereview.chromium.org/482013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the previous CL I made the build of pepper_test_plugin conditional
but forgot to remove the unconditional reference, leaving the build breakage
on Linux.
TBR=jrg,asargent,skylined
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/485008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chromium to chrome or chromeos, and add fpic for arm. remove bsf from all but arm
BUG=29934
TEST=make j6 r player_x11 BUILDTYPE=Release for all platforms and ensure they still link. Use size libffmpegsumo.so to confirm size has been reduced.
Review URL: http://codereview.chromium.org/483007
TBR=fbarchard@chromium.org
Review URL: http://codereview.chromium.org/487005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
34161).
There were problems building Skia and others for the 64-bit linux versions of the
Pepper test plugin, so I have disabled building that plugin except on Windows for now
and added a TODO.
One significant addition to the previous comment lines. The flag enable_gpu=1 now
causes the build definition ENABLE_GPU=1 to allow guarding of dependent code.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/481001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
or chromeos, and add fpic for arm. remove bsf from all but arm
BUG=29934
TEST=make -j6 -r player_x11 BUILDTYPE=Release for all platforms and ensure they still link. Use size libffmpegsumo.so to confirm size has been reduced.
Review URL: http://codereview.chromium.org/483007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original code review: http://codereview.chromium.org/428004
Command line utility to run the HostResolver.
The user provides a list of hosts to resolve, as well as optional timestamps
for when the resolutions should happen. These can be provided on the command
line as additional arguments or in a specified file.
Options:
--async: Specifies that the resolution should happen asynchronously.
--verbose: Spew out extra data.
--cachesize: Size of the DNS cache.
--cachettl: TTL of DNS cache entries in milliseconds.
--inputpath: File containing host name and optional timestamp, one per line.
BUG=NONE
TEST=Built and ran on Linux and Windows. Built on OSX via trybots but not run.
R=eroman
Review URL: http://codereview.chromium.org/485006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The example demonstrates how to use the Slider class.
BUG=none
TEST=manually
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=34142
Review URL: http://codereview.chromium.org/466055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to the OOM killer.
BUG=29752
TEST=During out of memory conditions, Linux kernel picks a plugin/renderer over the browser process.
Review URL: http://codereview.chromium.org/467058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
considerably *more* flaky on windows. Go back to the default number
of workers (0).
Sigh. It was worth a try.
Review URL: http://codereview.chromium.org/489001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=21732
TEST=none
Review URL: http://codereview.chromium.org/489002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34220 0039d316-1c4b-4281-b951-d872f2087c98
|