| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=322664
Review URL: https://codereview.chromium.org/227813002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262769 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Adds comments about the necessity of zero'd memory in mojo allocators.
R=darin@chromium.org
Review URL: https://codereview.chromium.org/229203003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also closes a security hole: the filesystem checks did not properly canonicalize the path, with the result that paths such as "/mnt/sdcard/../../data/data/yourdata" would have been accepted.
BUG=278117
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/23684004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262766 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=304341
R=nasko@chromium.org
Review URL: https://codereview.chromium.org/231063003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262765 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
From 844a42e5f5c7a106807b09b6c2ac6b00b166c1cc to 926038efc28089447a2f9292d7dc8cdc7eff7a36.
BUG=358713
TBR=derat@chromium.org
Review URL: https://codereview.chromium.org/231183003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262763 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
No functionality changes, just clean up.
BUG=none
Review URL: https://codereview.chromium.org/229003002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They were used to get the web_contents, which we pass in directly now.
It would be nice to remove RFH* from RenderViewContextMenu, this CL is first
step towards that.
BUG=304341
Test=Internal only change, nothing visible.
TBR=fsamuel@chromium.org
Review URL: https://codereview.chromium.org/229403002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After a lost context, it used to be the case that a tree wouldn't need
update draw properties (implying no ManageTilings prior to AppendQuads
or MarkVisibleResourcesAsRequired). This meant that if one layer added
a tiling and synced it to its twin, that the tiling state would not be
valid. This synced tiling would be the first tiling, but the resolution
wouldn't be set, causing the tiling state to be bogus.
The way to fix this is to simply set_needs_update_draw_properties when a
PictureLayerImpl loses its resources. This will force tilings to be
created and resolutions set correctly.
BUG=358350
Review URL: https://codereview.chromium.org/229283004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262756 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It failed Win x64 Builder:
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder/builds/17043/steps/compile/logs/stdio
> Improve GN public header file checking
>
> This makes the header checker and include iterator work from InputFiles (which basically just hold the file buffer) rather than just raw strings. This allows us to reference these files from Err.
>
> Some extra line/char tracking is now in the include iterator so we can actually quote from and annotate the place in the source file where the bad include is, which looks much nicer than "the file blah included blah". It also makes it possible to write much shorter error messages that still make sense.
>
> This adds visibility checking as previously documented in the help for "public" and a unit test for that.
>
> This updates the documentation for "public" which was wrong (it referred to patterns which was not used).
>
> R=scottmg@chromium.org
>
> Review URL: https://codereview.chromium.org/229423002
TBR=brettw@chromium.org
Review URL: https://codereview.chromium.org/231293003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=361547
Review URL: https://codereview.chromium.org/230753003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
r1892 Revert "Fix None target type with Ninja build."
r1891 Avoid duplicating non-configuration settings when merging
r1889 Adds xcode-ninja flavor for Xcode wrapper projects.
r1888 Edited wiki page GypHacking through web user interface.
r1887 android: Add support for multiarch builds.
r1886 android: Allow disabling the generation of alias targets.
r1885 android: Remove rule_trigger targets.
r1884 Implements ARCHS filtering for all generator on OS X.
r1883 Fix None target type with Ninja build.
r1882 Enable 64-bit architectures by default for Xcode 5.1 and higher.
r1881 Fix ARCHS selection when building for iOS.
BUG=none
TBR=scottmg@chromium.org
Review URL: https://codereview.chromium.org/230363004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of using a message-pump observer, use an event-handler on Env
to detect when user presses escape, and cancel the drag.
BUG=354062
R=sky@chromium.org
Review URL: https://codereview.chromium.org/228653003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Touch move absorption appears to be having too large of a web compatibility
impact, and there is debate about what the best fix is. So for now go
back to the behavior we've always shipped in the past - sending touchcancel
on the start of scroll.
BUG=360614
Review URL: https://codereview.chromium.org/230733005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes the header checker and include iterator work from InputFiles (which basically just hold the file buffer) rather than just raw strings. This allows us to reference these files from Err.
Some extra line/char tracking is now in the include iterator so we can actually quote from and annotate the place in the source file where the bad include is, which looks much nicer than "the file blah included blah". It also makes it possible to write much shorter error messages that still make sense.
This adds visibility checking as previously documented in the help for "public" and a unit test for that.
This updates the documentation for "public" which was wrong (it referred to patterns which was not used).
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/229423002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=N/A
Review URL: https://codereview.chromium.org/230543002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
BUG=308692
Review URL: https://codereview.chromium.org/212933007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
When opening the supervised user import overlay, we trigger a cursor update to
prevent that it still shows the hand cursor if the mouse is not moved.
BUG=361482
Review URL: https://codereview.chromium.org/230953002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Furthermore, implement BrowsingDataRemoverCompletionObserver in a separate place so it can be re-used by different tests.
BUG=354931
Review URL: https://codereview.chromium.org/230743003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262741 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Added event to networkingPrivate extension that portal detection is completed.
>
> BUG=354946
> TEST=ExtensionNetworkingPrivateApiTest.*
> R=yoz@chromium.org
>
> Review URL: https://codereview.chromium.org/225413005
TBR=ygorshenin@chromium.org
Review URL: https://codereview.chromium.org/231243003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262740 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=361159
Review URL: https://codereview.chromium.org/229053005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=347082
Review URL: https://codereview.chromium.org/228423002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This re-rasterizes CPU-rasterized layers animating scale at the
maximum scale that will be applied during the animation, if this
maximum scale can be computed.
BUG=224913
Review URL: https://codereview.chromium.org/226283004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262737 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=354946
TEST=ExtensionNetworkingPrivateApiTest.*
R=yoz@chromium.org
Review URL: https://codereview.chromium.org/225413005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add new items (315-324)
BUG=none
Review URL: https://codereview.chromium.org/229823002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262735 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
directories in ContentProvider's Cron method, so that individual failures don't
stop the entire cron from running.
R=yoz@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/230843003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=347985
TEST=SystemTrayTest.WithSystemModal
Review URL: https://codereview.chromium.org/225263020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove synchronous FileStream methods (OpenSync, CloseSync, SeekSync, Available, ReadSync, ReadUntilComplete, WriteSync, Truncate, FlushSync).
Remove EnableErrrorStatistics() and SetBoundNetLogSource() whose only user was download::BaseFile.
Remove FileStream::Context::async_ because we are always async.
BUG=356979
TEST=git cl try
Review URL: https://codereview.chromium.org/225463003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: https://codereview.chromium.org/222713002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/230423007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
theme/*/common/ash
BUG=None
TEST=None
R=oshima@chromium.org
Review URL: https://codereview.chromium.org/228043007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262724 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Load unsafe scripts" is clicked on Shield Page Action bubble.
http://crrev.com/241306 refactored ContentSettingsObserver to be a
RenderFrameObserver and it also modified most of corresponding components
in the browser side accordingly but didn't fix
ContentSettingMixedScriptBubbleModel::OnCustomLinkClicked(). It should
send ChromeViewMsg_SetAllowRunningInsecureContent message to all frames
belong to web_contents().
BUG=85271,333308
Review URL: https://codereview.chromium.org/212693005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=356204
R=vasilii@chromium.org
Review URL: https://codereview.chromium.org/230863004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This code has a bunch of DCHECKs, but that's not enough to understand
why a bug is happening in the wild. Add some temporary CHECKs to get
more information.
BUG=358350
Review URL: https://codereview.chromium.org/230983002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262719 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
startNetLogToFile and stopNetLog.
Initialize and get net statistics using UrlRequestContext methods InitializeStatistics and GetStatisticsJSON.
BUG=354143
Review URL: https://codereview.chromium.org/219193015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262718 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
not send XdndDrop if the XdndStatus message indicated that the drop will not be accepted
This CL has the side effect of surpressing the "Drag and drop is not supported" dialog on Unity.
BUG=360374
TEST=Manual, see bug
Review URL: https://codereview.chromium.org/227083003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=361594
TBR=mfomitchev@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/230923003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/222333002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduction of the password_manager namespace in http://crrev.com/262680 broke GTK compilation. This CL fixes it. Verified locally (both reproducing the compilation error, and the fix) on target browser_ui.
BUG=347927, 348523
R=dmazzoni@chromium.org
TBR=jam@chromium.org
Review URL: https://codereview.chromium.org/230363005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262714 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
After a while of staring cross-eyed at page_runner, I decided this was the
easiest way to verify we are killing all browsers properly.
BUG=
Review URL: https://codereview.chromium.org/229943003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Have FaviconTabHelper supports IsOffTheRecord to move knowledge of Profile out of favicon_handler.
BUG=359095
Review URL: https://codereview.chromium.org/227153007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=171122:171141&mode=html
TBR=
BUG=
Review URL: https://codereview.chromium.org/230303004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
This will allow us to delete the code behind SK_SUPPORT_LEGACY_GETTOTALCLIP
Review URL: https://codereview.chromium.org/228723006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I'd just like to check them in to drop a few files out of the big CL.
The DISALLOW_COPY_AND_ASSIGN isn't needed, and has to go for the big CL anyway.
BUG=108012
Review URL: https://codereview.chromium.org/229473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262706 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262705 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
WebFrameClient.
BUG=304341
R=nasko@chromium.org
Review URL: https://codereview.chromium.org/229373005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
For https://codereview.chromium.org/219483003/: Fix for x64 Android
BUG=346626
Review URL: https://codereview.chromium.org/226063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@262702 0039d316-1c4b-4281-b951-d872f2087c98
|