| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Expose a DownloadImage method from FavIconHelper to download/decode
image for an image url;
- Expose FavIconHelper from TabContents;
- Update CreateApplicationShortcutView to use the exposed DownloadImage
method to get web app icon instead of do it via URLFetcher/PNGCodec;
- Check and update web app icon and shortcuts when chrome is lauched as
app for OS_WIN;
- Code cleanup:
- Move a bunch of FavIconHelper methods that are not used externally
to private;
- Remove an unused cancelable_consumer_ from TabContents;
BUG=8539
TEST=Verify issue 8539 is fixed. And create a web page with a non PNG shortcut icon and verify it shows up in create application shortcut dialog.
Review URL: http://codereview.chromium.org/482003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Content script now only talks to the background page if a feed is found, preventing one frame with feed info getting clobbered by another frame without feed info.
2) Properly deleting the feed info as the tab is closed.
3) Linux doesn't support popups so I've readded the onClick handler.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/491039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34331 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
both by scrollbar changes and by SVG changes, and that both sets of images and
the code are getting updated in somewhat overlapping fashion.
It turns out, one of the tests was fixed for a few hours and then broke again
when WebKit changed (I think).
BUG=29748
Review URL: http://codereview.chromium.org/486028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34327 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The upstream fix: https://bugs.webkit.org/show_bug.cgi?id=31985
BUG=28916
TEST=trybot
Review URL: http://codereview.chromium.org/491003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34326 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
working again. Updating the test expectations for these tests.
BUG=29748
Review URL: http://codereview.chromium.org/484001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
------------------------------------------------------------------------
r34321 | estade@chromium.org | 2009-12-10 18:19:50 -0800 (Thu, 10 Dec 2009) | 5 lines
Extensions: don't send EXTENSION_PROCESS_CRASHED when the extension process is fast-terminated (i.e., didn't crash).
BUG=30057
Review URL: http://codereview.chromium.org/492014
Review URL: http://codereview.chromium.org/487023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34324 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=dglazkov
Review URL: http://codereview.chromium.org/488015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34323 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- prefer previous find from same tab contents over overall most recent find when re-opening find bar
- GTK + Windows: always update find bar view text if it doesn't match the search results.
TEST=see bug for repro steps
BUG=30006
Review URL: http://codereview.chromium.org/482015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
is fast-terminated (i.e., didn't crash).
BUG=30057
Review URL: http://codereview.chromium.org/492014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
switch from using confirms to just html with buttons.
This allows you to switch away from the tab at any time, and allows you to
exit out of updating at any time.
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/486026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/492013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test:
1. Build a (branded) Google Chrome.
2. From the command-line, run: "launchctl bslist | wc -l" and note the number.
3. Start Google Chrome on a fresh profile.
4. Once a browser window has opened, do #2 again, and note the number -- it should have increased (by 2).
5. Close the tab, and do #2 again. The number should have decreased by 1.
6. Open tabs, navigate, etc., and do #2 between each stage. Whenever a new (e.g., renderer) process is started, the number should increase (e.g., when you go to a "new" site). When a process is terminated (e.g., you close the last tab for a particular site), the number should decrease.
7. Quit, and do #2 again. Hopefully, the number should be the same as the first time.
(Note: when a renderer crashes, the number will not decrease -- so the number after quitting will not be the same as before starting. This is why this is only a stopgap. For comparison, do this on a branded Google Chrome without this patch; typically, the numbers will not decrease on renderer termination.)
BUG=28547
TEST=See above.
Review URL: http://codereview.chromium.org/484007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/491018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
last window was closed. It assumed that this meant the app was closing. Not the case with Mac apps. Added a mac-only notification APP_TERMINATED and use that to perform cleanup upon shutdown.
TEST=More description in the bug, but basically just make sure that background views stick around even after you've closed the last window.
BUG=28666
Review URL: http://codereview.chromium.org/465143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34316 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Add missing config.h.
Review URL: http://codereview.chromium.org/491010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=pkasting
BUG=none
TEST=covered by unittests
Review URL: http://codereview.chromium.org/491022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34314 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
included from a js file.
There is only one function that is specialized for each sample. The function is referenced in the js file but not defined. It is then defined in each html file.
R=kbr
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/487019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/488010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to run_webkit_tests.
First, a number of log messages have had their levels changed (mostly to
make them quieter).
Second, the script outputs a "meter" that shows progress through the
test run, which is a one line summary of where it's at current
(e.g. "parsing expectations", "gathering files". During the actual test
execution, the meter displays "%d tests completed as expected, %d didn't,
%d remain". The meter uses carriage returns but no linefeeds, so the output
is overwritten as it progresses. The meter is disabled if --verbose is
specified, to avoid unnecessary confusion.
Third, I removed the --find-baselines option. I think I was the only one
using it, and --sources is good enough (but added the baseline for
the checksum as well as the .png when using --sources).
Fourth, there is a new "--log" option that can be used to provide finer
granularity of logging. It accepts a comma-separated list of options, like:
--log 'actual,expected,timing':
"actual": the actual test results (# of failures by type and timeline)
"config": the test settings (results dir, platform, etc.)
"expected": the results we expected by type and timeline
"timing": test timing results (slow files, total execution, etc.)
All of this information is logged at the logging.info level (if the appropriate option is enabled).
Using the --verbose switch will cause all of options to be logged, as well
as the normal verbose output. In addition, the verbose output will disable
the meter (as mentioned above). Note that the "actual" results will be logged
to stdout, not stderr, for compatibility with the buildbot log parser.
Finally, the list of unexpected results (if any) will be logged to stdout,
along with a one-line summary of the test run.
The net result is that when run with no command line options (and when no
tests fail), only one line of output will be produced.
R=ojan@chromium.org,pam@chromium.org
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/465089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
(Already reviewed for content.)
TEST=none
BUG=none
TBR=aa
Review URL: http://codereview.chromium.org/490006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
(.dll on mac, for example).
TEST=Load an extension that requires a .dll or other platform-specific file and make sure it does not crash the browser.
BUG=29584
Review URL: http://codereview.chromium.org/492012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
SIGKILL was causing Apache to leave semaphores hanging around, leading to resource starvation and Apache failures on the bots (see also http://rackerhacker.com/2007/08/24/apache-no-space-left-on-device-couldnt-create-accept-lock/).
Using the PID returned from Popen wasn't actually cleaning up anything, causing Apache processes to linger until the next run. Also change the shutdown method to just take a pid, since that's all it uses from the process object anyhow.
TEST=After running layout_test_wrapper.py (like http://chrome-buildbot.corp.google.com:8016/builders/Webkit%20Linux%2064%20(V8-Latest)/builds/5080/steps/webkit_tests/logs/stdio), there are no lingering chrome-bot semaphores (ipcs -s | grep chrome) or apache processes (ps aux | grep apache2)
Review URL: http://codereview.chromium.org/491025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
original cl: http://codereview.chromium.org/482008
BUG=29578
TEST=Run valgrind test
Review URL: http://codereview.chromium.org/491028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This simplifies things a bit over the old way, and should be a step closer to supporting more QD-based plugins.
Also makes the HandleInputEvent logic a bit clearer.
BUG=none
TEST=QuickTime movies should still play on the Mac. Leaving a page with QuickTime content should not cause a crash.
Review URL: http://codereview.chromium.org/491027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The function to set keyboard focus to the chrome renderer window in a chrome frame instance
was sending the mouse click to the ancestor window, which is not correct. The ancestor window
is only needed to bring the whole hierarchy to the foreground.
Review URL: http://codereview.chromium.org/491026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
copy we make of the browser NSWindow.
We were accidentally disposing the dummy window in the plugin process that Chrome makes.
Review URL: http://codereview.chromium.org/486021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34303 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=21468,22520,28559
Review URL: http://codereview.chromium.org/490008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34302 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=3000
TEST=see bug
Review URL: http://codereview.chromium.org/463062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
twice because the circular memio buffer may have two contiguous parts of
data.
In the SSLClientSocket unit tests, we should compare the result of
sock->Write() with the expected value whether it completes synchronously
or asynchronously.
R=dank
BUG=29815
TEST=a new unit test that issue a hanging Read and then issue a Write.
Review URL: http://codereview.chromium.org/464082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=update and group unittests added
BUG=none
Review URL: http://codereview.chromium.org/465132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in the repository for the RSS extension.
BUG=None
TEST=Open Chrome Extension Samples page, click the
source code link and you should see the source, not
a 404.
Review URL: http://codereview.chromium.org/490004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch addresses signed/unsigned and 64-bit errors. The remaining fixes are more involved requiring changes/ifdefs to get around HWND. There's also a ton of "unused variable" warnings in the auto-generated code.
BUG=n/a
TEST=n/a
Review URL: http://codereview.chromium.org/492009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/491012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/489006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
tbr=oshima
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(and plugins processes on Windows).
We used to always try to load them, even if we didn't use them. It would
work fine if an update happened (because we didn't use them) and the files
were replaced.
Review URL: http://codereview.chromium.org/487001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=wtc
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
messages sent by ChromeFrame
are handled by the AutomationProvider class in Chrome, which also handles other IPC's not used by
ChromeFrame.
We now have a new class ChromeFrameAutomationProvider which derives from the AutomationProvider
class and validates that incoming IPC messages are valid ChromeFrame messages.
Bug=29931
Test=Covered by unit test
Review URL: http://codereview.chromium.org/476008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=n/a
TEST=n/a
TBR=apatrick
Review URL: http://codereview.chromium.org/491017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
http://codereview.chromium.org/484005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
http://codereview.chromium.org/487012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=29762
TEST=Open the options dialog. Note that there is no invisible rectangle.
Review URL: http://codereview.chromium.org/492006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34286 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
---------------
linux: theme scrollbars from GTK theme
Pick the color of the slider's thumbpart and rail from the GTK theme.
We cannot match the exact visual appearance of the GTK theme, as
rendering engines can make arbitrary changes to the actual visual
appearance. But by sampling a representative set of pixels, we ensure
that we will at least match the general color scheme.
BUG=10949
patch by <markus [at] chromium>
original review: http://codereview.chromium.org/400027/show
Review URL: http://codereview.chromium.org/479006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
or chromeos, and add fpic for arm. remove bsf from all but arm
BUG=29934
TEST=make -j6 -r player_x11 BUILDTYPE=Release for all platforms and ensure they still link. Use size libffmpegsumo.so to confirm size has been reduced.
Review URL: http://codereview.chromium.org/483007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=29994
Review URL: http://codereview.chromium.org/490007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clearing dataSource in the source's -dealloc seems generally good.
HungRendererController having a local copy of the titles is in case
the table view is redrawn as part of closing the window (this can
happen if the window is closed while the user is mousing on the
table, and perhaps at other times).
BUG=29558
TEST=Crash noted in bug stops happening.
Review URL: http://codereview.chromium.org/469016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
o bookmark sync while offline.
BUG=19738
TEST=Attempt to log in to bookmark sync while offline. The error should be
"Connection Unavailable"
Review URL: http://codereview.chromium.org/455038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modify the test_expectations module so it can still build up a set
of expectations with a test list even if the files don't exist locally.
This is needed by the LTTF dashboard app (which isn't checked in yet).
Also add test_expectations.GetOptions(), which is also needed by the LTTF app.
R=ojan@chromium.org
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/460152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34278 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
I've long known I needed to fix this, but today I was annoyed enough by it
that I finally did it.
Review URL: http://codereview.chromium.org/477005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=wtc
Review URL: http://codereview.chromium.org/488008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34276 0039d316-1c4b-4281-b951-d872f2087c98
|