| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This will be developed in the mojo repo along with the rest of the mojo
shell code.
R=cpu@chromium.org
Review URL: https://codereview.chromium.org/681093003
Cr-Commit-Position: refs/heads/master@{#301694}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL constructs a global network change notifier in cronet, and make it
listen to network changes by default. Note that after this CL, cronet embedders
will have to add permission.ACCESS_NETWORK_STATE and permission.ACCESS_WIFI_STATE.
BUG=415614
Review URL: https://codereview.chromium.org/670193002
Cr-Commit-Position: refs/heads/master@{#301693}
|
|
|
|
|
|
|
|
|
|
|
|
| |
We still need to render flipped while doing render-to-texture in GLRenderer,
otherwise anything using RTT appears upside down (menus, screenshots), so
InitializeViewport now takes the flip state directly
BUG=418149
Review URL: https://codereview.chromium.org/637653003
Cr-Commit-Position: refs/heads/master@{#301692}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=427616
/analyze pointed out that the loop range-check used the comma operator
when && was probably intended. The bug was harmless, but confusing, so
I fixed it.
/analyze also pointed out that the code was checking data read by a
function and then checking whether the read succeeded. Reversing the
order of the checks has no effect except to get rid of the undefined
behavior.
Review URL: https://codereview.chromium.org/678193003
Cr-Commit-Position: refs/heads/master@{#301691}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When pinch ends we have a tiling that is not the right resolution, but
the last drawn frame may have been considered "complete" regardless
since it was the raster scale.
Outside of the pinch action that scale would not be used as the raster
scale however, so we should UpdateDrawProperties to get a new raster
scale.
If we just do that, however, the new tiles are rastered but do not
trigger an actual redraw if they take longer than the SetNeedsRedraw()
called from PinchGestureEnd, since the scheduler is not watching for
new tiles and drawing constantly (since it's last frame was complete).
So we damage the viewport, which causes us to draw everything and non-
ideal tiles will be considered incomplete and we'll be sure to get a
crisp result.
This last part is excessive and we can do better, but this is something
we can more easily merge to M39. Following up with other better ideas
in another CL https://codereview.chromium.org/671653005/ .
R=enne, vmpstr
BUG=427423
Review URL: https://codereview.chromium.org/682763003
Cr-Commit-Position: refs/heads/master@{#301690}
|
|
|
|
|
|
|
|
|
| |
R=aboxhall@chromium.org
BUG=427388,427796
Review URL: https://codereview.chromium.org/687733002
Cr-Commit-Position: refs/heads/master@{#301689}
|
|
|
|
|
|
|
|
| |
BUG=428000
Review URL: https://codereview.chromium.org/683243002
Cr-Commit-Position: refs/heads/master@{#301688}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The wallpaper code has a bunch of Ash dependencies. It is easiest to not
compile it on Athena in the interest of making Athena no longer depend on
Ash.
BUG=426561
TEST=None
Review URL: https://codereview.chromium.org/665863006
Cr-Commit-Position: refs/heads/master@{#301687}
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: https://codereview.chromium.org/640353005
Cr-Commit-Position: refs/heads/master@{#301686}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we now use dffs on animated text, we no longer need has_text().
The unit test code I've removed were used to test layers using
has_text(), since they don't do anything unique from the code
already called, it is no longer needed.
BUG=
Review URL: https://codereview.chromium.org/681383002
Cr-Commit-Position: refs/heads/master@{#301685}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix the problem that loading inspector from content_shell is failing with
thread_checker_.CalledOnValidThread() failed.
At ShellDevToolsFrontend::Show(), DevToolsHttpHandlerImpl::GetFrontendURL()
is called to get the frontend url, and inside the function,
HttpServer::GetLocalAddress() is called directly which is expected to be
called on the DevToolsHandler thread only.
To prevent the DCHECK failure, this patch keeps the ip address of HttpServer
as a member of DevToolsHttpHandlerImpl instance and use it.
BUG=425423
Review URL: https://codereview.chromium.org/666673007
Cr-Commit-Position: refs/heads/master@{#301684}
|
|
|
|
|
|
|
|
|
|
|
|
| |
to fix closure compilation error
R=dbeam@chromium.org
NOTRY=true
NOTREECHECKS=true
Review URL: https://codereview.chromium.org/682153002
Cr-Commit-Position: refs/heads/master@{#301683}
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/3165c95..9e6a38f
TBR=leviw@chromium.org,yurys@chromium.org
Review URL: https://codereview.chromium.org/686823003
Cr-Commit-Position: refs/heads/master@{#301682}
|
|
|
|
|
|
|
|
|
|
|
| |
Stars support for tablet will not be finished till M40, so it is
temporarily disabled on tablet.
BUG=NONE
Review URL: https://codereview.chromium.org/679343002
Cr-Commit-Position: refs/heads/master@{#301681}
|
|
|
|
|
|
|
|
|
|
|
| |
This helps with problems where Embedded Search does not recognize the /s
endpoint as a Google search.
BUG=426706
Review URL: https://codereview.chromium.org/678133002
Cr-Commit-Position: refs/heads/master@{#301680}
|
|
|
|
|
|
|
|
|
| |
R=lcwu@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/686873002
Cr-Commit-Position: refs/heads/master@{#301679}
|
|
|
|
|
|
|
|
|
| |
R=xhwang@chromium.org,lcwu@chromium.org
BUG=None
Review URL: https://codereview.chromium.org/683893003
Cr-Commit-Position: refs/heads/master@{#301678}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Similar to NaCl r13990, this adds a gyp variable pnacl_translator_dir to
specify a directory containing a built PNaCl translator to package into
Chromium, which overrides the default behavior (which is to use the translator
downloaded by package_version.py based on the NaCl DEPS).
R=dyen@chromium.org,jvoung@chromium.org
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3954
Review URL: https://codereview.chromium.org/681133002
Cr-Commit-Position: refs/heads/master@{#301677}
|
|
|
|
|
|
|
|
|
|
| |
BUG=425863
TEST=manual
NOTRY=true
Review URL: https://codereview.chromium.org/683793005
Cr-Commit-Position: refs/heads/master@{#301676}
|
|
|
|
|
|
|
|
|
|
|
|
| |
>> Move Destination.Origin.DEVICE printers into cloud devices section.
>> BUG=416701
>> Review URL: https://codereview.chromium.org/602863002
BUG=427977
Review URL: https://codereview.chromium.org/681983002
Cr-Commit-Position: refs/heads/master@{#301675}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL moves ExtensionInstallPrompt::ShowParams to its own class. The new class
observes the content::WebContents and gfx::NativeWindow for their destruction.
If the window is closed prior to the "Confirm Install" prompt showing, the
prompt is shown as a non-modal free-standing dialog.
BUG=422814
TEST=ExtensionInstallPromptBrowserTest.*
Review URL: https://codereview.chromium.org/662073002
Cr-Commit-Position: refs/heads/master@{#301674}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Google C++ style guide states:
Explicitly annotate overrides of virtual functions or virtual
destructors with an override or (less frequently) final specifier.
Older (pre-C++11) code will use the virtual keyword as an inferior
alternative annotation. For clarity, use exactly one of override,
final, or virtual when declaring an override.
To better conform to these guidelines, the following constructs have
been rewritten:
- if a base class has a virtual destructor, then:
virtual ~Foo(); -> ~Foo() override;
- virtual void Foo() override; -> void Foo() override;
- virtual void Foo() override final; -> void Foo() final;
This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.
BUG=417463
R=jennyz@chromium.org
Review URL: https://codereview.chromium.org/683473005
Cr-Commit-Position: refs/heads/master@{#301673}
|
|
|
|
|
|
|
|
| |
BUG=427622
Review URL: https://codereview.chromium.org/682733002
Cr-Commit-Position: refs/heads/master@{#301672}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to latest editor spec http://rawgit.com/w3c/html-api-map/master/index.html
Recommended AXRoleDescription of "address" to disambiguate
from "contentinfo" landmark role for address element.
BUG=169577
Review URL: https://codereview.chromium.org/670493002
Cr-Commit-Position: refs/heads/master@{#301671}
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=media_unittests pass
Review URL: https://codereview.chromium.org/681523002
Cr-Commit-Position: refs/heads/master@{#301670}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/skia/+log/eb06588..8f0d69e
CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=hcm@google.com
Review URL: https://codereview.chromium.org/687713002
Cr-Commit-Position: refs/heads/master@{#301669}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from android_browser_backend to android_platform_backend:
setting SSL relax flag
application profile manipulation
setting debug app
kill app
port forwarding
dumping stack trace and standard output
root CA manipulation
BUG=417542
Review URL: https://codereview.chromium.org/656383002
Cr-Commit-Position: refs/heads/master@{#301668}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds a raster source that is an opaque interface
for picture pile impl. It also removes the picture pile base
ref count and adds it to the raster source. This makes it
possible to use a member picture pile, instead of a ref
pointer with one owner.
What is missing here is the next step: removing picture pile
base in favour of keeping shared data on the pile and copying
it over. This should allow us to clean up the data and only
share what is actually shared.
R=danakj, enne, reveman
Review URL: https://codereview.chromium.org/666273002
Cr-Commit-Position: refs/heads/master@{#301667}
|
|
|
|
|
|
|
|
|
| |
This dependency doesn't exist in the gyp build and doesn't appear to be
used.
Review URL: https://codereview.chromium.org/681213002
Cr-Commit-Position: refs/heads/master@{#301666}
|
|
|
|
|
|
|
|
|
|
|
|
| |
According to latest editor's draft http://rawgit.com/w3c/html-api-map/master/index.html
Article tag should have 'article' as AXRoleDescription.
BUG=426836
TBR=piman
Review URL: https://codereview.chromium.org/673213002
Cr-Commit-Position: refs/heads/master@{#301665}
|
|
|
|
|
|
|
|
| |
BUG=417706
Review URL: https://codereview.chromium.org/667713003
Cr-Commit-Position: refs/heads/master@{#301664}
|
|
|
|
|
|
|
|
|
|
| |
Slightly broaden the regex for card numbers so "cardNum" counts and the regex for cardholder name so "cardName" counts.
BUG=427603
Review URL: https://codereview.chromium.org/683723002
Cr-Commit-Position: refs/heads/master@{#301663}
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary for in-process command buffer to be able
to use this interface.
BUG=423533
Review URL: https://codereview.chromium.org/656263003
Cr-Commit-Position: refs/heads/master@{#301662}
|
|
|
|
|
|
|
|
| |
the camera FPS eg 31 fps is wanted, the supported range is [11,30] then the final FPS should be selected to be 30 instead of 11
Review URL: https://codereview.chromium.org/641293002
Cr-Commit-Position: refs/heads/master@{#301661}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
OverviewButtonTray changes its active state in response to user touch and activation. It would dismiss the active state when pressed again. However Overview Mode can be dismissed by other actions.
Implment and Observer in WindowSelectorController to notify of entering/exiting Overview Mode. Have OverviewButtonTray listen and update its state on dismissal.
TEST=OverviewButtonTrayTest.ActiveStateOnlyDuringOverviewMode
BUG=419875
Review URL: https://codereview.chromium.org/671303005
Cr-Commit-Position: refs/heads/master@{#301660}
|
|
|
|
|
|
|
|
|
| |
Enables the slimming paint work: http://www.chromium.org/blink/slimming-paint
This is dependent on https://codereview.chromium.org/684653002/
Review URL: https://codereview.chromium.org/678763007
Cr-Commit-Position: refs/heads/master@{#301659}
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2681a69..3165c95
TBR=leviw@chromium.org,yurys@chromium.org
Review URL: https://codereview.chromium.org/680363002
Cr-Commit-Position: refs/heads/master@{#301658}
|
|
|
|
|
|
|
|
|
|
|
|
| |
from about 4ms to 0.7ms for each 720p frame.
If the current video frame is of the same size as the previous frame, reuse the shared memory and overwrite the previous frame. Pepper does not hold onto a frame after it has been processed, and it indicates processing is done by sending a new request, so overwriting the previous frame should be fine.
BUG=423365
Review URL: https://codereview.chromium.org/653873003
Cr-Commit-Position: refs/heads/master@{#301657}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
People in OWNERS files should do reviews. If they can't, they should
remove themselves. "Just owners:" is only used in a single file and
both entries are in a higher-level OWNERS files anyways, so it doesn't
even have a real effect here.
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/681603003
Cr-Commit-Position: refs/heads/master@{#301656}
|
|
|
|
|
|
|
|
|
|
| |
This change includes fix for AES calculation for MIPS.
TEST=libsrtp tests and Chromium's content_browsertests
BUG=
Review URL: https://codereview.chromium.org/685633003
Cr-Commit-Position: refs/heads/master@{#301655}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On failure to load libchromium_android_linker.so, we retry with
libchromium_android_linker.cr.so. If the latter fails then only
the name 'libchromium_android_linker.cr.so' appears in the logcat.
This is confusing where (commonly) this is not a components build.
Add a warning to clarify that libchromium_android_linker.cr.so
is a load retry with a different name.
BUG=
Review URL: https://codereview.chromium.org/683163003
Cr-Commit-Position: refs/heads/master@{#301654}
|
|
|
|
|
|
|
|
|
|
| |
Netflix plugin has been removed from ChromeOS. See bug for details.
BUG=406573
Review URL: https://codereview.chromium.org/682753002
Cr-Commit-Position: refs/heads/master@{#301653}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When launching webview new window api sample on Athena, an exception will be thrown:
[FATAL:chrome_web_view_guest_delegate.cc(49)] Check failed: menu_delegate.
This is because the athena::CreateWebContentsViewDelegate() doesn't add a new ContextMenuDelegateUserData to web contents when it creates a new WebContentsViewDelegate(WebContentsViewDelegateImpl). To fix it, I let WebContentsViewDelegateImpl to inherit ContextMenuDelegate as well, so it can call the constructor of ContextMenuDelegate and add ContextMenuDelegateUserData to web contents when initializing.
BUG=397364
Review URL: https://codereview.chromium.org/637413006
Cr-Commit-Position: refs/heads/master@{#301652}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/681143002
Cr-Commit-Position: refs/heads/master@{#301651}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:1 of https://codereview.chromium.org/646033008/)
Reason for revert:
No longer needed
Original issue's description:
> Add some more debugging info for invalid referrers
>
> BUG=422871
> R=battre@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/92a102affe8141960e7ceda34c4ff193928121f7
TBR=battre@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=422871
Review URL: https://codereview.chromium.org/680373002
Cr-Commit-Position: refs/heads/master@{#301650}
|
|
|
|
|
|
|
|
|
|
|
| |
bevc and ilevy left the team a long time ago.
BUG=
NOTRY=True
Review URL: https://codereview.chromium.org/680933002
Cr-Commit-Position: refs/heads/master@{#301649}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This previously could occur, as we use a quadratic regression to estimate
finger velocity. Rapid deceleration would result in a fling in the
wrong direction.
BUG=417855
TEST=VelocityTrackerTest.NoDirectionReversal
Review URL: https://codereview.chromium.org/610583002
Cr-Commit-Position: refs/heads/master@{#301648}
|
|
|
|
|
|
|
|
|
|
|
| |
Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a15dd25..2681a69
TBR=leviw@chromium.org,yurys@chromium.org
Review URL: https://codereview.chromium.org/678323003
Cr-Commit-Position: refs/heads/master@{#301647}
|
|
|
|
|
|
|
|
|
|
|
| |
renderer’s, for debug builds only
BUG=407376
TEST=none
Review URL: https://codereview.chromium.org/676823003
Cr-Commit-Position: refs/heads/master@{#301646}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows identifying the device generating the event. In a future
patch this will allow properly routing of touch events to the correct
platform window.
BUG=none
Review URL: https://codereview.chromium.org/628693002
Cr-Commit-Position: refs/heads/master@{#301645}
|