summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Explicitly compare to NULL when looking for weak_import symbols.craig.schlenter@chromium.org2009-09-181-3/+3
| | | | | | | | | | | | | | Changing the comparison form affects the warning messages generated in various circumstances. See the codereview for details. Also, Apple docs claim that !symbol comparisons will not work. Spotted by Matthew Vosburgh. Review URL: http://codereview.chromium.org/214012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26569 0039d316-1c4b-4281-b951-d872f2087c98
* Make extension shelf resize correctly with the window.thakis@chromium.org2009-09-181-1/+1
| | | | | | | | | | | I just changed the shelf to autosize horizontally and to be anchored at the bottom and the left and right sides in IB (it was anchored to the top left before and had no autoresizing). BUG=none TEST=Enable extension shelf in browser_window_controller.mm (turn #if 0 into #if 1), then build & start chromium. Resize the browser window. The shelf should now stay at the bottom of the window and stay sane. Review URL: http://codereview.chromium.org/208023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26568 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Adds animations to the findbar.rohitrao@chromium.org2009-09-185-230/+408
| | | | | | | | BUG=http://crbug.com/14908 TEST=Findbar should animate open and closed, unless switching tabs. Review URL: http://codereview.chromium.org/195105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26567 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Disable autoresizing of subviews when going into and out of fullscreenrohitrao@chromium.org2009-09-181-0/+8
| | | | | | | | | | | mode. This will prevent spurious renderer resizes and reduce flicker. BUG=http://crbug.com/21666 TEST=Layout of www.google.com should not be messed up after exiting fullscreen mode. Review URL: http://codereview.chromium.org/210011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26566 0039d316-1c4b-4281-b951-d872f2087c98
* ExtensionAPIClientTest.GetLastFocusedWindow is flakymaruel@chromium.org2009-09-181-1/+2
| | | | | | | | | TBR=rafaelw TEST=ExtensionAPIClientTest.GetLastFocusedWindow in unit_tests BUG=22248 Review URL: http://codereview.chromium.org/207029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26565 0039d316-1c4b-4281-b951-d872f2087c98
* Re-applying build/common.gypi patch from http://codereview.chromium.org/195078timurrrr@chromium.org2009-09-181-0/+4
| | | | | | | | | | The previous patch was reverted until buildbot master was restarted. After the restart, GYP_DEFINES contains "release_valgrind_build=1" http://build.chromium.org/buildbot/waterfall/builders/Chromium Linux Builder (valgrind)/builds/2/steps/gclient/logs/stdio Review URL: http://codereview.chromium.org/196140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26564 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/203029 for Thiago:sky@chromium.org2009-09-183-9/+14
| | | | | | | | | | | | | | | | | | [Windows] Bookmark-menu button should be themed like any other menu button. Command: $ chrome --bookmark-menu BUG=18954 TEST=open chrome/chromium with --bookmark-menu switch in the command line, apply a theme, see if the bookmark-menu is themed? Reset to default theme, see if the bookmark-menu come backs to default state. TEST=none BUG=none Review URL: http://codereview.chromium.org/208017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26563 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: don't duplicate eval scripts on each panel switch. yurys@google.com2009-09-183-8/+60
| | | | | | Review URL: http://codereview.chromium.org/211012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26562 0039d316-1c4b-4281-b951-d872f2087c98
* Added two suppressions for benign races in ICUtimurrrr@chromium.org2009-09-181-0/+14
| | | | | | Review URL: http://codereview.chromium.org/216004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26561 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the theme popup menu and just have a reset button to match the other ↵thomasvl@chromium.org2009-09-186-368/+131
| | | | | | | | | | | | platforms. This avoids us needed extra localization strings, and we'll look to pick up any new UI when it's done for all platforms. Remove the autoseparating_menu since it is no longer used. TEST=Prefs just has a reset button and no theme popup list. BUG=none Review URL: http://codereview.chromium.org/214011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26560 0039d316-1c4b-4281-b951-d872f2087c98
* Allow popup windows to have a title displayed in the titlebar.pinkerton@chromium.org2009-09-181-0/+6
| | | | | | | | BUG=17918 TEST=popups get a title, nobody else does. Expose should show title. Review URL: http://codereview.chromium.org/209020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26559 0039d316-1c4b-4281-b951-d872f2087c98
* Try again to land "Implement script API:executeScript"aa@chromium.org2009-09-1828-7/+584
| | | | | | | | | http://codereview.chromium.org/173556 TBR=mpcomplete@chromium.org Patch from Jerry Tang <tangjie@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26556 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where we fail to install an extension that has an emptyaa@chromium.org2009-09-184-13/+1
| | | | | | | | | | | | | | | | permissions array in its manifest. This was caused an old attempt to display a warning in this situation, back when we were ambitious. BUG=22157 TEST=Install extension associated with bug. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26534 Review URL: http://codereview.chromium.org/213009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26555 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce WebKit::WebSecurityOrigin as a wrapper arounddarin@chromium.org2009-09-1815-19/+203
| | | | | | | | | | | | | | | | | WebCore::SecurityOrigin. This provides us a little wiggle room in the future in case we ever want to provide more details about a security origin beyond just its stringified value. This was done on recommendation from Adam Barth. R=jorlow BUG=21967 TEST=none Review URL: http://codereview.chromium.org/211013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26554 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit Update 48491:48500ukai@chromium.org2009-09-181-1/+1
| | | | | | | | | | TBR=dglazkov BUG=none TEST=none Review URL: http://codereview.chromium.org/213021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26553 0039d316-1c4b-4281-b951-d872f2087c98
* The WebPluginImpl::paint function can be invoked when the delegate_ member ↵ananta@chromium.org2009-09-181-0/+2
| | | | | | | | | | | | | | | | | | is NULL. This scenario can happen if a plugin is reinitialized, in which case the plugin instance is torn down and a new one is initialized. If the second initialization fails, we have a plugin instance in the renderer which has a NULL delegate_. Fix is to add a NULL check for the delegate in the paint function. Fixes http://code.google.com/p/chromium/issues/detail?id=22196 Bug=22196 Review URL: http://codereview.chromium.org/215018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26552 0039d316-1c4b-4281-b951-d872f2087c98
* Addressing two comments from Darin.tommi@chromium.org2009-09-181-2/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/216021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26551 0039d316-1c4b-4281-b951-d872f2087c98
* Don't build the RPMs for ChromeOS.thestig@chromium.org2009-09-181-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/210014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26550 0039d316-1c4b-4281-b951-d872f2087c98
* This test still fails on the mac.darin@chromium.org2009-09-181-0/+1
| | | | | | | | TBR=jam Review URL: http://codereview.chromium.org/214019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26548 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustage caused by unintended changes being committed.darin@chromium.org2009-09-181-2/+1
| | | | | | | | | | TBR=jorlow BUG=none TEST=none Review URL: http://codereview.chromium.org/207028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26547 0039d316-1c4b-4281-b951-d872f2087c98
* Fix plugin crash caused by removal of EMBED element during NPP_New.darin@chromium.org2009-09-183-3/+10
| | | | | | | | | | | | | | | | We get into trouble if FrameLoaderClient::createPlugin returns non- null if the EMBED element was removed from the DOM during NPP_New. This CL makes changes to main.cpp to support the layout test, which corresponds to http://trac.webkit.org/changeset/48361. R=jam BUG=21841 TEST=covered by layout test Review URL: http://codereview.chromium.org/211008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26546 0039d316-1c4b-4281-b951-d872f2087c98
* Moving two http utility functions to a separate source file due to ↵tommi@chromium.org2009-09-183-16/+33
| | | | | | | | | | | | | dependency on icu. This allows usage of e.g. HeadersIterator without pulling in all of icu. TEST=no code change. BUG=none Review URL: http://codereview.chromium.org/213017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26545 0039d316-1c4b-4281-b951-d872f2087c98
* Implement GetCurrentCountryID() for Linux.suzhe@chromium.org2009-09-181-1/+28
| | | | | | | | | | | This CL implements GetCurrentCountryID() function for Linux. BUG=none TEST=none Review URL: http://codereview.chromium.org/203079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26544 0039d316-1c4b-4281-b951-d872f2087c98
* Preparing rollback in case things don't work out.bradnelson@google.com2009-09-1835-909/+33
| | | | | | | | | | | This rolls back 26540, gregoryd's attempt at a nacl landing. BUG=None TEST=None Review URL: http://codereview.chromium.org/213019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26543 0039d316-1c4b-4281-b951-d872f2087c98
* Pulling in newer nacl.bradnelson@google.com2009-09-182-1/+5
| | | | | | | | | | BUG=None TEST=None TBR=gregoryd Review URL: http://codereview.chromium.org/211021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26542 0039d316-1c4b-4281-b951-d872f2087c98
* Build -dbgsym Debian packages. These contain the stripped-out debugging ↵tschmelcher@google.com2009-09-185-33/+74
| | | | | | | | symbols and can be installed on a system to automatically enable symbolic debugging. Review URL: http://codereview.chromium.org/210018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26541 0039d316-1c4b-4281-b951-d872f2087c98
* This is a copy of http://codereview.chromium.org/153002/showgregoryd@google.com2009-09-1834-33/+905
| | | | | | | | | | First step towards NaCl-Chrome integration:1. NaCl plugin becomes a built-in plugin in Chrome and runs in the renderer process.2. Most of the changes are related to launching the NaCl process (that loads and runs the NaCl module) and establishing the initial communication between that process and the NaCl plugin.3. This CL relies on another CL that contains the changes on the Native Client side: http://codereview.chromium.org/1501904. Command line flag "--internal-nacl" is required to enable the built-in NaCl plugin.5. NaCl still cannot run in Chrome sandbox, so the "--no-sandbox" flag is also required TBR=bradnelson Review URL: http://codereview.chromium.org/207025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26540 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 26534: "Fix bug where we fail to install an extensionaa@chromium.org2009-09-181-0/+5
| | | | | | | | that has an empty" TBR=rafaelw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26538 0039d316-1c4b-4281-b951-d872f2087c98
* Check for supported schemes and examine request methods at key points. We ↵michaeln@google.com2009-09-189-56/+158
| | | | | | | | | | | | | | | | | | | | | | | support http, https, and file (dbg only) URLs for now. * Added IsSchemeSupported, IsMethodSupported and IsMethodAndSchemeSupported helpers, and string constants. * Check for supported schemes and methods during cache selection and during request interception. Must be GET for cache selectino, GET or HEAD for request interception. * Renamed some data members in WebApplicationCacheHostImpl to more closely match naming elsewhere. * Added AppCacheHost::Observer to make life easier. (I like the observer model, and even noticed that the chrome code base has a multi-threaded version too (ala Gears)... nice :) * Switched to using the observer model in AppCacheRequestDispatcher instead of a WeakPtr. One of the observable methods is OnDestructionImminent(host). * Added gyp dependency on the net library BUG=none TEST=none Review URL: http://codereview.chromium.org/205017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26537 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where we access a view after deletion.paul@chromium.org2009-09-183-3/+12
| | | | | | | | | | | | | | | | | When the download shelf menu option 'Remove' is chosen, the view is removed and deleted (along with the object representing the download) so we must not access them after the removal. This CL NULLs the download pointer in the menu to prevent any futher access. BUG=20810 TEST=Remove an item from the download shelf and Chrome should not crash. Review URL: http://codereview.chromium.org/216018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26536 0039d316-1c4b-4281-b951-d872f2087c98
* Enable bookmark sync building by default for Chromium builds on windows.chron@chromium.org2009-09-181-9/+2
| | | | | | Review URL: http://codereview.chromium.org/207019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26535 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug where we fail to install an extension that has an emptyaa@chromium.org2009-09-181-5/+0
| | | | | | | | | | | | | | permissions array in its manifest. This was caused an old attempt to display a warning in this situation, back when we were ambitious. BUG=22157 TEST=Install extension associated with bug. Review URL: http://codereview.chromium.org/213009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26534 0039d316-1c4b-4281-b951-d872f2087c98
* Retry landing the flip changes. This time with DEPS!mbelshe@google.com2009-09-1817-0/+3770
| | | | | | | | | BUG=none TEST=flip_session_unittest.cc flip_network_transaction_unittest.cc flip_framer_test.cc Review URL: http://codereview.chromium.org/210016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26533 0039d316-1c4b-4281-b951-d872f2087c98
* Remove whiltelist checks for protocol for <audio> and <video>hclam@chromium.org2009-09-181-21/+0
| | | | | | | | | | | BUG=22152 Allow <audio> and <video> to request urls with protocol not limited to file, http and https. Review URL: http://codereview.chromium.org/212011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26532 0039d316-1c4b-4281-b951-d872f2087c98
* Linux Printing: Move file open operation to file thread.estade@chromium.org2009-09-184-46/+63
| | | | | | | | | | | Also delete the temp file when we're done with it (usually). BUG=22097 TEST=printing still works Review URL: http://codereview.chromium.org/215015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26531 0039d316-1c4b-4281-b951-d872f2087c98
* Break out page load test into its own target on Linux.estade@chromium.org2009-09-183-39/+75
| | | | | | | | | | | Also, build the reliability_tests target on Linux. Neither of the new targets have trybots or buildbots yet, however, they do work for me locally. BUG=19085 Review URL: http://codereview.chromium.org/209022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26530 0039d316-1c4b-4281-b951-d872f2087c98
* Language detection works only for Windows now. Make ↵sidchat@chromium.org2009-09-183-1/+8
| | | | | | | | | | chrome.tabs.detectLanguage return default (English) for non-Windows OS. Review URL: http://codereview.chromium.org/199064 BUG=www.crbug.com/20692 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26529 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Strict transport security: add checkbox to clear state."agl@chromium.org2009-09-1814-81/+4
| | | | | | | This reverts commit r25955. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26528 0039d316-1c4b-4281-b951-d872f2087c98
* Let arrow up/down in find bar scroll page.thakis@chromium.org2009-09-181-1/+3
| | | | | | | | | | | This now matches both windows _and_ common sense. BUG=none as far as I know TEST=Go to a web page with scrollbar (e.g. en.wikipedia.org), focus find bar hit arrow up/down. Page should now scroll. Review URL: http://codereview.chromium.org/212012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26527 0039d316-1c4b-4281-b951-d872f2087c98
* While fixing bug 22070 (Toolstrip theme background not updated when resizing ↵finnur@chromium.org2009-09-184-47/+31
| | | | | | | | | | | | Chrome window) I added code to trigger repainting the background on resize. This flushed out a problem (Skia exceptions) that was causing the extension tests to become flaky on the bots (bug 22135). I've changed the code to do a deep copy on the subset bitmap we get before passing it down to the renderer, which causes Skia to not go haywire when drawing the background. That makes it possible to fix bug 22070, which now causes the background to be updated on resize. There is also now no need to set the background_needs_repaint_ flag to true before calling Layout. We also don't need to keep track of whether we are detached or not, we just need to monitor the background_needs_repaint_ flag. BUG=22070, 22135 TEST=Monitor the bots and see if the tests become flaky again. Review URL: http://codereview.chromium.org/215017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26526 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 26523 "Upstreamings parts of webkit.gyp (step 1)" because it ↵nsylvain@chromium.org2009-09-186-976/+921
| | | | | | | | breaks the mac webkit build badly. Review URL: http://codereview.chromium.org/210017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26525 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 26484 "This is not production code; landing some experimental ↵nsylvain@chromium.org2009-09-1716-3769/+0
| | | | | | | | | | network code." because it broke the "check_deps" step on Chromium XP Review URL: http://codereview.chromium.org/212015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26524 0039d316-1c4b-4281-b951-d872f2087c98
* Upstreamings parts of webkit.gyp (step 1)yaar@chromium.org2009-09-176-921/+976
| | | | | | | | | | | | | | | | | | | | | | This is step 1 a multi-step process that is part of the webkit chromium port. This step includes: A. Refactoring the wtf, pcre & webcore targets into separate files javascriptcore.gypi and webcore.gyp, which would eventually move upstream. B. Refactoring the feature_define variables into features.gypi, to allow two sets of feature defines - one for chromium port and one for chromium. C. Refactoring the config target into config.gyp, since currently both javascriptcore and webcore target depend on it. Next steps: 2. Eliminate config dependency. 3. Make features.gypi only override built-in variables that live upstream (so we don't have to maintain 2 parallel feature lists). 4. Really move webcore.gyp & javascriptcore.gyp to webkit.org Review URL: http://codereview.chromium.org/212003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26523 0039d316-1c4b-4281-b951-d872f2087c98
* Fix layout test buildbot rednessr, removed a couple of tests from ↵japhet@chromium.org2009-09-171-0/+7
| | | | | | | | | | | | test_expecations that I shouldn't have. BUG=none TEST=green TBR=nsylvain Review URL: http://codereview.chromium.org/213014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26522 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the deadlock when Flash tries to make WMP full screen. This is a ↵jam@chromium.org2009-09-176-19/+48
| | | | | | | | | one-off solution that detects this case and returns the reply to the sync message before calling WMP. I don't think this is a generic problem, since we haven't seen it before, and the generic solutions have too many side-effects. BUG=15985 Review URL: http://codereview.chromium.org/210004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26521 0039d316-1c4b-4281-b951-d872f2087c98
* Retry that check for nullness in url request automation job.tommi@chromium.org2009-09-171-2/+7
| | | | | | | | | TEST=run automation tests. BUG=none Review URL: http://codereview.chromium.org/210012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26520 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a presubmit script to honor the tree status.bradnelson@google.com2009-09-171-0/+91
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/208016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26519 0039d316-1c4b-4281-b951-d872f2087c98
* Splitting out svn:eol-style LF from other file changes in ↵atwilson@chromium.org2009-09-171-10/+10
| | | | | | http://codereview.chromium.org/207002 because having them together makes the try server barf. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26518 0039d316-1c4b-4281-b951-d872f2087c98
* Two extensions doc cleanups.asargent@chromium.org2009-09-174-20/+64
| | | | | | | | | | | | | -Note presence of tab property on message ports in background pages and toolstrips -Fix pageActions listener callback reference BUG=none TEST=none Review URL: http://codereview.chromium.org/208003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26517 0039d316-1c4b-4281-b951-d872f2087c98
* Stop running the old WMP plugin test, it's not passingjam@chromium.org2009-09-171-1/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26516 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 00:51:11 +0000