summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Add a simple example history extension.skerner@chromium.org2010-04-064-0/+138
| | | | | | | | | BUG=32362 TEST=Manual. Review URL: http://codereview.chromium.org/1568012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43727 0039d316-1c4b-4281-b951-d872f2087c98
* Win32 plumbing for dragend event.dcheng@chromium.org2010-04-067-22/+68
| | | | | | | | | | | This plumbs the actual dropEffect that occurred back into WebKit so that dragend is dispatched with the correct dropEffect. Note that this only helps with drags that start in Chrome and end outside of Chrome. Since WebDropTarget always lies and claims that no drop occurred, drags that start in Chrome and end in Chrome will still be incorrect. BUG=39399 TEST=Manual testing using the attached test case on the bug. Review URL: http://codereview.chromium.org/1136007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43726 0039d316-1c4b-4281-b951-d872f2087c98
* Disable incremental linking for startup_tests. A trybot could not link this ↵thestig@chromium.org2010-04-061-0/+9
| | | | | | | | | | binary anymore after I added some shutdown tests. BUG=none TEST=none Review URL: http://codereview.chromium.org/1569022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43725 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: simplify dump_app_syms since newer versions of Breakpad no longer ↵thestig@chromium.org2010-04-061-20/+6
| | | | | | | | | | generates different signatures for stripped/unstripped binaries. BUG=none TEST=none Review URL: http://codereview.chromium.org/1627001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43724 0039d316-1c4b-4281-b951-d872f2087c98
* Show Page Info dialog on mouse up, not mouse down.pkasting@chromium.org2010-04-062-2/+12
| | | | | | | | | BUG=40229 TEST=Visit a page. Click down, then up on the location bar icon. The dialog should only appear on mouse up. Review URL: http://codereview.chromium.org/1621003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43723 0039d316-1c4b-4281-b951-d872f2087c98
* Fixe for #38367 AutoFill UI bug: extra-long fields behaved incorrectly.georgey@chromium.org2010-04-061-2/+2
| | | | | | | | BUG=38367 TEST=In the bug. Review URL: http://codereview.chromium.org/1625002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43722 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Implement status icons on linux.evan@chromium.org2010-04-068-3/+181
| | | | | | | | | | | | | (Retry with less build breakage this time.) BUG=37375 TEST=out/Debug/unit_tests --gtest_filter=StatusTrayGtkTest.* Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1421001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43721 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Add a call to |-layoutTabs| so that restored pinned tabs look as they ↵rsesek@chromium.org2010-04-061-0/+4
| | | | | | | | | | | should. BUG=39900 TEST=Open a new tab, navigate, and pin it. Close the window. Restore the window. Tab should still appear pinned. Review URL: http://codereview.chromium.org/1628004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43720 0039d316-1c4b-4281-b951-d872f2087c98
* Linux UI tweaks: adjust spacing, add a string, make Customize button ↵dantasse@chromium.org2010-04-062-17/+24
| | | | | | | | invisible instead of disabled Review URL: http://codereview.chromium.org/1591017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43719 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce valid Mac plugin event and drawing model pairingsstuartmorgan@chromium.org2010-04-065-7/+17
| | | | | | | | | | | Refuse to load plugins that violate the specs. BUG=38341 TEST=none Review URL: http://codereview.chromium.org/1558020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43718 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fix a couple of libc calls in a compromised context.agl@chromium.org2010-04-061-8/+17
| | | | | | | | | | | We shouldn't call memset nor socketpair once we have crashed. BUG=39292 TEST=none http://codereview.chromium.org/1210006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43717 0039d316-1c4b-4281-b951-d872f2087c98
* Make Mac plugin window interposing more conservative about activating pluginstuartmorgan@chromium.org2010-04-061-2/+23
| | | | | | | | | | | Don't switch to the plugin process for offscreen windows (like the one opened by Unity). BUG=38996 TEST=Open a Unity sample. It shouldn't lose focus on every mouse event (although it will still lose focus once). Review URL: http://codereview.chromium.org/1626002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43716 0039d316-1c4b-4281-b951-d872f2087c98
* detect preferences errorserikkay@chromium.org2010-04-0640-134/+412
| | | | | | | | | BUG=38352 TEST=none Review URL: http://codereview.chromium.org/1120006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43715 0039d316-1c4b-4281-b951-d872f2087c98
* Relaxes tab strip memory leak suppression as it was too specific.sky@chromium.org2010-04-061-11/+1
| | | | | | | | | | BUG=40475 TEST=none TBR=oshima@chromium.org Review URL: http://codereview.chromium.org/1566018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43714 0039d316-1c4b-4281-b951-d872f2087c98
* Enable WorkerTest.WorkerScriptError which now have same results on win, ↵yurys@chromium.org2010-04-061-2/+1
| | | | | | | | | | linux and mac after http://trac.webkit.org/changeset/57147 is rolled. BUG=38918 Review URL: http://codereview.chromium.org/1596011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43712 0039d316-1c4b-4281-b951-d872f2087c98
* Abstracted language switch logic to its model class.glotov@google.com2010-04-068-109/+176
| | | | | | | | | BUG=37070 TEST=none Review URL: http://codereview.chromium.org/1596007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43711 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 57137: 57147pfeldman@chromium.org2010-04-061-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43710 0039d316-1c4b-4281-b951-d872f2087c98
* Fix docking behaviour for devtools windows that don't have an associated ↵mnissler@chromium.org2010-04-069-26/+38
| | | | | | | | | | | browser window BUG=40090 TEST=none Review URL: http://codereview.chromium.org/1567014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43709 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Get theme providers from a window's delegate, not its window ↵rohitrao@chromium.org2010-04-062-6/+6
| | | | | | | | | | controller. These are actually the same object, but they are set at different times during the switch to fullscreen. BUG=39323 TEST=Go fullscreen with the Android Robot theme installed. Tab text for unselected tabs should be grey, not black. Review URL: http://codereview.chromium.org/1576019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43708 0039d316-1c4b-4281-b951-d872f2087c98
* Add menu and menu item events to the accessibility extension api, anddmazzoni@chromium.org2010-04-0614-85/+325
| | | | | | | | | | | | | | generate menu item notifications for gtk menus. The code to generate menu open and close events is a little more complicated and will come in a future patch. BUG=none TEST=navigated menus with keyboard, watched notifications fire Review URL: http://codereview.chromium.org/1585011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43707 0039d316-1c4b-4281-b951-d872f2087c98
* Make DidProcessCrash a bit more solid and accurate on Windowsphajdan.jr@chromium.org2010-04-065-14/+38
| | | | | | | | | | | | | I hit the NOTREACHED() inside it while debugging an unrelated problem. Also, now there is one less special case in this function's contract. TEST=none BUG=38048 Review URL: http://codereview.chromium.org/1315009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43706 0039d316-1c4b-4281-b951-d872f2087c98
* Add NormalizeLanguageCode() to normalize language codes.satorux@chromium.org2010-04-063-9/+50
| | | | | | | | | | | | | | The normalization is needed to avoid duplicates in the language table in the language config diloag, as well as the combobox in the "add language" dialog, when engines return "jpn" and "ja" as language codes. Along the way, fixed typos in function names. TEST=added unit tests, and manually Review URL: http://codereview.chromium.org/1512022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43705 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a suppression entry added in r39812 since the suppression seems not ↵yusukes@google.com2010-04-061-24/+0
| | | | | | | | | | | | to be necessary anymore. BUG=36616 TEST=see the linux valgrind bot keeps green TBR=dpranke Review URL: http://codereview.chromium.org/1559017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43704 0039d316-1c4b-4281-b951-d872f2087c98
* WebKit roll 57067:57139.pfeldman@chromium.org2010-04-061-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43703 0039d316-1c4b-4281-b951-d872f2087c98
* Relaxes the suppression rule for Issue 40505.hbono@chromium.org2010-04-061-9/+0
| | | | | | | | | | | This change just relaxes the suppression rule for Issue 40505 to cover Linux bots. TBR=georgey BUG=40505 TEST=make valgrind bots green. Review URL: http://codereview.chromium.org/1561015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43702 0039d316-1c4b-4281-b951-d872f2087c98
* Enable interactive_ui_testsoshima@chromium.org2010-04-068-69/+145
| | | | | | | | | | | | | | | | | | | | | | | * changed DCHECK in tree_node_model to make it easy to find how it failed. * Fixed compilation error in find_bar_host_interactive_uitest.cc on linux/views. * Disabled BrowserKeyEventsTest.AccessKeys for Chromeos Added/Changed ui_test_utils::RunAllPendingInMessageLoop where necessary. * Disabled tab_dragging_tests. I included the source so that we can catch compilation error even if tests do not run. Changed the comment from // -> /* as GCC complains the use of "\" (and potentially dangerous) * Added SleepInMessageLoop to allow event loop to execute the tasks/events while waiting. * For RunAllPendingInMessageLoop change, please see http://codereview.chromium.org/1591004 BUG=39736 TEST=interactive_ui_tests should pass with following cls http://codereview.chromium.org/1594003 http://codereview.chromium.org/1545011. Review URL: http://codereview.chromium.org/1576008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43701 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding:oshima@chromium.org2010-04-064-24/+131
| | | | | | | | | | | | | | | | | BookmarkBarView tests fixes * Add BOOKMARK_CONTEXT_MENU_SHOWN notification. On Linux, event handling is asynchronous, but the showing context menu is blocking, so we can't use RunAllPending(). * Convert gtk keycode to Win when checking accelerator. BUG=39736 TEST=none (interactive_ui_tests should pass once enabled it'll be enabled by http://codereview.chromium.org/1576008 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43699 Review URL: http://codereview.chromium.org/1545011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43700 0039d316-1c4b-4281-b951-d872f2087c98
* Suppression memcheck:Addr4 error in chromium os valgrind(4) ui_testoshima@chromium.org2010-04-061-0/+15
| | | | | | | | | | BUG=40505 TEST= chromium os valgrind (4) should cycle green TBR=mrossetti@chromium.org Review URL: http://codereview.chromium.org/1562013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43699 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make content bubbles wider in languages that have long translations of ↵thakis@chromium.org2010-04-068-53/+215
| | | | | | | | | | | | | "Manage" and "Done. xib changes: Anchor bubble view on right side, make it autoresize horizontally. Same for divider line, radio groups, and title. Make widthbased tweakers at bottom horizontally autoresize. Hook up manage and done buttons to controller. BUG=39393 TEST=See bug. Review URL: http://codereview.chromium.org/1527012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43698 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress Valgrind leak (heapcheck already suppressed).cira@chromium.org2010-04-061-1/+14
| | | | | | | | | BUG=40499 TBR=mrossetti Review URL: http://codereview.chromium.org/1570014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43697 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43692 - Adds some debugging info in hopes of tracking leak insky@chromium.org2010-04-063-27/+19
| | | | | | | | | | | | | | | bounds_animator/tab_strip. BUG=40475 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/1609008 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/1512021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43696 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the underlying escaping function JsonDoubleQuoteT to escape < and > ↵inferno@chromium.org2010-04-063-5/+8
| | | | | | | | | | characters BY DEFAULT to prevent script execution. BUG=40147 TEST=StringEscapeTest.* Review URL: http://codereview.chromium.org/1512013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43695 0039d316-1c4b-4281-b951-d872f2087c98
* Change how the calculation is performed for determining the location of the ↵mrossetti@chromium.org2010-04-066-16/+28
| | | | | | | | | | | arrow tip in a bubble window. BUG=40406 TEST=1) Not in full-screen and with language set to English, press Cmd-D and verify bubble is properly positioned with arrow tip pointing to star. Change language to Espanol and repeat test. 2) Now in full-screen, repeat the tests. Review URL: http://codereview.chromium.org/1623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43694 0039d316-1c4b-4281-b951-d872f2087c98
* Fix xss in onListingParsingError by using encodeuri() on the document.location.inferno@chromium.org2010-04-061-1/+2
| | | | | | | | | | Reviewed in http://codereview.chromium.org/1512013 BUG=40147 Test=None git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43693 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some debugging info in hopes of tracking leak insky@chromium.org2010-04-063-19/+27
| | | | | | | | | | | | bounds_animator/tab_strip. BUG=40475 TEST=none TBR=jcivelli@chromium.org Review URL: http://codereview.chromium.org/1609008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43692 0039d316-1c4b-4281-b951-d872f2087c98
* Move more extensions hard coded error messages to .grd file. finnur@chromium.org2010-04-062-28/+82
| | | | | | | | | | | Patch from Thiago Farina. Previously reviewed here: http://codereview.chromium.org/931001 BUG=23086 TEST=Chrome should work as before (no visible change). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43691 0039d316-1c4b-4281-b951-d872f2087c98
* Suppress the heapcheck leak in a test.cira@chromium.org2010-04-061-0/+13
| | | | | | | | | BUG=40499 TBR=mrossetti Review URL: http://codereview.chromium.org/1585018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43687 0039d316-1c4b-4281-b951-d872f2087c98
* Make an error message verbose to investigate a un-reproducible bug.tkent@chromium.org2010-04-061-2/+7
| | | | | | | | BUG=35198 TEST=none Review URL: http://codereview.chromium.org/1528018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43686 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Don't show toolbar border without the toolbar.estade@chromium.org2010-04-061-5/+8
| | | | | | | | | BUG=39172 TEST=visual Review URL: http://codereview.chromium.org/1549021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43685 0039d316-1c4b-4281-b951-d872f2087c98
* Localize CSS files in content scripts (but don't localize JS files).cira@chromium.org2010-04-068-25/+266
| | | | | | | | | | | Add UserScriptSlave unittest. BUG=39899 TEST=List css file in content_scripts section of the manifest. Refer to an image using url(chrome-extension://__MSG_@@extension_id_/image.png); within that css. @@extension_id message should be replaced with actual id of the extension. Review URL: http://codereview.chromium.org/1585013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43684 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark manager: Fix tree indentationarv@chromium.org2010-04-062-30/+53
| | | | | | | | | BUG=39228 TEST=Create lots of nested folders (more than 10 levels deep). Review URL: http://codereview.chromium.org/1539023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43683 0039d316-1c4b-4281-b951-d872f2087c98
* Correct the bug number for the disabled chrome frame tests.ananta@chromium.org2010-04-062-2/+2
| | | | | | | | TBR=amit Review URL: http://codereview.chromium.org/1562012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43682 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Mac build, part 2.pkasting@chromium.org2010-04-061-2/+0
| | | | | | | | BUG=27570 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43680 0039d316-1c4b-4281-b951-d872f2087c98
* GTK plumbing for dragend.dcheng@chromium.org2010-04-055-34/+34
| | | | | | | | | | | This plumbs the actual dropEffect that occurred back into WebKit so that dragend is dispatched with the correct dropEffect. BUG=39399 TEST=Manual testing using the attached test case on the bug. Review URL: http://codereview.chromium.org/1589015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43679 0039d316-1c4b-4281-b951-d872f2087c98
* Add a scoped notifier for pref dictionaries / lists.chron@chromium.org2010-04-057-7/+55
| | | | | | | | | | | | | Other options included subclassing the pref value types, making the firenotifications public, or just friend classing. Since values can contain other values, such as dictionary within dictionary, it didn't seem like a good idea to subclass. We might want to consider combining the scoped lookup with the GetMutableList call at some point, but some callers keep a long reference so that might be a bad idea. BUG=38557 TEST=manual Review URL: http://codereview.chromium.org/1549020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43678 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Mac build failure.pkasting@chromium.org2010-04-051-1/+1
| | | | | | | | BUG=27570 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43677 0039d316-1c4b-4281-b951-d872f2087c98
* Replace omnibox icons with new set that are all the same size (19x19).pkasting@chromium.org2010-04-0554-3315/+67
| | | | | | | | | TBR=jnj BUG=27570 TEST=Type "paypal.com", watch as it loads, ensure address doesn't shift sideways when the lock appears. Review URL: http://codereview.chromium.org/1560015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43676 0039d316-1c4b-4281-b951-d872f2087c98
* sync: Specify linking dependencies correctly. The browser library contains ↵thestig@chromium.org2010-04-052-7/+2
| | | | | | | | | | | lots of files in chrome/browser/sync. They need to depend on the syncapi library and not just sync_proto. BUG=none TEST=Random CLs don't trigger linking errors. TBR=nick Review URL: http://codereview.chromium.org/1564010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43675 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "BookmarkBarView tests fixes"oshima@chromium.org2010-04-054-123/+22
| | | | | | | | | | I don't understand why this is still causing the problem, but reverting this for now. This reverts commit 6bb4f22703226e093644c28afe34d975cc7d549d. Review URL: http://codereview.chromium.org/1612005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43674 0039d316-1c4b-4281-b951-d872f2087c98
* Don't compare wchar_t *szork@chromium.org2010-04-051-1/+1
| | | | | | | | | BUG=38559 TEST=Manual test. Review URL: http://codereview.chromium.org/1562011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43673 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 02:56:25 +0000