| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=102540
TEST=run DownloadProtectionServiceTest::CheckClientDownloadSuccess. Doesn't current have any visible side effects.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108315
Review URL: http://codereview.chromium.org/8438012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=BUILD
Review URL: http://codereview.chromium.org/8372077
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108411 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Build
Review URL: http://codereview.chromium.org/8372068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=102526
TEST=sync_unit_tests
Review URL: http://codereview.chromium.org/8438015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allow javascript unit tests using webui test_api framework.
I moved javascript2webui.js over to chrome/test/base/js2gtest.js and shared it
across webui and unit tests with an extra parameter for test type, which governs
the few differences, such as what to include/subclass from and the flavor of
gtest (TEST_F v. IN_PROC_BROWSER_TEST_F).
v8_unit_test implemented 2 main methods to make it work with the generated C++
- AddLibrary - loads the file in the test context
- RunJavascriptF - launches the runTest with the testFixture and testName,
coordinating with Error and ChromeSend to report results.
Helper functions:
- Error - watches for console.error, noting failure if seen.
- ChromeSend - pulls apart the result from the test_api's call to
chrome.send('testResult', [ok, msg])
R=arv@chromium.org
BUG=87820
TEST=unit_tests --gtest_filter=FrameworkUnitTest.*
Review URL: http://codereview.chromium.org/8418015
TBR=scr@chromium.org
Review URL: http://codereview.chromium.org/8440060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
r=viettrungluu
Review URL: http://codereview.chromium.org/8351085
TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/8423072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
non-official builds and wasn't checked for NULL before usage.
I was tempted to use #ifdefs for all this, but that really made the
code ugly. So, we get the if check.
I'm TBRing since this is giving some instability on the bots.
BUG=102725
TEST=none
TBR=ben@chromium.org,finnur@chromium.org
R=ben@chromium.org,finnur@chromium.org
Review URL: http://codereview.chromium.org/8386069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108400 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it's not a part of ntp4. It controlled the display state of the various sections in ntp3.
BUG=76706
TEST=trybots
Review URL: http://codereview.chromium.org/8438028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=build
Review URL: http://codereview.chromium.org/8423047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108397 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
folder for unit tests.
BUG=102593
TEST=unit_tests (ExtensionServiceTest.InstallAppsWithUnlimtedStorage)
does not print error messages.
Review URL: http://codereview.chromium.org/8437030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108396 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=caseq
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8423063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108395 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
japhet synthesized this state in the renderer from just the focus
bit, which caused a mac-only regression. This is a prerequisite for
the fix.
BUG=101599
TEST=none
Review URL: http://codereview.chromium.org/8439049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108392 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I moved javascript2webui.js over to chrome/test/base/js2gtest.js and shared it
across webui and unit tests with an extra parameter for test type, which governs
the few differences, such as what to include/subclass from and the flavor of
gtest (TEST_F v. IN_PROC_BROWSER_TEST_F).
v8_unit_test implemented 2 main methods to make it work with the generated C++
- AddLibrary - loads the file in the test context
- RunJavascriptF - launches the runTest with the testFixture and testName,
coordinating with Error and ChromeSend to report results.
Helper functions:
- Error - watches for console.error, noting failure if seen.
- ChromeSend - pulls apart the result from the test_api's call to
chrome.send('testResult', [ok, msg])
R=arv@chromium.org
BUG=87820
TEST=unit_tests --gtest_filter=FrameworkUnitTest.*
Review URL: http://codereview.chromium.org/8418015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
libyuv is an open source project that includes YUV conversion and scaling functionality, which will be used for chromoting and <video>. It's also used by libjingle/peerconnection for effects and rendering related.
BUGS=none
TEST=none
Review URL: http://codereview.chromium.org/8428003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=cevans
BUG=101458
Review URL: http://codereview.chromium.org/8439065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108385 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8416043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108383 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Manual test by clicking on the panel titlebar to minimize the panel.
Review URL: http://codereview.chromium.org/8437074
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Manual
Review URL: http://codereview.chromium.org/8351080
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108381 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The problem is that chmod() fails on NTFS and FAT file systems.
That should not cause the download to fail.
The bug was introduced in r99579 (Chrome 15). I tested it with the previous revision and that one, to verify that as the point where the bug first showed up.
BUG=50104,102200
TEST=Download a file on Ubuntu, to an NTFS disk.
Review URL: http://codereview.chromium.org/8438048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108380 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=100893
TEST=NONE
Review URL: http://codereview.chromium.org/8437068
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108379 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
remove an unneeded prefs check.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8386028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108378 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=binji@chromium.org
BUG=None
TEST=WebIntentsModelTest.*
Review URL: http://codereview.chromium.org/8351060
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
The MIME type had acquired double-quotes in a recent CL, preventing the plugin from being detected and loaded.
Review URL: http://codereview.chromium.org/8387055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Hosts will have a Connect button if online, and the text Offline otherwise.
The host list will display only once one or more hosts are registered, for now.
Connection setup code still needs to be rationalized between the two modes.
The necessary host-side changes will arrive in a separate CL.
Review URL: http://codereview.chromium.org/8432021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:21585
TEST=On ChromeOS, ctrl-j for the downloads page, click on Open Downloads Folder to have a new tab open with the filemanager extension positioned in the Downloads folder.
Review URL: http://codereview.chromium.org/8439018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108374 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
it occured because after the ntp opens, if you don't do anything to add the animating-tile-page class, things don't animate. Pass true for animate in removeTile to fix this. Also, condense some code in the drop-on-trash control flow.
BUG=95021
TEST=uninstalling apps via right click menu or dragging to trash works as expected on the current NTP and other open NTPs; same for most visited tiles
Review URL: http://codereview.chromium.org/8439033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=97820
TEST=We start getting advanced clicks in Sync Promo's UMA.
R=sail@chromium.org
Review URL: http://codereview.chromium.org/8386058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
success-close.
R=binji@chromium.org
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8386057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
parameter.
By default, the autotest still runs the same pyauto suite that runs all
the perf tests: CHROMEOS_PERF. However, the autotest now accepts a
command-line option "--suite=SUITE_NAME", to run a different pyauto suite
if needed.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/8438008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=102765
TEST=
Review URL: http://codereview.chromium.org/8351088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
To see if it is just taking a long time or if there is a more serious problem.
BUG=102725
Review URL: http://codereview.chromium.org/8386067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108368 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=98687
TEST=*WebstorePrivate*
Review URL: http://codereview.chromium.org/8430033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=100392
TEST=
Review URL: http://codereview.chromium.org/8428015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=git cl try on this CL goes to linux_redux too
Review URL: http://codereview.chromium.org/8430030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
created. To get this right required moving SadTabView into its own
widget.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/8437020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108364 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
window style.
BUG=none
TEST=none
R=ben@chromium.org,jamescook@chromium.org
Review URL: http://codereview.chromium.org/8439046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108362 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/8416025
Use GYP to build nacl_irt
Converts Chrome from using scons to using GYP when building nacl_irt.
This change causes chrome to use GYP based components for untrusted
code. As a benifit, GYP will no longer need to run and scrape scons
output to determine irt dependencies. This also allows us to avoid
invoking scons during the build process.
We roll NaCl deps to get a fix for a simultaneous 32/64 bit build
issue on Windows.
This broke the mac build due to a missing dependency where pthread.h was
unavailable. This header gets copied to the correct location during the
prep_toolchain action. I've added the appropriate dependency shown bellow
to the original patch.
This add the addition dependency to ppruntime
'dependencies': [
'<(DEPTH)/native_client/src/tools.gyp:prep_toolchain'
],
TEST= try
BUG= http://code.google.com/p/chromium/issues/detail?id=96782
Review URL: http://codereview.chromium.org/8440004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=Try chromoting in arabic.
Review URL: http://codereview.chromium.org/8364025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The SunSpider suite outputs a total overall result, followed by a set of
categories, where each category includes a total result for that category,
along with the individual benchmark results within that category.
Previously, the SunSpider test in perf.py did not output the result for
each category to be graphed. It now does.
BUG=chromium-os:18457
TEST=None
Review URL: http://codereview.chromium.org/8386048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108359 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=94399
TEST=lots
Review URL: http://codereview.chromium.org/8312005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Hopefully this will result in a call stack and help diagnose the bug referenced.
BUG=102725
Review URL: http://codereview.chromium.org/8439058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8437062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
r=viettrungluu
Review URL: http://codereview.chromium.org/8351085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108352 0039d316-1c4b-4281-b951-d872f2087c98
|