summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* ake string_util::WriteInto() DCHECK() that the supplied |length_with_null| > ↵pkasting@chromium.org2011-11-2937-271/+214
| | | | | | | | | | | | 1, meaning that the without-'\0' string is non-empty. This replaces the conditional code added recently that makes this case return NULL. It's easier to understand if it's simply an error to call WriteInto() in this case at all. Add DCHECK()s or conditionals as appropriate to callers in order to ensure this assertion holds. BUG=none TEST=none Review URL: http://codereview.chromium.org/8418034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112005 0039d316-1c4b-4281-b951-d872f2087c98
* Make JavaType a struct and move it to its own filesteveblock@chromium.org2011-11-296-95/+103
| | | | | | | | | | | | | | This will simplify adding support for JavaScript arrays, where we'll need JavaType to also store the type of the array elements. Also remove NPIdentifierToString() BUG=105547 Review URL: http://codereview.chromium.org/8728005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112004 0039d316-1c4b-4281-b951-d872f2087c98
* net: make interstitials fatal for pinned sitesagl@chromium.org2011-11-299-469/+391
| | | | | | | | | | BUG=105582 TEST=net_unittests Review URL: http://codereview.chromium.org/8727003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112003 0039d316-1c4b-4281-b951-d872f2087c98
* Plumb STYEL_GENERIC thru BrowserShowHtmlDialog, ShowHtmlDialog, ↵bshe@chromium.org2011-11-2935-42/+101
| | | | | | | | | | | | | | | | | | | | | | | | | | | | CreateViewsWindow. Split from http://codereview.chromium.org/8461015/ STYEL_GENERIC is promoted from bubble_window_style in this CL: http://codereview.chromium.org/8469006/ This CL plumbs the promoted STYLE_GENERIC thru the following functions: BrowserShowHtmlDialog ShowHtmlDialog CreateViewsWindow The purpose of this change is to enable us passing a STYLE_FLUSH_CONTENT&STYLE_XBAR dialog style through BrowserShowHtmlDialog for certificate viewer html dialog. See crbug.com/102511 and http://codereview.chromium.org/8461015/ for detail. Ultimately we may be implementing the styles not related to window decorations in other platforms for consistency. BUG=102511 TEST=None Review URL: http://codereview.chromium.org/8676014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112002 0039d316-1c4b-4281-b951-d872f2087c98
* Add per-tab "JavaScript enabled" preference.mnaganov@chromium.org2011-11-2913-14/+201
| | | | | | | | | | BUG=105537 TEST=TabContentsWrapperTest.PerTabJavaScriptEnabled Review URL: http://codereview.chromium.org/8716004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112001 0039d316-1c4b-4281-b951-d872f2087c98
* Widen heapcheck suppression for PeerConnectionHandlerTest_Basic_Testcbentzel@chromium.org2011-11-291-2/+2
| | | | | | | | | BUG=105624 TBR=grunell@chromium.org Review URL: http://codereview.chromium.org/8687036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112000 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a failing DCHECK in MetricsLogManager.nileshagrawal@chromium.org2011-11-291-1/+1
| | | | | | | | | | | | | | StoreStagedLogAsUnsent can be called with a NULL staged_log_. (when compressed_staged_log_text_ is not empty). Modifying the expectation to reflect that. BUG= TEST= Review URL: http://codereview.chromium.org/8729015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111999 0039d316-1c4b-4281-b951-d872f2087c98
* Remove custom Task implementations in content renderer_host and tab_contents.dcheng@chromium.org2011-11-299-344/+139
| | | | | | | | | | | render_widget_helper.cc is a bit trickier and is being deferred to another CL. BUG=none TEST=trybots Review URL: http://codereview.chromium.org/8677004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111998 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 111988 - Land change for grunell@: "Adding support for MediaStream ↵tommi@chromium.org2011-11-2926-1760/+42
| | | | | | | | | | | | | | | | | and PeerConnection functionality. " Original review: http://codereview.chromium.org/8060055/ This is the second attempt at landing since the earlier one broke the shared component build. TBR=darin, scherkus Review URL: http://codereview.chromium.org/8725040 TBR=tommi@chromium.org Review URL: http://codereview.chromium.org/8726044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111996 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 111994 - Adding missing OVERRIDE tags.tommi@chromium.org2011-11-291-3/+3
| | | | | | | | | TBR=motownavi TBR=tommi@chromium.org Review URL: http://codereview.chromium.org/8659049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111995 0039d316-1c4b-4281-b951-d872f2087c98
* Adding missing OVERRIDE tags.tommi@chromium.org2011-11-291-3/+3
| | | | | | TBR=motownavi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111994 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable ExtensionServiceTest.UninstallExtension on Windows (speculatively).yoz@chromium.org2011-11-291-8/+1
| | | | | | | | | | | under the presumption that http://codereview.chromium.org/8598028/ fixes the possible ScopedTempDir issues. BUG=96296 TEST=ExtensionServiceTest.UninstallExtension Review URL: http://codereview.chromium.org/8588071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111993 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize resource bundle for GPU process on Mac, so it can load its ↵jochen@chromium.org2011-11-291-0/+2
| | | | | | | | | | | | sandbox definition BUG=105720 TEST=none (guess why it broke it the first place :-/ ) Review URL: http://codereview.chromium.org/8727030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111992 0039d316-1c4b-4281-b951-d872f2087c98
* Memcheck::Unaddressable suppression for WebCore::CachedResource::finishcbentzel@chromium.org2011-11-291-0/+15
| | | | | | | | | BUG=104749 TBR=simonjam@chromium.org Review URL: http://codereview.chromium.org/8726042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111989 0039d316-1c4b-4281-b951-d872f2087c98
* Land change for grunell@: "Adding support for MediaStream and PeerConnection ↵tommi@chromium.org2011-11-2926-42/+1760
| | | | | | | | | | | | | | functionality. " Original review: http://codereview.chromium.org/8060055/ This is the second attempt at landing since the earlier one broke the shared component build. TBR=darin, scherkus Review URL: http://codereview.chromium.org/8725040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111988 0039d316-1c4b-4281-b951-d872f2087c98
* Widen suppression for NetworkInfoDictionary::set_iconcbentzel@chromium.org2011-11-291-1/+1
| | | | | | | | | BUG=99307 TBR=mnissler@chromium.org Review URL: http://codereview.chromium.org/8687035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111987 0039d316-1c4b-4281-b951-d872f2087c98
* Properly initialize the next callback ID to 1.brettw@chromium.org2011-11-291-1/+1
| | | | | | | | | | | This is necessary because 0 is reserved as an error value. This causes the first file ref call used from the proxy to fail. BUG=89961 Review URL: http://codereview.chromium.org/8659017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111986 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the UMA out of process test and add a comment that we're not planning onbrettw@chromium.org2011-11-291-4/+2
| | | | | | | proxying this any time soon. Review URL: http://codereview.chromium.org/8726012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111985 0039d316-1c4b-4281-b951-d872f2087c98
* Photo Editor: disable Autofix button if the image is already well balanced.kaznacheev@chromium.org2011-11-294-129/+119
| | | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/8729026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111984 0039d316-1c4b-4281-b951-d872f2087c98
* Itemize and layout text lazily in RenderTextWin.asvitkine@chromium.org2011-11-292-5/+38
| | | | | | | | | | | | This matches what is done in render_text_linux.cc and avoids doing unnecessary work unless needed. BUG=none TEST=Run chrome.exe with command-line --use-pure-views. Edit text in the omnibox. It should work as before. Review URL: http://codereview.chromium.org/8633019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111983 0039d316-1c4b-4281-b951-d872f2087c98
* Suppression for ChromeRenderViewObserver::CaptureFrameThumbnail.cbentzel@chromium.org2011-11-291-0/+17
| | | | | | | | | BUG=105744 TBR=reed@chromium.org Review URL: http://codereview.chromium.org/8728034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111982 0039d316-1c4b-4281-b951-d872f2087c98
* Disk cache: Update the remove/insert data files.rvargas@google.com2011-11-2967-17/+18
| | | | | | | | | | | | It's been 2 years and three months since the pointer member of RankingsNode was deprecated. These test files were saved before that. BUG=100125 TEST=none Review URL: http://codereview.chromium.org/8637022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111979 0039d316-1c4b-4281-b951-d872f2087c98
* Working around gsutil not liking drive letters plus backslashes.bradnelson@google.com2011-11-291-2/+1
| | | | | | | | | | | BUG=None TEST=None R=noelallen@google.com TBR Review URL: http://codereview.chromium.org/8659046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111978 0039d316-1c4b-4281-b951-d872f2087c98
* Remove empty files.tony@chromium.org2011-11-294-0/+0
| | | | | | | | These files were supposed to be removed by r111811. TBR=ojan git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111977 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust suppression for leak in nss_ClearErrorStack.cbentzel@chromium.org2011-11-291-3/+6
| | | | | | | | | BUG=77990 TBR=wtc@chromium.org Review URL: http://codereview.chromium.org/8664033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111974 0039d316-1c4b-4281-b951-d872f2087c98
* Remove JingleSessionManager::set_allow_local_ips().sergeyu@chromium.org2011-11-294-15/+2
| | | | | | | | | Currently allow_local_ips is always set to true, and there is no reason not to allow local IP addresses. Review URL: http://codereview.chromium.org/8728011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111973 0039d316-1c4b-4281-b951-d872f2087c98
* Makes ppapi tests copy files over unconditionally.sky@chromium.org2011-11-291-16/+16
| | | | | | | | | | | BUG=none TEST=none R=noelallen@chromium.org Review URL: http://codereview.chromium.org/8661003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111972 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Breakpad-enabled Mac builds following r111783, with the Breakpad updatemark@chromium.org2011-11-291-0/+9
| | | | | | | past r889. Review URL: http://codereview.chromium.org/8729037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111971 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a WebGraphicsContext3D implementation that will be used forsky@chromium.org2011-11-294-4/+493
| | | | | | | | | | | | | | testing and what not. I'll wire this up separately. BUG=104360 TEST=none R=piman@chromium.org Review URL: http://codereview.chromium.org/8729016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111970 0039d316-1c4b-4281-b951-d872f2087c98
* Force annotation of overridden methods with OVERRIDE.avi@chromium.org2011-11-2915-64/+70
| | | | | | | | | BUG=104314 TEST=green builds Review URL: http://codereview.chromium.org/8727007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111969 0039d316-1c4b-4281-b951-d872f2087c98
* checkbins.py: enable /SAFESEH check now that all binaries are passing.scherkus@chromium.org2011-11-291-3/+1
| | | | | | | | BUG=104188 Review URL: http://codereview.chromium.org/8726019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111968 0039d316-1c4b-4281-b951-d872f2087c98
* Widen heapcheck suppression for StopAssociationSynccbentzel@chromium.org2011-11-291-4/+0
| | | | | | | | | BUG=105667 TBR=timsteele@chromium.org Review URL: http://codereview.chromium.org/8659043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111967 0039d316-1c4b-4281-b951-d872f2087c98
* Fix chromedriver shutdown tests.kkania@chromium.org2011-11-291-7/+7
| | | | | | | | | | BUG=none TEST=none TBR=hnguyen Review URL: http://codereview.chromium.org/8729038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111966 0039d316-1c4b-4281-b951-d872f2087c98
* Use callback_forward.h instead of callback.h where possible.erikwright@chromium.org2011-11-2913-10/+13
| | | | | | | | | | | | | | | | | callback_forward.h will be committed separately, before this commit, and is included here only to assist in running try jobs. It will be removed before the final commit. You are asked to review this as you have OWNERS for these files. BUG=None TEST=Compiles R=jam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111936 Review URL: http://codereview.chromium.org/8699010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111965 0039d316-1c4b-4281-b951-d872f2087c98
* Fix resource file generation to point to output_dir instead of build_dir.siggi@chromium.org2011-11-291-7/+8
| | | | | | | | | | | | | This makes the RC script correct for the Syzygy-optimized mini_installer, which was previously turning out identical to the unoptimized one. Quench annoying progress spew from makecab. R=rogerm@chromium.org,robertshield@chromium.org Review URL: http://codereview.chromium.org/8726035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111962 0039d316-1c4b-4281-b951-d872f2087c98
* Fix python scripts in src/tools/maruel@chromium.org2011-11-297-0/+0
| | | | | | | | | | | Continuation of r111960. The commit queue doesn't support yet removing svn:executable bit so some changes were left out. BUG=105108 Original Review URL: http://codereview.chromium.org/8678023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111961 0039d316-1c4b-4281-b951-d872f2087c98
* Fix python scripts in src/tools/maruel@chromium.org2011-11-2998-559/+498
| | | | | | | | | | | | | | | | | | Make sure that: - shebang is only present for executable files - shebang is #!/usr/bin/env python - __main__ is only present for executable files - file's executable bit is coherent Also fix EOF LF to be only one. TBR=timurrrr@chromium.org BUG=105108 TEST= Review URL: http://codereview.chromium.org/8678023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111960 0039d316-1c4b-4281-b951-d872f2087c98
* Tighten up chrome/browser's DEPS so that we don't have any more includes ↵jam@chromium.org2011-11-291-39/+18
| | | | | | | | | from content/common while we remove the last ones. BUG=98716 Review URL: http://codereview.chromium.org/8727035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111959 0039d316-1c4b-4281-b951-d872f2087c98
* remove entry from includes as it is already pulled from the dependenciesensonic@google.com2011-11-291-1/+0
| | | | | | Review URL: http://codereview.chromium.org/8440063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111958 0039d316-1c4b-4281-b951-d872f2087c98
* Move the RendererProcessType enum out of ChildProcessInfo. It's actually ↵jam@chromium.org2011-11-297-84/+82
| | | | | | | | | never set on that object, and is only used/set by chrome, so moved it out to memory_details.h:ProcessMemoryInformation. BUG=98716 Review URL: http://codereview.chromium.org/8726022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111957 0039d316-1c4b-4281-b951-d872f2087c98
* enable shadermask optimization in skiareed@google.com2011-11-291-1/+1
| | | | | | Review URL: http://codereview.chromium.org/8725035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111956 0039d316-1c4b-4281-b951-d872f2087c98
* Implementing prefetch in the Photo Editorkaznacheev@chromium.org2011-11-294-175/+434
| | | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/8658007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111955 0039d316-1c4b-4281-b951-d872f2087c98
* jGet the examples to run in aura_shell.ben@chromium.org2011-11-2954-745/+1289
| | | | | | | | | | | | | | . Reorganizes views_examples target into two: views_examples_lib (a component) and views_examples_exe (a runner in views, which builds in Aura but does not run without crashing due to lack of desktop environment). . Refactors ExamplesMain into ExamplesWindowContents, a contents view that hosts the examples UI. Makes a publicly exported function from views examples to show a window containing this view. . Moves the examples into the views namespace. . Adds a button to launch the ExamplesWindow inside aura_shell. . Adds a NativeTabbedPaneViews to host the examples content. This is not a production class and is mostly just intended to get something onto the screen. The code is copy-pasta from NativeTabbedPaneWin. I imagine we can get rid of all of this once we stop using TabbedPanes in Chrome. http://crbug.com/105622 TEST=none Review URL: http://codereview.chromium.org/8687013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111954 0039d316-1c4b-4281-b951-d872f2087c98
* The root of problem is x button or alt+f4 didn't close the window ↵bshe@chromium.org2011-11-292-3/+6
| | | | | | | | | | | | | | completely. There are still something in the pendingdialog list need to be cleaned. BUG=105311 TEST=settings->under the hood->Manage certificates->import; close the dialog by x button or alt+f4; click import button again; verify if the dialog shows up again. Review URL: http://codereview.chromium.org/8692006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111953 0039d316-1c4b-4281-b951-d872f2087c98
* aura: #include a header used. This caused a compilation error from r111936.sadrul@chromium.org2011-11-291-0/+5
| | | | | | | | | BUG=105713 TEST=none Review URL: http://codereview.chromium.org/8664030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111952 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ChildThread dependency from Chrome. In the future we might want to ↵jam@chromium.org2011-11-293-10/+12
| | | | | | | | | expose it as an interface, but for now that's not required. BUG=98716 Review URL: http://codereview.chromium.org/8726023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111951 0039d316-1c4b-4281-b951-d872f2087c98
* Suppression for OptionsUIHTMLSource uninitialized memory.cbentzel@chromium.org2011-11-291-0/+25
| | | | | | | | | BUG=105715 TBR=mnissler@chromium.org Review URL: http://codereview.chromium.org/8725038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111950 0039d316-1c4b-4281-b951-d872f2087c98
* Use callback_forward.h instead of callback.h where possible.erikwright@chromium.org2011-11-292-2/+2
| | | | | | | | | | | | | | | callback_forward.h will be committed separately, before this commit, and is included here only to assist in running try jobs. It will be removed before the final commit. You are asked to review this as you have OWNERS for these files. BUG=None TEST=Compiles R=mnissler@chromium.org Review URL: http://codereview.chromium.org/8700012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111949 0039d316-1c4b-4281-b951-d872f2087c98
* Use callback_forward.h instead of callback.h where possible.erikwright@chromium.org2011-11-291-1/+1
| | | | | | | | | | | | | | | callback_forward.h will be committed separately, before this commit, and is included here only to assist in running try jobs. It will be removed before the final commit. You are asked to review this as you have OWNERS for these files. BUG=None TEST=Compiles R=darin@chromium.org Review URL: http://codereview.chromium.org/8699009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111948 0039d316-1c4b-4281-b951-d872f2087c98
* Use callback_forward.h instead of callback.h where possible.erikwright@chromium.org2011-11-294-5/+3
| | | | | | | | | | | | | | | callback_forward.h will be committed separately, before this commit, and is included here only to assist in running try jobs. It will be removed before the final commit. You are asked to review this as you have OWNERS for these files. BUG=None TEST=Compiles R=ajwong@chromium.org Review URL: http://codereview.chromium.org/8697005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111947 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-28 06:31:57 +0000