| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
transaction
is recreated, and make sure that truncated_ is also creared.
This is a tentative fix for some crashes from the reliability bot.
BUG=28850
TEST=none
TBR=eroman
Review URL: http://codereview.chromium.org/444020
TBR=rvargas@google.com
Review URL: http://codereview.chromium.org/452002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is re-created, and make sure that truncated_ is also creared.
This is a tentative fix for some crashes from the reliability bot.
BUG=28850
TEST=none
TBR=eroman
Review URL: http://codereview.chromium.org/444020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modified the FlipIOBuffer to use a DrainableIOBuffer instead
of a IOBufferWithSize. When a write completes, we drain the
bytes, and only fetch the next FlipFrame from the queue after
we have fully drained the buffer.
I will update the tests to be much more thorough in my next
CL.
BUG=none
TEST=FlipNetworkTransactionTest.PartialWrites
Review URL: http://codereview.chromium.org/451002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
stderr. This is a re-submit of an earlier checkin that we reverted (r32911),
but fixes the problem where we tried to delete open files, and also doesn't
double-write the error log.
BUG=none
R=ukai@chromium.org
TEST=none
Review URL: http://codereview.chromium.org/444019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33244 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The concept of "ticket promotion" is added to the application when Keystone is
in use. Ticket promotion is used to turn a user Keystone ticket, which Chrome
normally establishes when it launches, into a system Keystone ticket, after
successful user authentication and authorization. Having a system Keystone
with a system ticket means that updates are applied with root privileges
instead of user privileges, essentially eliminating the possibility that a
user will fall off of the auto-update train because they can read and execute
but not write the application.
Two principles of promotion apply:
- An application on a user ticket NEEDS promotion if it determines that it
doesn't have permission to write to itself. Being on a user ticket, an
update attempt would fail.
- An application on a user ticket WANTS promotion if it already NEEDS
promotion. Additionally, if it is installed in a system-wide location
such as /Applications, it will WANT promotion, even if it does not NEED it.
If promotion is needed, an info bar will show up on launch requesting it.
This info bar works similarly to the default browser info bar: it has a "don't
bother me again" button, it will only show up after the first launch, it won't
disappear on navigation if the navigation happens very quickly, and it won't
show itself if another info bar is up. This means that if both the default
browser info bar and the promotion info bar have a shot at showing, only one
will win. In my experience, each wins about half of the time.
If promotion is needed, the update UI in the About window will be hidden.
Checking for updates and offering to apply them doesn't make much sense when
the update won't be able to install successfully. All of the auto-update
machinery is still working in the background, but the About window UI is
hidden.
If promotion is wanted, the About window will contain a new button allowing
the user to enter promotion. This gives access to the same promotion routine
as the promotion info bar. It can be used even from an administrative account
that is able to update the application without promotion. It's intended to be
used by the system administrator of the family without requiring them to
switch to one of the kids' accounts.
BUG=16360
TEST=Exhaustively, please.
Review URL: http://codereview.chromium.org/437053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=trybot
BUG=28918
Review URL: http://codereview.chromium.org/450001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=trybots
BUG=10351,17015
Review URL: http://codereview.chromium.org/449001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=trybots
BUG=none
Review URL: http://codereview.chromium.org/448001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=trybots
BUG=none
Review URL: http://codereview.chromium.org/444018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=trybot
BUG=23473
Review URL: http://codereview.chromium.org/434122
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=trybot
BUG=none
Review URL: http://codereview.chromium.org/447003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=trybot
BUG=none
Review URL: http://codereview.chromium.org/443024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=trybot
BUG=none
Review URL: http://codereview.chromium.org/443023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
file_util::CreateDirectory() function is supposed to succeed if the
directory already exists, but in the previous implementation when two
processes/threads called the function at the same time for the same
path, one would see a failure.
Also, get rid of the use of SHCreateDirectoryEx function. For one, it
is highly serializing because it calls SHChangeNotify. The race was
actually easy to reproduce by starting two instances of Chrome both at
the same time, with a profile directory flag indicating a profile
directory that did not previously exist.
For another, SHCreateDirectoryEx would fail with ERROR_CANCELLED if
any of the path components were not visible, according to its MSDN
documentation.
BUG=none
TEST=[base_unittests.exe --gtest_filter=*CreateDirectory* ], and/or install Chrome Frame on a fresh machine and make sure the first page you navigate to has two Chrome Frame instances on it - you should get no DCHECK on failure of PathService::Override
Review URL: http://codereview.chromium.org/437090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/447001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/434112
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG10458 LINUX : LayoutTests/fast/dom/java-applet-calls.html = FAIL
BUG23488 MAC : LayoutTests/fast/overflow/004.html = IMAGE
BUG=10458,23488
TEST=trybot
Review URL: http://codereview.chromium.org/446003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
own copy using DEPS. This is to avoid pywebsocket version mismatch.
If in the future WebKit supports DEPS-like mechanism, we should switch
back to DEPS-based approach.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/444014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
SystemMonitor makes an assumption that through its lifetime a MessageLoop exists and stays the same. It is difficult and error-prone to satisfy that when it is a Singleton. It has caused problems in the past.
Additionally, extract HighResoltionTimerManager out of time_win.cc, eliminating yet another Singleton.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/431008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also, for inactive toolbar on Windows, use a grayscale version of blue.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/444015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
https://bugs.webkit.org/show_bug.cgi?id=31832
BUG=2084
Review URL: http://codereview.chromium.org/443022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
net_unittests
TBR=dank
TEST=TSAN Mac bot should become ~20% faster on net_unittests
Review URL: http://codereview.chromium.org/443020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
library with upstream source code from the new vendor branch patterns
in third_party\jemalloc and third_party\tcmalloc.
BUG=27911
TEST=none
Review URL: http://codereview.chromium.org/435040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33208 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=20450,20458
TBR=abarth
Review URL: http://codereview.chromium.org/434113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=27364
TEST=DevToolsSanityTest.TestCachedResourceMimeType
Review URL: http://codereview.chromium.org/437089
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert "Fix a memory leak in DnsReloadTimer"
Valgrind test_shell_tests still fails, will investigate offline. :(
TBR=wtc
BUG=12710
Review URL: http://codereview.chromium.org/434115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=wtc
BUG=12710
Review URL: http://codereview.chromium.org/443019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) Added the link to the ignore files documentation
2) Fixed a typo
3) Used new "fun_r" instead of "fun" for a couple of functions to speed up some large tests from net_, unit_ and ui_.
4) Used new "fun_hist" for unibrow namespace to do coarser history tracking - bottleneck on unit_.
Please see http://code.google.com/p/data-race-test/wiki/ThreadSanitizerIgnores
for the details of new ignore rules. They are present since the new TSAN version (rev1274)
TBR=dank
TEST=TSAN bots should remain green AND become faster.
Review URL: http://codereview.chromium.org/441028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We're going to have it enabled for all tests, but I'm enabling
it one-by-one to limit damage from possible problems.
TEST=none
BUG=12710
Review URL: http://codereview.chromium.org/439007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I should have modified the non-static version.
BUG=none
TEST=none
TBR=aa
Review URL: http://codereview.chromium.org/437088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/399073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=atwilson
BUG=28847
TEST=none
Review URL: http://codereview.chromium.org/434111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=rvargas
BUG=28850
TEST=none
Review URL: http://codereview.chromium.org/437087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
WbeKit bug 31873 (https://bugs.webkit.org/show_bug.cgi?id=31873) changes the context "data" from a JavaScript object to a string. This c$
BUG=23058
TEST=none
Review URL: http://codereview.chromium.org/443002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Div sizes and positions in the actual results image look good to me, but it is failing due to subtle differences in fonts for the test description.
BUG=10458
TEST=none
Review URL: http://codereview.chromium.org/437058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jorlow
BUG=11838
TEST=none
Review URL: http://codereview.chromium.org/437086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=stuartmorgan
BUG=28824
TEST=none
Review URL: http://codereview.chromium.org/443018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBT=atwilson
BUG=28847
TEST=none
Review URL: http://codereview.chromium.org/444013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=willchan
BUG=28818, 28828
TEST=Random ui test / startup flakiness goes away on Linux.
Review URL: http://codereview.chromium.org/437085
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For WebKit, https://bugs.webkit.org/show_bug.cgi?id=31861 is underway.
This patch will make Chromium use the same version.
(An alternative would be to change DEPS and test scripts to use
pywebsocket under src/third_party/WebKit/WebKitTools. Perhaps I may
address it in a separate change.)
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/441015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
0.5% of users will participate websocket live experiment.
BUG=28843
TEST=none
Review URL: http://codereview.chromium.org/434110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=atwilson
BUG=28847
TEST=none
Review URL: http://codereview.chromium.org/443016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
page_heap_linux.cc, since the Linux build can't use the current
Windows-specific version of page_heap.cc.
Adds #ifdef in page_heap.h for API changes where the old API is
still used by Linux and the new API is used by windows.
BUG=27911
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
latest script:
http://groups.google.com/group/chromium-extensions/browse_thread/thread/bca3dea2da278813/8083425efdf11186#8083425efdf11186
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/436024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Fix disabled code to make it compile again.
* The test doesn't pass if the importer thinks this is the first run of
the browser, so call CreateSentinel() to mark this as a subsequent run.
BUG=11838
TEST=none
Review URL: http://codereview.chromium.org/437083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
updated upstream (bugs.webkit.org/show_bug.cgi?id=31455).
BUG=10432
TEST=none
Review URL: http://codereview.chromium.org/384042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Run src/webkit/tools/layout_tests/layout_package/http_server.sh without
arguments, and observe the process exits gracefully (does not print traceback).
Review URL: http://codereview.chromium.org/435042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33175 0039d316-1c4b-4281-b951-d872f2087c98
|