| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also do a bunch of cleanup:
-move safe browsing messages together
-get rid of webkit_param_traits and common_param_trait since they're no longer needed
-remove the multiple include of IPC files from places that don't need it
TBR=tsepez
Review URL: http://codereview.chromium.org/6713084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79235 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=cmp
Review URL: http://codereview.chromium.org/6734001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79234 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
R=darin@chromium.org,brettw@chromium.org,jam@chromium.org,ben@chromium.org
Review URL: http://codereview.chromium.org/6534012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79233 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason: it does a memcpy on the stack.
BUG=None
TEST=None
R=avi@chromium.org,maruel@chromium.org
Review URL: http://codereview.chromium.org/6730002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=cmp
TBR=ericu@google.com
Review URL: http://codereview.chromium.org/6733014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=cmp
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove unused header includes.
Original review:
http://codereview.chromium.org/6712006/
BUG=
TEST=
Review URL: http://codereview.chromium.org/6711051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79229 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Instead, return the FileSystem URI of the root. This will make it easier
to swap in different filesystem implementations.
BUG=71635
TEST=Just a couple in FileSystemUtilTests, but a bunch of existing ones [this doesn't add much new functionality].
Review URL: http://codereview.chromium.org/6603034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79228 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Linux dual monitor environment", FireFox uses Xinerama to get screen width/height information. If we cannot use Xinerama, return the same width/height info as before.
BUG=28560
TEST=1, Prepare dual monitor Linux system which can use Xinerama. 2, Launch browser and run javascript "document.write("screen.witdh = " + screen.width + "<br>");". 3, Make sure the width is in single monitor width size.
Patch by Takano.Naoki@gmail.com.
Original Review: http://codereview.chromium.org/6714036/
Review URL: http://codereview.chromium.org/6725024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This value is accrued without locking, and hence is too
commonly corrupted. Even if it is gathered
perfectly, I've been informed that for very large
samples the computed variance is "not a stable
metric" and can diverge." If we did want to
look at the variance for most distribution, then
we need to look at the variance of the log
normal distribution, which would mean we wanted
to take the sum-of-squares of the log, which is
computationally intense... and probably of little
value.
Bottom line: Remove the useless metric.
I still need to change the protobufs so that
this value is optional in uploads, but other than
that tiny point, this CL removes almost all
traces of this metric.
r=rtenneti
Review URL: http://codereview.chromium.org/6672071
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79225 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Disabled the TCMalloc double-free detection,
which should restore much of the performance loss
caused by this experiment (to find double frees,
if any). This should resolve bug 76640
As an alternate experiment to better illuminate our
memory corruption problem, this CL also enables
WinHeap (default Windows allocator) in the browser
process. There is a chance that this will cause a
very tiny reduction in performance, but it will surely
increase our crash rate (based on what we saw recently
on the dev channel).
BUG=76640
r=rtenneti
Review URL: http://codereview.chromium.org/6705027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79224 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/6705015 /
http://trac.webkit.org/changeset/81821 .
TBR=tkent@chromium.org,tony@chromium.org
Review URL: http://codereview.chromium.org/6676103
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=71097
TEST=none; no visible change
Review URL: http://codereview.chromium.org/6672059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
While this slightly degeneralizes some stats-collection code,
the svn history shows that this code has, over several years, only been used for SDCH,
and thus it's worth some degeneralization in order to greatly simplify URLRequestJob.
BUG=none
TEST=try bots
Review URL: http://codereview.chromium.org/6713019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/6719014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/6725027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79216 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=set kGpuMaxCrashCount to zero and verified the test fails
Review URL: http://codereview.chromium.org/6705008
TBR=amarinichev@chromium.org
Review URL: http://codereview.chromium.org/6730014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move ExtractCompositionInfo method in chrome/browser/renderer_host/gtk_im_context_wrapper.cc to ui/base/gtk/gtk_im_context_util.cc
BUG=75003
TEST=none
Review URL: http://codereview.chromium.org/6709023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6719006
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/6696053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79212 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=72040
TEST=none
Review URL: http://codereview.chromium.org/6719006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/6674041
Patch from Huyen Nguyen <hnguyen@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79210 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
enum histogram.
BUG=
TEST=ClientSideDetectionHostTest
Review URL: http://codereview.chromium.org/6725036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79207 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:11613
TEST=imageburner should download the latest mario beta and burn it on a usb stick.
Review URL: http://codereview.chromium.org/6312143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=70659
TEST=none
Review URL: http://codereview.chromium.org/6731009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window.open to launch a popup
BUG=70659
TEST=Tests should not fail on Pyauto bots
Review URL: http://codereview.chromium.org/6731008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Patch from Fabien Tassin <fta@sofaraway.org>.
R=tony@chromium.org,darin@chromium.org
Review URL: http://codereview.chromium.org/6729004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79202 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes made by this CL:
1. Adds OnBeforeUserAction() and OnAfterUserAction() in TextfieldController.
2. Adds Textfield::HasSelection().
3. Changes NativeTextfieldViews to use KeyEvent::GetCharacter().
3. Refactors AutocompleteEditViewViews to use new TextfieldController methods.
BUG=75003
TEST=views_unittests --gtest_filter=*Textfield* and interactive_ui_tests --gtest_filter=AutocompleteEditViewViews*
Review URL: http://codereview.chromium.org/6685082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=mirandac,dmaclach
Review URL: http://codereview.chromium.org/6730007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
work for any source.
BUG=none
TEST=none
R=phajdan.jr@chromium.org
Review URL: http://codereview.chromium.org/6722027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
startup urls and last of pinned tabs.
BUG=67227
TEST=see bug
R=brettw@chromium.org
Review URL: http://codereview.chromium.org/6705010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=With pepper flash
Review URL: http://codereview.chromium.org/6725037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I forgot to update the README.chromium in r62331 to mention that we have local
changes to this code now.
BUG=none
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79196 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
split them each into 2 equivalent groups of equal size for comparison
purposes.
R=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/6731007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=set kGpuMaxCrashCount to zero and verified the test fails
Review URL: http://codereview.chromium.org/6705008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79194 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
591 Switched to D3D10 shader compiler.
590 Track dirty texture parameters and images separately.
589 Track texture serials instead of id's.
588 Keep track of applied textures and dirty state to minimize D3D calls.
587 Fix checking for floating-point render target texture support.
586 Copy texture data of incomplete textures to the image arrays.
585 Retrieve current texture properties from the image array to avoid D3D call.
584 Retrieve texture width, height and type from the top-level image.
583 Texture image refactoring.
582 Remove redundant dirtyImageData() check.
581 Check image type in texture completeness test.
580 InternalFormat and format are the same.
579 Fix dirty texture state management.
578 Eliminate the weak base texture pointer.
R=kbr@chromium.org
Review URL: http://codereview.chromium.org/6725003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/6696048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79189 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
In r79038, I moved the inspector files into resources.pak, so
we don't need to include the directory anymore.
Review URL: http://codereview.chromium.org/6722010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
sampleRate()
BUG=none
TEST=none
TBR=tony@chromium.org
Review URL: http://codereview.chromium.org/6733006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79187 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Changing the pyauto popup tests to use this.
BUG=70659
TEST=Popup tests should not fail on pyauto bots
Review URL: http://codereview.chromium.org/6724016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(media://...).
The raw video pipeline graph only has two filters - one pass-thru decoder filter and one renderer filter.
Contributed by ronghuawu@google.com
Original code reviews:
http://codereview.chromium.org/6658001/ (pipeline changes)
http://codereview.chromium.org/6621049/ (pass-thru filter)
BUG=none
TEST=media_unittests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79149
Review URL: http://codereview.chromium.org/6726006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79185 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It was MIA for some reason.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6726014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- linux-release-hardy/dhtml/vm_rss_final_b/vm_rss_f_b (from r78369)
- linux-release-hardy/dhtml/vm_rss_final_t/vm_rss_f_t (from r78369)
BUG=none
TEST=perf steps are green
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/6732004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Infer clean shutdown from the fact that shutdown methods are being called, so clients don't have to make two MetricsService shutdown calls at each stage of shutdown.
BUG=None
TEST=Existing tests
Review URL: http://codereview.chromium.org/6712020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79182 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=bots green
TBR=nduca@chromium.org
R=avi@chromium.org,darin@chromium.org,brettw@chromium.org,jam@chromium.org,ben@chromium.org
Review URL: http://codereview.chromium.org/6732003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes issue 76963, in which a tab closure while a page is being saved results in a crash. See that issue for details.
BUG=76963
TEST=Relevant tests pass, can't repro 76963.
Review URL: http://codereview.chromium.org/6708075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
data when the gpu process is running.
BUG=77170
TEST=in windows, run crash_service.exe, run chrome --noerrdialogs, go to about:crash, view crash dump files in <userdir>\AppData\Local\Chromium\User Data\Crash Reports
Review URL: http://codereview.chromium.org/6722009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interfaces will allow JavaScript to send data asynchronously to a module instance, and the module instance to asynchronously send data to a JavaScript message handler.
Note, I did something differently from other per-instance interfaces. While the C interface has 'PPB_Messaging' and 'PPP_Messaging' separate from the Instance interfaces, I stuck the per-instance messaging in to pp::Instance. It seems more intuitive to me, and doesn't have the drawbacks of having too many functions in the C layer instance interfaces. Happy to back off of that position, but it's worth a shot.
Overview:
From JavaScript, you can invoke 'postMessage' on the embedded module. That results in a call to 'PPP_Messaging::HandleMessage'.
From Native Code, you can invoke 'PPB_Messaging::PostMessage', which results
in a call to an 'onmessage' function on the DOM element for the module
instance in the JavaScript code (if one has been registered).
Please see the included example or the examples in the comments of
PPB_Messaging and PPP_Messaging.
Restrictions:
- This implementation is synchronous. A later CL will make it asynchronous.
- This implementation supports only intrinsic values and strings (all types that PP_Var supports except for objects). Object & array support will come later.
- This implementation only allows for 1 channel per instance. You can not expose other 'channels' or 'ports'. Future CLs will add support for MessagePorts.
BUG=None
TEST=test_post_message.h/.cc
(This CL replaces http://codereview.chromium.org/6538028/ )
Review URL: http://codereview.chromium.org/6716005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79178 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Increasing renderer command-line size leads to problems. This is a temporary
work-around, but a long term solution is needed.
BUG=chromium-os:13289
TEST=before patch, increase renderer command line size to about 1k, observe the
hangs. apply patch, observe no hang with same command line.
Review URL: http://codereview.chromium.org/6733001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79177 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=pfeldman
BUG=
TEST=
Review URL: http://codereview.chromium.org/6733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79176 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
graphics card changed, we reset the info; otherwise, only fill in the originally unset fields instead of of overwriting everything. The reason is that the newly collected information may not always be more comprehensive then the previous ones.
With this CL, we can remove the duplicate information collection in preliminary GPUInfo collection and full GPUInfo collection. Also, this prepares us to handle dual GPUs and dymanic GPU switching situations.
BUG=none
TEST=bots green
Review URL: http://codereview.chromium.org/6726028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79175 0039d316-1c4b-4281-b951-d872f2087c98
|