summaryrefslogtreecommitdiffstats
path: root/AUTHORS
Commit message (Collapse)AuthorAgeFilesLines
* Copy Mark Seaborn from the Native Client authors file to the Chromium authorsbrettw@chromium.org2011-08-261-0/+1
| | | | | | | | | | | | file. This makes the Native Client authors file a subset of the Chromium one so that we can update the copyright notices of the code we recently moved into the Chrome repo to be "Copyright the Chromium Authors." TEST=none BUG=none Review URL: http://codereview.chromium.org/7770001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98499 0039d316-1c4b-4281-b951-d872f2087c98
* Optimize all images in chrome/app and chrome/browser.tony@chromium.org2011-08-151-0/+1
| | | | | | | | | | | | | | | | | | | The following lossless PNG crunchers were used: - AdvPNG - OptiPNG - PNGCrush - PNGOUT Total savings: 1.001.550 bytes, i.e. almost 1 MB. Patch from Mathias Bynens <mathias@qiwi.be> BUG=chromium:92525 TEST=none Review URL: http://codereview.chromium.org/7638001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96786 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a corner case bug in the HexStringToInt conversion function which ↵ali.akbar@gmail.com2011-08-121-0/+1
| | | | | | | | | | | | | | | | | | | | | caused the string "0x" to be treated as a valid hexadecimal number. Although the parsed result was 0, the boolean flag returned indicated that the hex number was in proper format The IteratorRangeToNumber class's Invoke function increments the string pointer by 2 if the string starts with "0x" or "0X" and the length is greater than *or equal* to 2 If the length of the string is 2, i.e "0x", after the pointer increment, the string would be empty and the function returns true as the parse result Changed the condition from "greater than or equal to" to "greater than" Added another test cases which now properly treats "0x" as an invalid hex string Contributed by ali.akbar@gmail.com BUG=92054 Review URL: http://codereview.chromium.org/7584031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96605 0039d316-1c4b-4281-b951-d872f2087c98
* Added a link to the downloads tab that opens the downloads folder.fhd@ubercode.de2011-07-281-0/+1
| | | | | | | | | | | | Contributed by fhd@ubercode.de BUG=8915 TEST=chrome://downloads has a link labeled "Open downloads folder" that opens the configured downloads folder. Review URL: http://codereview.chromium.org/7398026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94493 0039d316-1c4b-4281-b951-d872f2087c98
* Disable part of InProcessBrowserTest.InjectIDBKey to prepare for upstream ↵levin@chromium.org2011-07-191-0/+1
| | | | | | | | | | | | | changes. InProcessBrowserTest.InjectIDBKey depends on internal details about the format produced by WebSerializedScriptValue; this format will change should https://bugs.webkit.org/show_bug.cgi?id=63481 land. After the WebKit change is complete, this test will be re-enabled in a way that works with the new format. BUG=None TEST=This is a test modification. Review URL: http://codereview.chromium.org/7400030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93053 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up of -Wunused-but-set-variable (gcc 4.6)pph34r@gmail.com2011-06-251-0/+1
| | | | | | | | | | BUG=80071 TEST=base_unittests Review URL: http://codereview.chromium.org/7232025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90489 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for Linux kernels >=3.0-rc1 in Python related build files by:tony@chromium.org2011-06-161-0/+1
| | | | | | | | | | | | | | | - replacing occurences of sys.platform == 'linux2' with sys.platform.startswith('linux') - congregating occurences of sys.platform in ('linux[X]', 'linuxY', ...) to sys.platform.startswith('linux') - adding the key 'linux3' to all relevant lookup dicts BUG=85845 TEST=Try building chromium on Linux >=3.0-r1 Review URL: http://codereview.chromium.org/7172016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89354 0039d316-1c4b-4281-b951-d872f2087c98
* Allow wildcard for corporate CLA. Add nvidia to AUTHORS.maruel@chromium.org2011-06-131-5/+14
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7003151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88891 0039d316-1c4b-4281-b951-d872f2087c98
* Add ruben to AUTHORS so people stop asking if he's signed the CLA.tony@chromium.org2011-05-271-0/+1
| | | | | | Review URL: http://codereview.chromium.org/7085010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87086 0039d316-1c4b-4281-b951-d872f2087c98
* Modifies the event handler for WM_APPCOMMAND events to return TRUE if the ↵mma.public@gmail.com2011-05-031-0/+1
| | | | | | | | | | | | | event was handled. Previously it returned 0 causing the event to bubble up to the DefWndProc, which would synthesize keypresses appropriate for the event and cause it to effectively be handled twice. This should fix double handling of events for people with devices that generate WM_APPCOMMAND messages (tablets, Logitech mice, etc...) BUG=19672 TEST=See various cases reported on bug Review URL: http://codereview.chromium.org/6901076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83975 0039d316-1c4b-4281-b951-d872f2087c98
* Send the 'page_url' parameter of the page (on which the right click was made tobrettw@chromium.org2011-04-201-0/+1
| | | | | | | | | | | | | | | open the context menu) as the 'referer' field of the http header field. This change is done for cases OPENLINKNEWTAB, OPENLINKNEWWINDOW, and NOT for OPENLINKOFFTHERECORD (Incognito). Also Https to Https transition must NOT send the referrer and this is checked in the 'OpenURL' method. Call to the ShouldHideReferrer method is done at render_view.cc Author Ramkumar Gokarnesan - ramgo@yahoo-inc.com BUG=1935 TEST=Try right click on a URL and click 'open link in new tab' or 'open link in new window' and see the referer information being sent as a part of the http header field. verify with wireshark / VS debugger. Original review http://codereview.chromium.org/6681030/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82323 0039d316-1c4b-4281-b951-d872f2087c98
* Replacing outdated DCHECK(a == b) with DCHECK_EQ(a, b).david.mike.futcher@gmail.com2011-04-181-0/+1
| | | | | | | | | | | | | This is my first attempt at contributing, so please tell me where I'm going wrong. BUG=58409 TEST= Review URL: http://codereview.chromium.org/6851016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81988 0039d316-1c4b-4281-b951-d872f2087c98
* Adds method call to UpdatePrintableSizeInPrintParameters() to fix Content ↵clementskau@gmail.com2011-04-131-0/+1
| | | | | | | | | | | | | Area width on print on Linux. This happens in connection with CSS3 Paged Media margins. BUG=79157 TEST=Try and print a page with CSS3 Paged Media margins like: http://dl.dropbox.com/u/599885/CSS3_Paged_Media_Margin_test.htm Review URL: http://codereview.chromium.org/6825074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81355 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Allow text selection in the page info bubble.rsesek@chromium.org2011-03-301-0/+1
| | | | | | | | | | | BUG=52526 TEST=Try going to any web page and click on either the padlock or the globe icon. The text within the bubble should be selectable. Review URL: http://codereview.chromium.org/6683063 Patch from Seshadri Mahalingam <seshadri.mahalingam@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79819 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/2928005/ for Dill:sky@chromium.org2011-03-221-0/+1
| | | | | | | | | | | | Loads favicons when openning back/forward menu for any urls that don't have favicons. BUG=5679 TEST=Restore a tab with a navigation history, check favicons. Review URL: http://codereview.chromium.org/6708029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79000 0039d316-1c4b-4281-b951-d872f2087c98
* WinDDK ATL and MSVC express 2008/2005 compatability mark@chromium.org2011-03-211-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Gives 'out of the box' compatability with VC2008 express - i.e. no modifications needed to system headers or .gyp* files or related hacks. Just set the GYP_MSVS_VERSION to 200Xe (e for express, same as the linked blog on the issue and first google hit as well). 1) Changes to build\common.gypi to turn off to define COMPILER_MSVC_EXPRESS if a express is detected (through the GYP_MSVC_VERSION environment variable), turn off the _SECURE_ATL define (which is flagged as an error with WinDDK's ATL, _SECURE_ATL adds [more] CRT checks to other ATL versions) and hard to link to the atl stdthunk library with express editions. Also, explicitly link to the base WinSDK libraries in common.gypi and mini_installer.gypi for MSVC 2005 express. 2) Fixes a few .cc files that have the wrong include order with the ATL headers when using the Windows DDK ATL. The Windows DDK ATL brings in intsafe.h (WinSDK, not WinDDK) with atlwin.h and generates multiple INTXX_MIN/MAX def warnings which get flagged as errors with the warnings as errors flag if not included before other libraries that have the same definitions like ICU. 3) Changes to .rc files to avoid pulling in afxres.h (an MFC header - it's available in the WinDDK) and winres.h which VCExpress doesn't have (it's available in a WinSDK sample, but that kind of the purpose of it). The main Chromium .rc files are already structured this way, I just changed the rest and changed the output of grit to do the same. 4) Removes the memset obj file linking in mini_installer.gyp and simply implements memset for mini_installer.cc. Only changes to the chromium branch now. There are some .rc files in the Python26, Native Client, and Angle in samples that could #3 changes. They are not required for Chromium, however. ------ VC2005SP1 can be downloaded at http://www.microsoft.com/downloads/en/details.aspx?FamilyId=7B0B0339-613A-46E6-AB4D-080D4D4A8C4E&displaylang=en (or non-SP1 at http://download.microsoft.com/download/8/3/a/83aad8f9-38ba-4503-b3cd-ba28c360c27b/ENU/vcsetup.exe) VC2008SP1 can be downloaded at http://www.microsoft.com/downloads/en/details.aspx?FamilyId=F3FBB04E-92C2-4701-B4BA-92E26E408569&displaylang=en currently. The base developer instructions work fine afterwards with a couple tweaks for express versions: http://www.chromium.org/developers/how-tos/build-instructions-windows Under "Additional (free) downloads" under step 2: X) Only the first 3 Non-SP KB Patches are needed for express. Don't forget to forget GYP_MSVS_VERSION environment as appropriate - 2008e for Visual C++ 2008 Express, for example. Under "Additional (free) downloads" after step 5 [These only apply to 2008 express, 2005 works fine out of the box]: 6A) Download the WinDDK for the atl headers and libs - http://msdn.microsoft.com/en-us/windows/hardware/gg487463.aspx. It works fine, but you do not need to install the whole DDK. In the WDK directory just install headers.msi, libs_x86fre.msi, and libs_x64fre.msi; just grab the atl headers and atl*.lib libs; right click the installers and uninstall afterwards. Add the appropriate include and lib paths to your global settings. 6B) To build x64 targets (x64 Native Client) download: http://www.cppblog.com/Files/xcpp/VCE64BIT_WIN7SDK.zip Follow the readme instructions. Further information behind that and x64 target building with express: - http://jenshuebel.wordpress.com/2009/02/12/visual-c-2008-express-edition-and-64-bit-targets/ - http://www.cppblog.com/xcpp/archive/2009/09/09/vc2008express_64bit_win7sdk.html ---------------- BUG=1433, 5026, 72885 TEST=Compiles in both Debug and Release mode in Visual C++ Express 2008/2005 and does not effect other build setups. In addition, the WinDDK ATL compiles with the secure_atl=0 in the GYP_DEFINES environment variable on non-express versions of MSVC. Review URL: http://codereview.chromium.org/6676030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78921 0039d316-1c4b-4281-b951-d872f2087c98
* Removing references to off the record in comments and log messages.akalin@chromium.org2011-03-081-0/+1
| | | | | | | | | | | Original patch by vipul.bhasin@gmail.com. BUG=3333 TEST=None Review URL: http://codereview.chromium.org/6625076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77331 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compiling on gcc-4.6.hbono@chromium.org2011-02-251-0/+1
| | | | | | | | | | | | This change removes invalid direct calls to constructors and replaces NULL to 0 as workarounds for a compiler bug of gcc 4.6. Patch from Maarten Lankhorst <m.b.lankhorst@gmail.com>. BUG=none TEST=fix builds on gcc 4.6 Review URL: http://codereview.chromium.org/6596005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76046 0039d316-1c4b-4281-b951-d872f2087c98
* Begin the DCHECK() cleanup. Starting off with /src/chrome/a* and ↵rsesek@chromium.org2011-02-171-0/+1
| | | | | | | | | | | /src/chrome/browser/a* BUG=58409 Review URL: http://codereview.chromium.org/6539002 Patch from Kushal Pisavadia <kushi.p@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75314 0039d316-1c4b-4281-b951-d872f2087c98
* Clamp posix file names to NAME_MAX.thestig@chromium.org2011-02-111-0/+1
| | | | | | | | | | | | | Note: This is one out of two patches that together will fix sub-frame exporting during 'save page as'. The other one is here: https://bugs.webkit.org/show_bug.cgi?id=53897 Patch from Magnus Danielsson <fuzzac@gmail.com> Original CL: http://codereview.chromium.org/6286140/ BUG=25303 TEST=Open www.cnn.com and click 'save page as'. Check the log to make sure no files failed to save due to too long file names. Review URL: http://codereview.chromium.org/6474018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74684 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed the "My Bookmarks" sample extension.kurrik@chromium.org2011-02-081-0/+1
| | | | | | | | | | | | | | | | Stopped referencing a broken jqueryui URL for css and started using a resource hosted at ajax.googleapis.com. Also replaced some single quotes with double quotes. This was causing a parse error since the single quotes where inside another string delineated with single quotes. Patch from Sam McDonald <sam@sammcd.com> BUG=70072 TEST=Load bookmarks extension into a browser. Check that no errors appear in inspector. Click edit on a bookmark to makes sure UI css looks right. Review URL: http://codereview.chromium.org/6447010 Patch from Sam McDonald <sam@sammcd.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74137 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak atomicops implementation for Mac OS X to compile correctly when __LP64__mark@chromium.org2011-01-101-0/+1
| | | | | | | | | | | | | | is defined. Patch by Ben Karel <eschew@gmail.com>. BUG=54554 TEST= - base_unittests --gtest_filter='AtomicOpsTest.*' - Compile base/string_util.cc (outside of Chromium) as 64-bit code on Mac OS X 10.6. Review URL: http://codereview.chromium.org/6091007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70942 0039d316-1c4b-4281-b951-d872f2087c98
* Move more extensions hard coded error messages to .grd file.tfarina@chromium.org2010-12-221-0/+1
| | | | | | | | | | | | | | BUG=51398 TEST=trybots Original Review: http://codereview.chromium.org/4953002/ Signed-off-by: Lauri Oherd <lauri.oherd@gmail.com> Reviewed-by: Aaron Boodman <aa@chromium.org> Review URL: http://codereview.chromium.org/6088002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69914 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the possibility to resize the "Edit Bookmark" dialog.thakis@chromium.org2010-11-171-0/+1
| | | | | | | | | | BUG=60966 TEST=NONE Review URL: http://codereview.chromium.org/5116002 Patch from Peter Beverloo <peter@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66424 0039d316-1c4b-4281-b951-d872f2087c98
* Add Sevan Janiyan to the AUTHORS file.maruel@chromium.org2010-11-151-0/+1
| | | | | | Review URL: http://codereview.chromium.org/5019001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66134 0039d316-1c4b-4281-b951-d872f2087c98
* Roll GTM r375:410davidben@chromium.org2010-11-101-0/+1
| | | | | | | | | | | | | | | | | | Addresses an assert fired on the Mac whenever a new ConstrainedDialog is opened in the sheet end callback of another dialog, either from two consecutive sheets or having another sheet in the queue. This assert was fired from the client certificate selection dialog. (Also add myself to the AUTHORS file since I apparently never got around to doing that for contributions after my internship.) R=avi BUG=56948 TEST=none Review URL: http://codereview.chromium.org/4638005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65625 0039d316-1c4b-4281-b951-d872f2087c98
* Added a check to see if the SaveFileDefaultDirectory exists, if not it uses ↵tony@chromium.org2010-10-011-0/+1
| | | | | | | | | | | | | the DownloadDefaultDirectory instead. Contributed by pnettleship@gmail.com BUG=47561 TEST=Create folder, save html page into folder, delete folder, resave page. If the deleted folder is not re-created automatically, and you are defaulting to the default download di then it worked. Review URL: http://codereview.chromium.org/3449022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61214 0039d316-1c4b-4281-b951-d872f2087c98
* Revert accidentally included test change.evan@chromium.org2010-09-171-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59814 0039d316-1c4b-4281-b951-d872f2087c98
* Disable WorkerTest.WorkerHttpLayoutTests. It always times out.evan@chromium.org2010-09-171-0/+1
| | | | | | BUG=16934 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59812 0039d316-1c4b-4281-b951-d872f2087c98
* Add CoreLocation support to Chrome.allanwoj@chromium.org2010-09-131-0/+1
| | | | | | | | | | | | | | | | | | | | | Patch from Jorge Villatoro <jorge@tomatocannon.com> This add core location support to the Geolocation code. Included are the base location provider class, a data provider class that allows CoreLocation to run on the UI thread, and an Objective C wrapper for CoreLocation. Hints were taken from the CoreWLAN Api class in the same directory for dynamically loading the framework, since CoreLocation is only available on Snow Leopard (Mac OS X 10.6) This new provider has also been added to the location arbitrator in the same way that the libgps provider was added. BUG=45548 TEST=Open the browser with the --enable-geolocation argument on 10.6 and visit http://maps.google.com/maps/m Review URL: http://codereview.chromium.org/3092015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59213 0039d316-1c4b-4281-b951-d872f2087c98
* Save and restore the options window position instead of always centering the ↵pinkerton@google.com2010-08-231-0/+1
| | | | | | | | | | window. BUG=34644 TEST=Open options window, move and close the window, re-open and ensure position is saved. Contributed by Steven Pennington <spenn@engr.uvic.ca> git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57086 0039d316-1c4b-4281-b951-d872f2087c98
* Added a method to check if a browser is closing.pinkerton@chromium.org2010-08-101-0/+1
| | | | | | | | | | | | | | | | Added a method to get the next node ID for bookmarks managed by the bookmark model. Added AppleScript support. Added scripting definition file. Added support for saving tab. Added localization support. Added consistent error nos/error messages. (patch developed by v.a.shreyas@gmail.com) BUG=27468 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55569 0039d316-1c4b-4281-b951-d872f2087c98
* Fix acquisition of thumbnail images on Linux.scherkus@chromium.org2010-07-271-0/+2
| | | | | | | | | | Patch by jwillcox@litl.com: http://codereview.chromium.org/2904010/show BUG=48066 TEST=Load a page from new tab page, then ensure the thumbnail is updated by viewing the new tab page again git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53721 0039d316-1c4b-4281-b951-d872f2087c98
* Add Iceweasel to the list of browsers shown in about:memory.evan@chromium.org2010-07-071-0/+1
| | | | | | | | BUG=44602 Based on a patch from Giuseppe Iuculano <giuseppe@iuculano.it>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51730 0039d316-1c4b-4281-b951-d872f2087c98
* Change prototype to match upstream change from ffmpeg trunk to fix build ↵fbarchard@chromium.org2010-06-081-0/+1
| | | | | | | | | | | with system ffmpeg. Declare the url_write buffer parameter as const BUG=45821 TEST=Build with use_system_ffmpeg on and off (1/0). git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49139 0039d316-1c4b-4281-b951-d872f2087c98
* Save/restore position for the preferences window based on prefs,tfarina@chromium.org2010-06-031-0/+1
| | | | | | | | | | | BUG=34644 TEST=Try moving the preferences window and confirm it works. Patch from Mingmin Xie <melvinxie@gmail.com> Review URL: http://codereview.chromium.org/2592001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48834 0039d316-1c4b-4281-b951-d872f2087c98
* Invalid URLs are no longer mangled when reopening the Options window.mhm@chromium.org2010-05-261-0/+1
| | | | | | | | | | | | | If the homepage URL is changed to an invalid URL, the homepage preference is swapped to a blank URL and NTP is shown. BUG=40996 TEST=Set homepage to http://www.google.com, close Chromium, restart Chromium and see homepage set to http://www.google.com. Set homepage to http://, close Chromium, restart Chromium and see homepage set to New Tab Page. Patch by Jared Wein <weinjared@gmail.com> Review URL: http://codereview.chromium.org/2102019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48270 0039d316-1c4b-4281-b951-d872f2087c98
* Small fix to r45696agl@chromium.org2010-05-241-0/+1
| | | | | | | | (Patch from Ningxin Hu) http://codereview.chromium.org/2097003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48037 0039d316-1c4b-4281-b951-d872f2087c98
* Fix NULL vs 0 problems which break the build with -Werror using GCC 4.5evan@chromium.org2010-05-061-0/+1
| | | | | | | | | | | BUG=none TEST=try to compile with gcc 4.5 Patch by Benjamin Jemlich <pcgod99@gmail.com>. Review URL: http://codereview.chromium.org/2007003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46601 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure tint for frame_incognito is stored in "Cached Theme.pak".erg@chromium.org2010-04-211-0/+1
| | | | | | | | | BUG=41743 TEST=See bug Review URL: http://codereview.chromium.org/1758001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45222 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for the <keygen> element to Windows, matchingwtc@chromium.org2010-04-011-0/+1
| | | | | | | | | | | | | | | support present on Linux and Mac OS X. Contributed by Ryan Sleevi <ryan.sleevi@gmail.com>. Original review URL: http://codereview.chromium.org/843005 R=wtc BUG=148 TEST=KeygenHandler.SmokeTest Review URL: http://codereview.chromium.org/1591006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43365 0039d316-1c4b-4281-b951-d872f2087c98
* Port the option to import bookmarks from a file to Linuxevan@chromium.org2010-04-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | | - Call ImportNow from browser_main.cc - Move necessary functions and a class from first_run_win.cc to first_run.cc and update first_run.h accordingly. - Add some #defines for different OSes and some TODO(port) comments. These changes will allow the use of the --import-from-file option to import bookmarks from a file at first run. I have built and tested this on Linux and Windows. BUG=32728 TEST=run with --import-from-file Patch from Brian G. Merrell <bgmerrell@gmail.com> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43277 Review URL: http://codereview.chromium.org/1515004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43294 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 43277 - Port the option to import bookmarks from a file to Linuxarv@chromium.org2010-03-311-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | Call ImportNow from browser_main.cc Move necessary functions and a class from first_run_win.cc to first_run.cc and update first_run.h accordingly. Add some #defines for different OSes and some TODO(port) comments. These changes will allow the use of the importfromfile option to import bookmarks from a file at first run. I have built and tested this on Linux and Windows. BUG=32728 TEST=run with importfromfile Patch from Brian G. Merrell <bgmerrell@gmail.com> Review URL: http://codereview.chromium.org/1515004 TBR=evan@chromium.org This broke BookmarkBarGtkBrowserTest.ClickOnFloatingTest Review URL: http://codereview.chromium.org/1591005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43285 0039d316-1c4b-4281-b951-d872f2087c98
* Port the option to import bookmarks from a file to Linuxevan@chromium.org2010-03-311-0/+1
| | | | | | | | | | | | | | | | | | | | | - Call ImportNow from browser_main.cc - Move necessary functions and a class from first_run_win.cc to first_run.cc and update first_run.h accordingly. - Add some #defines for different OSes and some TODO(port) comments. These changes will allow the use of the --import-from-file option to import bookmarks from a file at first run. I have built and tested this on Linux and Windows. BUG=32728 TEST=run with --import-from-file Patch from Brian G. Merrell <bgmerrell@gmail.com> Review URL: http://codereview.chromium.org/1515004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43277 0039d316-1c4b-4281-b951-d872f2087c98
* Honor select-all on tab-away when omnibar is empty (gtk)tony@chromium.org2010-03-191-0/+1
| | | | | | | | | | | | | | | | | Also added a browser test for this case. The bug is an ordering error, possibly because the programmer was unaware that GetStateForTabSwitch can actually mutate the selection state, for the odd case outlined in bug 38385. BUG=38385 TEST=Delete URL from omnibar. Create tab, delete tab. URL should be reverted and selected. Patch by Matthew Willis <appamatto@gmail.com> Review URL: http://codereview.chromium.org/1047004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42085 0039d316-1c4b-4281-b951-d872f2087c98
* Implements AeroPeek of Windows 7.hbono@chromium.org2010-03-101-0/+1
| | | | | | | | | | | This change integrates the custom AeroPeek implementation into Chromium, which shows the thumbnail list of all tabs and the preview image of the tab selected from the thumbnail list. It uses the AeroPeekManager object, which is a proxy between TabStripModel and Windows to translate events from TabStripModel for Windows, and vice versa. To listen events from TabStripModel without changing the existing part of Chromium, this AeroPeekManager class implements the TabStripModelObserver interface. Even though this change doesn't include any automated tests for AeroPeek, I would like to send its automated UI test as a separate change. Nevertheless, it just creates/deletes a tab and see this AeroPeekManager can create its thumbnail window correctly. BUG=6337 TEST=base_unittests.exe --gtest_filter=ScopedNativeLibrary.Basic Review URL: http://codereview.chromium.org/303033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41133 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the use of the master_preferences file in Linux.tony@chromium.org2010-03-101-0/+1
| | | | | | | | | | | | | | | Also refactor FirstRunTabs to use GURL instead of wstring. BUG=none TEST=Add master_preferences file to directory containing the chrome binary and execute chrome with the --first-run option. Original patch by bgmerrell@gmail.com at http://codereview.chromium.org/551160 Review URL: http://codereview.chromium.org/796001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41131 0039d316-1c4b-4281-b951-d872f2087c98
* Correct positioning of tooltips in nonclient portion of Aero windows. ↵pkasting@chromium.org2010-03-041-0/+1
| | | | | | | | | Original patch by Jay Soffian (see http://codereview.chromium.org/652104 ), r=me. BUG=36489 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40656 0039d316-1c4b-4281-b951-d872f2087c98
* Modified SavePackage(TabContents* tab_contents) of save_package.cc.tony@chromium.org2010-03-021-0/+1
| | | | | | | | | | | | | | | | | | Used the same fix provided for issue 12748. This is done to retrieve actual url of the web page displayed in tab instead of displayed url. Displayed url is different from actual url when viewing source of a web page. ex: view-source:http://www.google.lk/ This is the reason why chrome fails to save source of web page. BUG = 23584 TEST= Visit a web page. Right click and select "view page source". Right click and select Save as. Select web page complete in save dialog. Click save. Source is saved without being cancelled. Repeat the above steps, but select web page only instead of complete in save dialog. Source is saved without chrome getting crashed. Review URL: http://codereview.chromium.org/660264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40338 0039d316-1c4b-4281-b951-d872f2087c98
* Add TLS server_name extension support for Mac Chrome.wtc@chromium.org2010-02-241-0/+1
| | | | | | | | | | | | | | | | | | This enables server name indication (SNI) support. Patch written by Paul Kehrer <paul.l.kehrer@gmail.com>. Original review URL: http://codereview.chromium.org/656024 R=wtc BUG=30684 TEST=Go to https://carol.sni.velox.ch/ or https://xn--k4h.ws (an IDN SNI site Paul Kehrer uses for testing). Without the patch the latter will throw up a cert error, while the former will have text stating that the server_name extension is not present. Review URL: http://codereview.chromium.org/660005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39934 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 06:16:54 +0000