| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
This reverts r207892 - build failure on Linux x64.
TBR=kbr@chromium.org
BUG=238755
Review URL: https://codereview.chromium.org/16915005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Try again w/ gyp fix.
TBR=kbr@chromium.org, mymax@amazon.com
BUG=238755
Review URL: https://codereview.chromium.org/17115014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Compile failure on Linux ... not sure why this wasn't caught before.
TBR=kbr@chromium.org
BUG=238755
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch landed on behalf of mymax@amazon.com. OWNERS approvals are in
https://chromiumcodereview.appspot.com/17005007/ . Try jobs (w/o binaries)
are in https://chromiumcodereview.appspot.com/17422003/ .
TBR=kbr@chromium.org
BUG=238755
Review URL: https://codereview.chromium.org/17341003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
3th dev
In content layer, everywhere get the top level window from |WebContentsViewWin::GetTopLevelNativeWindow() |.
In another way, content has the dependence of toplevel windows, but in the impl of ||WebContentsViewWin::GetTopLevelNativeWindow() |
we just use the hard code |getparent|. we thinks the toplevel window must be the contents parents, it is not correct for 3th dev.
however content is a Transparent layer for 3th dev. It is not a good designer. content should not suppose toplevel window is content view's parent.
Review URL: https://chromiumcodereview.appspot.com/16323010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=248115
TEST=manual testing on windows
Review URL: https://chromiumcodereview.appspot.com/16632007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Originally landed in r204547
Reverted in r204553 due to cq anomaly.
Android builds with coverage=1 fail due to uninitialized variable
warnings in base/linux_util.cc and base/net/net_util.cc
BUG=245467
TBR=willchan
Review URL: https://chromiumcodereview.appspot.com/16589002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CQ anomaly x2.
> Fix errors when building android with coverage=1
>
> Android builds with coverage=1 fail due to uninitialized variable
> warnings in base/linux_util.cc and base/net/net_util.cc
>
> BUG=245467
>
> Review URL: https://chromiumcodereview.appspot.com/16077010
TBR=rwalker@codeaurora.org
Review URL: https://codereview.chromium.org/16505004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Android builds with coverage=1 fail due to uninitialized variable
warnings in base/linux_util.cc and base/net/net_util.cc
BUG=245467
Review URL: https://chromiumcodereview.appspot.com/16077010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
CQ error. Committed without tryjobs.
> Fix errors when building android with coverage=1
>
> Android builds with coverage=1 fail due to uninitialized variable
> warnings in base/linux_util.cc and base/net/net_util.cc
>
> BUG=245467
>
> Review URL: https://chromiumcodereview.appspot.com/16077010
TBR=rwalker@codeaurora.org
Review URL: https://codereview.chromium.org/16415008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Android builds with coverage=1 fail due to uninitialized variable
warnings in base/linux_util.cc and base/net/net_util.cc
BUG=245467
Review URL: https://chromiumcodereview.appspot.com/16077010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
hover around an element with title attribution.
BUG=239437
TEST=Run content_shell.exe and go to http://xkcd.com, hover around the image in the middle should show the tooltips.
Review URL: https://chromiumcodereview.appspot.com/15649020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/16265002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from Joseph Gentle <josephg@gmail.com>
R=jeremya@chromium.org
BUG=243995
Review URL: https://chromiumcodereview.appspot.com/15953004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
at https://codereview.chromium.org/14929006/).
Added MIPS DSPr2 optimization for BGRAConvolve2D routine.
The following routines are optimized:
- ConvolveVertically
- ConvolveHorizontally
Performance gain measured on Malta 74Kc board:
- our standalone test/bench application ~45%
- chromium unit_test ~20%
R=hubbe@chromium.org, senorblanco@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15742005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Issue 14859003: Removes the compile time flag for Datalist element in the Blink source. This patch disables the run time flag on the Android platform.
BUG=237516
Review URL: https://chromiumcodereview.appspot.com/14861002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/15402005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=241988
TEST=Visual
R=mmenke@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15397006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201117 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
-Werror=narrowing does not allow narrowing conversion of 'source_texture_id'
from 'int' to 'unsigned int' in texture_copier_unittest.cc.
BUG=
Review URL: https://chromiumcodereview.appspot.com/15001032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changed SavePackage and unit tests to use DestinationUpdated(). This
function does the same work as UpdateProgress(). We stick to
DestinationUpdated() since it's part of DownloadDestinationObserver
interface (so already used elsewhere).
This patch makes the interface implementation as public to allow
access from SavePackage and unit tests. These functions were already
public in the interface itself.
BUG=239475
TEST=content_unittests and making sure chrome is built
Review URL: https://chromiumcodereview.appspot.com/14646036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
navigation on OS X Lion.
The code to trigger back/forward navigation from mouse wheel events is currently broken. It triggers on all unhandled wheel events including events with a delta of zero, even though JavaScript never gets a chance to handle them (WheelEventDispatchMediator ignores them). This CL fixes that by only reporting wheel events with non-zero deltas as unhandled. It also fixes a bug where the wrong wheel event is reported as unhandled if there are additional wheel events in the queue.
BUG=239731
TEST=Visit http://jsfiddle.net/Qs3JJ/, horizontal scroll with two fingers on trackpad, no history navigation should happen.
Review URL: https://chromiumcodereview.appspot.com/14795004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/15091004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199659 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added support for installing dependencies on
non-english Ubuntu 13.04
BUG=239505
TEST=Tested manually
Review URL: https://chromiumcodereview.appspot.com/15085010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the distro name, but retain distro name as a fallback in case the hostname
fails. Uses gethostname() from unistd.h.
BUG=123827
TEST=Verify on a Linux machine that the hostname apppears in
chrome://sync-internals > Sync Node Browser > Root > Device Information.
Review URL: https://chromiumcodereview.appspot.com/14963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198704 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/13818017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
flag.
This is the second part of the webkit bug described here:
https://bugs.webkit.org/show_bug.cgi?id=113394
BUG=224314
Review URL: https://chromiumcodereview.appspot.com/12681024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement OnError virtual function, when network is down, OnError can be invoked.
Send error code to render process from browser process through IPC.
This patch depends on Blink side patch which can be found from https://codereview.chromium.org/14071008/
BUG=128057
TEST=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196728
R=avi@chromium.org, jln@chromium.org, kinuko@chromium.org, tyoshino@chromium.org, yutak@chromium.org
Review URL: https://codereview.chromium.org/10668018
Patch from Li Yin <li.yin@intel.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197854 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is in order to support the "msvs-ninja" generator, which is being
added in https://codereview.chromium.org/13867004/.
R=ilevy@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/14322014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Looks like it made a layout test flaky.
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showLargeExpectations=true&showExpectations=true&tests=http%252Ftests%252Fwebsocket%252Ftests%252Fhybi%252Fclose.html
> Websocket should fire 'error' event if no server available
> Implement OnError virtual function, when network is down, OnError can be invoked.
> Send error code to render process from browser process through IPC.
>
> This patch depends on Blink side patch which can be found from https://codereview.chromium.org/14071008/
>
>
> BUG=128057
> TEST=
>
> Review URL: https://chromiumcodereview.appspot.com/10668018
TBR=li.yin@intel.com
Review URL: https://codereview.chromium.org/14335011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implement OnError virtual function, when network is down, OnError can be invoked.
Send error code to render process from browser process through IPC.
This patch depends on Blink side patch which can be found from https://codereview.chromium.org/14071008/
BUG=128057
TEST=
Review URL: https://chromiumcodereview.appspot.com/10668018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14065024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Documents in idl files with the [inline_doc] attribute are now properly rendered inline. Links to inline docs no longer work and will cause errors.
BUG=187494
Review URL: https://chromiumcodereview.appspot.com/14322003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Gamepad API is not implemented on Android yet, so disabling the run-time flag.
BUG=
Review URL: https://chromiumcodereview.appspot.com/14241027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
because this method can be called twice when using iBus. In this case,
a compositing Korean Hangul character can be committed twice.
Contributed by joone.hur@intel.com
BUG=50485
TEST=Follow the bug description.
Review URL: https://chromiumcodereview.appspot.com/13818036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195916 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adding this checkbox makes user to be aware of auto detecting proxy
option and also meets the new design suggested to solve the same.
Providing this checkbox also ease the user to select between auto
configuring proxy(PAC) and auto detecting proxy(WPAD). This
checkbox functions similar to the one already provided to select
single proxy mode.
Contributed by sathish.kuppuswamy@intel.com
BUG=chromium:222576
TEST=Built the changes along with Chromium OS, verified the
behaviour of the checkbox and proxy connection. Selected
"Automatic proxy configuration" option
1, Verified internet access after checking "use a
autoconfiguration URL" checkbox and entering a valid PAC
URL in the URL field(Auto configuring proxy).
2, Verified internet access, leaving "use a autoconfiguration
URL" unchecked(Auto Detecting proxy). Same is been verified by
checking "use a autoconfiguration URL" checkbox, but leaving
the URL field blank.
Review URL: https://chromiumcodereview.appspot.com/13334007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=230621
Review URL: https://chromiumcodereview.appspot.com/14235006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195483 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
MouseMove event. This patch requiers a separate patch I submitted to blink.
BUG=179054
TEST=Load the 2d or input example plugins and try to draw in them.
Review URL: https://chromiumcodereview.appspot.com/14324006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
PluginInstance was declared twice so removing redundant declaration
Review URL: https://chromiumcodereview.appspot.com/13976005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=231019
Review URL: https://chromiumcodereview.appspot.com/14145003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
memory cache. It could appear if memory cache had sparse entries.
TEST=Run DiskCacheBackendTest.MemoryOnlyDoom* tests from net_unittests
binary.
Review URL: https://chromiumcodereview.appspot.com/12951014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The build was failing on GCC 4.8.0 and glibc 2.17 because unistd.h was not
being included despite read(2), pipe(2), write(2) and close(2) being used.
BUG=
TEST=Try to build using the setup described above.
Review URL: https://chromiumcodereview.appspot.com/14048011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium does not use the frame flattening code on any platform, though it used
to use it for frameset flattening on Android, but that is no longer the case.
As there is no intention of ever using it, it should be removed. This change
basically removed the code related to the WebCore setting.
Committed on behalf of Kenneth Rohde Christiansen <kenneth.r.christiansen@intel.com>.
TBR=darin@chromium.org
BUG=231898
Review URL: https://codereview.chromium.org/14293008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Invalidate the messages map for the extension in case the extension is reloaded
with a new messages map.
BUG=53628
TEST=Load an unpacked extension with i18n messages used in a content script.
Open a window or tab that loads the i18n messages. Change the messages.json
file. Reload the extension and the messages should be changed.
Review URL: https://chromiumcodereview.appspot.com/12319073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was getting this error before this patch:
error: narrowing conversion of ‘(((color >> 16) & 255u) * 257u)’ from ‘SkColor {aka unsigned int}’ to ‘guint16 {aka short unsigned int}’ inside { } is ill-formed in C++11 [-Werror=narrowing]
BUG=130810
Review URL: https://chromiumcodereview.appspot.com/12684005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188351 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Signed-off-by: Jun Jiang <jun.a.jiang@intel.com>
BUG=179754
Review URL: https://chromiumcodereview.appspot.com/12412007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187827 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
keyboard shortcuts.
The sample extension, 'Tab Shortcuts', uses the commands api to capture keypresses, and uses the tabs api to toggle the pinned state of the active tab or duplicate the current tab without the need of the tabs permission (using an event page).
Patch from Aaron Jacobs <samusaaron3@gmail.com>
BUG=141865
Review URL: https://chromiumcodereview.appspot.com/12481004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187728 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch from Sam Larison <qufighter@gmail.com>
new DCHECK will fail if rowBytes() on SkBitmap is too low
"Windows drivers sometimes require that scanlines (rows in the image) be memory aligned. That is why they are sometimes larger than they would strictly need to be."
Instead of attempting to compute row bytes, we should be using the rowBytes() provided by SkBitmap
BUG=176062
TEST=The test case involves using the "Capture Visible Content" feature of the Google Screen Capture extension on a newly loaded http:// page after installation of the extension. The bug produces itself if after I size the window my window.innerWidth is 1000 or any other non-multiple of 16 (window.innerWidth % 16 != 0)
Review URL: https://chromiumcodereview.appspot.com/12313139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
specification
TEST=Use a third-party fnv1a-128 implementation to verify the test values.
BUG=
Review URL: https://chromiumcodereview.appspot.com/12340054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If PKG_CONFIG_PATH is set, then prepend these paths to those generated
by the wrapper. This allows cross-compilation using sysroots with pkgconfig
directories in non-standard locations.
This change is safer than the original patch (https://codereview.chromium.org/12320047/), which was reverted (https://codereview.chromium.org/12317063/) due to what appears to be a chromeos builder with PKG_CONFIG_PATH set to an incomplete value (should probably be unset).
Add Opera Software to the AUTHORS file
BUG=
Review URL: https://chromiumcodereview.appspot.com/12340023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184184 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
only being applied to the top left corner of the view. Scaling the canvas to the device scale factor before applying the clip rect for painting the background fixes the issue.
BUG=175698
Review URL: https://chromiumcodereview.appspot.com/12249002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184100 0039d316-1c4b-4281-b951-d872f2087c98
|