| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
support present on Linux and Mac OS X.
Contributed by Ryan Sleevi <ryan.sleevi@gmail.com>.
Original review URL: http://codereview.chromium.org/843005
R=wtc
BUG=148
TEST=KeygenHandler.SmokeTest
Review URL: http://codereview.chromium.org/1591006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Call ImportNow from browser_main.cc
- Move necessary functions and a class from first_run_win.cc to
first_run.cc and update first_run.h accordingly.
- Add some #defines for different OSes and some TODO(port) comments.
These changes will allow the use of the --import-from-file option to
import bookmarks from a file at first run.
I have built and tested this on Linux and Windows.
BUG=32728
TEST=run with --import-from-file
Patch from Brian G. Merrell <bgmerrell@gmail.com>
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43277
Review URL: http://codereview.chromium.org/1515004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Call ImportNow from browser_main.cc
Move necessary functions and a class from first_run_win.cc to
first_run.cc and update first_run.h accordingly.
Add some #defines for different OSes and some TODO(port) comments.
These changes will allow the use of the importfromfile option to
import bookmarks from a file at first run.
I have built and tested this on Linux and Windows.
BUG=32728
TEST=run with importfromfile
Patch from Brian G. Merrell <bgmerrell@gmail.com>
Review URL: http://codereview.chromium.org/1515004
TBR=evan@chromium.org
This broke BookmarkBarGtkBrowserTest.ClickOnFloatingTest
Review URL: http://codereview.chromium.org/1591005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Call ImportNow from browser_main.cc
- Move necessary functions and a class from first_run_win.cc to
first_run.cc and update first_run.h accordingly.
- Add some #defines for different OSes and some TODO(port) comments.
These changes will allow the use of the --import-from-file option to
import bookmarks from a file at first run.
I have built and tested this on Linux and Windows.
BUG=32728
TEST=run with --import-from-file
Patch from Brian G. Merrell <bgmerrell@gmail.com>
Review URL: http://codereview.chromium.org/1515004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also added a browser test for this case.
The bug is an ordering error, possibly because the
programmer was unaware that GetStateForTabSwitch
can actually mutate the selection state, for the
odd case outlined in bug 38385.
BUG=38385
TEST=Delete URL from omnibar. Create tab, delete tab. URL should be reverted and selected.
Patch by Matthew Willis <appamatto@gmail.com>
Review URL: http://codereview.chromium.org/1047004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This change integrates the custom AeroPeek implementation into Chromium, which shows the thumbnail list of all tabs and the preview image of the tab selected from the thumbnail list. It uses the AeroPeekManager object, which is a proxy between TabStripModel and Windows to translate events from TabStripModel for Windows, and vice versa. To listen events from TabStripModel without changing the existing part of Chromium, this AeroPeekManager class implements the TabStripModelObserver interface.
Even though this change doesn't include any automated tests for AeroPeek, I would like to send its automated UI test as a separate change. Nevertheless, it just creates/deletes a tab and see this AeroPeekManager can create its thumbnail window correctly.
BUG=6337
TEST=base_unittests.exe --gtest_filter=ScopedNativeLibrary.Basic
Review URL: http://codereview.chromium.org/303033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41133 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also refactor FirstRunTabs to use GURL instead of wstring.
BUG=none
TEST=Add master_preferences file to directory containing the chrome binary and
execute chrome with the --first-run option.
Original patch by bgmerrell@gmail.com at
http://codereview.chromium.org/551160
Review URL: http://codereview.chromium.org/796001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Original patch by Jay Soffian (see http://codereview.chromium.org/652104 ), r=me.
BUG=36489
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Used the same fix provided for issue 12748.
This is done to retrieve actual url of the web page displayed in tab instead of displayed url.
Displayed url is different from actual url when viewing source of a web page.
ex: view-source:http://www.google.lk/
This is the reason why chrome fails to save source of web page.
BUG = 23584
TEST= Visit a web page. Right click and select "view page source". Right click and select Save as. Select web page complete
in save dialog. Click save. Source is saved without being cancelled.
Repeat the above steps, but select web page only instead of complete in save dialog. Source is saved without chrome getting crashed.
Review URL: http://codereview.chromium.org/660264
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40338 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enables server name indication (SNI) support.
Patch written by Paul Kehrer <paul.l.kehrer@gmail.com>.
Original review URL: http://codereview.chromium.org/656024
R=wtc
BUG=30684
TEST=Go to https://carol.sni.velox.ch/ or https://xn--k4h.ws
(an IDN SNI site Paul Kehrer uses for testing). Without the
patch the latter will throw up a cert error, while the former
will have text stating that the server_name extension is not
present.
Review URL: http://codereview.chromium.org/660005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
base/process_util_posix.cc, base/third_party/nspr/prcpucfg.h,
third_party/npapi/bindings/npapi.h: added alternate Solaris OS choice
BUG=30101
TEST=compiles
Patch by James Choi <jchoi42@pha.jhu.edu>.
Review URL: http://codereview.chromium.org/606069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39220 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
then check later to see if they are actually dirty. Arguably this is unnecessary, but I've been lead to believe (and my quick debugging has shown) that metahandles used in a WriteTransaction tend to get dirtied. The majority of times the TakeSnapshot... loop executes now, the dirty_metahandles set is empty.There's also the benefit that it's pretty clear that the ScopedKernelLock, which is needed to look up an entry by metahandle, is held when we're iterating through the [possibly] dirty_metahandles in the TakeSnapshot... function. This is arguably less true of the WriteTransaction deconstructor. But if there's a different way to get the new dirty flag from an original then that's probably the way to go. I found out the hard way that checking the dirty flag of the original means nothing as I was leaking away metahandles.I added a short protected function to Directory that acts as a wrapper for the kernel_->dirty_metahandles->insert function. It seemed like the thing to do to decouple it somewhat. Plus we can check there to see if it's actually dirty if that's what we decide to do.We piggy-back on the transaction lock to save us thread-safety concerns in dealing with the dirty_metahandles set.
One more thing: if I'm screwing up any meta-stuff here please don't be afraid to share. I'd hate to be writing too much, too little, or about the wrong stuff in these things :)
Added two unit tests to ensure that the WriteTransaction deconstructor and TakeSnapshotForSaveChanges function were cooperating. One makes sure that all of the dirty metahandles show up again and the other makes sure that the non-dirty dirty_metahandles are disgarded. I had to move some things out of the anonymous namespace in order for the FRIEND_TEST macro to work correctly.
Old patch: http://codereview.chromium.org/585007
BUG=19901
TEST=SyncableDirectoryTest.TakeSnapshotGetsAllDirtyHandlesTest, SyncableDirectoryTest.TakeSnapshotGetsOnlyDirtyHandlesTest
AUTHOR=Alex Gartrell (AlexGartrell@gmail.com)
chron submitting on original author's behalf.
Review URL: http://codereview.chromium.org/598006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
preparation for autofill sync.
BUG=30959
TEST=WebDatabaseTest.GetAllAutofillEntries
Review URL: http://codereview.chromium.org/598004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Beaudoin (see http://codereview.chromium.org/555145 ), r=me.
BUG=13703
TEST=Click and drag the left or middle buttons in the omnibox dropdown. The selection or hover should track your movement and the appropriate entry should be activated on mouse up.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It was nessessary to add a IPC Message with no Paramter for the reload frame
request to the webkit renderer and to add a menu string. The command should
only reload the frame clicked in for opening the context menu and let the
other parts of the webpage unmodified and unrefreshed.
BUG=3858
TEST=Try to click on "Reload Frame" in the context menu of a frame and see if that frame reloads.
Review URL: http://codereview.chromium.org/552126
Patch from alexander@sulfrian.net.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37414 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
attribute of the button to the correct key.
BUG=33124
TEST=Check that the Certificate Information button is enabled on an https page.
Review URL: http://codereview.chromium.org/552171
Patch from Vernon Tang.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by Bernard Cafarelli <voyageur@gentoo.org>
TEST=none
BUG=22140
Review URL: http://codereview.chromium.org/524061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=23069
TEST=Download large file, click pause in download item's menu to pause/unpause.
Review URL: http://codereview.chromium.org/524009
Patch from sig11@reprehensible.net.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35384 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to open a new window instead of reusing the most recent tab for
opening cmdline URLs.
BUG=2843
TEST=Run with --new-window switch and confirm that a new window pops up
patch by <clemens [at] endorphin dot org>
original review: <http://codereview.chromium.org/464060>
Review URL: http://codereview.chromium.org/503023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34926 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
we create SSL tunnels through a proxy. The patch is contributed by
Kaspar Brand <googlecontrib@velox.ch>.
R=hawk,wtc
BUG=28732
TEST=none
Review URL: http://codereview.chromium.org/437046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in mock_filters.h.
Updated unit tests accordingly.
Patch by Dominic Jodoin <dominic.jodoin@gmail.com>
BUG=21040
TEST=Run the media_unittests and AudioRendererImplTest test suite in unit_tests. Ensure there is no Google Mock failures and that all tests are passing.
Review URL: http://codereview.chromium.org/404016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with GNOME HIG.
BUG=18076
TEST=Compile and see label
Original patch by Ramkumar Ramachandra <artagnon@gmail.com> at
http://codereview.chromium.org/338015/show
Review URL: http://codereview.chromium.org/333052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the system goes into power-save sleep mode while downloading files,
the download fails. So, prevent sleep mode until the download finishes.
This patch introduces a new RAII class to request that the system's
power-save mode be disabled - PowerSaveBlocker.
This is only implemented for win32; other platforms are stubbed out.
This only partially implements bug 25420 it only attempts to handle the
downloading case.
Patch by Bryan Donlan <bdonlan@gmail.com>
BUG=25420
TEST=Download a large file with the system sleep timeout set to a short interval.
Review URL: http://codereview.chromium.org/287017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GUI is still missing, so certificates and private keys have to be
stored manually, p.e.:
$ pk12util -d sql:$HOME/.pki/nssdb -i PKCS12_file.p12
Adds --auto-ssl-client-auth command-line option to enable this feature.
Patch contributed by Jaime Soriano <jsorianopastor@gmail.com>.
Original review URL: http://codereview.chromium.org/220009
R=wtc
BUG=16830
TEST=Try to connect to a web page that requires SSL authentication and
confirm that it connects if and only if a valid certificate is stored in
the ~/.pki/nssdb database.
Review URL: http://codereview.chromium.org/276037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29188 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
closes the dialog.
BUG=19786
TEST=Open Sync Bookmaeks Login dialog. Enter credentials, TAB between fields, etc. to ensure nothing is broken. Hit the ESC key to dismiss the dialog.
Patch by Randy Posynick (http://codereview.chromium.org/199069)
Review URL: http://codereview.chromium.org/246020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
window, not open a tab in an existing incognito window.
(Vedran Šajatović)
BUG=21175
TEST=New Incognito Window from dock with an incognito window already open
Review URL: http://codereview.chromium.org/207054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
patch by Philippe Beauchamp (see http://codereview.chromium.org/149742 ), r=me.
BUG=6173
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL171023 by Song YeWen.
BUG=16020
TEST=test with all media types and ensure there are no memory leaks are
functional differences from previous version.
Review URL: http://codereview.chromium.org/174027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
causes a blank spot which no other thumbnail can be dragged to. This
will go away on page refresh, but we can easily redraw all items
keeping the filler in the rightmost indices.
Original patch by pierre.lafayette@gmail.com, http://codereview.chromium.org/160152
BUG=17738
r=me
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21869 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
focus on Mac. This entails the following:
- getting notifications that the main window has become or lost key
window status (in BrowserWindowController) [new]
- ... which tells the RenderWidgetHostView(Mac) to (de)activate [new]
- ... which tells the RenderWidgetHost to (de)activate [new]
- ... which sends a ViewMsg_SetActive message [new message] to the
RenderView [new]
- ... which tells the WebView(Impl) to (de)activate [new]
- ... which tells its page()'s FocusController to (de)activate [new]
- ... which is now in WebKit-land.
N.B.: "Activate" is the nomenclature used in WebKit; "focus"/"blur" can
sometimes (kind of) mean the same thing, but is ambiguous, since "focus"
has a more specific meaning.
Added a WebView unit test, which currently only tests to make sure that
SetActive() (and IsActive() [also new]) work correctly. The changes to
the other classes aren't very testable since they don't actually do
anything (other than pass things along).
BUG=12507
TEST=webkit/glue/webkit_unittest.cc
Patch by viettrungluu@gmail.com (see http://codereview.chromium.org/159048 ),
r=avi
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
From Thiago:
This patch is to solve the problem in import/export bookmarks. They aren't
exported correctly and also not imported
correctly. Now when the bookmarks are exported the character " are escaped to
" and when they are imported,
they are unescaped.
BUG=7505
TEST=Try importing/exporting bookmarks, make sure nothing is broken.
Review URL: http://codereview.chromium.org/126222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=13206
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19596 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now css files are opened inside browser instead of download.
Also - making lint happy on the mime_util.cc
BUG=7192
R=abarth
TEST=MimeTypeTests.MimeTypeTests
Patch by Yuri Gorobets.
Original review URL: http://codereview.chromium.org/125005
Review URL: http://codereview.chromium.org/125058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Press ctrl+q and chrome should quit
Patch by Jacob Mandelson <jacob@mandelson.org> via
http://codereview.chromium.org/119393
Review URL: http://codereview.chromium.org/118522
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18085 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The approach is borrowed from render_process_host's kMaxRenderersByRamTier.
The values were chosen to keep a minimal number of DIBs in the extreme low RAM
case, and scale up linearly from there to the previous (constant) value of 5.
Patch by Joel Stanley.
BUG=12028
Review URL: http://codereview.chromium.org/115452
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/115929
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17195 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The approach is borrowed from render_process_host's kMaxRenderersByRamTier.
The values were chosen to keep a minimal number of DIBs in the extreme low RAM
case, and scale up linearly from there to the previous (constant) value of 5.
Patch by Joel Stanley.
BUG=12028
Review URL: http://codereview.chromium.org/115452
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
vista without hebrew support
the bug reason is documented in the source for all to see and the bug=12093 (http://code.google.com/p/chromium/issues/detail?id=12093)
the code has been tested with and without a debugger but i have to admit, the unit_tests rarely pass on my machine (the ui ones never do)but this code i changed leaves the state EXACTLY like it was and solves this issue at least
BUG=12093
TEST=run unit_tests.exe on Hebrew Windows; run Chrome; open a page which contains a <textarea dir="ltr"></textarea> element; press control+right-shift key, and; verify its "dir" attribute becomes "rtl".
Review URL: http://codereview.chromium.org/115849
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pages into an HTML label tag, to make it clickable and more friendly to screen
readers.
TEST= Navigate to ianfette.org and click on the text "I understand that visiting
this site may harm my computer". Checkbox should toggle.
BUG= 12714
Original patch by chromium@willhirsch.co.uk
Original review: http://codereview.chromium.org/115815
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
After this patch DirectoryWatcher when asked for recursive watch will scan the
subtree and add inotify watches for each subfolder, but further changes to the
tree structure won't trigger adding/removing watches.
Support for really recursive watches is planned. This is just to divide the
work, because the task is not easy.
Based on patch by Janwar Dinata <j.dinata@gmail.com> reviewed at http://codereview.chromium.org/92151
http://crbug.com/8968
Review URL: http://codereview.chromium.org/115229
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Patch contributed by Robert Sesek <rsesek@bluestatic.org>
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
does resolve the location bar not being focused bug on the mac build.
Patch by Sean Bryant (sean@cyberwang.net).
BUG=9419
Review URL: http://codereview.chromium.org/100140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
ISO-8859-1 which confuses editors.
Review URL: http://codereview.chromium.org/99191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
cds->cbData is data length in bytes, and min_message_size is in characters. So it needs to be multiplied by sizeof(wchar_t)
Review URL: http://codereview.chromium.org/93078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
review.
BUG=9659
TEST=none
Review URL: http://codereview.chromium.org/60106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
when I checked in the RSS auto-detect changelist (r11672). :(
This happened because when I re-created the changelist I ran gcl from the src\Chrome directory as opposed to running it from the src directory.
TBR=evanm
Review URL: http://codereview.chromium.org/42191
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Reverting for now. Will try again later
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11645 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part 1 is RSS feed auto-discovery.
This will parse the web page header to find the feeds in the document and notify
the browser to display the RSS icon in the toolbar. You can click on the icon,
but it will just navigate to the first feed on the page, which (unless it has
been designed to be browser friendly) will just dump XML as text on the user.
For this reason I have disabled the code that makes the RSS icon appear and
intend to enable it when we have a good landing page to display the XML.
Review URL: http://codereview.chromium.org/43109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11640 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
have selected in your prefs instead of always choosing the chrome::DIR_DEFAULT_DOWNLOADS path.
This will only affect you if you have not used 'save as...' before and do not have a SaveFileDefaultDirectory set.
Patch contributed by Paul Robinson <paulRobinson85@googlemail.com>
BUG=8049
Review URL: http://codereview.chromium.org/43016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11465 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
status.
Original patch by Kim Christensen (see http://codereview.chromium.org/28150 ), r=me,brettw, tweaked slightly.
BUG=7227
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10558 0039d316-1c4b-4281-b951-d872f2087c98
|