| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this change the beta and unstable rpm packages were without an icon as
both were correctly specifying the correct name in desktop file
(Icon=google-chrome-beta resp. Icon=google-chrome-unstable) but icon with that
name was never installed.
As a consequence installing the Chrome stable and beta rpm packages and later
removing the beta package would remove the icon and left the stable installation
without any (as both were using the same name without channel: google-chrome).
To fix the issue we need to define the PACKAGE variable in rpm/build.sh the same
way as in debian/build.sh so when we start to process the postinst.include
template (that is included from chrome.spec.template) the PACKAGE variables is
replaced with correct value (google-chrome for stable otherwise
google-chrome-beta or google-chrome-unstable) on not just google-chrome for all
channels as previously.
Also replace the PACKAGE_FILENAME usages in rpm/chrome.spec.template with
PACKAGE when it finally contains the right value and use the PACKAGE_FILENAME
just to specify the package name (where the channel is suffixed in the name even
for the stable channel).
BUG=529008
Review URL: https://codereview.chromium.org/1416053008
Cr-Commit-Position: refs/heads/master@{#357505}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This extends event handlers to pass tilt angles from Android MotionEvent
to Blink touch points, so that on the Blink side, PointerEvent tiltX and
tiltY can be filled with real tilt angles.
This CL is a part of a patch series:
1. https://codereview.chromium.org/1253183005/
for new WebPointerProperties fields
2. https://codereview.chromium.org/1260693003/
for eventSender web pointer property support
3. https://codereview.chromium.org/1192563002/
for handling tilt in Blink event handlers
4. https://codereview.chromium.org/1417803002/
(this)
This CL is based on the abandoned CL at
https://codereview.chromium.org/1187273004/
BUG=514360
Review URL: https://codereview.chromium.org/1417803002
Cr-Commit-Position: refs/heads/master@{#357471}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1425663005
Cr-Commit-Position: refs/heads/master@{#357351}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Screenshot: http://imgur.com/6QgBxmS
BUG=469889
R=meacer@chromium.org
TEST=Start Chrome.
Open an 'about:blank' page.
Bring up the Chrome Security UI Pop-up.
Click on 'Connection' tab.
The two sections should not be empty.
Review URL: https://codereview.chromium.org/1423503003
Cr-Commit-Position: refs/heads/master@{#357275}
|
|
|
|
|
|
|
|
|
|
|
| |
Newer 360 controllers have the product ID of 0719. Adding this to
chromium enables standard mapping to be performed. Without it, buttons
will behave differently than defined in the GamePad API standard
mapping.
Review URL: https://codereview.chromium.org/1418513011
Cr-Commit-Position: refs/heads/master@{#356244}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1419443004
Cr-Commit-Position: refs/heads/master@{#355867}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1413663005
Cr-Commit-Position: refs/heads/master@{#355597}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The gpu driver bug list contained a workaround to enable virtual
contexts for Imagination GPUs when running on Android. Generalise
this to all platforms (in particular, ChromeOS) as the underlying
issue is present in all current Imagination drivers, irrespective
of the platform.
BUG=536822
TEST=WebGL aquarium: Notice performance increase
Signed-off-by: Rufus Hamade <rufus.hamade@imgtec.com>
Review URL: https://codereview.chromium.org/1384013003
Cr-Commit-Position: refs/heads/master@{#353500}
|
|
|
|
|
|
|
|
|
|
|
|
| |
The value attribute serves as the default value of the input element if
its dirty flag is false. If the flag is false, the view should be
updated when the attribute is changed.
BUG=522815
Review URL: https://codereview.chromium.org/1397693002
Cr-Commit-Position: refs/heads/master@{#353245}
|
|
|
|
|
|
|
|
|
|
| |
PowerLineFrequency enums instead of integers to reduce the amount of static casting required
BUG=525167
Review URL: https://codereview.chromium.org/1345993002
Cr-Commit-Position: refs/heads/master@{#352234}
|
|
|
|
|
|
|
|
|
|
|
|
| |
"Youngsoo Choi <kenshin.choi@samsung.com>" is included in AUTHORS.
Signed-off-by: Youngsoo Choi <kenshin.choi@samsung.com>
BUG=
Review URL: https://codereview.chromium.org/1343303004
Cr-Commit-Position: refs/heads/master@{#349705}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds missing comma in WATCHLIST after
0af49ad54149ee0c13b6e8b87d0c66a4b5d79c9f and serves to fix the following error:
```
$ git cl upload --send-mail
Using 50% similarity for rename/copy detection. Override with --similarity.
ERROR:root:Cannot parse /home/ilia/p/chromium/src/WATCHLISTS. invalid syntax (<string>, line 928)
Running presubmit upload checks ...
[...]
```
BUG=
TEST=
R=ben@chromium.org,brettw@chromium.org,nyquist@chromium.org
Review URL: https://codereview.chromium.org/1345313002
Cr-Commit-Position: refs/heads/master@{#349369}
|
|
|
|
|
|
|
|
|
| |
This issue was found using a code linter. There was a missing bracket for the
macro in the unit test. Also added myself to AUTHORS.
Review URL: https://codereview.chromium.org/1298133003
Cr-Commit-Position: refs/heads/master@{#348609}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
data loaded.
This patch updates the HTMLMediaElement's network state to "NetworkStateLoaded"
when 100% buffering update is received in WebMediaPlayerAndroid.
Then HTMLMediaElement stops m_progressEventTimer and resets network state
to NETWORK_IDLE.
BUG=529047
Review URL: https://codereview.chromium.org/1307363011
Cr-Commit-Position: refs/heads/master@{#348505}
|
|
|
|
|
|
|
|
|
|
|
| |
Currently we're sticking with deprecated apis to make it easier to support both gtk2 and gtk3. If Chrome ever drops gtk2 support, it might be a good idea to do a complete port.
BUG=132847
R=erg@chromium.org,estade@chromium.org
Review URL: https://codereview.chromium.org/1234223005
Cr-Commit-Position: refs/heads/master@{#348339}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When |decode_calls_per_second_| is set (not 0), DecodeNextFragment()
will be called at the given rate. When decoding is slow, a
BitstreamBuffer may be released after the last DcodeNextFragment()
being called. In that case, decoder's Flush() will not be called,
and the test will hang forever.
To fix this issue, we call Flush() when all BitstreamBuffers are
processed in NotifyEndOfBitstreamBuffer().
BUG=439831
Test=Run the test on veyron_minnie
patch from issue 791573002 at patchset 80001 (http://crrev.com/791573002#ps80001)
Review URL: https://codereview.chromium.org/1321423004
Cr-Commit-Position: refs/heads/master@{#347599}
|
|
|
|
|
|
|
|
|
| |
BUG=133915
TEST=Related cr: https://codereview.chromium.org/1313793005/#ps20001
Review URL: https://codereview.chromium.org/1316443003
Cr-Commit-Position: refs/heads/master@{#345477}
|
|
|
|
|
|
|
|
|
| |
BUG=472381
R=eroman@chromium.org
Review URL: https://codereview.chromium.org/1286373002
Cr-Commit-Position: refs/heads/master@{#345237}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Gamepad API will be "permanently" disabled after switching tabs. The
only way to get it working again is a full restart of the browser.
IOHIDManagerOpen() returns kIOReturnBadArgument after notifications have
been unregistered from I/O Kit.
Since this is all happening within the PauseHint() handler, synthesize
the pausing mechanism with a boolean instead of unregistering and
re-registering with I/O Kit. One subtle difference is that the connect
and disconnect events are still dispatched when paused, which allows
these events to do their magic even when the observing tabs are not
processing gamepad input. This is desirable, IMHO; you don't want to
miss a connect/disconnect event just because the tab isn't focused.
Also there's a stray address-of operator that I noticed on a function
pointer. That was removed for consistency.
BUG=522385,500931
R=bajones@chromium.org
TEST=See crbug.com/522385 and crbug.com/500931 for repro steps.
Review URL: https://codereview.chromium.org/1307513002
Cr-Commit-Position: refs/heads/master@{#344529}
|
|
|
|
|
|
|
|
| |
Locales should be restored after tests and scoping should be used. Added restores and one restore changed to scoped version.
Review URL: https://codereview.chromium.org/1162603004
Cr-Commit-Position: refs/heads/master@{#344453}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1291093002
Cr-Commit-Position: refs/heads/master@{#344023}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1292773002
Cr-Commit-Position: refs/heads/master@{#343571}
|
|
|
|
|
|
|
|
|
| |
BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1286103002
Cr-Commit-Position: refs/heads/master@{#343155}
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes bug 517642 by adding an AccessibilityEvent that tells the
user where InfoBars can be found.
BUG=517642
Review URL: https://codereview.chromium.org/1278873003
Cr-Commit-Position: refs/heads/master@{#342891}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds missing support for handling broadcast and multicast
options in UDP sockets. It is required to update the UDPSocket
interface to use PPB_UDPSocket_1_2, available in M43.
Refactor SocketNode, TCPNode and UDPNode so SetSockOpt() method is
available only on the parent class and each subclass thus implements
the specialized method according to the level.
BUG=None
Signed-off-by: Eduardo Lima (Etrunko) <eduardo.lima@intel.com>
Review URL: https://codereview.chromium.org/1258123002
Cr-Commit-Position: refs/heads/master@{#341572}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now supporting various flavors of WinRT in the target_os argument.
Setting compiler and linker flags so cc files are compiled
to support C++/CX syntax.
This is part of a larger effort to port WebRTC to WinRT.
Review URL: https://codereview.chromium.org/1150183009
Cr-Commit-Position: refs/heads/master@{#340893}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1259713003
Cr-Commit-Position: refs/heads/master@{#340668}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1259523002
Cr-Commit-Position: refs/heads/master@{#340429}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some content (e.g. HLS live streams), attempting to seek will get the
media player stuck in an error state. In
https://codereview.chromium.org/22605013, this was addressed by preventing
seeks if the duration of the video is negative. However, with
https://codereview.chromium.org/617743004, a -1 returned by the Android
MediaPlayer will be converted to media::kInfiniteDuration().
This CL utilizes two seek booleans derived from the Android MediaPlayer to
determine if a seek should be allowed.
BUG=510641
TEST=MediaPlayerBridgeTest.*
Review URL: https://codereview.chromium.org/1234483003
Cr-Commit-Position: refs/heads/master@{#339762}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For resources not provided by the native theme (i.e. GTK2UI), fall
back to desktop (not ash) resources by calling MapThemeImage in this
case.
BUG=383711
R=erg@chromium.org
TEST=The shadow running along the top edge of the address bar to the
right of the tabs is visible again, especially when using a bright GTK
theme like Adwaita or Radiance. (see crbug.com/383711)
Review URL: https://codereview.chromium.org/1243513002
Cr-Commit-Position: refs/heads/master@{#339744}
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://codereview.chromium.org/1229933008
Cr-Commit-Position: refs/heads/master@{#339220}
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=jar@chromium.org, glider@chromium.org
LOG=N
Signed-off-by: Milton Chiang <milton.chiange@mediatek.com>
Review URL: https://codereview.chromium.org/1220213003
Cr-Commit-Position: refs/heads/master@{#339105}
|
|
|
|
|
|
|
|
|
|
| |
Note: I am not in AUTHOR files yet. Please help by verifying that I have sign the CLA.
Please also help by submitting the try jobs.
Review URL: https://codereview.chromium.org/1226253005
Cr-Commit-Position: refs/heads/master@{#338433}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add an API for the Android closed captions state change to be
plumbed down to Blink.
Blink-side CL: https://codereview.chromium.org/1118613002/
BUG=457850, 388588
Review URL: https://codereview.chromium.org/1110103004
Cr-Commit-Position: refs/heads/master@{#338350}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is my first change request so...
BUG=475506
TEST=Start Chrome with --kiosk and the context menu most not be shown.
Start Chrome without the --kiosk flag and the context menu must be shown.
Review URL: https://codereview.chromium.org/1091173005
Cr-Commit-Position: refs/heads/master@{#337741}
|
|
|
|
|
|
|
|
|
|
|
|
| |
calling gtk_status_icon_set_visible(, FALSE) before g_object_unref
resolves the issue if the space where the notification icon previously
were remaining after the notifications being dismissed.
BUG=504945
Review URL: https://codereview.chromium.org/1218563002
Cr-Commit-Position: refs/heads/master@{#337466}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is intended to replace the proposed changes of https://codereview.chromium.org/917473002/ and
https://codereview.chromium.org/882223011/. This coupled with the changes in
https://codereview.chromium.org/1154013002 should resolve bug 318937. Rather than always sending a
_NET_ACTIVE_WINDOW hint, keep track of the active window by tracking the _NET_ACTIVE_WINDOW property
of the X11 root window, and send a _NET_ACTIVE_WINDOW only if the window is not already active.
This prevents spurious raises in some window managers when click to raise is disabled.
R=agoode@chromium.org, sadrul@chromium.org
BUG=318937
TEST=In an affected WM like XFCE or E19, disable click-to-raise and overlap a window over Chromium.
Click in the rendering area of Chromium and observe that it is not raised. Click on a link in another
application with Chromium as the default browser and note that the Chromium window is raised correctly.
Review URL: https://codereview.chromium.org/1212643008
Cr-Commit-Position: refs/heads/master@{#337282}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch splits the in-memory TransportSecurityState::DomainState up into TransportSecurityState::STSState and TransportSecurityState::PKPState. This patch also updates quite a few tests but there should be no change in behavior. There are some changes in the NetInternalTest because net-internals still expects STS and PKP states to be stored and processed together.
The STS and PKP states are still tied together:
- In the on-disk storage which slightly complicates the serialization logic because
both states have to be merged into one entry until the on-disk storage is split up;
- In the preload data which is why the static state still returns both the STSState and
the PKPState in the same call;
- In net-internals which means the states cannot be added or removed independently.
BUG=470295
Review URL: https://codereview.chromium.org/1132043005
Cr-Commit-Position: refs/heads/master@{#336844}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
"suggestions".
We were rendering HyperlinkTextView and using clickedOnLink delegate to open a page containing <h1>"Aw, Snap!"</h1>. However in Mac when we right click on such links, we can see "copy link" button in context menu, but it was not working because it was lacking url. Now it is set to the proper URL.
BUG=484130
TEST=Follow these steps (taken from bug report)
1.Launch chrome,navigate to any webpage and enter chrome://kill inside omnibox to crash the page manually.
2.Now right click on suggestions link button and select 'copy link' option from context menu.
3.Open Ntp, right click and select paste option, observe.
Review URL: https://codereview.chromium.org/1204673002
Cr-Commit-Position: refs/heads/master@{#335741}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, to establish ChannelMojo connection,
server process MUST know the client process handle.
This CL is to release the obigation.
IntentToImpl is discussed in
https://groups.google.com/a/chromium.org/forum/#!topic/mojo-dev/Qpb9Qonbmys
TBR=morrita@chromium.org,agl@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1129063005
Cr-Commit-Position: refs/heads/master@{#335192}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When starting animations, use the specified start time of
the animation as the start time if it is set. Otherwise,
continue to use the current time.
LayerAnimationController would originally set the time of the
start event to the current time even if the animation had
a specified start time. This would result in the
AnimationDelegate and any LayerAnimationEventObserver from
getting an incorrect start time.
BUG=498404
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1169243002
Cr-Commit-Position: refs/heads/master@{#335128}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1186403004
Cr-Commit-Position: refs/heads/master@{#335118}
|
|
|
|
|
|
|
|
|
|
|
| |
Removed TestNowSource completely. Its usage updated under cc/test, cc/scheduler, cc/surfaces and components/scheduler with coressponding api of SimpleTestTickClock. Refactored num_now_calls_ functionality in NowNotCalledWhenThereAreNoDelayedTasks test to use TestAlwaysFailTimeSource
BUG=440281, 494887
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1132753008
Cr-Commit-Position: refs/heads/master@{#334341}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1146953004
Cr-Commit-Position: refs/heads/master@{#333972}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When creating a bookmark file by draging and droping the URL to the desktop
chromium uses the page title for the filename. In cases where the title starts
with a dot the webloc file will also start with a dot. Since files starting
with a dot are considered hidden and not shown by e.g. the Finder users won't
see the expected resulting file. To circumvent this a dot as the first
character is handled like any other character not allowed in a filename and
gets replaced by a hyphen.
BUG=138917
TEST=Paste "data:text/html,<title>. . . hey!</title>" into the Omnibox and drag
and drop the URL to the desktop.
Review URL: https://codereview.chromium.org/1118813005
Cr-Commit-Position: refs/heads/master@{#333649}
|
|
|
|
|
|
|
|
|
| |
BUG=479898
R=eroman@chromium.org
Review URL: https://codereview.chromium.org/1158193006
Cr-Commit-Position: refs/heads/master@{#332587}
|
|
|
|
|
|
|
|
|
|
|
| |
push_back(ptr.Pass()) in device/bluetooth
BUG=457697
R=rpaquay@chromium.org
Review URL: https://codereview.chromium.org/1160263002
Cr-Commit-Position: refs/heads/master@{#332546}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds the commandline switch "--enable-webrtc-dtls12" to enable
negotiation of DTLS 1.2 for WebRTC peerconnections.
BUG=428343
Review URL: https://codereview.chromium.org/1157093007
Cr-Commit-Position: refs/heads/master@{#332381}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1154103002
Cr-Commit-Position: refs/heads/master@{#331951}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1162503004
Cr-Commit-Position: refs/heads/master@{#331842}
|