summaryrefslogtreecommitdiffstats
path: root/AUTHORS
Commit message (Collapse)AuthorAgeFilesLines
* Space key doesn't work in AURA enabled build because in case of space key,sadrul@chromium.org2011-11-141-0/+1
| | | | | | | | | | | | | WebInputEvent::Char event is not sent to WebKit. TBR=sky@chromium.org BUG=103753 TEST=Load a html page with a text box and check if space key works. Review URL: http://codereview.chromium.org/8461004 Patch from Amruth Raj <ckqr36@motorola.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109918 0039d316-1c4b-4281-b951-d872f2087c98
* chrome should show the context menu on menu key press though last_mouse_down ↵brk376@motorola.com2011-11-081-0/+1
| | | | | | | | | | | | | | is NULL. BUG=102828 TEST=1. Open https://bugs.webkit.org/ 2. Focus input field using 'Tab' key. 3. Press menu or Shift+F10 key to open context menu. 4. This should open a menu. Review URL: http://codereview.chromium.org/8503009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109065 0039d316-1c4b-4281-b951-d872f2087c98
* Change the dev toggle in Extensions options page to use text-align instead ↵progame@chromium.org2011-10-251-0/+1
| | | | | | | | | | | | of float so it mirrors properly in RTL UI. BUG=101461 TEST=Open chrome://extensions/. Notice the dev toggle is to the right for English UI and to the left for Hebrew UI. Review URL: http://codereview.chromium.org/8381034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107116 0039d316-1c4b-4281-b951-d872f2087c98
* Invalid URLs should not be added to startup page list.nqk836@motorola.com2011-10-241-0/+1
| | | | | | | | | | BUG=100658 TEST=Try to add an invalid URL in start pages list in chrome://setttings. It should have no effect. Review URL: http://codereview.chromium.org/8349030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106947 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for a memory leak in views/controls/native/native_view_host_gtk.cctimurrrr@chromium.org2011-10-211-0/+1
| | | | | | | | | | | Landing a patch for Parag Radke, originally reviewed at http://codereview.chromium.org/8294008/ BUG=96368 TBR=sky Review URL: http://codereview.chromium.org/8353034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106696 0039d316-1c4b-4281-b951-d872f2087c98
* 97871: Bottom half of new tab button on tabstrip is not touchable.tony@chromium.org2011-10-191-0/+1
| | | | | | | | | | | | | | new-tab button hit rect doesnt extend to the bottom of the button. The touchable part of this + button is only the top half of it. Touches at the bottom half of the button do not register. Since the newtab button bitmap is different for touch and non-touch paths, the custom points should be updated for touch_ui path as per bitmap. BUG=97871 TEST=NONE Review URL: http://codereview.chromium.org/8316001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106377 0039d316-1c4b-4281-b951-d872f2087c98
* History: Hide 'edit items' button when there are no items to display.qghc36@motorola.com2011-10-191-0/+1
| | | | | | | | | | BUG=37978 TEST=Verify that history page with zero items should not display Edit Items button. Review URL: http://codereview.chromium.org/8334010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106251 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 106069 - Fix for Memory Leak 72698_bthestig@chromium.org2011-10-181-1/+0
| | | | | | | | | | | | | BUG=72698 TEST= Review URL: http://codereview.chromium.org/8330018 TBR=nrqv63@motorola.com Review URL: http://codereview.chromium.org/8349007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106112 0039d316-1c4b-4281-b951-d872f2087c98
* OpenBSD support for yasm.mark@chromium.org2011-10-181-1/+1
| | | | | | | | | | | | | - include the openbsd configuration for yasm - use the correct yasm_flags on every posix system except for mac Patch by Robert Nagy <robert.nagy@gmail.com> BUG= TEST= Review URL: http://codereview.chromium.org/8348002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106083 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for Memory Leak 72698_bnrqv63@motorola.com2011-10-181-0/+1
| | | | | | | | | | BUG=72698 TEST= Review URL: http://codereview.chromium.org/8330018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106069 0039d316-1c4b-4281-b951-d872f2087c98
* Stopping unnecessary update of file name to stop resetting of selection in ↵rosen.dash@gmail.com2011-10-171-0/+1
| | | | | | | | | | | | | | chrome://downloads. BUG=100528 TEST=None Patch by: rosen.dash@gmail.com Review URL: http://codereview.chromium.org/8311016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105904 0039d316-1c4b-4281-b951-d872f2087c98
* Use rewritten url of a tab to find the zoom level from zoom map. Zoom map iswrm364@motorola.com2011-10-141-0/+1
| | | | | | | | | | | | | | maintained using rewritten URLs. Using GetURL() to find the zoom level will fail in case of rewritten URLs as GetURL() returns virtual_url which will be different from the rewritten URL. Contributed by wrm364@motorola.com BUG=94408 Review URL: http://codereview.chromium.org/8262011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105474 0039d316-1c4b-4281-b951-d872f2087c98
* Add ARM (asm) memset routines to skia buildblr.bmlab@gmail.com2011-10-131-0/+1
| | | | | | | | | ARM ASM optimized memset routines provide better performance for platforms (with/without NEON) ,compared to portable C - version Review URL: http://codereview.chromium.org/8262005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105310 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build error while building with 'make' (Complete build).qtc746@motorola.com2011-10-131-0/+1
| | | | | | | | | | | Contributed by qtc746@motorola.com BUG:None TEST:None Review URL: http://codereview.chromium.org/8216006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105273 0039d316-1c4b-4281-b951-d872f2087c98
* OpenBSD and FreeBSD fixes for base.mark@chromium.org2011-10-131-0/+1
| | | | | | | | | | | | | OpenBSD and FreeBSD need -I/usr/local/include for <execinfo.h>. Use !#/usr/bin/env bash because on !linux it's not located there. Patch by Robert Nagy <robert@openbsd.org> BUG=none TEST=none Review URL: http://codereview.chromium.org/8228005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105257 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compilation when use_aura is turned ON.vamshi@motorola.com2011-10-031-0/+1
| | | | | | | | | | | BUG=none TEST=none Patch by vamshi@motorola.com Review URL: http://codereview.chromium.org/8109001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103688 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to get appropriate favicon for a URL which has icons for both touch ↵naveenbobbili@motorola.com2011-09-301-0/+1
| | | | | | | | | | | | and favicon types in DB. Since icon mappings are returned from DB in reverse sorted order (HistoryBackendTest.IconMappingsOrderTest) we need to run a loop on the vector to find the first match for the icon type and return the same. BUG=94897 TEST=Run HistoryBackendTest.IconMappingsOrderTest which confirms that we get a reverse sorted order icon mapping in the vector. Review URL: http://codereview.chromium.org/7969032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103496 0039d316-1c4b-4281-b951-d872f2087c98
* Add Pepper API to use UDP mtilburg@adobe.com2011-09-261-0/+4
| | | | | | | | | | | | author: mtilburg@adobe.com BUG=none TEST=tested with pepper flash Review URL: http://codereview.chromium.org/8036036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102817 0039d316-1c4b-4281-b951-d872f2087c98
* add Sanjoy Pal to AUTHORS.estade@chromium.org2011-09-241-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8044006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102622 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 102101 - Displaying the extensions count in extensions settings page.finnur@chromium.org2011-09-221-1/+0
| | | | | | | | (Vetoed by the UI leads) BUG=96855TEST=Load chrome://settings/extensionSettings and see that the title format is now Extensions (xx) where xx is the number of installed extensions in the list. Also if there are no extensions loaded then the title should be Extensions.Patch by naveenbobbili@motorola.comReview URL: http://codereview.chromium.org/7932021TBR=naveenbobbili@motorola.com Review URL: http://codereview.chromium.org/7993001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102267 0039d316-1c4b-4281-b951-d872f2087c98
* CUPS printing: Define CUPS_PRINTER_SCANNER for Linux if CUPS is < 1.4chrelad@gmail.com2011-09-221-0/+1
| | | | | | | | | | BUG=97409 TEST=Try compiling on Linux with CUPS < 1.4 Review URL: http://codereview.chromium.org/7980036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102248 0039d316-1c4b-4281-b951-d872f2087c98
* Displaying the extensions count in extensions settings page.naveenbobbili@motorola.com2011-09-211-0/+1
| | | | | | | | | | | BUG=96855 TEST=Load chrome://settings/extensionSettings and see that the title format is now Extensions (xx) where xx is the number of installed extensions in the list. Also if there are no extensions loaded then the title should be Extensions. Patch by naveenbobbili@motorola.com Review URL: http://codereview.chromium.org/7932021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102101 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the spelling of the comment in ImeInput::IsCtrlShiftPressed.ehsan.akhgari@gmail.com2011-09-151-0/+1
| | | | | | | | | | | | Found when borrowing the code into Mozilla. BUG=96706 TEST= Review URL: http://codereview.chromium.org/7903008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101343 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed crash when a SinglesplitView gets embedded inside SingleSplitView.tfarina@chromium.org2011-09-151-0/+1
| | | | | | | | | | | | | | BUG=None TEST=Added test example double_split_view in views/examples. R=sky@chromium.org,oshima@chromium.org,tfarina@chromium.org Patch from Gajendra Singh <wxjg68@motorola.com> Review URL: http://codereview.chromium.org/7911001 Patch from Gajendra Singh <wxjg68@motorola.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101298 0039d316-1c4b-4281-b951-d872f2087c98
* Clean the SingletonLock only if there is no previous Chromium process running.amruthraj@motorola.com2011-09-131-0/+1
| | | | | | | | | | | BUG=96134 TEST=Launch three Chrome processes to see that the third one doesn't crash. Patch by amruthraj@motorola.com Review URL: http://codereview.chromium.org/7796030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100943 0039d316-1c4b-4281-b951-d872f2087c98
* Copy Mark Seaborn from the Native Client authors file to the Chromium authorsbrettw@chromium.org2011-08-261-0/+1
| | | | | | | | | | | | file. This makes the Native Client authors file a subset of the Chromium one so that we can update the copyright notices of the code we recently moved into the Chrome repo to be "Copyright the Chromium Authors." TEST=none BUG=none Review URL: http://codereview.chromium.org/7770001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98499 0039d316-1c4b-4281-b951-d872f2087c98
* Optimize all images in chrome/app and chrome/browser.tony@chromium.org2011-08-151-0/+1
| | | | | | | | | | | | | | | | | | | The following lossless PNG crunchers were used: - AdvPNG - OptiPNG - PNGCrush - PNGOUT Total savings: 1.001.550 bytes, i.e. almost 1 MB. Patch from Mathias Bynens <mathias@qiwi.be> BUG=chromium:92525 TEST=none Review URL: http://codereview.chromium.org/7638001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96786 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a corner case bug in the HexStringToInt conversion function which ↵ali.akbar@gmail.com2011-08-121-0/+1
| | | | | | | | | | | | | | | | | | | | | caused the string "0x" to be treated as a valid hexadecimal number. Although the parsed result was 0, the boolean flag returned indicated that the hex number was in proper format The IteratorRangeToNumber class's Invoke function increments the string pointer by 2 if the string starts with "0x" or "0X" and the length is greater than *or equal* to 2 If the length of the string is 2, i.e "0x", after the pointer increment, the string would be empty and the function returns true as the parse result Changed the condition from "greater than or equal to" to "greater than" Added another test cases which now properly treats "0x" as an invalid hex string Contributed by ali.akbar@gmail.com BUG=92054 Review URL: http://codereview.chromium.org/7584031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96605 0039d316-1c4b-4281-b951-d872f2087c98
* Added a link to the downloads tab that opens the downloads folder.fhd@ubercode.de2011-07-281-0/+1
| | | | | | | | | | | | Contributed by fhd@ubercode.de BUG=8915 TEST=chrome://downloads has a link labeled "Open downloads folder" that opens the configured downloads folder. Review URL: http://codereview.chromium.org/7398026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94493 0039d316-1c4b-4281-b951-d872f2087c98
* Disable part of InProcessBrowserTest.InjectIDBKey to prepare for upstream ↵levin@chromium.org2011-07-191-0/+1
| | | | | | | | | | | | | changes. InProcessBrowserTest.InjectIDBKey depends on internal details about the format produced by WebSerializedScriptValue; this format will change should https://bugs.webkit.org/show_bug.cgi?id=63481 land. After the WebKit change is complete, this test will be re-enabled in a way that works with the new format. BUG=None TEST=This is a test modification. Review URL: http://codereview.chromium.org/7400030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93053 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up of -Wunused-but-set-variable (gcc 4.6)pph34r@gmail.com2011-06-251-0/+1
| | | | | | | | | | BUG=80071 TEST=base_unittests Review URL: http://codereview.chromium.org/7232025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90489 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for Linux kernels >=3.0-rc1 in Python related build files by:tony@chromium.org2011-06-161-0/+1
| | | | | | | | | | | | | | | - replacing occurences of sys.platform == 'linux2' with sys.platform.startswith('linux') - congregating occurences of sys.platform in ('linux[X]', 'linuxY', ...) to sys.platform.startswith('linux') - adding the key 'linux3' to all relevant lookup dicts BUG=85845 TEST=Try building chromium on Linux >=3.0-r1 Review URL: http://codereview.chromium.org/7172016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89354 0039d316-1c4b-4281-b951-d872f2087c98
* Allow wildcard for corporate CLA. Add nvidia to AUTHORS.maruel@chromium.org2011-06-131-5/+14
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7003151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88891 0039d316-1c4b-4281-b951-d872f2087c98
* Add ruben to AUTHORS so people stop asking if he's signed the CLA.tony@chromium.org2011-05-271-0/+1
| | | | | | Review URL: http://codereview.chromium.org/7085010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87086 0039d316-1c4b-4281-b951-d872f2087c98
* Modifies the event handler for WM_APPCOMMAND events to return TRUE if the ↵mma.public@gmail.com2011-05-031-0/+1
| | | | | | | | | | | | | event was handled. Previously it returned 0 causing the event to bubble up to the DefWndProc, which would synthesize keypresses appropriate for the event and cause it to effectively be handled twice. This should fix double handling of events for people with devices that generate WM_APPCOMMAND messages (tablets, Logitech mice, etc...) BUG=19672 TEST=See various cases reported on bug Review URL: http://codereview.chromium.org/6901076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83975 0039d316-1c4b-4281-b951-d872f2087c98
* Send the 'page_url' parameter of the page (on which the right click was made tobrettw@chromium.org2011-04-201-0/+1
| | | | | | | | | | | | | | | open the context menu) as the 'referer' field of the http header field. This change is done for cases OPENLINKNEWTAB, OPENLINKNEWWINDOW, and NOT for OPENLINKOFFTHERECORD (Incognito). Also Https to Https transition must NOT send the referrer and this is checked in the 'OpenURL' method. Call to the ShouldHideReferrer method is done at render_view.cc Author Ramkumar Gokarnesan - ramgo@yahoo-inc.com BUG=1935 TEST=Try right click on a URL and click 'open link in new tab' or 'open link in new window' and see the referer information being sent as a part of the http header field. verify with wireshark / VS debugger. Original review http://codereview.chromium.org/6681030/ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82323 0039d316-1c4b-4281-b951-d872f2087c98
* Replacing outdated DCHECK(a == b) with DCHECK_EQ(a, b).david.mike.futcher@gmail.com2011-04-181-0/+1
| | | | | | | | | | | | | This is my first attempt at contributing, so please tell me where I'm going wrong. BUG=58409 TEST= Review URL: http://codereview.chromium.org/6851016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81988 0039d316-1c4b-4281-b951-d872f2087c98
* Adds method call to UpdatePrintableSizeInPrintParameters() to fix Content ↵clementskau@gmail.com2011-04-131-0/+1
| | | | | | | | | | | | | Area width on print on Linux. This happens in connection with CSS3 Paged Media margins. BUG=79157 TEST=Try and print a page with CSS3 Paged Media margins like: http://dl.dropbox.com/u/599885/CSS3_Paged_Media_Margin_test.htm Review URL: http://codereview.chromium.org/6825074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81355 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Allow text selection in the page info bubble.rsesek@chromium.org2011-03-301-0/+1
| | | | | | | | | | | BUG=52526 TEST=Try going to any web page and click on either the padlock or the globe icon. The text within the bubble should be selectable. Review URL: http://codereview.chromium.org/6683063 Patch from Seshadri Mahalingam <seshadri.mahalingam@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79819 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/2928005/ for Dill:sky@chromium.org2011-03-221-0/+1
| | | | | | | | | | | | Loads favicons when openning back/forward menu for any urls that don't have favicons. BUG=5679 TEST=Restore a tab with a navigation history, check favicons. Review URL: http://codereview.chromium.org/6708029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79000 0039d316-1c4b-4281-b951-d872f2087c98
* WinDDK ATL and MSVC express 2008/2005 compatability mark@chromium.org2011-03-211-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Gives 'out of the box' compatability with VC2008 express - i.e. no modifications needed to system headers or .gyp* files or related hacks. Just set the GYP_MSVS_VERSION to 200Xe (e for express, same as the linked blog on the issue and first google hit as well). 1) Changes to build\common.gypi to turn off to define COMPILER_MSVC_EXPRESS if a express is detected (through the GYP_MSVC_VERSION environment variable), turn off the _SECURE_ATL define (which is flagged as an error with WinDDK's ATL, _SECURE_ATL adds [more] CRT checks to other ATL versions) and hard to link to the atl stdthunk library with express editions. Also, explicitly link to the base WinSDK libraries in common.gypi and mini_installer.gypi for MSVC 2005 express. 2) Fixes a few .cc files that have the wrong include order with the ATL headers when using the Windows DDK ATL. The Windows DDK ATL brings in intsafe.h (WinSDK, not WinDDK) with atlwin.h and generates multiple INTXX_MIN/MAX def warnings which get flagged as errors with the warnings as errors flag if not included before other libraries that have the same definitions like ICU. 3) Changes to .rc files to avoid pulling in afxres.h (an MFC header - it's available in the WinDDK) and winres.h which VCExpress doesn't have (it's available in a WinSDK sample, but that kind of the purpose of it). The main Chromium .rc files are already structured this way, I just changed the rest and changed the output of grit to do the same. 4) Removes the memset obj file linking in mini_installer.gyp and simply implements memset for mini_installer.cc. Only changes to the chromium branch now. There are some .rc files in the Python26, Native Client, and Angle in samples that could #3 changes. They are not required for Chromium, however. ------ VC2005SP1 can be downloaded at http://www.microsoft.com/downloads/en/details.aspx?FamilyId=7B0B0339-613A-46E6-AB4D-080D4D4A8C4E&displaylang=en (or non-SP1 at http://download.microsoft.com/download/8/3/a/83aad8f9-38ba-4503-b3cd-ba28c360c27b/ENU/vcsetup.exe) VC2008SP1 can be downloaded at http://www.microsoft.com/downloads/en/details.aspx?FamilyId=F3FBB04E-92C2-4701-B4BA-92E26E408569&displaylang=en currently. The base developer instructions work fine afterwards with a couple tweaks for express versions: http://www.chromium.org/developers/how-tos/build-instructions-windows Under "Additional (free) downloads" under step 2: X) Only the first 3 Non-SP KB Patches are needed for express. Don't forget to forget GYP_MSVS_VERSION environment as appropriate - 2008e for Visual C++ 2008 Express, for example. Under "Additional (free) downloads" after step 5 [These only apply to 2008 express, 2005 works fine out of the box]: 6A) Download the WinDDK for the atl headers and libs - http://msdn.microsoft.com/en-us/windows/hardware/gg487463.aspx. It works fine, but you do not need to install the whole DDK. In the WDK directory just install headers.msi, libs_x86fre.msi, and libs_x64fre.msi; just grab the atl headers and atl*.lib libs; right click the installers and uninstall afterwards. Add the appropriate include and lib paths to your global settings. 6B) To build x64 targets (x64 Native Client) download: http://www.cppblog.com/Files/xcpp/VCE64BIT_WIN7SDK.zip Follow the readme instructions. Further information behind that and x64 target building with express: - http://jenshuebel.wordpress.com/2009/02/12/visual-c-2008-express-edition-and-64-bit-targets/ - http://www.cppblog.com/xcpp/archive/2009/09/09/vc2008express_64bit_win7sdk.html ---------------- BUG=1433, 5026, 72885 TEST=Compiles in both Debug and Release mode in Visual C++ Express 2008/2005 and does not effect other build setups. In addition, the WinDDK ATL compiles with the secure_atl=0 in the GYP_DEFINES environment variable on non-express versions of MSVC. Review URL: http://codereview.chromium.org/6676030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78921 0039d316-1c4b-4281-b951-d872f2087c98
* Removing references to off the record in comments and log messages.akalin@chromium.org2011-03-081-0/+1
| | | | | | | | | | | Original patch by vipul.bhasin@gmail.com. BUG=3333 TEST=None Review URL: http://codereview.chromium.org/6625076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77331 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compiling on gcc-4.6.hbono@chromium.org2011-02-251-0/+1
| | | | | | | | | | | | This change removes invalid direct calls to constructors and replaces NULL to 0 as workarounds for a compiler bug of gcc 4.6. Patch from Maarten Lankhorst <m.b.lankhorst@gmail.com>. BUG=none TEST=fix builds on gcc 4.6 Review URL: http://codereview.chromium.org/6596005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76046 0039d316-1c4b-4281-b951-d872f2087c98
* Begin the DCHECK() cleanup. Starting off with /src/chrome/a* and ↵rsesek@chromium.org2011-02-171-0/+1
| | | | | | | | | | | /src/chrome/browser/a* BUG=58409 Review URL: http://codereview.chromium.org/6539002 Patch from Kushal Pisavadia <kushi.p@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75314 0039d316-1c4b-4281-b951-d872f2087c98
* Clamp posix file names to NAME_MAX.thestig@chromium.org2011-02-111-0/+1
| | | | | | | | | | | | | Note: This is one out of two patches that together will fix sub-frame exporting during 'save page as'. The other one is here: https://bugs.webkit.org/show_bug.cgi?id=53897 Patch from Magnus Danielsson <fuzzac@gmail.com> Original CL: http://codereview.chromium.org/6286140/ BUG=25303 TEST=Open www.cnn.com and click 'save page as'. Check the log to make sure no files failed to save due to too long file names. Review URL: http://codereview.chromium.org/6474018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74684 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed the "My Bookmarks" sample extension.kurrik@chromium.org2011-02-081-0/+1
| | | | | | | | | | | | | | | | Stopped referencing a broken jqueryui URL for css and started using a resource hosted at ajax.googleapis.com. Also replaced some single quotes with double quotes. This was causing a parse error since the single quotes where inside another string delineated with single quotes. Patch from Sam McDonald <sam@sammcd.com> BUG=70072 TEST=Load bookmarks extension into a browser. Check that no errors appear in inspector. Click edit on a bookmark to makes sure UI css looks right. Review URL: http://codereview.chromium.org/6447010 Patch from Sam McDonald <sam@sammcd.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74137 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak atomicops implementation for Mac OS X to compile correctly when __LP64__mark@chromium.org2011-01-101-0/+1
| | | | | | | | | | | | | | is defined. Patch by Ben Karel <eschew@gmail.com>. BUG=54554 TEST= - base_unittests --gtest_filter='AtomicOpsTest.*' - Compile base/string_util.cc (outside of Chromium) as 64-bit code on Mac OS X 10.6. Review URL: http://codereview.chromium.org/6091007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70942 0039d316-1c4b-4281-b951-d872f2087c98
* Move more extensions hard coded error messages to .grd file.tfarina@chromium.org2010-12-221-0/+1
| | | | | | | | | | | | | | BUG=51398 TEST=trybots Original Review: http://codereview.chromium.org/4953002/ Signed-off-by: Lauri Oherd <lauri.oherd@gmail.com> Reviewed-by: Aaron Boodman <aa@chromium.org> Review URL: http://codereview.chromium.org/6088002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69914 0039d316-1c4b-4281-b951-d872f2087c98
* Adding the possibility to resize the "Edit Bookmark" dialog.thakis@chromium.org2010-11-171-0/+1
| | | | | | | | | | BUG=60966 TEST=NONE Review URL: http://codereview.chromium.org/5116002 Patch from Peter Beverloo <peter@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66424 0039d316-1c4b-4281-b951-d872f2087c98
* Add Sevan Janiyan to the AUTHORS file.maruel@chromium.org2010-11-151-0/+1
| | | | | | Review URL: http://codereview.chromium.org/5019001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66134 0039d316-1c4b-4281-b951-d872f2087c98