| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
| |
InfoBarGtk::CreateMenuButton
BUG=NONE
TEST=NONE
Review URL: http://codereview.chromium.org/9602007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125090 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
regions to be turned back on via a command line flag.
BUG=chromium:115937
TEST=pass the flag --enable-css-regions to chrome on start up
Review URL: http://codereview.chromium.org/9523002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
created by the extension.
Contributed by yumios.art@gmail.com
BUG=112637
TEST=Try to create dialog boxes by a extension and a website(localhost).
Review URL: http://codereview.chromium.org/9426022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124275 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the caret to the end of the line with TAB, and filtered out redundant URLs.
This adds the ability to move through Omnibox result matches using TAB in addition to the arrow keys. To enable this, pressing TAB to move the caret to the end of the line was removed and the keyword hint/shortcut logic has been modified.
The Omnibox popup now shows keyword markers on the right side of matches that have associated keywords (represented by a right arrow). When this kind of match is selected, and the keyword is accepted, the match changes appearance by animating in the associated keyword match from the right to display the "Search X for <>" message.
If multiple matches have the same keyword then only the most relevant match will display the keyword marker and hint. Pressing TAB while a keyword hint is shown will enter keyword mode in place; the results will no longer change when keyword mode is entered. Additionally, substituting keyword provider matches will only be shown if a keyword substitution
is available.
Finally, results with redundant destination URLs (e.g., "foo.com", "www.foo.com") will have the less relevant URLs filtered out.
This also addresses some GTK omnibox browsertest flakiness; see bug 112041.
See original change review at http://codereview.chromium.org/6731036
Contributed by aaron.randolph@gmail.com
BUG=57748,76278,77662,80934,84420
TEST=Press TAB to move the selection down the list of results, SHIFT+TAB to move up.
Review URL: http://codereview.chromium.org/9309099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Landing patch for aaron.randolph:
http://codereview.chromium.org/9309099/
BUG=57748, 76278, 77662, 80934, 84420
TEST=
Review URL: https://chromiumcodereview.appspot.com/9417032
TBR=sail@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9419043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Landing patch for aaron.randolph:
http://codereview.chromium.org/9309099/
BUG=57748, 76278, 77662, 80934, 84420
TEST=
Review URL: https://chromiumcodereview.appspot.com/9417032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122412 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=83481
TEST=mouse select text from http://en.wikipedia.org/wiki/Main_Page
Toolbox -> Print -> Print to File -> Selection -> Print, verify that PDF contains only selection.
Toolbox -> Print -> Print to File -> All Pages -> Print, verify that PDF contains all pages.
Toolbox -> Print -> Print to File -> Pages: 1 -> Print, verify that PDF contains only page 1.
Review URL: http://codereview.chromium.org/9379039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121844 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
any kind of button
R=dmazzoni@chromium.org
BUG=98979
TEST=Manually with accProbe
Review URL: http://codereview.chromium.org/9375045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
Review URL: https://chromiumcodereview.appspot.com/9368023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121254 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is mostly contributed by Vinay(vinaya@adobe.com): http://codereview.chromium.org/9235035
Comparing with 9235035, this change:
- fixes the NaCl Proxy.
- adds untrusted tests.
- does other small fixes.
BUG=None
TEST=test_net_address_private and test_net_address_private_untrusted
Review URL: https://chromiumcodereview.appspot.com/9307115
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121106 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
traverse through the Omnibox results, removed moving the caret to the end of the line with TAB, and filtered out redundant URLs.
This adds the ability to move through Omnibox result matches using TAB in addition to the arrow keys. To enable this, pressing TAB to move the caret to the end of the line was removed and the keyword hint/shortcut logic has been modified.
The Omnibox popup now shows keyword markers on the right side of matches that have associated keywords (represented by a right arrow). When this kind of match is selected, and the keyword is accepted, the match changes appearance by animating in the associated keyword match from the right to display the "Search X for <>" message.
If multiple matches have the same keyword then only the most relevant match will display the keyword marker and hint. Pressing TAB while a keyword hint is shown will enter keyword mode in place; the results will no longer change when keyword mode is entered. Additionally, substituting keyword provider matches will only be shown if a keyword substitution
is available.
Finally, results with redundant destination URLs (e.g., "foo.com", "www.foo.com") will have the less relevant URLs filtered out.
This also addresses some GTK omnibox browsertest flakiness; see bug 112041.
Contributed by aaron.randolph@gmail.com
BUG=57748,76278,77662,80934,84420
TEST=Press TAB to move the selection down the list of results, SHIFT+TAB to move up.
Review URL: http://codereview.chromium.org/6731036
TBR=aaron.randolph@gmail.com
Review URL: https://chromiumcodereview.appspot.com/9310017
TBR=kinuko@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9309097
TBR=pkasting@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Omnibox results, removed moving the caret to the end of the line with TAB, and filtered out redundant URLs.
This adds the ability to move through Omnibox result matches using TAB in addition to the arrow keys. To enable this, pressing TAB to move the caret to the end of the line was removed and the keyword hint/shortcut logic has been modified.
The Omnibox popup now shows keyword markers on the right side of matches that have associated keywords (represented by a right arrow). When this kind of match is selected, and the keyword is accepted, the match changes appearance by animating in the associated keyword match from the right to display the "Search X for <>" message.
If multiple matches have the same keyword then only the most relevant match will display the keyword marker and hint. Pressing TAB while a keyword hint is shown will enter keyword mode in place; the results will no longer change when keyword mode is entered. Additionally, substituting keyword provider matches will only be shown if a keyword substitution
is available.
Finally, results with redundant destination URLs (e.g., "foo.com", "www.foo.com") will have the less relevant URLs filtered out.
This also addresses some GTK omnibox browsertest flakiness; see bug 112041.
Contributed by aaron.randolph@gmail.com
BUG=57748,76278,77662,80934,84420
TEST=Press TAB to move the selection down the list of results, SHIFT+TAB to move up.
Review URL: http://codereview.chromium.org/6731036
TBR=aaron.randolph@gmail.com
Review URL: https://chromiumcodereview.appspot.com/9310017
TBR=kinuko@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9309097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
results, removed moving the caret to the end of the line with TAB, and filtered out redundant URLs.
This adds the ability to move through Omnibox result matches using TAB in addition to the arrow keys. To enable this, pressing TAB to move the caret to the end of the line was removed and the keyword hint/shortcut logic has been modified.
The Omnibox popup now shows keyword markers on the right side of matches that have associated keywords (represented by a right arrow). When this kind of match is selected, and the keyword is accepted, the match changes appearance by animating in the associated keyword match from the right to display the "Search X for <>" message.
If multiple matches have the same keyword then only the most relevant match will display the keyword marker and hint. Pressing TAB while a keyword hint is shown will enter keyword mode in place; the results will no longer change when keyword mode is entered. Additionally, substituting keyword provider matches will only be shown if a keyword substitution
is available.
Finally, results with redundant destination URLs (e.g., "foo.com", "www.foo.com") will have the less relevant URLs filtered out.
This also addresses some GTK omnibox browsertest flakiness; see bug 112041.
Contributed by aaron.randolph@gmail.com
BUG=57748,76278,77662,80934,84420
TEST=Press TAB to move the selection down the list of results, SHIFT+TAB to move up.
Review URL: http://codereview.chromium.org/6731036
TBR=aaron.randolph@gmail.com
Review URL: https://chromiumcodereview.appspot.com/9310017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120018 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the caret to the end of the line with TAB, and filtered out redundant URLs.
This adds the ability to move through Omnibox result matches using TAB in addition to the arrow keys. To enable this, pressing TAB to move the caret to the end of the line was removed and the keyword hint/shortcut logic has been modified.
The Omnibox popup now shows keyword markers on the right side of matches that have associated keywords (represented by a right arrow). When this kind of match is selected, and the keyword is accepted, the match changes appearance by animating in the associated keyword match from the right to display the "Search X for <>" message.
If multiple matches have the same keyword then only the most relevant match will display the keyword marker and hint. Pressing TAB while a keyword hint is shown will enter keyword mode in place; the results will no longer change when keyword mode is entered. Additionally, substituting keyword provider matches will only be shown if a keyword substitution
is available.
Finally, results with redundant destination URLs (e.g., "foo.com", "www.foo.com") will have the less relevant URLs filtered out.
This also addresses some GTK omnibox browsertest flakiness; see bug 112041.
Contributed by aaron.randolph@gmail.com
BUG=57748,76278,77662,80934,84420
TEST=Press TAB to move the selection down the list of results, SHIFT+TAB to move up.
Review URL: http://codereview.chromium.org/6731036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
accumulating them. Now, the objects are removed from the list when they are no longer needed, instead of being set to null.BUG=110459TEST=1. Go to any webpage 2. Go to a different webpage 3. Go back to step 1 and repeat many times. Before the fix pool_objects_ in win2k_threadpool grows with each new webpage visited. After the fix pool_objects_.size() is bounded even as new webpages are visited.
Review URL: http://codereview.chromium.org/9243014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
patterns. I.e. "file:///*" matches all file URIs.
Full/explicit/absolute paths (e.g. "file:///foo/bar.html") are still supported.
contributed by Francois Kritzinger (francoisk777@gmail.com)
BUG=77149
TEST=ContentSettingsPattern*
Review URL: http://codereview.chromium.org/9254028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=109705
TEST=Load me2mom app and confirm background gradient appears only once
Review URL: http://codereview.chromium.org/9187052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117515 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch changes the behavior on all systems to match the behavior on Linux
ie. there is always exactly one item selected in a run of radio items.
This patch includes a unit test (ExtensionMenuManagerTest.SanitizeRadioButtons).
BUG=49808
TEST=On any OS but Linux, load an extension that has a context menu without
items selected by defuat. One item shuold be selected, but none are.
Review URL: http://codereview.chromium.org/8935016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=35194
TEST=Try packing an extension from the browser, both overwriting and not overwriting an existing crx. And do a commandline browser extension pack.
Review URL: http://codereview.chromium.org/8947025
Patch from Clint Staley <clintstaley@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In revision 110671,
chrome/browser/resources/tracing/tracing_controller_tests.js is deleted, so
here this line is deleted correspondingly.
BUG=
TEST=
Review URL: http://codereview.chromium.org/8965073
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=35194
TEST=Try packing an extension from the browser, both overwriting and not overwriting an existing crx. And do a commandline browser extension pack.
Review URL: http://codereview.chromium.org/9044002
TBR=aa@chromium.org
Review URL: http://codereview.chromium.org/9102001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116419 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
in member functions of ChromeBrowserMainParts.
Contributed by simon.hong81@gmail.com
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/8983015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=35194
TEST=Try packing an extension from the browser, both overwriting and not overwriting an existing crx. And do a commandline browser extension pack.
Review URL: http://codereview.chromium.org/9044002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on the saved window state.
BUG=106967
TEST=Windows opened by window.open should be unmaximized by default
Review URL: http://codereview.chromium.org/9004046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to open downloaded files faster. Previously file was not opened until all the
icons were loaded.
Contributed by rryk.ua@gmail.com
BUG=62976
Review URL: http://codereview.chromium.org/8803001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original patch at http://codereview.chromium.org/8819014/ by Junmin Zhu <junmin.zhu@intel.com>
BUG=106001
TEST=manually
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/8989023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114944
Review URL: http://codereview.chromium.org/8921006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114993 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert due to compile breakage on ChromeOS.
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929
Review URL: http://codereview.chromium.org/8921006
TBR=tedvessenes@gmail.com
Review URL: http://codereview.chromium.org/8990002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114945 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114929
Review URL: http://codereview.chromium.org/8921006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114944 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Review URL: http://codereview.chromium.org/8921006
TBR=tedvessenes@gmail.com
Review URL: http://codereview.chromium.org/8984007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These changes address issue #106655. All variants of StringToInt have been
converted to use the StringPiece class. One instance of conversion, in
chrome/browser/history/text_database.cc, required copying an underlying
string. This is because the string type in question could use 8 or 16
bit characters depending on the OS type, and because StringPiece is not
implemented as a template, the code cannot specify whether to create a
StringPiece or StringPiece16. This should be remedied in a future CL.
R=erikwright@chromium.org
BUG=106655
TEST=
Review URL: http://codereview.chromium.org/8921006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changes std::string error to string16 in various locations of the Extensions file, spanning up the tree from ExtensionErrorReporter and Extension::InitFromValue, with conversion to string16 beginning at extension_l10n_util::LocalizeExtension and Extension::Create. Later patches can continue/expand the conversion.
BUG=71980
TEST=Run existing unit tests and browser tests, which have been adjusted for string16s.
Review URL: http://codereview.chromium.org/8890086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/8968004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=none
Review URL: http://codereview.chromium.org/8917030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When defined USE_XI2_MT, slot id of TouchEvent is maintained
by a map of tracking id to slot id. Because tracking id will
always keep increasing. The item should be released by TouchRelease
to free the slot id for future use.
BUG=106673
TEST=Manually Tested
Review URL: http://codereview.chromium.org/8839004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113850 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
-r/--revision: desired revision. Use DEPS if not given.
-b/--branch: branch where to create gclient. Use origin/master if not given.
-t/--tarball: Use tarball (http://src.chromium.org/svn/releases/) DEPS instead of src/DEPS.
BUG=none
TEST=
./tools/sync-webkit-git.py -r 97678
./tools/sync-webkit-git.py -t 16.0.912.41 -b origin/svn_912
Review URL: http://codereview.chromium.org/8769001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112481 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New API used:
gtk_widget_{set,get}_has_window - added 2.18 - replaces !GTK_WIDGET_NO_WINDOW
gtk_widget_{set,get}_allocation - added 2.18 - replaces direct access
gtk_bin_get_child - replaces direct access
gtk_widget_get_window - added 2.14 - replaces direct access
g_cclosure_marshal_VOID__BOXED - replaces gtk_marshal_VOID__BOXED
With these changes this directory can compile with GSEAL enabled and
deprecated functions disabled.
BUG=79722
TEST=Compiles and also the ui_unittests pass
Review URL: http://codereview.chromium.org/8646002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
D-Bus power managements interfaces (org.freedesktop.PowerManagement fro
KDE4/XFCE and org.gnome.SessionManager for Gnome).
The implementation consists of a Singleton class, DBusPowerSaveBlocker that
handles the D-Bus connection and IO thread. The specific D-Bus interfaces,
method calls and message processing is done in a DBusPowerSaveBlocker::Delegate.
There are two different implementations for this delegate, one for KDE4/XFCE and
one for Gnome.
If there is an unsupported desktop environment, no D-Bus object is instantiated,
and the ApplyBlock method won't do anything.
BUG=33605
TEST=manual
Review URL: http://codereview.chromium.org/8479005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebInputEvent::Char event is not sent to WebKit.
TBR=sky@chromium.org
BUG=103753
TEST=Load a html page with a text box and check if space key works.
Review URL: http://codereview.chromium.org/8461004
Patch from Amruth Raj <ckqr36@motorola.com>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is NULL.
BUG=102828
TEST=1. Open https://bugs.webkit.org/
2. Focus input field using 'Tab' key.
3. Press menu or Shift+F10 key to open context menu.
4. This should open a menu.
Review URL: http://codereview.chromium.org/8503009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109065 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
of float so it mirrors properly in RTL UI.
BUG=101461
TEST=Open chrome://extensions/. Notice the dev toggle is to the right for English UI and to the left for Hebrew UI.
Review URL: http://codereview.chromium.org/8381034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107116 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=100658
TEST=Try to add an invalid URL in start pages list in chrome://setttings. It should have no effect.
Review URL: http://codereview.chromium.org/8349030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106947 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Landing a patch for Parag Radke, originally reviewed at
http://codereview.chromium.org/8294008/
BUG=96368
TBR=sky
Review URL: http://codereview.chromium.org/8353034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
new-tab button hit rect doesnt extend to the bottom of the button. The touchable part of this +
button is only the top half of it. Touches at the bottom half of the button do not register.
Since the newtab button bitmap is different for touch and non-touch paths, the custom points
should be updated for touch_ui path as per bitmap.
BUG=97871
TEST=NONE
Review URL: http://codereview.chromium.org/8316001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106377 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=37978
TEST=Verify that history page with zero items should not display Edit Items button.
Review URL: http://codereview.chromium.org/8334010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106251 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=72698
TEST=
Review URL: http://codereview.chromium.org/8330018
TBR=nrqv63@motorola.com
Review URL: http://codereview.chromium.org/8349007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- include the openbsd configuration for yasm
- use the correct yasm_flags on every posix system except for mac
Patch by Robert Nagy <robert.nagy@gmail.com>
BUG=
TEST=
Review URL: http://codereview.chromium.org/8348002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=72698
TEST=
Review URL: http://codereview.chromium.org/8330018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome://downloads.
BUG=100528
TEST=None
Patch by: rosen.dash@gmail.com
Review URL: http://codereview.chromium.org/8311016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
maintained using rewritten URLs. Using GetURL() to find the zoom level will
fail in case of rewritten URLs as GetURL() returns virtual_url which will be
different from the rewritten URL.
Contributed by wrm364@motorola.com
BUG=94408
Review URL: http://codereview.chromium.org/8262011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105474 0039d316-1c4b-4281-b951-d872f2087c98
|