| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
Add myself to the AUTHORS file.
BUG=
Review URL: https://codereview.chromium.org/142573006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247356 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=331219
R=jeremy@chromium.org
TEST=Manual test please: Launch chrome and load the popup-bug.html in BUG331219
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246457
Review URL: https://codereview.chromium.org/140323005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/139853022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
should, as with other platforms, be disabled on OS X when there's no valid
webstore link.
BUG=331614
R=sail@chromium.org
Review URL: https://codereview.chromium.org/144293003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=337586
NOTRY=true
Review URL: https://codereview.chromium.org/143943013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246709 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid unneccessary copy of structures gfx::Vector2dF
by passing them by const ref rather than value.
Any struct of size > 4 bytes should be passed by const ref.
Passing by ref for these structs is faster than passing
by value, especially when invoking function has multiple parameters.
Pass gfx structs by const ref (gfx::Vector2dF)
BUG=159273
Review URL: https://codereview.chromium.org/130443005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mac port. (https://codereview.chromium.org/140323005/)
Reason for revert:
Avi is absolutely right, reverting.
Original issue's description:
> Set the maximum lines number to 32 for Javascript alert message on Mac port.
>
> BUG=331219
> R=jeremy@chromium.org
> TEST=Manual test please: Launch chrome and load the popup-bug.html in BUG331219
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246457
TBR=avi@chromium.org,yi.shen@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=331219
Review URL: https://codereview.chromium.org/145023010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=331219
R=jeremy@chromium.org
TEST=Manual test please: Launch chrome and load the popup-bug.html in BUG331219
Review URL: https://codereview.chromium.org/140323005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
various kinds of Intel Graphic Video driver.
Most of video driver run as texture mode as
default, but that's not all. In some drivers
support "UNDEFINED" or/and "OVERLAY" type
as default. That's why VA implement specific
render mode setting from "va.h".
VAVDA need run with *_LOCAL_GPU (name for texture),
so this CL want to set it.
BUG=NONE
Review URL: https://codereview.chromium.org/104853007/
Review URL: https://codereview.chromium.org/104853007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246310 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
support
on hardware and failing intentionally, which was not correct, the test should be skiped instead. This patch takes care of that along with the base patch.
On Aura with Nvidiea drivers the support is not there, so the test fails previously now weare skipping it by displaying the reason.
Android the support gets passed.
BUG=323150
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245772
Review URL: https://codereview.chromium.org/133363004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Caused assertion failures in content_gl_tests on all debug GPU bots.
> content_gl_tests were failing because, we are checking for rgb565 platform support
> on hardware and failing intentionally, which was not correct, the test should be skiped instead. This patch takes care of that along with the base patch.
> On Aura with Nvidiea drivers the support is not there, so the test fails previously now weare skipping it by displaying the reason.
> Android the support gets passed.
>
>
> BUG=323150
>
> Review URL: https://codereview.chromium.org/133363004
TBR=siva.gunturi@samsung.com
Review URL: https://codereview.chromium.org/142413002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
support
on hardware and failing intentionally, which was not correct, the test should be skiped instead. This patch takes care of that along with the base patch.
On Aura with Nvidiea drivers the support is not there, so the test fails previously now weare skipping it by displaying the reason.
Android the support gets passed.
BUG=323150
Review URL: https://codereview.chromium.org/133363004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL will share worker pool threads across LTHI for a single process.
Idea is to reduce the number of threads used per process.
For this, we implement WorkerPool::Inner as singleton, and LTHI/WorkerPool
would share the same instance per process.
Reviewer: reveman@chromium.org
BUG=239423
Review URL: https://codereview.chromium.org/73923003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/88033002/)
Reason for revert:
content_gl_tests failing on multiple gpu bots on the chromium.webkit buildbot.
Example: http://chromegw.corp.google.com/i/chromium.webkit/builders/GPU%20Mac10.7/builds/19123
Original issue's description:
> Add RGB565 Texture readback support in gl_helper
>
> Plan is to add a RGB565 readback and copy conversion for RGBA8 to RGB565 in GLHelper.
>
> BUG=323150
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245431
TBR=dtrainor@chromium.org,sievers@chromium.org,hubbe@chromium.org,aelias@chromium.org,piman@chromium.org,siva.gunturi@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=323150
Review URL: https://codereview.chromium.org/137783022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Plan is to add a RGB565 readback and copy conversion for RGBA8 to RGB565 in GLHelper.
BUG=323150
Review URL: https://codereview.chromium.org/88033002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=334253
R=ksakamoto@chromium.org
Review URL: https://codereview.chromium.org/139343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245257 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=334049
Review URL: https://codereview.chromium.org/138913002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245113 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
CLA is signed and I have couple of patches for review 126933003 and 123463006.
Review URL: https://codereview.chromium.org/128363003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When supplying a zero size to getcwd() typical behavior is to allocate
internally and return a pointer. This behavior was already implemented, but
disabled by checking if size <= 0 and erroring with EINVAL. As size_t is
positive definite, this entire check can be removed.
R=noelallen@chromium.org, sbc@chromium.org, binji@chromium.org
BUG=
Review URL: https://codereview.chromium.org/122943005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for assistive technologies on Windows. This changeset adds support for
- article (xml-roles:article)
- header (xml-roles:banner)
- aside (xml-roles:complementary)
- address (xml-roles:contentinfo)
- footer (xml-roles:contentinfo)
- main (xml-roles:main)
- nav (xml-roles:navigation)
- section (xml-roles:region)
Patch from Takeshi Kurosawa <taken.spc@gmail.com>
BUG=253027
TEST=content\renderer\accessibility\accessibility_node_serializer.cc
Review URL: https://codereview.chromium.org/98183011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MacOSX. The problem is that the .plist was missing an entry for xhtml. In
order for drag and drop to work, each supported file type must be listed in the
applications's CFBundleDocumentTypes.
Add doug.turner@gmail.com to AUTHORS
BUG=319730
Review URL: https://codereview.chromium.org/104393004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Author hasn't signed the CLA.
> Skip downloading of nacl toolchain for android.
> Nacl is not enabled in android and it takes too long to download the toolchain.
>
> BUG=329646
>
> Review URL: https://codereview.chromium.org/116833006
TBR=mahesh.kk@samsung.com
Review URL: https://codereview.chromium.org/119103003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242470 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Nacl is not enabled in android and it takes too long to download the toolchain.
BUG=329646
Review URL: https://codereview.chromium.org/116833006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
consistency
Review URL: https://codereview.chromium.org/119043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242123 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/117153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/117193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=271470
NOTRY=true
Review URL: https://codereview.chromium.org/110903003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
YACC parser used by PPAPI idl parser needs error function for each keyword to handle error.
Due to missing error function for dictionary object, yacc parser was deleting all data in
the stack including start of the file and when it restarts and reach end of file, since start
of file is missing it goes in endless loop.
R=noelallen@chromium.org,sehr@chromoium.org,nbarth@chromium.org
BUG=320921
TEST=Add new dictionary object in idl file with missing semicolon, compilation will fail.
Review URL: https://codereview.chromium.org/101623003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=gnanasekar.s@samsung.com
Review URL: https://codereview.chromium.org/110163002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239461 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL has caused a break in check_perms on Linux builder.
> Adding myself to authors list
>
> BUG=NONE
>
> Review URL: https://codereview.chromium.org/87873002
TBR=gnanasekar.s@samsung.com
Review URL: https://codereview.chromium.org/109873004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=gnanasekar.s@samsung.com
NOTRY=true
Review URL: https://codereview.chromium.org/100053010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=NONE
Review URL: https://codereview.chromium.org/87873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
avoids launching android process, assumes app is already started.
BUG=634
R=craigdh@chromium.org
Review URL: https://codereview.chromium.org/81613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
module doesn't exit)
BUG=226278
Review URL: https://codereview.chromium.org/91483002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Fix: Compute update_rect separately from original dirty rects and pass
them to update_rect_ as well as updating the contents.
BUG=316469
Review URL: https://codereview.chromium.org/85143002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238911 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/87903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://code.google.com/p/chromium/issues/detail?id=314945
Patch from Chris Harrelson <chrishtr@gmail.com>
BUG=314945
..
..
Plumbing for for layout rectangle debug information.
BUG=
Review URL: https://codereview.chromium.org/61883006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238297 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=324670
Review URL: https://codereview.chromium.org/95603003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Contributed by self@brendanlong.com
BUG=313601
Review URL: https://codereview.chromium.org/85693006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: This CL caused a regression in sizes bots, see https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fchrome-si&checked=all&start_rev=236784&end_rev=237073
TBR=enne@chromium.org,tomhudson@chromium.org,wiltzius@chromium.org,danakj@chromium.org,jamesr@chromium.org,vivekg@chromium.org,siva.gunturi@samsung.com
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/85753003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
each function call
CC functions like CheckImplSidePaintingStatus will cycle through all the switches
every time the function is called. Initial patch is avoiding it only for IsImplSidePaintingEnabled. So we need a generic way for all the switches, for future use.
This patch provides a one time initialization of all the switches in its first encounter (InitializeSwitchesIfRequired)
and later on will just read the updated data of the corresponding switches, when required.
Declared a seperate structure for holding the switch enable/disable data and saving memory by using bit fields.
BUG=313193
TEST=None; no behavior changes;
Review URL: https://codereview.chromium.org/69123002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237068 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
been created.
BUG=305919
TEST=Navigate to chrome://settings/autofill, and add a new credit card.
Click edit on the newly created row, and then close the edit overlay by
clicking the cross in the top right, or by pressing <Esc>. Now, add a
new credit card. This patch ensures that the new card is added (previously,
the original card would be updated instead). This also applies to addresses.
Review URL: https://codereview.chromium.org/59823012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Included terminated (or crashed) extensions in results for GetExtensionByID when
include_disabled is set to true. The permissions link will now respond if the
extension is terminated manually as described in linked issue.
BUG=316585
Review URL: https://codereview.chromium.org/74203004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235885 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
features to be passed over IPC.
BUG=315428
Review URL: https://codereview.chromium.org/61503003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235770 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/36733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Intent to implement-and-ship: https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/maxTouchPoints/blink-dev/ayzxdztUlOQ/rd-z_Jo3ocIJ
navigator.maxTouchPoints is defined in the W3C Pointer Events
standard draft:
http://www.w3.org/TR/pointerevents/#widl-Navigator-maxTouchPoints
Depends on blink revision 160153:
https://src.chromium.org/viewvc/blink?view=revision&revision=160153
BUG=248918
Review URL: https://codereview.chromium.org/26764002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231203 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: https://codereview.chromium.org/37053005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Added unit test for base::scoped_refptr boolean operations.
Also added a comment to 'operator T*() const' in order to make it more apparent to the User that boolean operations with scoped_refptr are possible without invoking 'get()' method.
Review URL: https://codereview.chromium.org/26868003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229802 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: https://codereview.chromium.org/26143005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229713 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of passing ExtensionInfoMap to the constructor of NaClHostMessageFilter,
pass it to the chrome implementation of NaClBrowserDelegate. (NaClBrowserDelegateImpl).
Instead of passing around the ExtensionInfoMap for each function call,
the delegate directly uses its own ExtensionInfoMap object.
Original patch by Yael Aharon, with some modifications by myself.
This is part of an effort to componentize NaCl code.
BUG=244791
Review URL: https://codereview.chromium.org/26902002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229278 0039d316-1c4b-4281-b951-d872f2087c98
|