| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
patch so I added my account in AUTHOR file.
Review URL: https://codereview.chromium.org/1817843002
Cr-Commit-Position: refs/heads/master@{#382471}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added example extension that utilizes chrome.displaySource
API's. The 'tabCast' extension creates a WiFi Display
Session from the captured tab media stream.
API Proposal: https://docs.google.com/document/d/1svs0p_b6KAIiBrKjaORsA2D8Pd84u8ksnTCfubYVVWA
BUG=242107
Review URL: https://codereview.chromium.org/1812813002
Cr-Commit-Position: refs/heads/master@{#381914}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In rare cases on OS X with in-process-gpu and zero-copy disabled,
rendering deadlocks can be triggered when a brokered attachment
arrives before the channel reader registers itself as an observer
of the attachment broker.
This patch simply replays unhandled attachment for new observers,
giving them a chance at handling attachments received before they
registered. This is safe since attachments already have unique ids.
BUG=584201
R=erikchen@chromium.org
Review URL: https://codereview.chromium.org/1810503002
Cr-Commit-Position: refs/heads/master@{#381691}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1806553002
Cr-Commit-Position: refs/heads/master@{#381457}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On hosts with multiple code signing identities in their keychain,
allow selecting the identity through GYP defines, i.e.
GYP_DEFINES="... chromium_ios_signing_identity='iPhone Developer: Ilya Konstantinov (FOOBAR)'"
R=dpranke@chromium.org
Review URL: https://codereview.chromium.org/1714373002
Cr-Commit-Position: refs/heads/master@{#381154}
|
|
|
|
|
|
|
|
| |
BUG=588465
Review URL: https://codereview.chromium.org/1778883002
Cr-Commit-Position: refs/heads/master@{#380168}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When overlay scroll bars are used on elements with CSS `overflow` set to use
scroll bars, and the background of that element is dark, the color of the
scroll bar is now set to the "light" style. This was previously only done for
the document (body), not for elements with a scrollable area. Whenever the
background changes, the scroll bar style will be updated accordingly.
Even after this change, the scroll bar is rendered with the wrong color if the
scrollable element doesn't have a background of its own (but a parent element
uses a dark background). Fixing the issue for scrollable elements with
background set explicitly is an improvement to the current state though.
BUG=588709
R=wangxianzhu@chromium.org
Review URL: https://codereview.chromium.org/1738503003
Cr-Commit-Position: refs/heads/master@{#378843}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bootstrap didn't work due to recent modifications in base.
Unfortunately some new dependencies are required on OSX
and that required adding generated_build_date.h to be
available separately for the bootstrap process.
Tested on Linux and OSX.
BUG=None
TEST=./tools/gn/bootstrap/bootstrap.py
R=brettw@chromium.org,tfarina@chromium.org
Review URL: https://codereview.chromium.org/1692303004
Cr-Commit-Position: refs/heads/master@{#376133}
|
|
|
|
|
|
|
|
| |
BUG=N/A
Review URL: https://codereview.chromium.org/1698253002
Cr-Commit-Position: refs/heads/master@{#375716}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The focus was incorrectly moved to the textfield after using the
keyboard. This makes it awkward to search for the previous occurrence
using only the keyboard. The focus still moves to the textbox when using
the mouse so that the user is still able to type different search terms.
BUG=537714
R=msw@chromium.org
TEST=Press CTRL+F to open the Find-In-Page box. Enter random text. Press
TAB to focus previous or next button. Press ENTER or SPACE. The button
should still be focused.
Review URL: https://codereview.chromium.org/1660273003
Cr-Commit-Position: refs/heads/master@{#374578}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change will fix "Aw, Snap!" in Chromium for Linux on mips32,
which is caused by dissallowed __NR_send syscall:
sigsys_handlers.cc:**CRASHING**:seccomp-bpf failure in syscall 4000 + 0178
TEST=Running Chromium on MIPS CI20 board with 3.18 kernel
BUG=369594, 130022
Review URL: https://codereview.chromium.org/1666103002
Cr-Commit-Position: refs/heads/master@{#374357}
|
|
|
|
|
|
|
|
|
|
|
|
| |
flamecharts rather than node.functionName:node.url
BUG=575026
Also increasing the color range. In the current color scheme the colors have a very short range for CPU Flamecharts. This means stacks from different urls are easily identifiable.
Review URL: https://codereview.chromium.org/1623613004
Cr-Commit-Position: refs/heads/master@{#373329}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Substituted pattern ScopedVector push_back(ptr.release()) with push_back(ptr.Pass()) in the following directories: /src/ui/events/gesture_detection and /src/content/browser/renderer_host
Updated the change by substituting pattern ScopedVector push_back(ptr.Pass()) with push_back(std::move(ptr)).
BUG=457697
BUG=557422
Review URL: https://codereview.chromium.org/1415223007
Cr-Commit-Position: refs/heads/master@{#372926}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with a custom message_pump.
This change is needed to support the embedded case where Chromium runs inside a foreign host application. One example of this is the CEF project. See https://bitbucket.org/chromiumembedded/cef/issues/1805/improve-support-for-a-host-owned-message.
In the embedded case the host runs the OS message loop and the UI message_loop needs to delegate back to the host without pumping messages inside the standard UI message_pump.
BUG=576536
Review URL: https://codereview.chromium.org/1582123002
Cr-Commit-Position: refs/heads/master@{#372265}
|
|
|
|
|
|
|
|
| |
BUG=N/A
Review URL: https://codereview.chromium.org/1648623002
Cr-Commit-Position: refs/heads/master@{#372118}
|
|
|
|
|
|
|
|
|
|
|
| |
This patch fixs the issue that Chrome URL bar's overlay in SurfaceFlinger
becomes fullscreen after pull to refresh. It will reduce memory bandwidth.
BUG=581626
Review URL: https://codereview.chromium.org/1638303002
Cr-Commit-Position: refs/heads/master@{#372048}
|
|
|
|
|
|
|
|
|
|
|
| |
Expose more paper sizes when printing to PDF
R=alekseys@chromium.org
BUG=493830
Review URL: https://codereview.chromium.org/1407353003
Cr-Commit-Position: refs/heads/master@{#370964}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Modified from https://codereview.chromium.org/1475393002/ by Riku Voipio
<riku.voipio@linaro.org>.
In the boringssl commit a91fd063cf87b905a4d3b06387727deb4a7016d0 [1]
.arch armv8-a+crypto has been disabled for clang.
So -march=armv8-a+crypto now needs to be set on command line to
build chromium/boringssl with clang. This commit fixes debian/arm64
chromium build.
[1] https://boringssl-review.googlesource.com/4411
BUG=none
Review URL: https://codereview.chromium.org/1574073003
Cr-Commit-Position: refs/heads/master@{#369247}
|
|
|
|
|
|
|
|
|
|
|
| |
increased ConnectErrorCode enum and cases in
BluetoothDeviceAndroid::OnConnectionStateChange
BUG=531058
Review URL: https://codereview.chromium.org/1464443002
Cr-Commit-Position: refs/heads/master@{#368649}
|
|
|
|
|
|
|
|
|
| |
BUG=295792
TEST=negativeshaderapi.html and negativevertexarrayapi.html
Review URL: https://codereview.chromium.org/1552653002
Cr-Commit-Position: refs/heads/master@{#367907}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL is a smaller set of the CL https://codereview.chromium.org/688253002/
It fixes some broken functionality exposed by that CL.
R=avi
BUG=384970
Review URL: https://codereview.chromium.org/1554253004
Cr-Commit-Position: refs/heads/master@{#367850}
|
|
|
|
|
|
|
|
|
|
| |
|local_state| no longer being used in Predictor. So it is safe to remove.
BUG=573994
Review URL: https://codereview.chromium.org/1558983002
Cr-Commit-Position: refs/heads/master@{#367818}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously the parsing of the `log2_tile_rows` field in the
uncompressed header would consume one bit too many in the case
where log2_tile_rows > 0. This corrupts the reading of the rest of
the header and causes playback to fail. Here the reading logic is
corrected.
BUG=569149
TEST=play the linked media in the bug on samus
Signed-off-by: Scott D Phillips <scott.d.phillips@intel.com>
Review URL: https://codereview.chromium.org/1516413003
Cr-Commit-Position: refs/heads/master@{#367404}
|
|
|
|
|
|
|
|
| |
BUG=N/A
Review URL: https://codereview.chromium.org/1547053002
Cr-Commit-Position: refs/heads/master@{#367359}
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/1547283002
Cr-Commit-Position: refs/heads/master@{#367047}
|
|
|
|
|
|
|
|
|
|
|
|
| |
InputType test has duplicate data, "host#ref", on line 86 and 88.
modified: components/omnibox/browser/autocomplete_input_unittest.cc
BUG=571771
Review URL: https://codereview.chromium.org/1548893002
Cr-Commit-Position: refs/heads/master@{#366982}
|
|
|
|
|
|
|
|
|
| |
BUG=568959
TEST=Related cr: https://codereview.chromium.org/1535403002/
Review URL: https://codereview.chromium.org/1544533002
Cr-Commit-Position: refs/heads/master@{#366395}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
isSecureContext() can now be called without an error message string argument. Also removed unused strings/error messages previously used in calls to isSecureContext().
Note: This affects all variants of ExecutionContext
BUG=567298
R=tkent@chromium.org
Review URL: https://codereview.chromium.org/1504403003
Cr-Commit-Position: refs/heads/master@{#366331}
|
|
|
|
|
|
|
|
|
|
| |
This is needed to analyze the performance of CMAA implementation in Chromium, compared to the possible Mesa version.
BUG=535198
Review URL: https://codereview.chromium.org/1523233003
Cr-Commit-Position: refs/heads/master@{#366068}
|
|
|
|
|
|
|
|
|
|
|
|
| |
ProxyProperties is present in Android up to KITKAT_WATCH, and
is renamed to ProxyInfo and made public in Lollipop.
BUG=569923
R=xunjieli
Review URL: https://codereview.chromium.org/1527613007
Cr-Commit-Position: refs/heads/master@{#365997}
|
|
|
|
|
|
|
|
| |
BUG=554289
Review URL: https://codereview.chromium.org/1527603002
Cr-Commit-Position: refs/heads/master@{#365399}
|
|
|
|
|
|
|
|
|
|
|
| |
Small cleanup which replaces the const value with const reference return value
of the reponse_original_url() function.
BUG=568959
Review URL: https://codereview.chromium.org/1527673002
Cr-Commit-Position: refs/heads/master@{#365341}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In a similar fashion to what it has been done for GLX, we create a child
XWindow to control resizes of EGL surfaces without exposing bugs in some
drivers which clobber the back buffer, resulting in flashes.
Contrary to GLX, EGL can be used in platforms not using the X Window System,
so we only apply this change in those cases, leaving the original code
untouched for non X11-based systems.
BUG=326995
R=piman@chromium.org
Review URL: https://codereview.chromium.org/1480333002
Cr-Commit-Position: refs/heads/master@{#364681}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
width
For container with 'fit-content' width value, when computing the width of
its child, it tries to get container's available logical width, which has not
been set. Because the container's width depends on the child.
BUG=560248
TEST=fast/css-intrinsic-dimensions/fit-content-container-with-replaced-child.html
Review URL: https://codereview.chromium.org/1499403002
Cr-Commit-Position: refs/heads/master@{#364105}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
which some buggy servers do.
Patch by tfh@skip.org
R=mmenke@chromium.org
BUG=536811
Review URL: https://codereview.chromium.org/1451993007 .
Patch from tfh <tfh@skip.org>.
Cr-Commit-Position: refs/heads/master@{#360845}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This basically reflects the logic from FrameLoader::startLoad. Before this patch, javascript: document navigations could be performed during page dismissal events. This could be problematic, especially that dismissal events prevent loaders from being stopped or detached.
This patch adds a bail-out condition to FrameLoader::replaceDocumentWhileExecutingJavaScriptURL.
BUG=556724
Review URL: https://codereview.chromium.org/1451123002
Cr-Commit-Position: refs/heads/master@{#360242}
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://codereview.chromium.org/1440633002
Cr-Commit-Position: refs/heads/master@{#360024}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds additional domains to the root PRESUBMIT check,
"_CheckHardcodedGoogleHostsInLowerLayers", based on hostnames
currently used in Chromium.
Previously, this check only validated that "google.com" was not
hard-coded, but did not catch other common hostnames:
- gstatic.com
- googleapis.com
- googlezip.net
- googledrive.com
- appspot.com
Note that this check is non-blocking, only prompting the user
with a warning before continuing the submit operation.
BUG=164568
TEST=PRESUBMIT_test.py
Review URL: https://codereview.chromium.org/1403673003
Cr-Commit-Position: refs/heads/master@{#359869}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tested with all combinaisons of
GYP_DEFINES="media_use_ffmpeg=i media_use_libvpx=j media_use_libwebm=k"
with i,j,k in {0, 1}^3
Same with GN:
media_use_ffmpeg = i
media_use_libvpx = j
media_use_libwebm = k
with i,j,k in {false, true}^3
If disabled it shows a black rectangle on video tag as expected.
If only ffmpeg is disabled, it succeeds to play webm video encoded with vpx.
BUG=
R=reillyg@chromium.org, jochen@chromium.org, xhwang@chromium.org, raymes@chromium.org
TEST=GYP_DEFINES="media_use_ffmpeg=0 media_use_libvpx=0 media_use_libwebm=0"
Review URL: https://codereview.chromium.org/1415793003
Cr-Commit-Position: refs/heads/master@{#359855}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
split the test into 3 separate tests. Copy the test images
to fast/images/resources since that directory is available
during testing: see Source/web/webkit_unit_tests.isolate
Update the test helper: it was allocating SharedBuffer for
the encoded image source on every byte to perform the test
and satisfy the test goals, but that was time intensive.
Instead, double buffer the source into 2 SharedBuffer, and
alternate those as input to the image decoder to speed the
tests (order 40ms now) and still properly test the decoder
onSetData() handling code.
Measurement shows the contribution of different techniques
to the fix. Taken on i7 5500U, Ubuntu, Default build:
initial: ~12,000ms
only with new pictures: ~500ms
only append (old pictures ~800ms
append and new picts: 89ms
append + alternate + new pics: 93ms
The values are for 3 tests combined.
BUG=528664, 439655
Review URL: https://codereview.chromium.org/1405053005
Cr-Commit-Position: refs/heads/master@{#359739}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NFC object is a member of NavigatorNFC that is supplement for Navigator.
Therefore, NFC object will be alive as long as Navigator object exists.
Because of that, inheritance from ActiveDOMObject is not required.
PageLifeCycleObserer is used to fullfill visibility use-case.
https://w3c.github.io/web-nfc/#handling-window-visibility-and-focus
BUG=520391
Review URL: https://codereview.chromium.org/1439063002
Cr-Commit-Position: refs/heads/master@{#359531}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As the existing comments in code indicate the current limit of 30 WebSockets
was chosen arbitrarily. The limit of 30 WebSockets is impacting
real world web sites, for an example, See http://crbug.com/486800
As a reference Firefox has a 200 WebSocket limit.
R=asanka@chromium.org
BUG=486800
Review URL: https://codereview.chromium.org/1130073004
Cr-Commit-Position: refs/heads/master@{#359051}
|
|
|
|
|
|
|
|
|
|
|
| |
__NR_unlink is not defined on arm64.
BUG=None
R= mdempsky
Review URL: https://codereview.chromium.org/1424513005
Cr-Commit-Position: refs/heads/master@{#358579}
|
|
|
|
|
|
|
|
| |
BUG=411568
Review URL: https://codereview.chromium.org/1415683010
Cr-Commit-Position: refs/heads/master@{#358559}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix deadlock when two or more threads are waiting for the
connection_type_initialized conditional variable. Also
add myself in AUTHORS file.
TEST=net_unittests --gtest_filter=AddressTrackerLinuxTest.BroadcastInit
Review URL: https://codereview.chromium.org/1407083007
Cr-Commit-Position: refs/heads/master@{#358376}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Before this change the beta and unstable rpm packages were without an icon as
both were correctly specifying the correct name in desktop file
(Icon=google-chrome-beta resp. Icon=google-chrome-unstable) but icon with that
name was never installed.
As a consequence installing the Chrome stable and beta rpm packages and later
removing the beta package would remove the icon and left the stable installation
without any (as both were using the same name without channel: google-chrome).
To fix the issue we need to define the PACKAGE variable in rpm/build.sh the same
way as in debian/build.sh so when we start to process the postinst.include
template (that is included from chrome.spec.template) the PACKAGE variables is
replaced with correct value (google-chrome for stable otherwise
google-chrome-beta or google-chrome-unstable) on not just google-chrome for all
channels as previously.
Also replace the PACKAGE_FILENAME usages in rpm/chrome.spec.template with
PACKAGE when it finally contains the right value and use the PACKAGE_FILENAME
just to specify the package name (where the channel is suffixed in the name even
for the stable channel).
BUG=529008
Review URL: https://codereview.chromium.org/1416053008
Cr-Commit-Position: refs/heads/master@{#357505}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This extends event handlers to pass tilt angles from Android MotionEvent
to Blink touch points, so that on the Blink side, PointerEvent tiltX and
tiltY can be filled with real tilt angles.
This CL is a part of a patch series:
1. https://codereview.chromium.org/1253183005/
for new WebPointerProperties fields
2. https://codereview.chromium.org/1260693003/
for eventSender web pointer property support
3. https://codereview.chromium.org/1192563002/
for handling tilt in Blink event handlers
4. https://codereview.chromium.org/1417803002/
(this)
This CL is based on the abandoned CL at
https://codereview.chromium.org/1187273004/
BUG=514360
Review URL: https://codereview.chromium.org/1417803002
Cr-Commit-Position: refs/heads/master@{#357471}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/1425663005
Cr-Commit-Position: refs/heads/master@{#357351}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Screenshot: http://imgur.com/6QgBxmS
BUG=469889
R=meacer@chromium.org
TEST=Start Chrome.
Open an 'about:blank' page.
Bring up the Chrome Security UI Pop-up.
Click on 'Connection' tab.
The two sections should not be empty.
Review URL: https://codereview.chromium.org/1423503003
Cr-Commit-Position: refs/heads/master@{#357275}
|
|
|
|
|
|
|
|
|
|
|
| |
Newer 360 controllers have the product ID of 0719. Adding this to
chromium enables standard mapping to be performed. Without it, buttons
will behave differently than defined in the GamePad API standard
mapping.
Review URL: https://codereview.chromium.org/1418513011
Cr-Commit-Position: refs/heads/master@{#356244}
|