| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=dimich
Review URL: http://codereview.chromium.org/173029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23663 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/172093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ASSERTION FAILED: m_clients.contains(renderer)
(.../src/webkit/../third_party/WebKit/WebCore/css/CSSGradientValue.cpp:109 virtual WebCore::Image* WebCore::CSSGradientValue::image(WebCore::RenderObject*, const WebCore::IntSize&))
while hovering over tab thumbnails on the New Tab page on the Mac in a debug
build
Review URL: http://codereview.chromium.org/172049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23546 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
lands r165517
Review URL: http://codereview.chromium.org/172034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
TBR=jparent
Review URL: http://codereview.chromium.org/170011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23527 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/17860
TEST=Layout test backgroundSize02.html should be less wonky.
R=agl
Review URL: http://codereview.chromium.org/164568
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23523 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165537
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23446 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I added TIMEOUT to one video test that I missed in r23407.
Also, added some temporary exceptions to test_expectations.txt
while I investigate and fix or file appropriate bugs.
TEST=None
BUG=None
TBR=mbelshe@chromium.org
Review URL: http://codereview.chromium.org/165515
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
The layout test failures happened on other platforms too.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
(take two, this caused layout test failures which I missed the first time.)
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23394 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23376 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This contains very few changes. Two reasons for updating:
1. Get JSON parser fix.
2. Get idle notification callback into the API to experiment with
releasing memory when a renderer is idle.
BUG=19212, 19086
Review URL: http://codereview.chromium.org/165451
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This one is happening quickly to fix up the Linux breakage.
In another checkin I handle updating test expectations.
BUG=None
TEST=None
TBR=mbelshe@chromium.org
Review URL: http://codereview.chromium.org/165447
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=mbelshe@chromium.org
Review URL: http://codereview.chromium.org/164467
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23299 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the crash on linux or windows so now I'm trying again to see if it
still triggers the crash on the build bot.
Review URL: http://codereview.chromium.org/165444
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/17569
TEST=none
TBR=agl
Review URL: http://codereview.chromium.org/164422
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23223 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/164412
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/164406
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23206 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=19086,...
Review URL: http://codereview.chromium.org/164398
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/165347
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23129 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
GTMWindowSheetController. Add carpet bombing dialog as first per-tab sheet.
Depends http://codereview.appspot.com/105064 .
The main issue with this patch is that GTMWindowSheetController doesn't provide an api to move sheets between windows, so this CL disables tab dragging for tabs with sheets, and fullscreen mode for windows with sheets. We can fix this later.
Other stuff that should be done at some point, but not now:
* Open/Save panels should be per-tab
* Need an ui test that goes to page, then page with sheet, then hit back, forward, reload.
* Bookmark sheets should not be sheets but in a separate window
BUG=14666
TEST=Go to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html , a per-window sheet should appear. Things to test with this dialog:
* Hitting cmd-q while a sheet is open in any tab should not quit but instead focus the sheet.
* Hitting cmd-w while a sheet is open in any tab should not close the window but instead focus the sheet.
* Dragging a tab with a sheet should move the window (and keep the tab visible), not detach the tab.
* Going fullscreen should be disabled for windows with open tabs.
* When a per-tab sheet is open in a non-active tab, it shouldn't steal the focus, i.e. going to the page above, then hitting cmd-t, and then hitting cmd-l should work.
* Closing a non-frontmost tab with a per-tab sheet shouldn't crash.
* Going to the url above and quickly opening a new tab, so that the sheet opens while its tab is not front-most should work (sheet should display only when you switch back to the tab with the sheet).
* Go to google.com, then to skypher.com/SkyLined/Repro/Chrome/carpet bombing/repro.html ,
hit "backward" with open sheet, hit forward, focus location bar, hit enter. This shouldn't crash.
* Hitting escape should dismiss the sheet
* Hitting enter should confirm the sheet.
Review URL: http://codereview.chromium.org/159780
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23091 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=levin
BUG=19064
TEST=none
Review URL: http://codereview.chromium.org/165311
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/165273
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=levin
Review URL: http://codereview.chromium.org/165300
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
these is the WebKit::WebBindings API.
This will be a 2 sided commit with https://bugs.webkit.org/show_bug.cgi?id=28089
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/164214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
exception when you try to access a key
at an index that's greater than or equal to ___Storage.length, it simply returns a null.
This is yet another demonstration of why we need a NullableString16 (rather than passing around a string and
a bool) but this cannot block on that work.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/165289
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23011 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=levin
Review URL: http://codereview.chromium.org/165278
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22994 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
in order to fix interactive UI test failures that result.
BUG=18939
TEST=none
Review URL: http://codereview.chromium.org/165243
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22939 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18333
TEST=none
TBR=agl
Review URL: http://codereview.chromium.org/164234
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=16010,16638,17174
TEST=none
Review URL: http://codereview.chromium.org/165193
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no layout test failures
TBR=pkasting
Review URL: http://codereview.chromium.org/164197
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=18333
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22772 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
wk 46885) and some layout rebaselines (for pkasting's 46871 and rniwa's 46860).
BUG=none
TEST=none
TBR=pkasting
Review URL: http://codereview.chromium.org/164154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bookmark localization (BookmarkBar, BookmarkEditor, and BookmarkNameFolder).
Toolbar localization.
TabView localization (the tab itself).
Bookmark Editor window fixup:
Align the labels to the front of the edit fields (ui guidelines).
Make the labels auto size to their text and resize the window as needed.
Make the buttons auto size to their strings and adjust to stay right pinned.
Make the window resize in general correctly.
BUG=16764
TEST=Try the Danish local, a bunch of this UI should localized, and the bookmark editor shouldn't truncate the labels or buttons.
Review URL: http://codereview.chromium.org/160328
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22730 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/164147
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22727 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/165128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22726 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(1m40s -> 10s)
BUG=18712
TEST=None
TBR=sgk
Review URL: http://codereview.chromium.org/165120
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22722 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(including abarth's v8 revert, in hopes of fixing reliability).
BUG=none
TEST=no layout redness
TBR=amanda
Review URL: http://codereview.chromium.org/165062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=awalker
BUG=none
TEST=no layout test regressions
Review URL: http://codereview.chromium.org/165057
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22607 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=senorblanco
TEST=no layout test regressions
BUG=none
Review URL: http://codereview.chromium.org/165033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Covered by existing unittests
Review URL: http://codereview.chromium.org/162018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=senorblanco
TEST=no layout test regressions
BUG=none
Review URL: http://codereview.chromium.org/160655
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22498 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/160650
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22484 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I was unable to reproduce the failures from the bots on my machine.
If they appear again, the build will not break, ane we will get full info.
TEST=none
http://crbug.com/17706
Review URL: http://codereview.chromium.org/159866
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/162003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22474 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
evaluate the script directly.
This change will break the isolatedWorld tests until I land the change to
rename the layoutTestController method upstream.
R=darin
TEST=Coverged by LayoutTests.
Review URL: http://codereview.chromium.org/159782
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22467 0039d316-1c4b-4281-b951-d872f2087c98
|