summaryrefslogtreecommitdiffstats
path: root/PRESUBMIT.py
Commit message (Collapse)AuthorAgeFilesLines
* Hook up the presubmit check for empty descriptions.thestig@chromium.org2011-12-051-0/+2
| | | | | | | | | | BUG=none TEST=none NOTRY=true Review URL: http://codereview.chromium.org/8812001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113063 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 112034 - Add win_shared and linux_shared builder into the default try ↵ajwong@chromium.org2011-11-301-1/+1
| | | | | | | | | | | | | | | | bot set. Component builds breakages are easy to introduce because you can accidentally add a cross-component dependency without any warning if you're doing a normal static build. BUG=105750 TEST=none Review URL: http://codereview.chromium.org/8726043 TBR=ajwong@chromium.org Review URL: http://codereview.chromium.org/8762005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112317 0039d316-1c4b-4281-b951-d872f2087c98
* Add win_shared and linux_shared builder into the default try bot set.ajwong@chromium.org2011-11-291-1/+1
| | | | | | | | | | | Component builds breakages are easy to introduce because you can accidentally add a cross-component dependency without any warning if you're doing a normal static build. BUG=105750 TEST=none Review URL: http://codereview.chromium.org/8726043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112034 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in FRIEND_TEST presubmit nag.robertshield@chromium.org2011-11-291-1/+1
| | | | | | | | | BUG=NONE TEST=NONE TBR=maruel Review URL: http://codereview.chromium.org/8687033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111943 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit to find new uses of the old callback system.dcheng@chromium.org2011-11-281-0/+31
| | | | | | | | | BUG=none TEST=edit files locally, add random references to the old callback system, and run presubmit. Review URL: http://codereview.chromium.org/8714008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111729 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit check that enforces the use of FRIEND_TEST_ALL_PREFIXES() ↵robertshield@chromium.org2011-11-281-4/+24
| | | | | | | | | | | | rather than FRIEND_TEST() since the former allows tests to be marked FLAKY_/FAILS_/DISABLED_. Also speed up _CheckNoNewWStrings() a bit. BUG=NONE TEST=Attempt to submit a change that includes FRIEND_TEST(). Get scolded. Review URL: http://codereview.chromium.org/8660006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111699 0039d316-1c4b-4281-b951-d872f2087c98
* ForTest presubmit check non-failing for CQ by making it just a messagejoi@chromium.org2011-11-181-5/+15
| | | | | | | | | | | | | | | | instead of a warning on commit, since there continue to be occasional fale positives and to fix the last ones the presubmit script would need to invoke a full C++ parser. Update the warning text. BUG=none TEST=dev tested locally on a specially set-up branch with various files that tickle the presubmit test. Review URL: http://codereview.chromium.org/8586024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110690 0039d316-1c4b-4281-b951-d872f2087c98
* Add a couple of things to the whitelist as requested. Refactor.joi@chromium.org2011-10-201-5/+12
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8355017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106455 0039d316-1c4b-4281-b951-d872f2087c98
* Try to annoy users with a presubmit check when they hack around .DEPS.gitmaruel@chromium.org2011-10-191-0/+14
| | | | | | | | | | | R=cmp@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8346021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106313 0039d316-1c4b-4281-b951-d872f2087c98
* Make whitelist for files starting with test_ or mock_ treat pathjoi@chromium.org2011-10-181-1/+1
| | | | | | | | | | | before filename correctly. BUG=none TEST=none Review URL: http://codereview.chromium.org/8341004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106008 0039d316-1c4b-4281-b951-d872f2087c98
* Downgrade the wstring check from an error to a warning.tony@chromium.org2011-10-121-6/+7
| | | | | | | | | | BUG=None TEST=manual Review URL: http://codereview.chromium.org/8229016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104970 0039d316-1c4b-4281-b951-d872f2087c98
* Add test_ and mock_ prefixes to whitelist.joi@chromium.org2011-10-041-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8137001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104005 0039d316-1c4b-4281-b951-d872f2087c98
* Don't send CLs with only *.mm files to non-Mac try bots by default.asvitkine@chromium.org2011-09-271-1/+5
| | | | | | | | | | | Depends on: http://codereview.chromium.org/7925014/ BUG=none TEST=Create a CL with only *.mm files: gcl/git try should send only to mac bot. Create a CL that has non-*.mm files: try should send to windows and linux bots too. Review URL: http://codereview.chromium.org/8046013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103040 0039d316-1c4b-4281-b951-d872f2087c98
* presubmit - don't check test functions for wstringestade@chromium.org2011-09-231-1/+2
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7969020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102438 0039d316-1c4b-4281-b951-d872f2087c98
* Fix false positive that occurred because _test.cc files were notjoi@chromium.org2011-09-211-2/+1
| | | | | | | | | | | matched by the whitelist regexp. BUG=none TEST=none Review URL: http://codereview.chromium.org/7980032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102159 0039d316-1c4b-4281-b951-d872f2087c98
* PRESUBMIT: reject changes that add wstringsevan@chromium.org2011-09-131-0/+18
| | | | | | | | | We are trying to get rid of wstrings, but new code keeps getting checked in that adds more. This will help prevent future mistakes. Review URL: http://codereview.chromium.org/7886019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100974 0039d316-1c4b-4281-b951-d872f2087c98
* Add profile_sync_service_harness.cc to presubmit whitelist as it is ajoi@chromium.org2011-09-121-1/+3
| | | | | | | | | | | testing-only file. BUG=none TEST=none Review URL: http://codereview.chromium.org/7796039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100798 0039d316-1c4b-4281-b951-d872f2087c98
* Fix libbase interface check.avi@chromium.org2011-09-081-2/+1
| | | | | | | | | | | It was triggering for things like ui/base. BUG=none TEST=none Review URL: http://codereview.chromium.org/7861006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100240 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit check that catches iostream usage in header files.thakis@chromium.org2011-09-021-0/+22
| | | | | | | | | BUG=94794 TEST=none Review URL: http://codereview.chromium.org/7792076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99291 0039d316-1c4b-4281-b951-d872f2087c98
* Add rules to exclude files with paths containing /test/, /tool/ and /tools/.joi@chromium.org2011-08-151-2/+3
| | | | | | | | | BUG=none TEST=manually tested by developer Review URL: http://codereview.chromium.org/7637015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96768 0039d316-1c4b-4281-b951-d872f2087c98
* Add check to help prevent test-only function usage in production code.joi@chromium.org2011-08-101-0/+52
| | | | | | | | | BUG=none TEST=Manual testing was performed. Warning message from presubmit test includes note to report issues to joi@chromium.org Review URL: http://codereview.chromium.org/7582002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96184 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify the author check.maruel@chromium.org2011-06-151-3/+1
| | | | | | | | | | | | | 2 lines removed! R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7144016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89182 0039d316-1c4b-4281-b951-d872f2087c98
* Allow wildcard for corporate CLA. Add nvidia to AUTHORS.maruel@chromium.org2011-06-131-3/+10
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7003151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88891 0039d316-1c4b-4281-b951-d872f2087c98
* presubmit: Make AUTHORS presubmit check use lower-cased email addresses.thakis@chromium.org2011-06-061-2/+2
| | | | | | | | | | | This is so that presubmit stops complaining about Takano.Naoki@gmail.com. BUG=none TEST=none Review URL: http://codereview.chromium.org/7024048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88004 0039d316-1c4b-4281-b951-d872f2087c98
* Fix presubmit check for non committersmaruel@chromium.org2011-05-311-1/+1
| | | | | | | | TBR=dpranke@chromium.org BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87346 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure non chromite/googler contributor is listed in AUTHORS.maruel@chromium.org2011-05-281-0/+26
| | | | | | | | | | | | | | It's easy to get a non-committer patch in with the commit-queue. Verifying CLA is outside the scope of this change. BUG= TEST= Review URL: http://codereview.chromium.org/6794027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87177 0039d316-1c4b-4281-b951-d872f2087c98
* Don't check for @interface in _unittest.mm files in basethakis@chromium.org2011-05-021-1/+2
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6880347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83737 0039d316-1c4b-4281-b951-d872f2087c98
* Don't let the presubmit check warn about |@interface| in comments in base.thakis@chromium.org2011-04-291-1/+1
| | | | | | | | | | | | | | Doesn't catch all /**/ style comments, but in practice we don't use /**/ comments, and when we do, we start every line with a *, and that's caught. (On the flipside, this doesn't catch "/**/@interface". http://stackoverflow.com/questions/1732348/regex-match-open-tags-except-xhtml-self-contained-tags/1732454#1732454) BUG=none TEST=none Review URL: http://codereview.chromium.org/6905134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83578 0039d316-1c4b-4281-b951-d872f2087c98
* Remove pending builds check, it's going to interfere with the commit queuemaruel@chromium.org2011-04-221-25/+0
| | | | | | | | | | | | | | | and slows down presubmit without much advantage anymore. Remove input_api.json check, it cannot be None anymore. R=nsylvain@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6896011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82611 0039d316-1c4b-4281-b951-d872f2087c98
* Migrating common checks to a location that affects all chromium projects.bradnelson@google.com2011-03-271-93/+9
| | | | | | | | | | BUG=None TEST=None R=erikkay@chromium.org,dpranke@chromium.org,maruel@chromium.org Review URL: http://codereview.chromium.org/6676115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79515 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on OWNERS checking in chromium/srcdpranke@chromium.org2011-03-181-0/+6
| | | | | | Review URL: http://codereview.chromium.org/6597065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78699 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce copyright-year updates in PRESUBMIT.fischman@chromium.org2011-03-171-4/+5
| | | | | | | | | | | | | | | | This implements the policy handed down in http://g/chrome-team/browse_thread/thread/2a27340089ff5f6c and codified in http://dev.chromium.org/developers/coding-style#TOC-File-headers Note that while the thread above permits the range usage (i.e. 2008-2011), the coding-style document does not, so this change removes that usage. BUG=none TEST=manual testing with changes to file header. Review URL: http://codereview.chromium.org/6694043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78550 0039d316-1c4b-4281-b951-d872f2087c98
* Make the ~/.subversion/config check a notice instead of an error.maruel@chromium.org2011-02-211-2/+2
| | | | | | | | | | | | | | It's less important now that all contributors suffered from it. Also, it's very painful for people working on other projects that don't use the same default settings. TEST=none BUG=none Review URL: http://codereview.chromium.org/6529017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75561 0039d316-1c4b-4281-b951-d872f2087c98
* Add more clarification to subversion/config error.maruel@chromium.org2011-02-011-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6392037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73334 0039d316-1c4b-4281-b951-d872f2087c98
* People hate to read text so put a link directly to the file.maruel@chromium.org2011-01-241-1/+3
| | | | | | | | | | TBR=thakis TEST=presubmit check is clearer BUG=none Review URL: http://codereview.chromium.org/6314017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72336 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new presubmit check to enforce automatic svn properties in svn config.maruel@chromium.org2011-01-231-0/+44
| | | | | | | | | | | This should help simplifying project maintenance. BUG=none TEST=none Review URL: http://codereview.chromium.org/6241012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72305 0039d316-1c4b-4281-b951-d872f2087c98
* Remove BUG= and TEST= checks from upload commit presubmit check.maruel@chromium.org2011-01-181-8/+9
| | | | | | | | | | | Fix PRESUBMIT.py to exclude Makefile. BUG=none TEST=presubmit check is less noisy Review URL: http://codereview.chromium.org/5976009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71622 0039d316-1c4b-4281-b951-d872f2087c98
* Convert build.chromium.org URLs to new URL format.chase@chromium.org2010-12-241-1/+1
| | | | | | | | | BUG=none TEST=scripts keep working Review URL: http://codereview.chromium.org/5961009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70143 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit check that makes sure no interfaces or categories are in ↵thakis@chromium.org2010-12-191-0/+21
| | | | | | | | | | | libbase. BUG=46929 TEST=none Review URL: http://codereview.chromium.org/6017004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69672 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit check to catch usage of Singleton<T> in header files.satish@chromium.org2010-12-141-0/+20
| | | | | | | | | BUG=65298 TEST=none Review URL: http://codereview.chromium.org/5753006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69129 0039d316-1c4b-4281-b951-d872f2087c98
* Using json based tree status check.bradnelson@google.com2010-08-261-2/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3116046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57444 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit check that catches |const NSString*| and friends.thakis@chromium.org2010-08-041-0/+23
| | | | | | | | BUG=TEST=none Review URL: http://codereview.chromium.org/3082016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54925 0039d316-1c4b-4281-b951-d872f2087c98
* Add net/tools/spdyshark/ to the presubmit exclude path list.tfarina@chromium.org2010-08-041-0/+1
| | | | | | | | | | | With that the lint doesn't complain about bad license header. BUG=50266 TEST=None Review URL: http://codereview.chromium.org/3080024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54857 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in PRESUBMIT.py because of default argument ordering.maruel@chromium.org2010-05-051-5/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1941004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46520 0039d316-1c4b-4281-b951-d872f2087c98
* Presubmit should now interpret "Closed" (upper case C) as meaning the tree ↵apatrick@chromium.org2010-03-301-1/+1
| | | | | | | | | | | is closed. TEST=none at all BUG=none Review URL: http://codereview.chromium.org/1560003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43126 0039d316-1c4b-4281-b951-d872f2087c98
* Move presubmit checks to depot_tools presubmit_canned_checks and add a ↵maruel@chromium.org2010-03-191-113/+20
| | | | | | | | | | | | | warning about json support. Use filter=1 to remove false and null data TEST=presubmit check passes BUG=none Review URL: http://codereview.chromium.org/1156001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42123 0039d316-1c4b-4281-b951-d872f2087c98
* Fix PRESUBMIT.py to handle 'true' and 'false' literals from the JSON data.glider@chromium.org2010-03-181-1/+5
| | | | | | Review URL: http://codereview.chromium.org/1111001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41944 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the list of slow slaves.maruel@chromium.org2010-02-021-11/+1
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/568022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37882 0039d316-1c4b-4281-b951-d872f2087c98
* Tolerate the form 20xx-20xx for copyrights since it's used in a few headers.maruel@chromium.org2010-01-281-2/+2
| | | | | | | | | TEST=none BUG=28291 Review URL: http://codereview.chromium.org/556059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37415 0039d316-1c4b-4281-b951-d872f2087c98
* Add back *.txt and *.json for the svn:eol-style check.maruel@chromium.org2010-01-281-3/+10
| | | | | | | | | | | Don't add them to the other checks because they are not relevant. TEST=none BUG=none Review URL: http://codereview.chromium.org/556051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37412 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 14:31:54 +0000