summaryrefslogtreecommitdiffstats
path: root/PRESUBMIT.py
Commit message (Collapse)AuthorAgeFilesLines
* Don't let the presubmit check warn about |@interface| in comments in base.thakis@chromium.org2011-04-291-1/+1
| | | | | | | | | | | | | | Doesn't catch all /**/ style comments, but in practice we don't use /**/ comments, and when we do, we start every line with a *, and that's caught. (On the flipside, this doesn't catch "/**/@interface". http://stackoverflow.com/questions/1732348/regex-match-open-tags-except-xhtml-self-contained-tags/1732454#1732454) BUG=none TEST=none Review URL: http://codereview.chromium.org/6905134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83578 0039d316-1c4b-4281-b951-d872f2087c98
* Remove pending builds check, it's going to interfere with the commit queuemaruel@chromium.org2011-04-221-25/+0
| | | | | | | | | | | | | | | and slows down presubmit without much advantage anymore. Remove input_api.json check, it cannot be None anymore. R=nsylvain@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6896011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82611 0039d316-1c4b-4281-b951-d872f2087c98
* Migrating common checks to a location that affects all chromium projects.bradnelson@google.com2011-03-271-93/+9
| | | | | | | | | | BUG=None TEST=None R=erikkay@chromium.org,dpranke@chromium.org,maruel@chromium.org Review URL: http://codereview.chromium.org/6676115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79515 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on OWNERS checking in chromium/srcdpranke@chromium.org2011-03-181-0/+6
| | | | | | Review URL: http://codereview.chromium.org/6597065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78699 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce copyright-year updates in PRESUBMIT.fischman@chromium.org2011-03-171-4/+5
| | | | | | | | | | | | | | | | This implements the policy handed down in http://g/chrome-team/browse_thread/thread/2a27340089ff5f6c and codified in http://dev.chromium.org/developers/coding-style#TOC-File-headers Note that while the thread above permits the range usage (i.e. 2008-2011), the coding-style document does not, so this change removes that usage. BUG=none TEST=manual testing with changes to file header. Review URL: http://codereview.chromium.org/6694043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78550 0039d316-1c4b-4281-b951-d872f2087c98
* Make the ~/.subversion/config check a notice instead of an error.maruel@chromium.org2011-02-211-2/+2
| | | | | | | | | | | | | | It's less important now that all contributors suffered from it. Also, it's very painful for people working on other projects that don't use the same default settings. TEST=none BUG=none Review URL: http://codereview.chromium.org/6529017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75561 0039d316-1c4b-4281-b951-d872f2087c98
* Add more clarification to subversion/config error.maruel@chromium.org2011-02-011-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6392037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73334 0039d316-1c4b-4281-b951-d872f2087c98
* People hate to read text so put a link directly to the file.maruel@chromium.org2011-01-241-1/+3
| | | | | | | | | | TBR=thakis TEST=presubmit check is clearer BUG=none Review URL: http://codereview.chromium.org/6314017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72336 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new presubmit check to enforce automatic svn properties in svn config.maruel@chromium.org2011-01-231-0/+44
| | | | | | | | | | | This should help simplifying project maintenance. BUG=none TEST=none Review URL: http://codereview.chromium.org/6241012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72305 0039d316-1c4b-4281-b951-d872f2087c98
* Remove BUG= and TEST= checks from upload commit presubmit check.maruel@chromium.org2011-01-181-8/+9
| | | | | | | | | | | Fix PRESUBMIT.py to exclude Makefile. BUG=none TEST=presubmit check is less noisy Review URL: http://codereview.chromium.org/5976009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71622 0039d316-1c4b-4281-b951-d872f2087c98
* Convert build.chromium.org URLs to new URL format.chase@chromium.org2010-12-241-1/+1
| | | | | | | | | BUG=none TEST=scripts keep working Review URL: http://codereview.chromium.org/5961009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70143 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit check that makes sure no interfaces or categories are in ↵thakis@chromium.org2010-12-191-0/+21
| | | | | | | | | | | libbase. BUG=46929 TEST=none Review URL: http://codereview.chromium.org/6017004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69672 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit check to catch usage of Singleton<T> in header files.satish@chromium.org2010-12-141-0/+20
| | | | | | | | | BUG=65298 TEST=none Review URL: http://codereview.chromium.org/5753006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69129 0039d316-1c4b-4281-b951-d872f2087c98
* Using json based tree status check.bradnelson@google.com2010-08-261-2/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3116046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57444 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit check that catches |const NSString*| and friends.thakis@chromium.org2010-08-041-0/+23
| | | | | | | | BUG=TEST=none Review URL: http://codereview.chromium.org/3082016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54925 0039d316-1c4b-4281-b951-d872f2087c98
* Add net/tools/spdyshark/ to the presubmit exclude path list.tfarina@chromium.org2010-08-041-0/+1
| | | | | | | | | | | With that the lint doesn't complain about bad license header. BUG=50266 TEST=None Review URL: http://codereview.chromium.org/3080024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54857 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug in PRESUBMIT.py because of default argument ordering.maruel@chromium.org2010-05-051-5/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1941004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46520 0039d316-1c4b-4281-b951-d872f2087c98
* Presubmit should now interpret "Closed" (upper case C) as meaning the tree ↵apatrick@chromium.org2010-03-301-1/+1
| | | | | | | | | | | is closed. TEST=none at all BUG=none Review URL: http://codereview.chromium.org/1560003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43126 0039d316-1c4b-4281-b951-d872f2087c98
* Move presubmit checks to depot_tools presubmit_canned_checks and add a ↵maruel@chromium.org2010-03-191-113/+20
| | | | | | | | | | | | | warning about json support. Use filter=1 to remove false and null data TEST=presubmit check passes BUG=none Review URL: http://codereview.chromium.org/1156001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42123 0039d316-1c4b-4281-b951-d872f2087c98
* Fix PRESUBMIT.py to handle 'true' and 'false' literals from the JSON data.glider@chromium.org2010-03-181-1/+5
| | | | | | Review URL: http://codereview.chromium.org/1111001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41944 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the list of slow slaves.maruel@chromium.org2010-02-021-11/+1
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/568022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37882 0039d316-1c4b-4281-b951-d872f2087c98
* Tolerate the form 20xx-20xx for copyrights since it's used in a few headers.maruel@chromium.org2010-01-281-2/+2
| | | | | | | | | TEST=none BUG=28291 Review URL: http://codereview.chromium.org/556059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37415 0039d316-1c4b-4281-b951-d872f2087c98
* Add back *.txt and *.json for the svn:eol-style check.maruel@chromium.org2010-01-281-3/+10
| | | | | | | | | | | Don't add them to the other checks because they are not relevant. TEST=none BUG=none Review URL: http://codereview.chromium.org/556051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37412 0039d316-1c4b-4281-b951-d872f2087c98
* Use the newly added CheckLicense() canned check to verify license boiler ↵maruel@chromium.org2010-01-281-18/+21
| | | | | | | | | | | | | plate on source files. Don't check for the year since there was no clear concensus about systematically updating the year on every change. TEST=none BUG=28291 Review URL: http://codereview.chromium.org/552203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37361 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old files.nsylvain@chromium.org2009-11-201-3/+0
| | | | | | Review URL: http://codereview.chromium.org/425008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32711 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy checkin to trigger the botsnsylvain@chromium.org2009-11-151-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32026 0039d316-1c4b-4281-b951-d872f2087c98
* Fix PRESUBMIT.py when simplejson is present.maruel@chromium.org2009-11-091-1/+1
| | | | | | | | | TBR=nsylvain TEST=none BUG=none Review URL: http://codereview.chromium.org/380005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31477 0039d316-1c4b-4281-b951-d872f2087c98
* Warn when number of inflight build is too high.maruel@chromium.org2009-11-091-0/+57
| | | | | | | | TEST=none BUG=27143 Review URL: http://codereview.chromium.org/381005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31470 0039d316-1c4b-4281-b951-d872f2087c98
* Remove executable bit on PRESUBMIT.py since it is not an executable.maruel@chromium.org2009-10-241-1/+0
| | | | | | | | | | NO CODE CHANGE. TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30015 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy checkin to trigger the builbotnsylvain@chromium.org2009-10-111-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28683 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy change to trigger the buildbotsnsylvain@chromium.org2009-10-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28676 0039d316-1c4b-4281-b951-d872f2087c98
* Disable CheckSvnModifiedDirectories for now. It doesn't work well in ↵thestig@chromium.org2009-10-011-2/+3
| | | | | | | | | | | third_party. BUG=none TEST=none TBR=maruel Review URL: http://codereview.chromium.org/246055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27710 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetPreferredTrySlaves() to presubmit scripts.thestig@chromium.org2009-09-291-0/+4
| | | | | | | | BUG=23071 TEST=none Review URL: http://codereview.chromium.org/251024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27449 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy checkin to trigger the botsnsylvain@chromium.org2009-09-241-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27028 0039d316-1c4b-4281-b951-d872f2087c98
* Fix try job status PRESUBMIT check when an issue is private.maruel@chromium.org2009-09-181-0/+3
| | | | | | | | TEST=presubmit doesn't throw an exception on private issues BUG=none Review URL: http://codereview.chromium.org/207030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26598 0039d316-1c4b-4281-b951-d872f2087c98
* Check for svn directories with modified properties during presubmit. These ↵thestig@chromium.org2009-08-151-0/+2
| | | | | | | | directories may trigger unwanted commits due to svn's recursive behavior. Review URL: http://codereview.chromium.org/165427 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23506 0039d316-1c4b-4281-b951-d872f2087c98
* Make the try job presubmit check (CheckTryJobExecution) less verbose.maruel@chromium.org2009-08-121-21/+19
| | | | | | | | | | Also clean up the Tree is closed presubmit check (CheckTreeIsOpen). TEST=none BUG=none Review URL: http://codereview.chromium.org/165251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23195 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy checkin to trigger the botsnsylvain@chromium.org2009-07-311-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22160 0039d316-1c4b-4281-b951-d872f2087c98
* Make the "tree is closed" presubmit check an error, not ansylvain@chromium.org2009-07-291-2/+2
| | | | | | | | | warning. pressing "y" is too easy. It's better to have to use "--force" or "--no_presubmit" Review URL: http://codereview.chromium.org/159596 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21978 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce presubmit check of try run. Add a nice message to give feedback to ↵maruel@chromium.org2009-07-101-10/+9
| | | | | | | | | | the right person. BUG=none TEST=none Review URL: http://codereview.chromium.org/155354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20397 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce correct mime-type on some files formats (especially images).maruel@chromium.org2009-06-261-0/+4
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/147221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19437 0039d316-1c4b-4281-b951-d872f2087c98
* Display the actual tree status when the tree is closed. Much more helpful.maruel@chromium.org2009-06-111-4/+32
| | | | | | | | TEST=Try committing when the tree is closed to see. BUG=none Review URL: http://codereview.chromium.org/119437 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18125 0039d316-1c4b-4281-b951-d872f2087c98
* Use new canned checks in PRESUBMIT.pymaruel@chromium.org2009-06-111-109/+39
| | | | | | | | | | | | Also fix gcl presubmit tree status check when the change hasn't been uploaded nor gcl try'ed. Remove PRESUBMIT_unittest.py since it's not useful anymore. TEST=none BUG=none Review URL: http://codereview.chromium.org/119432 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18124 0039d316-1c4b-4281-b951-d872f2087c98
* Use input_api.ReadFile() instead of rolling out its own.maruel@chromium.org2009-06-101-13/+1
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/118484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18051 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy change to trigger the buildbotsnsylvain@chromium.org2009-06-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18019 0039d316-1c4b-4281-b951-d872f2087c98
* Add try job status check on commit.maruel@chromium.org2009-06-081-0/+44
| | | | | | | | | | It acts as an advisory presubmit check for now since the try server isn't that stable. BUG=none TEST=gcl commit warns the user when a pending change hasn't passed the try job. Review URL: http://codereview.chromium.org/119295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17870 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy change to trigger the slaves - NO CODE CHANGEnsylvain@chromium.org2009-06-071-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17846 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy change to trigger the build slaves - NO CODE CHANGEnsylvain@chromium.org2009-06-071-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17845 0039d316-1c4b-4281-b951-d872f2087c98
* Add the tree check there instead of implementing it in the root PRESUBMIT.py.maruel@chromium.org2009-06-051-7/+19
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/119201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17729 0039d316-1c4b-4281-b951-d872f2087c98
* Fix PRESUBMIT.py's path handling.maruel@chromium.org2009-06-041-1/+1
| | | | | | Review URL: http://codereview.chromium.org/118202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17574 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-16 21:56:52 +0000