summaryrefslogtreecommitdiffstats
path: root/PRESUBMIT.py
Commit message (Collapse)AuthorAgeFilesLines
* Removing my contact details from PRESUBMIT.pyjoi@chromium.org2014-03-271-3/+2
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/214703002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259914 0039d316-1c4b-4281-b951-d872f2087c98
* [NaCl SDK] nacl_io: Add support for JavaScript handshake on exitsbc@chromium.org2014-03-241-0/+1
| | | | | | | | | | | | | | | | | | Without this _exit() can lose messages that are still in transit to JavaScript. Also, fix using_ppapi_simple example. Exclude native_client_sdk from PRESUBMIT check on stdout/stderr. The code here doesn't get built into chrome itself. BUG=337584 R=binji@chromium.org, maruel@chromium.org Review URL: https://codereview.chromium.org/152743004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258953 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Add a simple platform-level shared memory implementation.viettrungluu@chromium.org2014-03-211-0/+1
| | | | | | | | | | | | | | | (Unfortunately, base::SharedMemory doesn't quite meet our needs right now, and it'll be a while -- if ever -- before I manage to refactor it so that it does.) Not yet implemented on Windows. (This should be simple, but I'll do it separately.) R=darin@chromium.org Review URL: https://codereview.chromium.org/205583008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258667 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable swarming jobs.maruel@chromium.org2014-03-201-3/+4
| | | | | | | | | | | | | The failure rate is currently unacceptably high. Disabling normal runs will permits us to run more perf tests on the prod instance. R=vadimsh@chromium.org BUG=354263 NOTRY=true Review URL: https://codereview.chromium.org/206773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258382 0039d316-1c4b-4281-b951-d872f2087c98
* Change asan builders to only set compile by default.stip@chromium.org2014-03-191-2/+3
| | | | | | | | BUG=354052 Review URL: https://codereview.chromium.org/204753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258121 0039d316-1c4b-4281-b951-d872f2087c98
* Remove X11 and GTK dependencies from host_forwarderzhenyu.liang@intel.com2014-03-191-0/+1
| | | | | | | | | | Use libevent as the implementation of MessagePumpForUI. BUG=346113 Review URL: https://codereview.chromium.org/176713005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257853 0039d316-1c4b-4281-b951-d872f2087c98
* More sync of PRESUBMIT with what CQ runsphajdan.jr@chromium.org2014-03-131-9/+2
| | | | | | | | | | | | | | | | | This removes some configs that were here below in an attempt to reduce the tryserver load. They can be added later slowly after we verify they don't cause unnecessary load. Note that CQ was not checking them anyway, so they were losing at least 50% CL coverage. TBR=maruel BUG=317931 Review URL: https://codereview.chromium.org/198333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256739 0039d316-1c4b-4281-b951-d872f2087c98
* Change top-level PRESUBMIT to support split tryserverphajdan.jr@chromium.org2014-03-121-11/+20
| | | | | | | | | | | | | This also fixes problems with generic trybots not being triggered when other presubmit files which already support multiple masters get in scope. BUG=334892 R=maruel@chromium.org Review URL: https://codereview.chromium.org/197963003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256698 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land: Change the user action file format from .txt to .xml.yiyaoliu@chromium.org2014-03-071-10/+14
| | | | | | | | | | | | | | | In this way, more information can be added (currently added 'description' and 'owner' for each action) A few functions are moved from tools/metrics/histograms to tools/metrics/common to be shared by tools/metrics and tools/histograms. CL 149503005 broke in http://crrev.com/255357. Add a patch to fix histograms presubmit. BUG=340735 NOTRY=true Review URL: https://codereview.chromium.org/180743027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255680 0039d316-1c4b-4281-b951-d872f2087c98
* Fix UserAction presubmit incorrectly not matching existing actions.tedchoc@chromium.org2014-03-071-1/+1
| | | | | | | | | | BUG=340735 TBR=maruel@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/189783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255530 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 255357 "Change the user action file format from .txt to ...."dcaiafa@google.com2014-03-061-14/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Believed to be behind the failures in the Linux builder: http://build.chromium.org/p/chromium/builders/Linux/builds/47996 Errors in the log: .../actions/print_style.py: Has executable bit but not shebang or ELF header .../histograms/print_style.py: Has executable bit but not shebang or ELF header Refers to files in the CL. > Change the user action file format from .txt to .xml. > > In this way, more information can be added (currently added 'description' and 'owner' for each action) > > A few functions are moved from tools/metrics/histograms to tools/metrics/common to be shared by tools/metrics and tools/histograms. > > BUG=340735 > NOTRY=true > > Review URL: https://codereview.chromium.org/149503005 TBR=yiyaoliu@chromium.org Review URL: https://codereview.chromium.org/188793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255404 0039d316-1c4b-4281-b951-d872f2087c98
* Change the user action file format from .txt to .xml.yiyaoliu@chromium.org2014-03-061-10/+14
| | | | | | | | | | | | | In this way, more information can be added (currently added 'description' and 'owner' for each action) A few functions are moved from tools/metrics/histograms to tools/metrics/common to be shared by tools/metrics and tools/histograms. BUG=340735 NOTRY=true Review URL: https://codereview.chromium.org/149503005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255357 0039d316-1c4b-4281-b951-d872f2087c98
* Add user action check to general presubmit.yiyaoliu@chromium.org2014-03-031-0/+29
| | | | | | | | BUG=340735 Review URL: https://codereview.chromium.org/179993002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254543 0039d316-1c4b-4281-b951-d872f2087c98
* Add UMA stats to record when DLLs are successfully blocked in the Browser.csharp@chromium.org2014-03-031-0/+1
| | | | | | | | BUG=345287 Review URL: https://codereview.chromium.org/174013007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254480 0039d316-1c4b-4281-b951-d872f2087c98
* Fix presubmit after my latest changesphajdan.jr@chromium.org2014-02-271-9/+11
| | | | | | | | | | | | | | | This is a follow-up to https://codereview.chromium.org/179453003/ Removing CheckRietveldTryJobExecution because the implementation is currently empty anyway and the trybot config will become more and more dynamic so that static list is becoming less and less accurate. BUG=317931 R=maruel@chromium.org Review URL: https://codereview.chromium.org/183623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253896 0039d316-1c4b-4281-b951-d872f2087c98
* Update presubmit default trybots to be more similar to CQ configphajdan.jr@chromium.org2014-02-271-42/+7
| | | | | | | | | BUG=317931 R=maruel@chromium.org Review URL: https://codereview.chromium.org/179453003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253867 0039d316-1c4b-4281-b951-d872f2087c98
* Add gfx_unittests to trybot list for mac and windows.stip@chromium.org2014-02-271-1/+2
| | | | | | | | BUG=331829, 299841 Review URL: https://codereview.chromium.org/178153005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253820 0039d316-1c4b-4281-b951-d872f2087c98
* Only run Java checkstyle on Upload and not Submit.aurimas@chromium.org2014-02-201-1/+1
| | | | | | | | | BUG=None NOTRY=true Review URL: https://codereview.chromium.org/171773007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252207 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude vulcanize-generated HTML/JS from PRESUBMIT.py checksraymes@google.com2014-02-191-0/+1
| | | | | | | | | | | | | These files are automatically generated for the PDF extension. The long term solution is not to check in vulcanize-generated files. These files may not be needed once HTMLImports are fully implemented in chrome. BUG=303491 R=arv@chromium.org, maruel@chromium.org Review URL: https://codereview.chromium.org/154223003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251890 0039d316-1c4b-4281-b951-d872f2087c98
* Remove src/cloud_print from _CheckSpamLogging.vitalybuka@chromium.org2014-02-111-0/+1
| | | | | | | | | | None of src/cloud_print is part of chrome binary. NOTRY=true Review URL: https://codereview.chromium.org/159933005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250550 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude tools/ from console spam PRESUBMITscottmg@chromium.org2014-02-111-2/+1
| | | | | | | | | | tools/ are often standalone or intended to interact with console output. R=maruel@chromium.org Review URL: https://codereview.chromium.org/130263011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250455 0039d316-1c4b-4281-b951-d872f2087c98
* Swap linux_aura for linux_gtk in PRESUBMIT try stuff.agable@chromium.org2014-02-071-13/+6
| | | | | | | | | | | | | Needs to land at the same time as the master restart for https://codereview.chromium.org/151393003/ BUG=336581 NOTRY=true R=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/147233003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249591 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for threading and atomic ops in QNX Neutrino.ctruta@blackberry.com2014-02-061-0/+1
| | | | | | | | | | | | | BUG= Patch by: Eli Fidler <efidler@blackberry.com>, Jeff Rogers <jrogers@blackberry.com>, Cosmin Truta <ctruta@blackberry.com>. Review URL: https://codereview.chromium.org/156233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249390 0039d316-1c4b-4281-b951-d872f2087c98
* Skip _CheckFilePermissions check on Windowsadamk@chromium.org2014-02-031-0/+2
| | | | | | | | | | | | Executable bits are wonky on Windows, so checking them doesn't get us anything and incorrectly disallows uploading of, e.g., python scripts. R=maruel@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/142973008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248605 0039d316-1c4b-4281-b951-d872f2087c98
* content: Add a new target 'test_netscape_plugin' to build the module in ↵tfarina@chromium.org2014-02-011-2/+3
| | | | | | | | | | | | shell/tools/plugin BUG=331302 TEST=ninja -C out_cros/Debug test_netscape_plugin builds R=jochen@chromium.org Review URL: https://codereview.chromium.org/145723004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248358 0039d316-1c4b-4281-b951-d872f2087c98
* Fix _CheckFilePermissions to actually flag presubmit errorsadamk@chromium.org2014-01-301-8/+6
| | | | | | | | | | | | | | Previously it was misusing subprocess.Popen such that no output was ever captured from checkperms.py. Also, changed the check to use input_api.subprocess instead of importing subprocess. R=maruel@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/143013004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247805 0039d316-1c4b-4281-b951-d872f2087c98
* Recognize KIF tests in top-level PRESUBMIT.pypvalenzuela@chromium.org2014-01-291-1/+1
| | | | | | | | | | | | This change allows KIF (an iOS integration test framework) tests to be analyzed appropriately by presubmit checks such as _CheckNoProductionCodeUsingTestOnlyFunctions. BUG=NONE Review URL: https://codereview.chromium.org/133233009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247718 0039d316-1c4b-4281-b951-d872f2087c98
* Add telemetry_unittests and telemetry_perf_unittests.stip@chromium.org2014-01-241-0/+4
| | | | | | | | | NOTRY=true BUG=156398 Review URL: https://codereview.chromium.org/145013014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246939 0039d316-1c4b-4281-b951-d872f2087c98
* Re-add linux_nacl_sdk_build trybot to the default try list.sbc@chromium.org2014-01-231-3/+1
| | | | | | | | | | | | | This bot is now green, and will work with or without the ARM linux cross compiler bring installed (for now). TEST=git cl try NOTRY=true BUG=335303 Review URL: https://codereview.chromium.org/135253004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246672 0039d316-1c4b-4281-b951-d872f2087c98
* LogMessage::Init must check untrusted severity_ value before using it as an ↵tsepez@chromium.org2014-01-231-0/+1
| | | | | | | | | | | array index. Another common case hit with the IPC fuzzer, and easy to handle. BUG=329723 Review URL: https://codereview.chromium.org/138953003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246474 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily remove NaCL SDK trybots from default try set.sbc@chromium.org2014-01-231-1/+3
| | | | | | | | | BUG=335303 R=maruel@chromium.org Review URL: https://codereview.chromium.org/132693024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246468 0039d316-1c4b-4281-b951-d872f2087c98
* [telemetry] bitmaptools as a standalone executableszym@chromium.org2014-01-221-0/+2
| | | | | | | | | | | | | | | | | | | The C++ binary implements simple per-pixel algorithms for SpeedIndex computation. This allows us to achieve near real-time processing without bringing external dependencies. The bitmaptools binary needs to be built before it can be used. The overhead of spawning a child process for each frame is about 3ms. BUG=323813 TEST=telemetry bitmap_unittest Original review: https://codereview.chromium.org/136793022 TBR=tonyg,maruel Review URL: https://codereview.chromium.org/131563009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246361 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 245684 "[telemetry] bitmaptools as a standalone executable"kbr@chromium.org2014-01-181-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | Broke gpu_tests step on Android Debug GPU bot; see crbug.com/323813 for details. > [telemetry] bitmaptools as a standalone executable > > The C++ binary implements simple per-pixel algorithms for SpeedIndex > computation. This allows us to achieve near real-time processing without > bringing external dependencies. > > The bitmaptools binary needs to be built before it can be used. > The overhead of spawning a child process for each frame is about 3ms. > > BUG=323813 > TEST=telemetry bitmap_unittest > > Review URL: https://codereview.chromium.org/136793022 TBR=szym@chromium.org Review URL: https://codereview.chromium.org/138143020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245712 0039d316-1c4b-4281-b951-d872f2087c98
* [telemetry] bitmaptools as a standalone executableszym@chromium.org2014-01-181-0/+2
| | | | | | | | | | | | | | | | The C++ binary implements simple per-pixel algorithms for SpeedIndex computation. This allows us to achieve near real-time processing without bringing external dependencies. The bitmaptools binary needs to be built before it can be used. The overhead of spawning a child process for each frame is about 3ms. BUG=323813 TEST=telemetry bitmap_unittest Review URL: https://codereview.chromium.org/136793022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245684 0039d316-1c4b-4281-b951-d872f2087c98
* Disable experimental tryserver builders.phajdan.jr@chromium.org2014-01-161-11/+0
| | | | | | | | | | | | They may be putting too much load on the tryserver. TBR=joi BUG=317931, 334681 Review URL: https://codereview.chromium.org/140503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245063 0039d316-1c4b-4281-b951-d872f2087c98
* Add nacl sdk builders to default try list.sbc@chromium.org2014-01-111-0/+6
| | | | | | | | | | | | These are the new "build-only" builders for that NaCl SDK which should be fast and reliable and catch basic build breaks. BUG=302579 Review URL: https://codereview.chromium.org/26747002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244280 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Increase percentage of manual try jobs going to recipe-based trybots.phajdan.jr@chromium.org2014-01-101-1/+1
| | | | | | | | | | | | | This goes from 10% to 25% . Over Jan 9 we got 13 jobs per builder with no problems. BUG=317931 R=joi@chromium.org Review URL: https://codereview.chromium.org/133603003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244160 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Increase percentage of manual try jobs going to recipe-based trybots.phajdan.jr@chromium.org2014-01-091-1/+1
| | | | | | | | | | | | This goes from 1% to 10% . Over Jan 7-8 we only got 3 jobs total with no problems. BUG=317931 R=joi@chromium.org Review URL: https://codereview.chromium.org/131503002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243844 0039d316-1c4b-4281-b951-d872f2087c98
* Port content::GLHelper over to GLES2Interfacejamesr@chromium.org2014-01-081-0/+2
| | | | | | | | | | | | This is necessary to remove the WebGraphicsContext3D getter from cc::ContextProvider. TBR=maruel@ for trivial PRESUBMIT.py change BUG=181120 Review URL: https://codereview.chromium.org/117233006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243499 0039d316-1c4b-4281-b951-d872f2087c98
* Do per-file OWNERS check for per-file DEPS changes.joi@chromium.org2014-01-081-6/+25
| | | | | | | | | | Before this, an OWNER of the entire directory that a new DEPS rule was pointing to would be required, even when the DEPS rule specified an individual file for which there are per-file OWNERS in the OWNERS file. BUG=290401 Review URL: https://codereview.chromium.org/116443011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243459 0039d316-1c4b-4281-b951-d872f2087c98
* Include order check should work better for files containing uncheckable includesb.kelemen@samsung.com2014-01-071-1/+1
| | | | | | | | | | Currently as soon as we see an uncheckable include (like ipc/*macros.h or windows.h) we stop checking the file. Instead we should just skip that line and continue checking. Review URL: https://codereview.chromium.org/105633012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243427 0039d316-1c4b-4281-b951-d872f2087c98
* Remove NaCl SDK bots from top-level PRESUBMIT.pybinji@chromium.org2014-01-071-6/+0
| | | | | | | | | | | | | | | This change was originally introduced to only run the NaCl SDK bots when all changes were to files in the native_client_sdk directory. This change is no longer safe, as some changes can affect other builders (such as changes to create_nmf.py and nacl_io). BUG=none R=stip@chromium.org Review URL: https://codereview.chromium.org/112953005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243396 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Send 1% of Chromium try jobs to recipe-based builders.phajdan.jr@chromium.org2014-01-071-0/+15
| | | | | | | | | BUG=317931 R=cmp@chromium.org, joi@chromium.org Review URL: https://codereview.chromium.org/108243005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243288 0039d316-1c4b-4281-b951-d872f2087c98
* Drop '2' from presubmit's chromedriver2_unittests.kkania@chromium.org2014-01-031-3/+3
| | | | | | | | | | chromedriver_unittests is a duplicate target that will eventually replace chromedriver2_unittests. BUG=none NOTRY=true Review URL: https://codereview.chromium.org/119753011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242899 0039d316-1c4b-4281-b951-d872f2087c98
* Only check changed lines for ForTest(ing) usage in production code.joi@chromium.org2014-01-021-4/+1
| | | | | | | | | | This is beneficial since there are occasional false positives, so it is nicer not to trigger them when you are just touching a file that contains them. BUG=none Review URL: https://codereview.chromium.org/123203002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242800 0039d316-1c4b-4281-b951-d872f2087c98
* Remove 'using base::string16;' from base/strings/string16.h and remove temporarydbeam@chromium.org2013-12-301-50/+0
| | | | | | | | | | | | PRESUBMIT.py _CheckForString16(). R=brettw@chromium.org, maruel@chromium.org TBR=sky@chromium.org, tsepez@chromium.org BUG=329295 Review URL: https://codereview.chromium.org/93903011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242733 0039d316-1c4b-4281-b951-d872f2087c98
* Adding win8/ and chrome_frame/ to _CheckForString16() whitelist.dbeam@chromium.org2013-12-201-0/+2
| | | | | | | | | | TBR=joi@chromium.org BUG=329295 NOTRY=true Review URL: https://codereview.chromium.org/119933003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242142 0039d316-1c4b-4281-b951-d872f2087c98
* Import TestRunner library into chromium.jochen@chromium.org2013-12-201-1/+9
| | | | | | | | | | | | | | | | | | | | The reasons for the move are: - it's actually a blink embedder, so it can't use blink/wtf types - it can't use base either - we want to replace CppBoundClass with gin::Wrappable, not possible in blink In the first step, this is mostly a 1:1 copy (except for include paths). Follow-up CLs will move the test plugin and layout tests helpers and clean up the coding style BUG=324658 R=abarth@chromium.org, maruel@chromium.org, torne@chromium.org, jam@chromium.org TBR=torne@chromium.org Review URL: https://codereview.chromium.org/110533009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242095 0039d316-1c4b-4281-b951-d872f2087c98
* Add more directories to _CheckForString16() whitelist.dbeam@chromium.org2013-12-201-1/+2
| | | | | | | | | | TBR=joi@chromium.org BUG=329295 NOTRY=true Review URL: https://codereview.chromium.org/119763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242052 0039d316-1c4b-4281-b951-d872f2087c98
* Add more directories to _CheckForString16() whitelist.dbeam@chromium.org2013-12-191-1/+9
| | | | | | | | | | TBR=joi@chromium.org BUG=329295 NOTRY=true Review URL: https://codereview.chromium.org/119523003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241985 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-09-16 12:08:14 +0000